booker_ruby 3.3.6 → 3.3.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c591cf33e4fcc339c3c5669f087b08f201af8ed51c5fa6720904a8e333306a7
-  data.tar.gz: 792f3c94f166f069a13738552171faf32e1227ed5e48a0da7d59e6f3b9d3f652
+  metadata.gz: abde0d7f63e8161e912b42af8d19a33dbc2f6745a59462ebbda85230fcb31f4a
+  data.tar.gz: 0150303f3ade42f4f2417de1fc28a5922a6e885a325c00f8f7c4c7396b1e1fb8
 SHA512:
-  metadata.gz: 7d02cde048331d194864cecbe0b04a3eb0231fc9a13b688727322e8db17e26d96dfa7bf6068fb2968b5affb7bec4112d2145665e089ca8b5eff746b3f810a967
-  data.tar.gz: 96973ce4f0f119092bf48dd1f19831f41538e41c4f6e28459f1c26ad034d3f6605b2de7627f825430fab59532031d9192e0c0a90435f8119492a24b3691b22a4
+  metadata.gz: 990a65f7a4cae381cd0ad34498c70184eda3b55ead242c8d44ade0f5989b228d70e02a83a3e30d4b7af1e6dcfe3fbad69c47f46d1b788867bf087b5287854e3f
+  data.tar.gz: 4b3b39a12dabbf33c7b3ceedbdc7402032f1425d91240faf75b0f8a85dd2f7150cf05e1e4c4d6c93250b895415f721628a2f9391c89ec81b0e5744f9213669f7

data/lib/booker/client.rb

@@ -136,13 +136,13 @@ module Booker
         end
       end
 
-      unless response.nil? || nil_or_empty_hash?(response.parsed_response)
+      unless response_is_error?(response, http_method)
         return results_from_response(response, booker_model)
       end
 
       # Retry on blank responses (happens in certain v4 API methods in lieu of an actual error)
       response = handle_errors!(url, http_options, HTTParty.send(http_method, url, http_options))
-      unless response.nil? || nil_or_empty_hash?(response.parsed_response)
+      unless response_is_error?(response, http_method)
         return results_from_response(response, booker_model)
       end
 
@@ -321,6 +321,12 @@ module Booker
         parsed_response
       end
 
+      def response_is_error?(response, http_method)
+        return false if (http_method == :delete) && (response.code == 204)
+
+        response.nil? || nil_or_empty_hash?(response.parsed_response)
+      end
+
       def nil_or_empty_hash?(obj)
         obj.nil? || (obj.is_a?(Hash) && obj.blank?)
       end

data/lib/booker/version.rb

@@ -1,3 +1,3 @@
 module Booker
-  VERSION = '3.3.6'
+  VERSION = '3.3.7'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: booker_ruby
 version: !ruby/object:Gem::Version
-  version: 3.3.6
+  version: 3.3.7
 platform: ruby
 authors:
 - Frederick
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-01 00:00:00.000000000 Z
+date: 2019-03-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty