boojs 0.0.29 → 0.0.30

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ee076999d3654b754da3a40822627c8324a0b9ec
-  data.tar.gz: 462e252cb637d6ad3d063b6e35faa6636d03fe6d
+  metadata.gz: 8afbb0e166580c67fdc4952b918827224e90a09e
+  data.tar.gz: 0e358c78333c5630542df9a918200f6ab188be6a
 SHA512:
-  metadata.gz: d760e8bae7f62534eee68d823e23397c5b60043bcd35fe45c92ba85e3fd07ae6296bbfa9fe4c33c3137ddd46f327545ed516edb170fd1eed1e955d5e3570b701
-  data.tar.gz: 7737bf0b63bd9dbcb90cbf42d67a964d73180d4dc34113fb842d711fac46f9847c3c75dd8a574f49eb669e805d49113b8c93263609546cedad72ed6d6d44f04e
+  metadata.gz: 5899ff5185e76d0a1130172f2b0453994faa4c2201bdaf46ed9798c60bf9c7cf713ffa0fdf668715d91d1d4262842d053f1ba1dd936a03a6202c683e39c17e20
+  data.tar.gz: e18edf2f45f15c15d079894c0598e290c4f376827432b855972487bc2d76300b4722cc9ceab16e2c6c273fee651300278923e4bb3caf30c6c2111fdc1d284a69

data/README.md

@@ -64,10 +64,18 @@ Verify that a file contains no javascript runtime initialization errors
 0
 ```
 
+
 #### NOTES
   * Calling `booPing()` will immediately return `"pong"` to `stdout`. You may use this to know when boo has started up fully.
   * `console.error(msg)` will output to `$stderr`.  `console.log(msg)` will output to `$stdout`.
 
+#### Local Storage Persistance
+Every restart of boojs will cause `localStorage` to be reset. There is a bug where multiple instances of `boojs` will all *share* the same
+instance of `localStorage`, so if you open multiple copies of boojs, you are guaranteed to delete `localStorage` of all boojs instances.
+You may restart the boojs intsance without deleting local storage via sending `$__RESTART__` directly to `stdin` of the boojs instance as
+it's own line. You may then wait for the reply `$__RESTART_OK__`. At this point, boojs will have restarted with a fresh instance except
+that `localStorage` will still be intact.
+
 ## Requirements
 
 - Ruby 2.1 or Higher

data/lib/boojs/version.rb

@@ -1,3 +1,3 @@
 module BooJS
-  VERSION = '0.0.29'
+  VERSION = '0.0.30'
 end

data/lib/boojs.rb

@@ -33,6 +33,7 @@ module BooJS
 
     begin
       #Do we have a syntax error?
+      #Open a pipe and check if syntax_error
       @syntax_error = false
       Timeout.timeout(8) do
         Open3.popen3 "#{$phantomjs_path} #{path}" do |_, out, err, _|
@@ -69,10 +70,16 @@ module BooJS
     return 1
   end
 
+  #Restart request
+  class PipeRestart < Exception
+  end
+
   #Optionally, accept code to inject and a command to run
   #If the command is nil, this is not executed as a oneshot
   def self.pipe(str=nil, cmd=nil, will_timeout=false, output_phantomjs_pid=false)
     js = %{
+      //Clear localStorage
+
       var system = require('system');
       function __spec_ping(str) {
         system.stdout.writeLine("pong"+str)
@@ -121,20 +128,34 @@ module BooJS
 
     @input_sender_r, @input_sender_w = IO.pipe
     
+    #Set to true on restarts, for knowing whether to output $__RESTART_OK__ when the restart finishes
+    pipe_restart = false
     #Phantom JS Process
     begin
       p = IO.popen("#{$phantomjs_path} #{tmp.path}")
 
+      #If it's not a pipe restart, then clear local storage
+      unless pipe_restart
+        @input_sender_w.puts "localStorage.clear();"
+      end
+
       #We are going to do a loop back (ready to rcv) to wait for the JS to respond before outputing the spec PID
       #So that in the specs, we have a reliable way of testing the process execution as ending this process
       #before the child process ends, will termiante the spawned process (PhantomJS) by default but not if it's
       #kept alive for a while (which we handle via sending it an INT in the ensure)
-      if output_phantomjs_pid
+      if output_phantomjs_pid and not pipe_restart #Dont re-emit the PID on pipe restarts
         @input_sender_w.puts "booPing();"
         res = p.readline
         puts p.pid
       end
 
+      #Tell stdout that we did restart
+      if pipe_restart
+        pipe_restart = false
+        puts "$__RESTART_OK__"
+        $stdout.flush
+      end
+
       loop do
         rr, _ = select([p, STDIN]); e = rr[0]
         #PhantomJS has written something
@@ -152,9 +173,18 @@ module BooJS
 
         #User has written to this program
         if e == STDIN
-          @input_sender_w.puts e.readline
+          res = e.readline
+          if res == "$__RESTART__\n"
+            pipe_restart = true
+            raise PipeRestart
+          else
+            @input_sender_w.puts res
+          end
         end
       end
+    rescue PipeRestart
+      Process.kill :INT, p.pid
+      retry
     ensure
       Process.kill :INT, p.pid
     end

data/spec/persist_spec.rb

@@ -0,0 +1,74 @@
+require 'open3'
+Dir.chdir File.join(File.dirname(__FILE__), '../')
+require './spec/helpers'
+
+RSpec.describe "Persist" do
+  $stdout.sync = true
+  it "Does accept the restart command" do
+    Open3.popen3 "ruby -Ilib ./bin/boojs" do |i, o, e, t|
+      begin
+        i.puts "$__RESTART__"
+        res = o.readline
+        expect(res).to eq("$__RESTART_OK__\n")
+      ensure
+        begin
+          Process.kill :INT, t[:pid]
+        rescue Errno::ESRCH
+        end
+      end
+    end
+  end
+
+  it "Does NOT persist during new process" do
+    #Try once
+    Open3.popen3 "ruby -Ilib ./bin/boojs" do |i, o, e, t|
+      begin
+        i.puts "localStorage.setItem('foo', 'bar');"
+        i.puts "console.log(localStorage.getItem('foo'))"
+        res = o.readline
+        expect(res).to eq("bar\n")
+      ensure
+        begin
+          Process.kill :INT, t[:pid]
+        rescue Errno::ESRCH
+        end
+      end
+    end
+
+    #Try again
+    Open3.popen3 "ruby -Ilib ./bin/boojs" do |i, o, e, t|
+      begin
+        i.puts "console.log(localStorage.getItem('foo'))"
+        res = o.readline
+        expect(res).to eq("null\n")
+      ensure
+        begin
+          Process.kill :INT, t[:pid]
+        rescue Errno::ESRCH
+        end
+      end
+    end
+
+  end
+
+  it "Does persist during restarts" do
+    Open3.popen3 "ruby -Ilib ./bin/boojs" do |i, o, e, t|
+      begin
+        i.puts "localStorage.setItem('foo', 'bar');"
+        i.puts "$__RESTART__"
+        res = o.readline
+        expect(res).to eq("$__RESTART_OK__\n")
+
+        i.puts "console.log(localStorage.getItem('foo'))"
+        res = o.readline
+        expect(res).to eq("bar\n")
+      ensure
+        begin
+          Process.kill :INT, t[:pid]
+        rescue Errno::ESRCH
+        end
+      end
+    end
+  end
+
+end

data/spec/sample_spec.rb

@@ -4,64 +4,64 @@ require './spec/helpers'
 
 #Files that are reported as bugged end up here for testing.
 RSpec.describe "Live Culture" do
-#  it "Can run jquery_ajax.js and output success" do
-    #begin
-      #@web = Webbing.get("/", 4545) do |info|
-        #{"hello" => "world"}
-      #end
+ it "Can run jquery_ajax.js and output success" do
+    begin
+      @web = Webbing.get("/", 4545) do |info|
+        {"hello" => "world"}
+      end
 
-      #begin
-        #Timeout.timeout(8) do
-          #IO.popen "ruby -Ilib ./bin/boojs ./spec/samples/jquery_ajax.js", "r" do |p|
-            #begin
-              #@res = p.readline.strip
-            #ensure
-              #Process.kill 9, p.pid
-            #end
-          #end
-        #end
-      #rescue
-      #end
+      begin
+        Timeout.timeout(8) do
+          IO.popen "ruby -Ilib ./bin/boojs ./spec/samples/jquery_ajax.js", "r" do |p|
+            begin
+              @res = p.readline.strip
+            ensure
+              Process.kill 9, p.pid
+            end
+          end
+        end
+      rescue
+      end
 
-      #expect(@res).to eq("success")
-    #ensure
-      #Process.kill(:KILL, @web.pid)
-    #end
-  #end
+      expect(@res).to eq("success")
+    ensure
+      Process.kill(:KILL, @web.pid)
+    end
+  end
 
-  #it "Will output to stderr on syntax error" do
-    #begin
-      #begin
-        #Timeout.timeout(8) do
-          #IO.popen "ruby -Ilib ./bin/boojs ./spec/samples/syntax_problem.js", "r" do |p|
-            #begin
-              #@res = p.readline.strip
-            #ensure
-              #Process.kill 9, p.pid
-            #end
-          #end
-        #end
-      #rescue
-      #end
+  it "Will output to stderr on syntax error" do
+    begin
+      begin
+        Timeout.timeout(8) do
+          IO.popen "ruby -Ilib ./bin/boojs ./spec/samples/syntax_problem.js", "r" do |p|
+            begin
+              @res = p.readline.strip
+            ensure
+              Process.kill 9, p.pid
+            end
+          end
+        end
+      rescue
+      end
 
-      #expect(@res).to eq(nil)
-    #ensure
-    #end
-  #end
+      expect(@res).to eq(nil)
+    ensure
+    end
+  end
 
-  #it "Will output '3' when running inputting set_a_stdin.js via stdin" do
-    #stim = File.open("./spec/samples/set_a_stdin.js")
+  it "Will output '3' when running inputting set_a_stdin.js via stdin" do
+    stim = File.open("./spec/samples/set_a_stdin.js")
 
-    #IO.popen "ruby -Ilib ./bin/boojs", "r+" do |p|
-      #loop do
-        #break if stim.eof
-        #p.puts stim.gets
-      #end
+    IO.popen "ruby -Ilib ./bin/boojs", "r+" do |p|
+      loop do
+        break if stim.eof
+        p.puts stim.gets
+      end
 
-      #res = p.readline.strip
-      #expect(res).to eq("3")
-    #end
-  #end
+      res = p.readline.strip
+      expect(res).to eq("3")
+    end
+  end
 
   $stdout.sync = true
   it "can run another_syntax_problem.js with the correct formatting for error" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: boojs
 version: !ruby/object:Gem::Version
-  version: 0.0.29
+  version: 0.0.30
 platform: ruby
 authors:
 - seo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-29 00:00:00.000000000 Z
+date: 2015-05-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -144,6 +144,7 @@ files:
 - spec/cli_spec.rb
 - spec/functions_spec.rb
 - spec/helpers.rb
+- spec/persist_spec.rb
 - spec/ping_spec.rb
 - spec/sample_spec.rb
 - spec/samples/another_syntax_problem.js
@@ -182,6 +183,7 @@ test_files:
 - spec/cli_spec.rb
 - spec/functions_spec.rb
 - spec/helpers.rb
+- spec/persist_spec.rb
 - spec/ping_spec.rb
 - spec/sample_spec.rb
 - spec/samples/another_syntax_problem.js