bolognese 0.10.2 → 0.10.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fdb263ed4888b67cb1e72c5e70251e297753082ff8c9d8ebc0a828361ffc09b8
-  data.tar.gz: 0ce0f6d026eb9bb4facc6da6063a5635e33dc3709b12e4c3acde674ed8acd15a
+  metadata.gz: bc0b25824fcc0ef740e3a84cee8d5a811481135b183f442f41b7706f29e25623
+  data.tar.gz: 7acdaf20087b71eaa8d49cc9649e3b701066a22c7c250801d55fcfb979d76d3a
 SHA512:
-  metadata.gz: 74a757193724aa369a1adeb421c195e17c7a6f49eda510db374937304a236ee2c1043126027a5814e3ab4245a05d3597dafc67acea11aee6643e33e1638bad37
-  data.tar.gz: cf6ffdc6ea3d908b0f8a74c7dbfba2971223b1472cc7cb2689bdcbc63155d130ce09b674b856d14784d525b6b86efec172f91fe72a4ac2dfb6d3d5b84237406f
+  metadata.gz: d2c0634ea207320e387174a52ea368a066263a06c1e48a838489477d6ae58b87c308c19f864c4768c036bcce606ee017b0ca8ba97a8c1d224bda861bdf82b740
+  data.tar.gz: 6082d4c5f232e1650a0a3b885624aad4476a0ae6033f710f96a4c0e64c03aee010089ab8752a2d99fd309f201eb56a3876a666903a6aa2e7e7c85210b8f38b00

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bolognese (0.10.2)
+    bolognese (0.10.3)
       activesupport (>= 4.2.5, < 6)
       benchmark_methods (~> 0.7)
       bibtex-ruby (~> 4.1)

data/lib/bolognese/metadata.rb

@@ -15,7 +15,7 @@ module Bolognese
         # generate name for method to call dynamically
         hsh = @from.present? ? send("get_" + @from, id: id, sandbox: options[:sandbox]) : {}
         string = hsh.fetch("string", nil)
-      elsif File.exist?(input)
+      elsif input.present? && File.exist?(input)
         ext = File.extname(input)
         if %w(.bib .ris .xml .json).include?(ext)
           string = IO.read(input)

data/lib/bolognese/metadata_utils.rb

@@ -90,7 +90,7 @@ module Bolognese
     end
 
     def should_passthru
-      (from == "datacite") && regenerate.blank?
+      (from == "datacite") && regenerate.blank? && raw.present?
     end
 
     def type

data/lib/bolognese/version.rb

@@ -1,3 +1,3 @@
 module Bolognese
-  VERSION = "0.10.2"
+  VERSION = "0.10.3"
 end

data/spec/writers/datacite_writer_spec.rb

@@ -175,7 +175,18 @@ describe Bolognese::Metadata, vcr: true do
       expect(subject.doi).to eq("10.4124/05f6c379-dd68-4cdb-880d-33d3e9576d52/1")
       expect(subject.service_provider).to eq("DataCite")
       expect(subject.state).to eq("not_found")
-      expect(subject.datacite).to be_nil
+      datacite = Maremma.from_xml(subject.datacite).fetch("resource", {})
+      expect(datacite["identifier"]).to eq("identifierType"=>"DOI", "__content__"=>"10.4124/05f6c379-dd68-4cdb-880d-33d3e9576d52/1")
+      expect(datacite["xmlns"]).to eq("http://datacite.org/schema/kernel-4")
+    end
+
+    it "no input" do
+      input = nil
+      subject = Bolognese::Metadata.new(input: input, from: "datacite", doi: "10.4124/05f6c379-dd68-4cdb-880d-33d3e9576d52/1")
+      expect(subject.valid?).to be false
+      datacite = Maremma.from_xml(subject.datacite).fetch("resource", {})
+      expect(datacite["identifier"]).to eq("identifierType"=>"DOI", "__content__"=>"10.4124/05f6c379-dd68-4cdb-880d-33d3e9576d52/1")
+      expect(datacite["xmlns"]).to eq("http://datacite.org/schema/kernel-4")
     end
   end
 
@@ -208,6 +219,15 @@ describe Bolognese::Metadata, vcr: true do
       expect(datacite.dig("descriptions", "description")).to eq("descriptionType"=>"Abstract", "__content__"=>"This is an abstract.")
     end
 
+    it "change description no input" do
+      input = nil
+      subject = Bolognese::Metadata.new(input: input, from: "datacite", doi: "10.4124/05f6c379-dd68-4cdb-880d-33d3e9576d52/1")
+      subject.description = "This is an abstract."
+      expect(subject.valid?).to be false
+      datacite = Maremma.from_xml(subject.datacite).fetch("resource", {})
+      expect(datacite.dig("descriptions", "description")).to eq("descriptionType"=>"Abstract", "__content__"=>"This is an abstract.")
+    end
+
     it "change license" do
       input = "10.7554/eLife.01567"
       subject = Bolognese::Metadata.new(input: input, from: "crossref")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bolognese
 version: !ruby/object:Gem::Version
-  version: 0.10.2
+  version: 0.10.3
 platform: ruby
 authors:
 - Martin Fenner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-05-07 00:00:00.000000000 Z
+date: 2018-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: maremma