blz 0.1.4.20140907.1 → 0.1.4.20140907.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c92ba1e85bfb29f54aa927bfed7c67711cbb2c30
-  data.tar.gz: ece9e41ea54f2d17311b10d2133556b1ae01f54a
+  metadata.gz: dcc624f8a1d94f6442eeca3cc87fc50159bf2915
+  data.tar.gz: 4aaa942082b94a7d76dd6cedd970ae133af8067d
 SHA512:
-  metadata.gz: de5fb1a8059494dcad8488e4d95901973fe3a9e457aa41c2740eebeac8b202ab3455ede3254bd1640bcdd434816cbde170be03a4a6f53c38fa9cd227bac07cdd
-  data.tar.gz: 0593c80481b54d1b1cd4f3c8c297c02da09d3ba2231a74d2c1bb5ab6567c9886d734d3aeb59336cf01d5d2ed5039d18ecacaa0341aa876e3ce5fb78924c73b21
+  metadata.gz: 112044c5a3cd5df8c4a8e26d7d11f76d0e57e8710b6bf51e398d3832904f450eedf0defe2cbb988a525498da8da2a3b6c8a8bb2784eb840ee24dbc972d2b669b
+  data.tar.gz: b68b0f12573d8ae07d755f0b7c0b20fa3dcd837ab82adca8657a61c71193863fae447aa971fe84fb091ed9f7c844eed9dfe9d391fccdf6dc65f3f25f1de2e5ba

data/CHANGELOG.md

@@ -1,4 +1,8 @@
-# 0.1.4.20140907a, released 2014-07-11
+# 0.1.4.20140907.2, released 2014-07-25
+
+* finders return an empty array when given `nil` or a blank string
+
+# 0.1.4.20140907.1, released 2014-07-11
 
 * apply update BIC of Sberbank (SEZBDEF1XXX → SEZDDEF1XXX)
   after Bundesbank ExtraNet notifcation from 2014-07-10

data/blz.gemspec

@@ -4,7 +4,7 @@ extra_rdoc_files = ['CHANGELOG.md', 'LICENSE', 'README.md']
 
 Gem::Specification.new do |s|
   s.name            = 'blz'
-  s.version         = '0.1.4.20140907.1'
+  s.version         = '0.1.4.20140907.2'
   s.platform        = Gem::Platform::RUBY
   s.summary         = "BLZ (Bankleitzahlen) for Ruby"
 

data/lib/blz/bank.rb

@@ -11,6 +11,8 @@ module BLZ
       #    exact:: Only return exact matches (false by default)
       #
       def find_by_blz(code, options = {})
+        return [] if blank?(code)
+
         exact = options.fetch(:exact, false)
         all.select do |bank|
           bank.blz == code || (!exact && bank.blz.start_with?(code))
@@ -19,6 +21,8 @@ module BLZ
 
       # Returns an array of all Banks with a substring of +city+.
       def find_by_city(substring)
+        return [] if blank?(substring)
+
         all.select do |bank|
           bank.city.index(substring)
         end
@@ -29,6 +33,8 @@ module BLZ
       #    exact:: Only return exact matches (false by default)
       #
       def find_by_bic(bic, options = {})
+        return [] if blank?(bic)
+
         exact = options.fetch(:exact, false)
         all.select do |bank|
           bank.bic == bic || (!exact && (bank.bic || '').start_with?(bic))
@@ -51,6 +57,18 @@ module BLZ
         end
         banks
       end
+
+      # Checks whether an object is blank (empty Array/Hash/String).
+      #
+      # Does not rely on ActiveSupport, but prefers that implementation.
+      def blank?(obj)
+        return true       if obj.nil?
+        return obj.blank? if obj.respond_to?(:blank?)
+        obj = obj.strip   if String === obj
+        return obj.empty? if obj.respond_to?(:empty?)
+
+        false
+      end
     end
 
     attr_reader :blz, :name, :zip, :city, :short_name, :bic
@@ -69,5 +87,6 @@ module BLZ
     def to_s
       [blz, name, "#{zip} #{city}", bic].compact.reject(&:empty?).join(', ')
     end
+
   end
 end

data/test/test_bank.rb

@@ -51,6 +51,16 @@ class TestBank < Test::Unit::TestCase
     assert results.find { |b| b.blz == "70150000" }
   end
 
+  def test_search_by_empty_bic
+    assert results = BLZ::Bank.find_by_bic('')
+    assert results.size == 0
+  end
+
+  def test_search_by_nil_bic
+    assert results = BLZ::Bank.find_by_bic(nil)
+    assert results.size == 0
+  end
+
   def test_to_s
     assert results = BLZ::Bank.find_by_blz("70150000", :exact_only => true)
     assert_equal 1, results.size

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: blz
 version: !ruby/object:Gem::Version
-  version: 0.1.4.20140907.1
+  version: 0.1.4.20140907.2
 platform: ruby
 authors:
 - Oliver Eilhard
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-11 00:00:00.000000000 Z
+date: 2014-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler