bluebird 0.1.0 → 0.2.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    NzdhMmI0OGJlM2U2ZjEwY2IxMzg0ZmJlZmNjOTNhYzg5MTQxOWY3Yg==
+    OWQ5YzRmNjg2NjhlNDRlZDk2NjZhNWM1MmMyOGUwZmRjZWI3NmUzMg==
   data.tar.gz: !binary |-
-    YTA5YmQ1MjQxNWE5MzBhNjQwNzc5NzRiY2QyNzQ2MTEzNDZjZDY0YQ==
+    YjUxZjAwMDM0MjljNjE2NzQ2MTc1ZmNhYWMxYmZkM2QxZTQ3ZTVkYw==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    NTIxM2QzMGExZGYxNjY0ZTRhMmZkZDc5N2M1MDllODA2ZTliMjQzZWZiNzY4
-    ZDczYzJkNjdkN2JkZTczNTI1OGQ3OTYyYTc1ZmY5OThiZjhkYjI1ODczNTAy
-    OWU1YzIwYmJjM2M1ZTNjMmQ1OGMzNjkxZGFkZGMwZjI0YTEwMTU=
+    YThhNjgwNmYwZWJhMWYwZmRlMDNjY2JkN2I1ZmY2NDc4MjhhNTY4YWY0OTNk
+    NTcwOGVmNjRlM2I3MDNmNDE5ZDE2YWQ2OTBkOTc4ZTM0NTMxZjBlNjM0MzEz
+    ZDE4NjYyOGRlZDRmOTk3YWU3MTUyZTc1NTkwZDU0ZWRkYzg2ZjM=
   data.tar.gz: !binary |-
-    NzFiYTYxY2M3ZmQ4YTlmNjZhNDE4MmUwZDQzMmYxMjUxMjM4MDRjMTI1Y2Ey
-    MjIzYzU4MzE2ODU5ODJjM2UwYzUzYjRiMGQwYTgxZTk3ZTUxYjc1YzA2YTA2
-    YTdlNTRiMGJhYmMyNzVmMmRiMWFhMDhiZmIwNjE0NzU0NDdhN2Q=
+    OWFlZGQ5MDdkMWY5MmFlNTg3OThkMWE5MzM2YTZhYWJlZmQ4MWQ0N2M0ZDBj
+    ZjE4YmMwOTZmYjgwMzE5MjMwYTY5M2VjYjU5OTI5ZThhYmI0MmYyN2ExN2Mz
+    OTgzNzUyYzlhODIwMWIwYjIwNDAwNDYwYmRhNDIwZGM3OGZiMGY=

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+# Changelog
+
+## 0.2.0 (March 13, 2014)
+
+  * Feature: via strategy added
+
+## 0.1.0 (March 4, 2014)
+
+  * initial release

data/README.md

@@ -1,4 +1,4 @@
-# Bluebird
+# Bluebird [![Gem Version](https://emrekutlu-test-1.appspot.com/gems/bluebird/version.png?right_bg=4183c4)](https://rubygems.org/gems/bluebird)
 
 Bluebird modifies your tweets, mostly to fit 140 characters.  
 It uses "strategies". Every strategy makes its own modifications to the tweets.  
@@ -41,7 +41,7 @@ end
 
 If you want to change defaults for Rails, create a file in <code>initializers</code> folder and copy the code above.  
 
-By default bluebird runs three strategies in these order; <code>strip</code>, <code>squeeze</code> and <code>truncate</code>. For detailed information about each strategy, visit [Strategies](https://github.com/emrekutlu/bluebird/wiki/Strategies).
+By default bluebird runs three strategies in these order; <code>strip</code>, <code>squeeze</code> and <code>truncate_text</code>. For detailed information about each strategy, visit [Strategies](https://github.com/emrekutlu/bluebird/wiki/Strategies).
 
 ## Usage
 

data/lib/bluebird.rb

@@ -8,6 +8,7 @@ require 'bluebird/strategies/base'
 require 'bluebird/strategies/strip'
 require 'bluebird/strategies/squeeze'
 require 'bluebird/strategies/truncate_text'
+require 'bluebird/strategies/via'
 
 module Bluebird
   class << self

data/lib/bluebird/partial.rb

@@ -1,6 +1,7 @@
 module Bluebird
   class Partial
 
+    attr_reader   :partial_type
     attr_accessor :content, :prev_partial, :next_partial
 
     def initialize(content, partial_type)

data/lib/bluebird/strategies/via.rb

@@ -0,0 +1,4 @@
+require 'bluebird/strategies/via/strategy'
+require 'bluebird/strategies/via/config'
+
+Bluebird::Config.register(:via, Bluebird::Strategies::Via::Config)

data/lib/bluebird/strategies/via/config.rb

@@ -0,0 +1,15 @@
+module Bluebird
+  module Strategies
+    module Via
+      class Config
+
+        @prefix = 'via'
+
+        class << self
+          attr_accessor :prefix, :username
+        end
+
+      end
+    end
+  end
+end

data/lib/bluebird/strategies/via/strategy.rb

@@ -0,0 +1,62 @@
+module Bluebird
+  module Strategies
+    module Via
+      class Strategy < Bluebird::Strategies::Base
+        class << self
+
+          def run(tweet, config)
+            if run?(config.via.username)
+              add_separator(tweet)
+              tweet.add_partial(text(config.via), :via)
+            end
+          end
+
+          private
+
+          def run?(username)
+            username_exists?(username) ? true : raise('Bluebird: config.via.username is missing.')
+          end
+
+          def add_separator(tweet)
+            if add_separator?(tweet)
+              add_separator_partial?(tweet) ? add_separator_partial(tweet) : add_space_to_last_partial(tweet)
+            end
+          end
+
+          def text(via_config)
+            "#{via_config.prefix} @#{via_config.username}"
+          end
+
+          def username_exists?(username)
+            if username
+              username.strip!
+              !username.eql?('')
+            else
+              false
+            end
+          end
+
+          def add_separator_partial?(tweet)
+            !tweet.partials.last.text?
+          end
+
+          def add_separator?(tweet)
+            tweet.partials.length > 0
+          end
+
+          def add_separator_partial(tweet)
+            tweet.add_partial(' ', :text)
+          end
+
+          def add_space_to_last_partial(tweet)
+            last = tweet.partials.last
+            unless last.content.end_with?(' ')
+              last.content += ' '
+            end
+          end
+
+        end
+      end
+    end
+  end
+end

data/lib/bluebird/tweet.rb

@@ -7,7 +7,8 @@ module Bluebird
 
     def initialize(status, opts = {})
       @original_status = status
-      @partials = extract_partials(status)
+      @partials = []
+      extract_partials(status)
       @media = opts[:media] if opts.has_key?(:media)
     end
 
@@ -39,6 +40,19 @@ module Bluebird
       partials.select { |partial| partial.cashtag? }
     end
 
+    def add_partial(content, partial_type)
+      if eligible_content?(content)
+        partial = Partial.new(content, partial_type)
+
+        if (last = partials.last)
+          last.next_partial = partial
+          partial.prev_partial = last
+        end
+
+        partials << partial
+      end
+    end
+
     private
 
     def total_partial_length
@@ -59,35 +73,19 @@ module Bluebird
       entities = extract_entities_with_indices(status, extract_url_without_protocol: true)
       length   = status.char_length
       index    = 0
-      partials = []
 
       entities.each do |entity|
         first = entity[:indices].first
         last  = entity[:indices].last
 
-        add_partial(partials, status[index, first - index], :text)
-        add_partial(partials, status[first, last - first], entity_type(entity))
+        add_partial(status[index, first - index], :text)
+        add_partial(status[first, last - first], entity_type(entity))
 
         index = last
       end
 
       if ending_partial?(index, length)
-        add_partial(partials, status[index, length - index], :text)
-      end
-
-      partials
-    end
-
-    def add_partial(partials, content, partial_type)
-      if eligible_content?(content)
-        partial = Partial.new(content, partial_type)
-
-        if (last = partials.last)
-          last.next_partial = partial
-          partial.prev_partial = last
-        end
-
-        partials << partial
+        add_partial(status[index, length - index], :text)
       end
     end
 

data/lib/bluebird/version.rb

@@ -1,3 +1,3 @@
 module Bluebird
-  VERSION = '0.1.0'
+  VERSION = '0.2.0'
 end

data/spec/strategies/via/strategy_spec.rb

@@ -0,0 +1,85 @@
+require 'spec_helper'
+
+describe Bluebird::Strategies::Via::Strategy do
+
+  let!(:strategy) { Bluebird::Strategies::Via::Strategy }
+
+  describe '#username_exists?' do
+    context 'When username is nil' do
+      it 'returns false' do
+        expect(strategy.send(:username_exists?, nil)).to be_false
+      end
+    end
+    context "When username is ''" do
+      it 'returns false' do
+        expect(strategy.send(:username_exists?, '')).to be_false
+      end
+    end
+    context "When username is ' '" do
+      it 'returns false' do
+        expect(strategy.send(:username_exists?, ' ')).to be_false
+      end
+    end
+    context 'When username is iekutlu' do
+      it 'returns false' do
+        expect(strategy.send(:username_exists?, 'iekutlu')).to be_true
+      end
+    end
+  end
+
+  describe '#text' do
+    it "adds 'prefix' to the begining" do
+      config = Bluebird::Strategies::Via::Config
+      config.username = 'iekutlu'
+      config.prefix   = 'via'
+      expect(strategy.send(:text, config).start_with?('via')).to be_true
+    end
+    it 'adds username to the end' do
+      config = Bluebird::Strategies::Via::Config
+      config.username = 'iekutlu'
+      expect(strategy.send(:text, config).end_with?('@iekutlu')).to be_true
+    end
+  end
+
+  describe '#add_separator?' do
+    context 'When tweet is not empty' do
+      it 'returns true' do
+        tweet = Bluebird::Tweet.new('Lorem ipsum')
+        expect(strategy.send(:add_separator?, tweet)).to be_true
+      end
+    end
+    context 'When tweet is empty' do
+      it 'returns false' do
+        tweet = Bluebird::Tweet.new('')
+        expect(strategy.send(:add_separator?, tweet)).to be_false
+      end
+    end
+  end
+
+  describe '#add_separator_partial' do
+    it "adds a new text partial whose content is ' '" do
+      tweet = Bluebird::Tweet.new('Lorem #ipsum')
+      strategy.send(:add_separator_partial, tweet)
+      last = tweet.partials.last
+      expect(last.text?).to be_true
+      expect(last.content).to eq ' '
+    end
+  end
+
+  describe '#add_space_to_last_partial' do
+    context 'When text partial has trailing space' do
+      it 'does not add trailing space' do
+        tweet = Bluebird::Tweet.new('Lorem ipsum ')
+        strategy.send(:add_space_to_last_partial, tweet)
+        expect(tweet.status).to eq 'Lorem ipsum '
+      end
+    end
+    context 'When text partial does not have trailing space' do
+      it 'adds trailing space' do
+        tweet = Bluebird::Tweet.new('Lorem ipsum')
+        strategy.send(:add_space_to_last_partial, tweet)
+        expect(tweet.status).to eq 'Lorem ipsum '
+      end
+    end
+  end
+end

data/spec/tweet_spec.rb

@@ -60,6 +60,13 @@ describe Bluebird::Tweet do
   end
 
   describe '#extract_partials' do
+
+    context 'When status is empty' do
+      it 'does not add any partial' do
+        tweet = Bluebird::Tweet.new('')
+        expect(tweet.partials.length).to eq 0
+      end
+    end
     it 'breaks tweet into partials' do
       tweet = Bluebird::Tweet.new('Lorem ipsum')
       expect(tweet.partials.length).to eq 1
@@ -206,4 +213,50 @@ describe Bluebird::Tweet do
       expect(partial.mention?).to be_true
     end
   end
+
+  describe '#add_partial' do
+
+    it 'sets the partial type' do
+      tweet = Bluebird::Tweet.new('Lorem ipsum dolor')
+      tweet.add_partial(' sit amet', :sit_amet)
+      expect(tweet.partials.last.partial_type).to be :sit_amet
+    end
+
+    context 'When there is no partials' do
+      it 'adds a new partial to the end of the tweet' do
+        tweet = Bluebird::Tweet.new('')
+        tweet.add_partial('Lorem ipsum', :text)
+        expect(tweet.partials.length).to be 1
+        partial = tweet.partials.first
+        expect(partial.prev_partial).to be nil
+        expect(partial.next_partial).to be nil
+      end
+    end
+
+    context 'When there is already one partial' do
+      it 'adds a new partial to the end of the tweet' do
+        tweet = Bluebird::Tweet.new('Lorem ipsum dolor')
+        expect(tweet.partials.length).to eq 1
+        tweet.add_partial(' sit amet', :text)
+        expect(tweet.partials.length).to eq 2
+        expect(tweet.partials.last.content).to eq ' sit amet'
+      end
+      it 'sets the next_partial of the first partial' do
+        tweet = Bluebird::Tweet.new('Lorem ipsum dolor')
+        first_partial = tweet.partials.first
+        tweet.add_partial(' sit amet', :sit_amet)
+        last_partial = tweet.partials.last
+        expect(first_partial.prev_partial).to be nil
+        expect(first_partial.next_partial).to be last_partial
+      end
+      it 'sets the prev_partial of the new partial' do
+        tweet = Bluebird::Tweet.new('Lorem ipsum dolor')
+        first_partial = tweet.partials.first
+        tweet.add_partial(' sit amet', :sit_amet)
+        last_partial = tweet.partials.last
+        expect(last_partial.prev_partial).to be first_partial
+        expect(last_partial.next_partial).to be nil
+      end
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bluebird
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - İ. Emre Kutlu
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-04 00:00:00.000000000 Z
+date: 2014-03-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: twitter-text
@@ -74,6 +74,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -90,12 +91,16 @@ files:
 - lib/bluebird/strategies/truncate_text.rb
 - lib/bluebird/strategies/truncate_text/config.rb
 - lib/bluebird/strategies/truncate_text/strategy.rb
+- lib/bluebird/strategies/via.rb
+- lib/bluebird/strategies/via/config.rb
+- lib/bluebird/strategies/via/strategy.rb
 - lib/bluebird/tweet.rb
 - lib/bluebird/version.rb
 - spec/spec_helper.rb
 - spec/strategies/squeeze/strategy_spec.rb
 - spec/strategies/strip/strategy_spec.rb
 - spec/strategies/truncate_text/strategy_spec.rb
+- spec/strategies/via/strategy_spec.rb
 - spec/tweet_spec.rb
 homepage: http://github.com/emrekutlu/bluebird
 licenses:
@@ -126,4 +131,5 @@ test_files:
 - spec/strategies/squeeze/strategy_spec.rb
 - spec/strategies/strip/strategy_spec.rb
 - spec/strategies/truncate_text/strategy_spec.rb
+- spec/strategies/via/strategy_spec.rb
 - spec/tweet_spec.rb