bloomberg_currency 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 5750a9ea831b7ce49a0e34ea6f50dd02e055a84c
-  data.tar.gz: d8d18e027f2fb8af17eecb69272e7eba0db81dab
+SHA256:
+  metadata.gz: d93abee4c1b84e8d2f7f697463b6c980f3bb11c1444c726b438ad486fd7b7f4a
+  data.tar.gz: e3643047ac9eb1addbe921c7bd34a7875895de1f2b34df26ba29b08c2fa99049
 SHA512:
-  metadata.gz: fae8f01e406f1ad92d792eaa7a3e4bc90faa3f39b75cace02be43b9fd1226c9c9b2e71e7ac5eb16b1730c1c4687839f79d869f9cde3b1fa7c449a00911a7db1b
-  data.tar.gz: fa004d8549d9606417bc50b3d5230ac8eeabf7897e3f49750bd9febaa98980831ee57a059560ffa40db49cc7e9cf10bf7bc6d4f289ae93faaff816eb7e45111f
+  metadata.gz: 17d85ed4ce21f18931f73453fd73c366b67695fb211e20197daa7159df590a852511fe3e09bceb8b0f7165359a45aede0dd090635671eba4d11f08c221b4a667
+  data.tar.gz: edf076ecd3c68af199a69f1275012193b606c15efba3dece0a9c275abe19dbfe160135f0f6cb1c3db6b24ddb41e3724f14aa864de2fff1439ec1c65721dba7e3

data/.gitignore

@@ -14,4 +14,4 @@ codeclimate-coverage-reporter.sh
 .DS_Store
 */**/.DS_Store
 
-.byebug_history
+/.byebug_history

data/.rubocop.yml

@@ -5,10 +5,18 @@ AllCops:
     - '**/Rakefile'
     - '**/config.ru'
   Exclude:
+    - bloomberg_currency.gemspec
     - 'db/**/*'
     - 'config/**/*'
     - 'script/**/*'
+    - 'spec/**/*'
     - !ruby/regexp /old_and_unused\.rb$/
 
 Metrics/LineLength:
-  Max: 120
+  Max: 120
+
+Metrics/MethodLength:
+  Max: 12
+
+Metrics/AbcSize:
+  Max: 18

data/.rubocop_todo.yml

@@ -1,7 +1,25 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2016-11-11 16:25:35 -0500 using RuboCop version 0.45.0.
+# on 2018-01-17 08:55:47 -0500 using RuboCop version 0.49.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Layout/EmptyLineAfterMagicComment:
+  Exclude:
+    - 'Gemfile'
+
+# Offense count: 1
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/BlockLength:
+  Max: 28
+
+# Offense count: 1
+# Configuration parameters: ExpectMatchingDefinition, Regex, IgnoreExecutableScripts, AllowedAcronyms.
+# AllowedAcronyms: CLI, DSL, ACL, API, ASCII, CPU, CSS, DNS, EOF, GUID, HTML, HTTP, HTTPS, ID, IP, JSON, LHS, QPS, RAM, RHS, RPC, SLA, SMTP, SQL, SSH, TCP, TLS, TTL, UDP, UI, UID, UUID, URI, URL, UTF8, VM, XML, XMPP, XSRF, XSS
+Style/FileName:
+  Exclude:
+    - 'Gemfile'

data/.ruby_version

@@ -0,0 +1 @@
+2.6.5

data/.travis.yml

@@ -1,6 +1,6 @@
 sudo: false
 language: ruby
 rvm:
-  - 2.2.4
-before_install: gem install bundler -v 1.13.6
-before_script: rubocop
+  - 2.6.5
+before_install: gem install bundler -v 1.17.2
+before_script: rubocop

data/bloomberg_currency.gemspec

@@ -34,12 +34,15 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 1.13'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '>= 12.3.3'
   spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'simplecov', '~> 0.11'
   spec.add_development_dependency 'rubocop', '~> 0.49.0'
   spec.add_development_dependency 'codeclimate-test-reporter', '~> 1.0', '>= 1.0.0'
   spec.add_development_dependency 'pry-byebug', '~> 3.5.1'
+  spec.add_development_dependency 'vcr', '~> 6.0.0'
+  spec.add_development_dependency 'webmock', '~> 3.5.0'
 
   spec.add_runtime_dependency 'nokogiri', '~> 1.6', '>= 1.6.8'
+  spec.add_runtime_dependency 'faraday', '~> 0.9.2'
 end

data/lib/bloomberg_currency.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require 'bloomberg_currency/version'
+require 'bloomberg_currency/api'
 require 'bloomberg_currency/api/site'
 require 'bloomberg_currency/api/host'
 require 'bloomberg_currency/quote'

data/lib/bloomberg_currency/api.rb

@@ -0,0 +1,7 @@
+module BC
+  module API
+    USER_AGENT = 'Mozilla/5.0 (Macintosh; Intel Mac OS X 11_2_1) '\
+                 'AppleWebKit/537.36 (KHTML, like Gecko) '\
+                 'Chrome/88.0.4324.150 Safari/537.36'.freeze
+  end
+end

data/lib/bloomberg_currency/api/site.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'open-uri'
+require 'faraday'
 require 'nokogiri'
 require 'bigdecimal'
 
@@ -21,8 +21,14 @@ module BC
         end
 
         def load_site(currency_one, currency_two)
-          file = open("#{BC::API::Host::URL}#{currency_one}#{currency_two}:CUR")
-          Nokogiri::HTML(file)
+          url = "#{BC::API::Host::URL}#{currency_one}#{currency_two}:CUR"
+          headers = {
+            'user-agent' => BC::API::USER_AGENT,
+            'referer' => 'https://www.google.com/'
+          }
+          file = Faraday.get(url, nil, headers)
+
+          Nokogiri::HTML(file.body)
         end
 
         def parse(document)
@@ -32,30 +38,57 @@ module BC
         end
 
         def parse_quote(document)
-          price_container          = document.xpath("//div[contains(@class, 'price-container')]")
-          detailed_quote_container = document.xpath("//div[contains(@class, 'detailed-quote')]")
-
-          price_element            = price_container.xpath("//div[@class='price']")
-          price_datetime_element   = price_container.xpath("//div[@class='price-datetime']")
-
+          price_container          = document.xpath("//section[contains(@class, 'quotePageSnapshot')]")
+          detailed_quote_container = document.xpath("//div[contains(@class, 'details__')]")
+          price_element            = price_container.xpath("//span[starts-with(@class, 'priceText__')]")
+          price_datetime_element   = price_container.xpath("//div[contains(@class, 'time__')]")
           price                    = price_element.text.strip.tr(',', '').to_f
-          datetime                 = DateTime.strptime(price_datetime_element.text.strip, 'As of %H:%M %p %z %m/%d/%Y')
+          datetime                 = calculate_datetime(price_datetime_element.children.first.text.strip)
           details_hash             = quote_details(detailed_quote_container)
 
           { price: price, datetime: datetime, detail: BC::QuoteDetail.new(details_hash), available: true }
         end
 
         def quote_details(container)
-          detail_elements = container.xpath("//div[@class='data-table data-table_detailed']").xpath(
-            "//div[contains(@class, 'cell') and contains(@class, 'cell__mobile-basic')]"
-          )
-
-          details_hash = {}
-          details_matrix = detail_elements.map { |a| a.text.strip.split('   ') }
-          details_matrix.each do |key_value_array|
-            details_hash[key_value_array[0].downcase.tr(' ', '_').to_sym] = key_value_array[1]
+          open_price = extract_value_from_detail(container, 'openprice')
+          previous_close = extract_value_from_detail(container, 'previousclosingpriceonetradingdayago')
+          total_return_ytd = extract_value_from_detail(container, 'totalreturnytd')
+          range_one_day = extract_values_for_range(container, 'rangeoneday')
+          range_52_weeks = extract_values_for_range(container, 'range52weeks')
+
+          {
+            open: open_price,
+            day_range: range_one_day,
+            previous_close: previous_close,
+            range_52_wks: range_52_weeks,
+            ytd_return: total_return_ytd
+          }
+        end
+
+        def extract_value_from_detail(container, section)
+          container
+            .xpath("//section[contains(@class, '#{section}')]")
+            .children[1].text
+        end
+
+        def extract_values_for_range(container, section)
+          container
+            .xpath("//section[contains(@class, '#{section}')]")
+            .children[1]
+            .children[0]
+            .children
+            .map(&:text)
+            .join('-')
+        end
+
+        def calculate_datetime(datetime_str)
+          if datetime_str.index(':')
+            DateTime.strptime(datetime_str, 'As of %H:%M %p %z %m/%d/%Y').to_s
+          else
+            DateTime.strptime(datetime_str, 'As of %m/%d/%Y').to_date.to_s
           end
-          details_hash
+        rescue
+          ''
         end
       end
     end

data/lib/bloomberg_currency/quote.rb

@@ -4,6 +4,7 @@ module BC
   # Quote Information Class
   class Quote
     attr_accessor :price, :datetime, :detail, :available
+
     def initialize(currency_one, currency_two)
       result     = BC::API::Site.quote(currency_one, currency_two)
 

data/lib/bloomberg_currency/quote_detail.rb

@@ -9,7 +9,7 @@ module BC
       @open                = process_float(attributes[:open])
       @day_range           = process_range(attributes[:day_range])
       @previous_close      = process_float(attributes[:previous_close])
-      @last_52_weeks_range = process_range(attributes[:"52wk_range"])
+      @last_52_weeks_range = process_range(attributes[:range_52_wks])
       @ytd_return          = process_float(attributes[:ytd_return])
     end
 

data/lib/bloomberg_currency/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BC
-  VERSION = '1.0.0'.freeze
+  VERSION = '1.1.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bloomberg_currency
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Sebastian Jimenez Velez
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-16 00:00:00.000000000 Z
+date: 2021-02-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,16 +28,16 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -84,22 +84,22 @@ dependencies:
   name: codeclimate-test-reporter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '1.0'
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.0.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: pry-byebug
   requirement: !ruby/object:Gem::Requirement
@@ -114,6 +114,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.5.1
+- !ruby/object:Gem::Dependency
+  name: vcr
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 6.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 6.0.0
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.5.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.5.0
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -134,6 +162,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.6.8
+- !ruby/object:Gem::Dependency
+  name: faraday
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.9.2
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.9.2
 description: Provides an easy to use API to get currency rates data from the Bloomberg
   website
 email:
@@ -142,11 +184,11 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".byebug_history"
 - ".gitignore"
 - ".rspec"
 - ".rubocop.yml"
 - ".rubocop_todo.yml"
+- ".ruby_version"
 - ".simplecov"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
@@ -158,6 +200,7 @@ files:
 - bin/setup
 - bloomberg_currency.gemspec
 - lib/bloomberg_currency.rb
+- lib/bloomberg_currency/api.rb
 - lib/bloomberg_currency/api/host.rb
 - lib/bloomberg_currency/api/site.rb
 - lib/bloomberg_currency/quote.rb
@@ -183,8 +226,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Bloomberg Currency helps you pull currency rates data from the Bloomberg