blood_contracts-core 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7c89ea50c7af537eb81bfd8f949165ffaffde2bdeb9aec92668e601acc90802c
-  data.tar.gz: 6c85bee20832ba39fc933987823b1dcbc7583ab0f991599837a2f0625d74d826
+  metadata.gz: 7f3ff63364178ca281b22b2ca291904ce9a70ec47056a41f9a622dd9a00c9a55
+  data.tar.gz: b5b000306c85eb7871fb3f4ad1c7a96d4fd8dbc8ceeab98bab49f50a78f611b0
 SHA512:
-  metadata.gz: fe7e788aac1df68e58bd5e28f2dfcf875f5b47deca6b0012cd309b81749f147b712290608d513bf97421f5064813e3a44a14888d63c774ac8f01cfa0027c27c0
-  data.tar.gz: 0a349cdc0f9f668fe7cda58a3531e322f6b76ee8116640ce4aad9e25d7ae58680f8a3c00cadc80c202b525974d6a66637b0c35ec5e7947a93d9e70bb375af061
+  metadata.gz: d84a0a438d5d264240e40ef8ba79f2732bcfa3f81d11533e9131b175887197c87e0ed84931126cf7aaa897c6fc7b68b7c0b17fc5ea49c03a383fec86ada6c658
+  data.tar.gz: 614ed9eb7021fc53fc0e55384868599afcfefb84437cf52a6739cb84e615bc929a3e5ad15ead259629820b32627d2641ae0f6738e33dda05ba8aa6d6cc94a864

data/CHANGELOG.md

@@ -5,6 +5,13 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## [0.4.1] - [2019-07-04]
+
+Fixes:
+
+Replaces the default context object in BC::Refined with simple Hash. No need to have default value for the context
+key elements. It violates principlke of least surprise.
+
 ## [0.4.0] - [2019-06-25]
 
 This is a first public release marked in change log with features extracted from production app.

data/blood_contracts-core.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name          = "blood_contracts-core"
-  gem.version       = "0.4.0"
+  gem.version       = "0.4.1"
   gem.authors       = ["Sergey Dolganov (sclinede)"]
   gem.email         = ["sclinede@evilmartians.com"]
 

data/lib/blood_contracts/core/anything.rb

@@ -1,7 +1,6 @@
 module BloodContracts::Core
   # Refinement type which represents data which is always correct
   class Anything < Refined
-
     # The type which is the result of data matching process
     # (for Anything is always self)
     #

data/lib/blood_contracts/core/pipe.rb

@@ -21,7 +21,7 @@ module BloodContracts::Core
         names ||= []
 
         raise ArgumentError unless args.all? { |type| type < Refined }
-        pipe = Class.new(Pipe) { def inspect; super; end }
+        pipe = Class.new(self) { def inspect; super; end }
         finalize!(pipe, args, names)
         pipe.class_eval(&block) if block_given?
         pipe
@@ -35,7 +35,7 @@ module BloodContracts::Core
       # rubocop:disable Style/CaseEquality
       def and_then(other_type, **kwargs)
         raise ArgumentError unless Class === other_type
-        pipe = Class.new(Pipe) { def inspect; super; end }
+        pipe = Class.new(self) { def inspect; super; end }
         finalize!(pipe, [self, other_type], kwargs[:names].to_a)
         pipe
       end
@@ -80,6 +80,7 @@ module BloodContracts::Core
     def initialize(*)
       super
       @context[:steps] = @context[:steps].to_a
+      @context[:steps_values] = {}
     end
 
     # The type which is the result of data matching process

data/lib/blood_contracts/core/refined.rb

@@ -73,7 +73,7 @@ module BloodContracts::Core
     # @param [Object] value that Refined holds and should match
     # @option [Hash<Symbol, Object>] context to share between types
     #
-    def initialize(value, context: Hash.new { |h, k| h[k] = {} }, **)
+    def initialize(value, context: {}, **)
       @errors = []
       @context = context
       @value = value
@@ -84,7 +84,7 @@ module BloodContracts::Core
     # @return [BC::Refined]
     #
     protected def match
-      fail NotImplementedError
+      raise NotImplementedError
     end
     alias call match
 

data/lib/blood_contracts/core/sum.rb

@@ -23,7 +23,7 @@ module BloodContracts::Core
           type.respond_to?(:sum_of) ? acc + type.sum_of.to_a : acc << type
         end
 
-        sum = Class.new(Sum) { def inspect; super; end }
+        sum = Class.new(self) { def inspect; super; end }
         finalize!(sum, new_sum)
         sum
       end
@@ -35,7 +35,7 @@ module BloodContracts::Core
       # @return [BC::Sum]
       #
       def or_a(other_type)
-        sum = Class.new(Sum) { def inspect; super; end }
+        sum = Class.new(self) { def inspect; super; end }
         new_sum = sum_of.to_a
         if other_type.respond_to?(:sum_of)
           new_sum += other_type.sum_of.to_a
@@ -71,11 +71,11 @@ module BloodContracts::Core
     # @return [BC::Refined]
     #
     def match
-      or_matches = self.class.sum_of.map do |type|
+      @or_matches = self.class.sum_of.map do |type|
         type.match(@value, context: @context)
       end
 
-      if (match = or_matches.find(&:valid?))
+      if (match = @or_matches.find(&:valid?))
         match
       else
         failure(:no_matches)

data/lib/blood_contracts/core/tuple.rb

@@ -24,7 +24,7 @@ module BloodContracts::Core
         names = args.pop.delete(:names) if args.last.is_a?(Hash)
 
         raise ArgumentError unless args.all? { |type| type < Refined }
-        tuple = Class.new(Tuple) { def inspect; super; end }
+        tuple = Class.new(self) { def inspect; super; end }
         tuple.instance_variable_set(:@attributes, args)
         tuple.instance_variable_set(:@names, names.to_a)
         tuple.instance_variable_set(:@finalized, true)
@@ -58,7 +58,6 @@ module BloodContracts::Core
       end
     end
 
-
     # List of values in Tuple
     #
     # @return [Array<Object>]
@@ -70,7 +69,7 @@ module BloodContracts::Core
     # @param [Array<Object>] *values that we'll keep inside the Tuple
     # @option [Hash<Symbol, Object>] context to share between types
     #
-    def initialize(*values, context: Hash.new { |h, k| h[k] = {} }, **)
+    def initialize(*values, context: {}, **)
       @context = context
       @context[:attributes] ||= {}
 

data/lib/blood_contracts/core/tuple_contract_failure.rb

@@ -1,5 +1,5 @@
 module BloodContracts::Core
-  # Represents failure in during of Tuple data matching
+  # Represents failure in Tuple data matching
   class TupleContractFailure < ContractFailure
     # Hash of attributes (name & type pairs)
     #

data/spec/blood_contracts/core_spec.rb

@@ -1,4 +1,3 @@
-
 require "spec_helper"
 
 RSpec.describe BloodContracts::Core do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: blood_contracts-core
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Sergey Dolganov (sclinede)
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-02 00:00:00.000000000 Z
+date: 2019-07-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler