blather 0.5.0 → 0.5.2

data/CHANGELOG

@@ -1,3 +1,10 @@
+v0.5.2
+  Bugfix(benlangfeld): Remove specs for the Nokogiri extensions which were moved out
+
+v0.5.1 - yanked
+  Feature(benlangfeld): Abstract out Nokogiri extensions and helpers into new Niceogiri gem for better sharing
+  Documentation(benlangfeld)
+
 v0.5.0
   Feature(radsaq): Add a #connected? method on Blather::Client
   Feature(benlangfeld)[API change]: Allow the removal of child nodes from an IQ reply

data/LICENSE

@@ -1,6 +1,6 @@
 Blather
 
-Copyright (c) 2009 Jeff Smick
+Copyright (c) 2011 Jeff Smick
  
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -19,7 +19,7 @@ XMPP DSL (and more) for Ruby written on EventMachine and Nokogiri.
 
 ## Installation
 
-    sudo gem install blather
+    gem install blather
 
 ## Example
 
@@ -173,4 +173,4 @@ than a change set made directly on master.
 
 # Copyright
 
-Copyright (c) 2009 Jeff Smick. See LICENSE for details.
+Copyright (c) 2011 Jeff Smick. See LICENSE for details.

data/blather.gemspec

@@ -8,7 +8,6 @@ Gem::Specification.new do |s|
   s.platform    = Gem::Platform::RUBY
   s.authors     = ["Jeff Smick"]
   s.email       = %q{sprsquish@gmail.com}
-  s.date        = %q{2010-09-02}
   s.homepage    = "http://github.com/sprsquish/blather"
   s.summary     = %q{Simpler XMPP built for speed}
   s.description = %q{An XMPP DSL for Ruby written on top of EventMachine and Nokogiri}
@@ -23,6 +22,7 @@ Gem::Specification.new do |s|
 
   s.add_dependency("eventmachine", ["~> 0.12.6"])
   s.add_dependency("nokogiri", [">= 1.4.0"])
+  s.add_dependency("niceogiri", [">= 0.0.4"])
   s.add_dependency("minitest", [">= 1.7.1"])
   s.add_dependency("activesupport", [">= 3.0.7"])
 

data/lib/blather.rb

@@ -2,7 +2,7 @@
 %w[
   rubygems
   eventmachine
-  nokogiri
+  niceogiri
   ipaddr
   digest/md5
   digest/sha1
@@ -13,7 +13,6 @@
 
   blather/core_ext/eventmachine
   blather/core_ext/ipaddr
-  blather/core_ext/nokogiri
 
   blather/errors
   blather/errors/sasl_error

data/lib/blather/version.rb

@@ -1,4 +1,4 @@
 module Blather
   # Blather version number
-  VERSION = '0.5.0'
+  VERSION = '0.5.2'
 end

data/lib/blather/xmpp_node.rb

@@ -2,15 +2,14 @@ module Blather
 
   # Base XML Node
   # All XML classes subclass XMPPNode it allows the addition of helpers
-  class XMPPNode < Nokogiri::XML::Node
+  class XMPPNode < Niceogiri::XML::Node
     # @private
     BASE_NAMES = %w[presence message iq].freeze
 
     # @private
     @@registrations = {}
 
-    class_inheritable_accessor  :registered_ns,
-                                :registered_name
+    class_inheritable_accessor :registered_ns, :registered_name
 
     # Register a new stanza class to a name and/or namespace
     #
@@ -32,8 +31,7 @@ module Blather
     # @param [String, nil] xmlns the namespace the node belongs to
     # @return [Class, nil] the class appropriate for the name/ns combination
     def self.class_from_registration(name, ns = nil)
-      name = name.to_s
-      @@registrations[[name, ns]]
+      @@registrations[[name.to_s, ns]]
     end
 
     # Import an XML::Node to the appropriate class
@@ -58,43 +56,8 @@ module Blather
     # @param [XML::Document, nil] doc the document to attach the node to. If
     # not provided one will be created
     # @return a new object with the registered name and namespace
-    def self.new(name = nil, doc = nil)
-      name ||= self.registered_name
-
-      node = super name.to_s, (doc || Nokogiri::XML::Document.new)
-      node.document.root = node unless doc
-      node.namespace = self.registered_ns unless BASE_NAMES.include?(name.to_s)
-      node
-    end
-
-    # Helper method to read an attribute
-    #
-    # @param [#to_sym] attr_name the name of the attribute
-    # @param [String, Symbol, nil] to_call the name of the method to call on
-    # the returned value
-    # @return nil or the value
-    def read_attr(attr_name, to_call = nil)
-      val = self[attr_name.to_sym]
-      val && to_call ? val.__send__(to_call) : val
-    end
-
-    # Helper method to write a value to an attribute
-    #
-    # @param [#to_sym] attr_name the name of the attribute
-    # @param [#to_s] value the value to set the attribute to
-    def write_attr(attr_name, value)
-      self[attr_name.to_sym] = value
-    end
-
-    # Helper method to read the content of a node
-    #
-    # @param [#to_sym] node the name of the node
-    # @param [String, Symbol, nil] to_call the name of the method to call on
-    # the returned value
-    # @return nil or the value
-    def read_content(node, to_call = nil)
-      val = content_from node.to_sym
-      val && to_call ? val.__send__(to_call) : val
+    def self.new(name = registered_name, doc = nil)
+      super name, doc, BASE_NAMES.include?(name.to_s) ? nil : self.registered_ns
     end
 
     # Turn the object into a proper stanza
@@ -103,133 +66,6 @@ module Blather
     def to_stanza
       self.class.import self
     end
-
-    # @private
-    alias_method :nokogiri_namespace=, :namespace=
-    # Attach a namespace to the node
-    #
-    # @overload namespace=(ns)
-    #   Attach an already created XML::Namespace
-    #   @param [XML::Namespace] ns the namespace object
-    # @overload namespace=(ns)
-    #   Create a new namespace and attach it
-    #   @param [String] ns the namespace uri
-    # @overload namespace=(namespaces)
-    #   Createa and add new namespaces from a hash
-    #   @param [Hash] namespaces a hash of prefix => uri pairs
-    def namespace=(namespaces)
-      case namespaces
-      when Nokogiri::XML::Namespace
-        self.nokogiri_namespace = namespaces
-      when String
-        self.add_namespace nil, namespaces
-      when Hash
-        if ns = namespaces.delete(nil)
-          self.add_namespace nil, ns
-        end
-        namespaces.each do |p, n|
-          ns = self.add_namespace p, n
-          self.nokogiri_namespace = ns
-        end
-      end
-    end
-
-    # Helper method to get the node's namespace
-    #
-    # @return [XML::Namespace, nil] The node's namespace object if it exists
-    def namespace_href
-      namespace.href if namespace
-    end
-
-    # Remove a child with the name and (optionally) namespace given
-    #
-    # @param [String] name the name or xpath of the node to remove
-    # @param [String, nil] ns the namespace the node is in
-    def remove_child(name, ns = nil)
-      child = xpath(name, ns).first
-      child.remove if child
-    end
-
-    # Remove all children with a given name regardless of namespace
-    #
-    # @param [String] name the name of the nodes to remove
-    def remove_children(name)
-      xpath("./*[local-name()='#{name}']").remove
-    end
-
-    # The content of the named node
-    #
-    # @param [String] name the name or xpath of the node
-    # @param [String, nil] ns the namespace the node is in
-    # @return [String, nil] the content of the node
-    def content_from(name, ns = nil)
-      child = xpath(name, ns).first
-      child.content if child
-    end
-
-    # Sets the content for the specified node.
-    # If the node exists it is updated. If not a new node is created
-    # If the node exists and the content is nil, the node will be removed
-    # entirely
-    #
-    # @param [String] node the name of the node to update/create
-    # @param [String, nil] content the content to set within the node
-    def set_content_for(node, content = nil)
-      if content
-        child = xpath(node).first
-        self << (child = XMPPNode.new(node, self.document)) unless child
-        child.content = content
-      else
-        remove_child node
-      end
-    end
-
-    alias_method :copy, :dup
-
-    # Inherit the attributes and children of an XML::Node
-    #
-    # @param [XML::Node] stanza the node to inherit
-    # @return [self]
-    def inherit(stanza)
-      set_namespace stanza.namespace if stanza.namespace
-      inherit_attrs stanza.attributes
-      stanza.children.each do |c|
-        self << (n = c.dup)
-        ns = n.namespace_definitions.find { |ns| ns.prefix == c.namespace.prefix }
-        n.namespace = ns if ns
-      end
-      self
-    end
-
-    # Inherit a set of attributes
-    #
-    # @param [Hash] attrs a hash of attributes to set on the node
-    # @return [self]
-    def inherit_attrs(attrs)
-      attrs.each  { |name, value| self[name] = value }
-      self
-    end
-
-    # The node as XML
-    #
-    # @return [String] XML representation of the node
-    def inspect
-      self.to_xml
-    end
-
-    # Check that a set of fields are equal between nodes
-    #
-    # @param [XMPPNode] other the other node to compare against
-    # @param [*#to_s] fields the set of fields to compare
-    # @return [Fixnum<-1,0,1>]
-    def eql?(o, *fields)
-      o.is_a?(self.class) && fields.all? { |f| self.__send__(f) == o.__send__(f) }
-    end
-
-    # @private
-    def ==(o)
-      eql?(o)
-    end
   end  # XMPPNode
 
 end  # Blather

data/spec/blather/xmpp_node_spec.rb

@@ -3,28 +3,6 @@ require 'spec_helper'
 describe Blather::XMPPNode do
   before { @doc = Nokogiri::XML::Document.new }
 
-  it 'generates a new node automatically setting the document' do
-    n = Blather::XMPPNode.new 'foo'
-    n.element_name.must_equal 'foo'
-    n.document.wont_equal @doc
-  end
-
-  it 'sets the new document root to the node' do
-    n = Blather::XMPPNode.new 'foo'
-    n.document.root.must_equal n
-  end
-
-  it 'does not set the document root if the document is provided' do
-    n = Blather::XMPPNode.new 'foo', @doc
-    n.document.root.wont_equal n
-  end
-
-  it 'generates a new node with the given document' do
-    n = Blather::XMPPNode.new 'foo', @doc
-    n.element_name.must_equal 'foo'
-    n.document.must_equal @doc
-  end
-
   it 'generates a node based on the registered_name' do
     foo = Class.new(Blather::XMPPNode)
     foo.registered_name = 'foo'
@@ -51,182 +29,9 @@ describe Blather::XMPPNode do
     Blather::XMPPNode.import(n).must_be_kind_of ImportSubClass
   end
 
-  it 'provides an attribute reader' do
-    foo = Blather::XMPPNode.new
-    foo.read_attr(:bar).must_be_nil
-    foo[:bar] = 'baz'
-    foo.read_attr(:bar).must_equal 'baz'
-  end
-
-  it 'provides an attribute reader with converstion' do
-    foo = Blather::XMPPNode.new
-    foo.read_attr(:bar, :to_sym).must_be_nil
-    foo[:bar] = 'baz'
-    foo.read_attr(:bar, :to_sym).must_equal :baz
-  end
-
-  it 'provides an attribute writer' do
-    foo = Blather::XMPPNode.new
-    foo[:bar].must_be_nil
-    foo.write_attr(:bar, 'baz')
-    foo[:bar].must_equal 'baz'
-  end
-
-  it 'provides a content reader' do
-    foo = Blather::XMPPNode.new('foo')
-    foo << (bar = Blather::XMPPNode.new('bar', foo.document))
-    bar.content = 'baz'
-    foo.read_content(:bar).must_equal 'baz'
-  end
-
-  it 'provides a content reader that converts the value' do
-    foo = Blather::XMPPNode.new('foo')
-    foo << (bar = Blather::XMPPNode.new('bar', foo.document))
-    bar.content = 'baz'
-    foo.read_content(:bar, :to_sym).must_equal :baz
-  end
-
-  it 'provides a content writer' do
-    foo = Blather::XMPPNode.new('foo')
-    foo.set_content_for :bar, 'baz'
-    foo.content_from(:bar).must_equal 'baz'
-  end
-
-  it 'provides a content writer that removes a child when set to nil' do
-    foo = Blather::XMPPNode.new('foo')
-    foo << (bar = Blather::XMPPNode.new('bar', foo.document))
-    bar.content = 'baz'
-    foo.content_from(:bar).must_equal 'baz'
-    foo.xpath('bar').wont_be_empty
-
-    foo.set_content_for :bar, nil
-    foo.content_from(:bar).must_be_nil
-    foo.xpath('bar').must_be_empty
-  end
-
   it 'can convert itself into a stanza' do
     class StanzaConvert < Blather::XMPPNode; register 'foo'; end
     n = Blather::XMPPNode.new('foo')
     n.to_stanza.must_be_kind_of StanzaConvert
   end
-
-  it 'provides "attr_accessor" for namespace' do
-    n = Blather::XMPPNode.new('foo')
-    n.namespace.must_be_nil
-
-    n.namespace = 'foo:bar'
-    n.namespace_href.must_equal 'foo:bar'
-  end
-
-  it 'will remove a child element' do
-    n = Blather::XMPPNode.new 'foo'
-    n << Blather::XMPPNode.new('bar', n.document)
-    n << Blather::XMPPNode.new('bar', n.document)
-
-    n.find(:bar).size.must_equal 2
-    n.remove_child 'bar'
-    n.find(:bar).size.must_equal 1
-  end
-
-  it 'will remove a child with a specific xmlns' do
-    n = Blather::XMPPNode.new 'foo'
-    n << Blather::XMPPNode.new('bar')
-    c = Blather::XMPPNode.new('bar')
-    c.namespace = 'foo:bar'
-    n << c
-
-    n.find(:bar).size.must_equal 1
-    n.find('//xmlns:bar', :xmlns => 'foo:bar').size.must_equal 1
-    n.remove_child '//xmlns:bar', :xmlns => 'foo:bar'
-    n.find(:bar).size.must_equal 1
-    n.find('//xmlns:bar', :xmlns => 'foo:bar').size.must_equal 0
-  end
-
-  it 'will remove all child elements' do
-    n = Blather::XMPPNode.new 'foo'
-    n << Blather::XMPPNode.new('bar')
-    n << Blather::XMPPNode.new('bar')
-
-    n.find(:bar).size.must_equal 2
-    n.remove_children 'bar'
-    n.find(:bar).size.must_equal 0
-  end
-
-  it 'provides a copy mechanism' do
-    n = Blather::XMPPNode.new 'foo'
-    n2 = n.copy
-    n2.object_id.wont_equal n.object_id
-    n2.element_name.must_equal n.element_name
-  end
-
-  it 'provides an inherit mechanism' do
-    n = Blather::XMPPNode.new 'foo'
-    n2 = Blather::XMPPNode.new 'foo'
-    n2.content = 'bar'
-    n2['foo'] = 'bar'
-
-    n.inherit(n2)
-    n['foo'].must_equal 'bar'
-    n.content.must_equal 'bar'
-    n2.to_s.must_equal n.to_s
-  end
-
-  it 'holds on to namespaces when inheriting content' do
-    n = parse_stanza('<message><bar:foo xmlns:bar="http://bar.com"></message>').root
-    n2 = Blather::XMPPNode.new('message').inherit n
-    n2.to_s.must_equal n.to_s
-  end
-
-  it 'provides a mechanism to inherit attrs' do
-    n = Blather::XMPPNode.new 'foo'
-    n2 = Blather::XMPPNode.new 'foo'
-    n2['foo'] = 'bar'
-
-    n.inherit_attrs(n2.attributes)
-    n['foo'].must_equal 'bar'
-  end
-
-  it 'has a content_from helper that pulls the content from a child node' do
-    f = Blather::XMPPNode.new('foo')
-    f << (b = Blather::XMPPNode.new('bar'))
-    b.content = 'content'
-    f.content_from(:bar).must_equal 'content'
-  end
-
-  it 'returns nil when sent #content_from and a missing node' do
-    f = Blather::XMPPNode.new('foo')
-    f.content_from(:bar).must_be_nil
-  end
-
-  it 'creates a new node and sets content when sent #set_content_for' do
-    f = Blather::XMPPNode.new('foo')
-    f.must_respond_to :set_content_for
-    f.xpath('bar').must_be_empty
-    f.set_content_for :bar, :baz
-    f.xpath('bar').wont_be_empty
-    f.xpath('bar').first.content.must_equal 'baz'
-  end
-
-  it 'removes a child node when sent #set_content_for with nil' do
-    f = Blather::XMPPNode.new('foo')
-    f << (b = Blather::XMPPNode.new('bar'))
-    f.must_respond_to :set_content_for
-    f.xpath('bar').wont_be_empty
-    f.set_content_for :bar, nil
-    f.xpath('bar').must_be_empty
-  end
-
-  it 'will change the content of an existing node when sent #set_content_for' do
-    f = Blather::XMPPNode.new('foo')
-    f << (b = Blather::XMPPNode.new('bar'))
-    b.content = 'baz'
-    f.must_respond_to :set_content_for
-    f.xpath('bar').wont_be_empty
-    f.xpath('bar').first.content.must_equal 'baz'
-    control = f.xpath('bar').first.pointer_id
-
-    f.set_content_for :bar, 'fiz'
-    f.xpath('bar').first.content.must_equal 'fiz'
-    f.xpath('bar').first.pointer_id.must_equal control
-  end
 end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: blather
 version: !ruby/object:Gem::Version 
-  prerelease: false
+  hash: 15
+  prerelease: 
   segments: 
   - 0
   - 5
-  - 0
-  version: 0.5.0
+  - 2
+  version: 0.5.2
 platform: ruby
 authors: 
 - Jeff Smick
@@ -14,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-09-02 00:00:00 +01:00
+date: 2011-06-09 00:00:00 +01:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -25,6 +26,7 @@ dependencies:
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 35
         segments: 
         - 0
         - 12
@@ -40,6 +42,7 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 7
         segments: 
         - 1
         - 4
@@ -48,138 +51,163 @@ dependencies:
   type: :runtime
   version_requirements: *id002
 - !ruby/object:Gem::Dependency 
-  name: minitest
+  name: niceogiri
   prerelease: false
   requirement: &id003 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 23
+        segments: 
+        - 0
+        - 0
+        - 4
+        version: 0.0.4
+  type: :runtime
+  version_requirements: *id003
+- !ruby/object:Gem::Dependency 
+  name: minitest
+  prerelease: false
+  requirement: &id004 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        hash: 9
         segments: 
         - 1
         - 7
         - 1
         version: 1.7.1
   type: :runtime
-  version_requirements: *id003
+  version_requirements: *id004
 - !ruby/object:Gem::Dependency 
   name: activesupport
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
+  requirement: &id005 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 9
         segments: 
         - 3
         - 0
         - 7
         version: 3.0.7
   type: :runtime
-  version_requirements: *id004
+  version_requirements: *id005
 - !ruby/object:Gem::Dependency 
   name: minitest
   prerelease: false
-  requirement: &id005 !ruby/object:Gem::Requirement 
+  requirement: &id006 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 9
         segments: 
         - 1
         - 7
         - 1
         version: 1.7.1
   type: :development
-  version_requirements: *id005
+  version_requirements: *id006
 - !ruby/object:Gem::Dependency 
   name: mocha
   prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
+  requirement: &id007 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 35
         segments: 
         - 0
         - 9
         - 12
         version: 0.9.12
   type: :development
-  version_requirements: *id006
+  version_requirements: *id007
 - !ruby/object:Gem::Dependency 
   name: bundler
   prerelease: false
-  requirement: &id007 !ruby/object:Gem::Requirement 
+  requirement: &id008 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 23
         segments: 
         - 1
         - 0
         - 0
         version: 1.0.0
   type: :development
-  version_requirements: *id007
+  version_requirements: *id008
 - !ruby/object:Gem::Dependency 
   name: rcov
   prerelease: false
-  requirement: &id008 !ruby/object:Gem::Requirement 
+  requirement: &id009 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 41
         segments: 
         - 0
         - 9
         - 9
         version: 0.9.9
   type: :development
-  version_requirements: *id008
+  version_requirements: *id009
 - !ruby/object:Gem::Dependency 
   name: yard
   prerelease: false
-  requirement: &id009 !ruby/object:Gem::Requirement 
+  requirement: &id010 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 5
         segments: 
         - 0
         - 6
         - 1
         version: 0.6.1
   type: :development
-  version_requirements: *id009
+  version_requirements: *id010
 - !ruby/object:Gem::Dependency 
   name: bluecloth
   prerelease: false
-  requirement: &id010 !ruby/object:Gem::Requirement 
+  requirement: &id011 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ~>
       - !ruby/object:Gem::Version 
+        hash: 11
         segments: 
         - 2
         - 1
         - 0
         version: 2.1.0
   type: :development
-  version_requirements: *id010
+  version_requirements: *id011
 - !ruby/object:Gem::Dependency 
   name: rake
   prerelease: false
-  requirement: &id011 !ruby/object:Gem::Requirement 
+  requirement: &id012 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
         segments: 
         - 0
         version: "0"
   type: :development
-  version_requirements: *id011
+  version_requirements: *id012
 description: An XMPP DSL for Ruby written on top of EventMachine and Nokogiri
 email: sprsquish@gmail.com
 executables: []
@@ -215,7 +243,6 @@ files:
 - lib/blather/client/dsl/pubsub.rb
 - lib/blather/core_ext/eventmachine.rb
 - lib/blather/core_ext/ipaddr.rb
-- lib/blather/core_ext/nokogiri.rb
 - lib/blather/errors.rb
 - lib/blather/errors/sasl_error.rb
 - lib/blather/errors/stanza_error.rb
@@ -274,7 +301,6 @@ files:
 - spec/blather/client/client_spec.rb
 - spec/blather/client/dsl/pubsub_spec.rb
 - spec/blather/client/dsl_spec.rb
-- spec/blather/core_ext/nokogiri_spec.rb
 - spec/blather/errors/sasl_error_spec.rb
 - spec/blather/errors/stanza_error_spec.rb
 - spec/blather/errors/stream_error_spec.rb
@@ -337,6 +363,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
@@ -345,13 +372,14 @@ required_rubygems_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
       segments: 
       - 0
       version: "0"
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.7
+rubygems_version: 1.4.2
 signing_key: 
 specification_version: 3
 summary: Simpler XMPP built for speed
@@ -359,7 +387,6 @@ test_files:
 - spec/blather/client/client_spec.rb
 - spec/blather/client/dsl/pubsub_spec.rb
 - spec/blather/client/dsl_spec.rb
-- spec/blather/core_ext/nokogiri_spec.rb
 - spec/blather/errors/sasl_error_spec.rb
 - spec/blather/errors/stanza_error_spec.rb
 - spec/blather/errors/stream_error_spec.rb

data/lib/blather/core_ext/nokogiri.rb

@@ -1,44 +0,0 @@
-# @private
-module Nokogiri
-module XML
-
-  # Nokogiri::Node extensions
-  class Node
-    # Alias #name to #element_name so we can use #name in an XMPP Stanza context
-    alias_method :element_name, :name
-    alias_method :element_name=, :name=
-
-    alias_method :attr_set, :[]=
-    # Override Nokogiri's attribute setter to add the ability to kill an attribute
-    # by setting it to nil and to be able to lookup an attribute by symbol
-    #
-    # @param [#to_s] name the name of the attribute
-    # @param [#to_s, nil] value the new value or nil to remove it
-    def []=(name, value)
-      name = name.to_s
-      value.nil? ? remove_attribute(name) : attr_set(name, value.to_s)
-    end
-
-    alias_method :nokogiri_xpath, :xpath
-    # Override Nokogiri's #xpath method to add the ability to use symbols for lookup
-    # and namespace designation
-    def xpath(*paths)
-      paths[0] = paths[0].to_s
-
-      if paths.size > 1 && (namespaces = paths.pop).is_a?(Hash)
-        paths << namespaces.inject({}) { |h,v| h[v[0].to_s] = v[1]; h }
-      end
-
-      nokogiri_xpath *paths
-    end
-    alias_method :find, :xpath
-
-    # Return the first element at a specified xpath
-    # @see #xpath
-    def find_first(*paths)
-      xpath(*paths).first
-    end
-  end
-
-end #XML
-end #Blather

data/spec/blather/core_ext/nokogiri_spec.rb

@@ -1,83 +0,0 @@
-require 'spec_helper'
-
-describe 'Nokogiri::XML::Node' do
-  before { @doc = Nokogiri::XML::Document.new }
-
-  it 'aliases #name to #element_name' do
-    node = Nokogiri::XML::Node.new 'foo', @doc
-    node.must_respond_to :element_name
-    node.element_name.must_equal node.name
-  end
-
-  it 'aliases #name= to #element_name=' do
-    node = Nokogiri::XML::Node.new 'foo', @doc
-    node.must_respond_to :element_name=
-    node.element_name.must_equal node.name
-    node.element_name = 'bar'
-    node.element_name.must_equal 'bar'
-  end
-
-  it 'allows symbols as hash keys for attributes' do
-    attrs = Nokogiri::XML::Node.new('foo', @doc)
-    attrs['foo'] = 'bar'
-
-    attrs['foo'].must_equal 'bar'
-    attrs[:foo].must_equal 'bar'
-  end
-
-  it 'ensures a string is passed to the attribute setter' do
-    attrs = Nokogiri::XML::Node.new('foo', @doc)
-    attrs[:foo] = 1
-    attrs[:foo].must_equal '1'
-
-    attrs[:jid] = Blather::JID.new('n@d/r')
-    attrs[:jid].must_equal 'n@d/r'
-  end
-
-  it 'removes an attribute when set to nil' do
-    attrs = Nokogiri::XML::Node.new('foo', @doc)
-    attrs['foo'] = 'bar'
-
-    attrs['foo'].must_equal 'bar'
-    attrs['foo'] = nil
-    attrs['foo'].must_be_nil
-  end
-
-  it 'allows attribute values to change' do
-    attrs = Nokogiri::XML::Node.new('foo', @doc)
-    attrs['foo'] = 'bar'
-
-    attrs['foo'].must_equal 'bar'
-    attrs['foo'] = 'baz'
-    attrs['foo'].must_equal 'baz'
-  end
-
-  it 'allows symbols as the path in #xpath' do
-    node = Nokogiri::XML::Node.new('foo', @doc)
-    node.must_respond_to :find
-    @doc.root = node
-    @doc.xpath(:foo).first.wont_be_nil
-    @doc.xpath(:foo).first.must_equal @doc.xpath('/foo').first
-  end
-
-  it 'allows symbols as namespace names in #xpath' do
-    node = Nokogiri::XML::Node.new('foo', @doc)
-    node.namespace = node.add_namespace('bar', 'baz')
-    @doc.root = node
-    node.xpath('/bar:foo', :bar => 'baz').first.wont_be_nil
-  end
-
-  it 'aliases #xpath to #find' do
-    node = Nokogiri::XML::Node.new('foo', @doc)
-    node.must_respond_to :find
-    @doc.root = node
-    node.find('/foo').first.wont_be_nil
-  end
-
-  it 'has a helper function #find_first' do
-    node = Nokogiri::XML::Node.new('foo', @doc)
-    node.must_respond_to :find
-    @doc.root = node
-    node.find_first('/foo').must_equal node.find('/foo').first
-  end
-end