blacklight_range_limit 9.0.0.beta1 → 9.0.0.beta2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8f262cbfeff305e3cd1567ffcd35b90e647d3afd3558b95cf9a2f739381b20ff
-  data.tar.gz: ddfa401cafc2c1dac75d06c13a2214c7abf2f96fce4dd1421bc0c4a343e0ad8f
+  metadata.gz: bfe80b379721a4e19e01ecb97a0f1ca6335e2e85ae3914abec0f2ae9ee9546b6
+  data.tar.gz: cdc7468b2f1e7f649f72a9f4200948cbc543d9f1e6a86bcac03b467c65b18ba2
 SHA512:
-  metadata.gz: 914a2910f0b99f6a9223cbdb32779c7a862d19a4d0d0c3ca973383c90e45e05fcf04fdc928ed3a7f7c0222ee87924071ae2af9cd4f219479adabd2601634d2f0
-  data.tar.gz: 8a11a84d0c57be9a3036518d284bd2f698e70303fbfcde30ad2d3ee66c4018ae15543df19c6d010423b724fb1452998faa3129682a6ce13f7300746e0a68e5b8
+  metadata.gz: df819d6ceb0f782c612d1eb83648a178ed2f555b599df666240cfa2cc7a75d0b3554ff29ff12ada5bdf3766bb74be88b76d054a95fd233d41309d2737bcb6cf2
+  data.tar.gz: 269df83223ddbed2fa371c9b0aa1ebc6d5afff775d5a313a6482ba8948412456b59bbe7b1b438e51143fe2941c3e643b3ba98f5a918287ce32b4867542871c69

data/.github/workflows/ruby.yml

@@ -11,7 +11,7 @@ on:
   push:
     branches: [main]
   pull_request:
-    branches: [main]
+    branches: ['**']
 
 jobs:
   test:

data/README.md

@@ -19,7 +19,7 @@ Decimal numbers and Dates are NOT supported; they theoretically could be in the
 
 * Javascript requires you to be using either rails-importmaps or a package.json-based builder like jsbundling-rails or vite-ruby.  Legacy "sprockets-only" is not supported, however propshaft or sprockets can be used as your base asset pipeline.
 
-* Blaklight 7.0+.  Rails 7.0+
+* Blacklight 7.0+.  Rails 7.0+
 
 
 # Installation
@@ -34,7 +34,10 @@ Run `rails generate blacklight_range_limit:install`
 
 ### Manual Javascript setup is not hard
 
-The installer could have trouble figuring out how to add Javascript to your particular setup. In the end, all you need is `blacklight-range-limit` either importmap-pinned (with it's chart.js dependency), or added to your package.json, and then, in a file that has access to the `Blacklight` import:
+The installer could have trouble figuring out how to add Javascript to your particular setup. If it's not working right and you want the installer to skip asset generation, you can execute as `rails generate blacklight_range_limit:install --skip-assets`.
+
+
+In the end, all you need is `blacklight-range-limit` either importmap-pinned (with its chart.js dependency), or added to your package.json, and then, in a file that has access to the `Blacklight` import:
 
     import BlacklightRangeLimit from "blacklight-range-limit";
     BlacklightRangeLimit.init({ onLoadHandler: Blacklight.onLoad });
@@ -59,7 +62,7 @@ For import map pins, note:
 
 ### Unreleased version?
 
-If you'd like to use an unrelased version from git, just add that to your Gemfile in the usual way.
+If you'd like to use an unreleased version from git, just add that to your Gemfile in the usual way.
 
 importmap-rails use should then Just Work.
 
@@ -99,11 +102,11 @@ config.add_facet_field 'pub_date', label: 'Publication Year', range_config: {
        chart_js: true,
        textual_facets: true,
        textual_facets_collapsible: true,
+       show_missing_link: true,
        chart_segment_border_color: "rgba(0,0,0, 0.5)",
        chart_segment_bg_color: "#ccddcc",
        chart_aspect_ratio: "2"
-    }
-)
+}
 ```
 
 * **:num_segments** :
@@ -112,19 +115,23 @@ config.add_facet_field 'pub_date', label: 'Publication Year', range_config: {
   * Default null. For a result set that has not yet been limited, instead of taking boundaries from results and making a second AJAX request to fetch segments, just assume these given boundaries. If you'd like to avoid this second AJAX Solr call, you can set :assumed_boundaries to a two-element array of integers instead, and the assumed boundaries will always be used. Note this is live ruby code, you can put calculations in there like Time.now.year + 2.
 * **chart_js**:
   * Default true. If false, the Javascript chart is not loaded, you can still get textual facets for bucket with `textual_facets` config.
-* **textual_facets**: Default true. Should we show textual facet list too? Universal design
+* **textual_facets**:
+  * Default true. Should we show textual facet list too? Universal design
   for accessibility, may have accessibilty concerns to turn off.
-* **textual_facets_collapsible**: Put the textual facets in a collapse/expand
+* **textual_facets_collapsible**:
+  * Put the textual facets in a collapse/expand
   disclosure. If you set chart_js to false, may make sense to set this to false too, to have
   textual facets only instead of chart?
-* **chart_segment_border_color** / **chart_segment_bg_color** :
+* **show_missing_link**:
+  * Default true. Display a link (with count) to results that are _missing_ a value for the range field.
+* **chart_segment_border_color** / **chart_segment_bg_color**:
   * Set colors for the edge and fill of the segment bars in the histogram.
-* chart_aspect_ratio: for chart.js, will fill available width then this determines size of chart. defaults to 2
-
+* **chart_aspect_ratio**:
+  * Defaults to 2. For chart.js, will fill available width then this determines size of chart.
 
 ## Javascript dependencies
 
-We use [chart.js](https://www.chartjs.org/) to draw the chart. It has one dependency of it's own. These need to be either pinned with importmap-rails, or used via the chart.js npm package and an npm-package-based bundler.
+We use [chart.js](https://www.chartjs.org/) to draw the chart. It has one dependency of its own. These need to be either pinned with importmap-rails, or used via the chart.js npm package and an npm-package-based bundler.
 
 There is **no CSS** needed.
 
@@ -169,4 +176,3 @@ Once you are done iterating on your test you will need to stop the application s
 # Publishing Javascript
 
 run `npm publish` to push the javascript package to https://npmjs.org/package/blacklight-range-limit
-

data/Rakefile

@@ -25,6 +25,44 @@ task ci: ['engine_cart:generate'] do
   end
 end
 
+desc "check npm and gem versions match before release"
+task :guard_version_match do
+  gem_version = File.read(__dir__ + "/VERSION").chomp
+  npm_version = JSON.parse(File.read(__dir__ + "/package.json"))["version"]
+
+  # 9.0.0.beta1 in gem becomes 9.0.0-beta1 in npm
+  gem_version_parts = gem_version.split(".")
+  npm_version_required = [
+    gem_version_parts.slice(0, 3).join("."),
+    gem_version_parts.slice(3, gem_version_parts.length).join(".")
+  ].join("-")
+
+  if npm_version != npm_version_required
+    raise <<~EOS
+      You should not publish without npm version in package.json matching gem version
+
+      gem version: #{gem_version}
+      package.json version: #{npm_version}
+
+      expected package.json version: #{npm_version_required}
+
+    EOS
+  end
+end
+
+# Get our guard to run before `rake release`'s, and warning afterwards
+task "release:guard_clean" => :guard_version_match
+Rake::Task["guard_version_match"].enhance do
+  puts <<~EOS
+
+    ⚠️  Please remember to run `npm publish` the npm package too!  ⚠️
+
+    If you don't have permission, please ask someone who does for help.
+    https://www.npmjs.com/package/blacklight-range-limit
+
+  EOS
+end
+
 
 namespace :test do
   namespace :spec do

data/VERSION

@@ -1 +1 @@
-9.0.0.beta1
+9.0.0.beta2

data/app/components/blacklight_range_limit/range_facet_component.html.erb

@@ -19,7 +19,7 @@
       <!-- no results profile if missing is selected -->
       <% unless @facet_field.missing_selected? %>
         <%# this has to be on page if you want calculated facets to show up, JS sniffs it.
-          it was very hard to get chart.js to be succesfully resonsive, required this wrapper!
+          it was very hard to get chart.js to be successfully responsive, required this wrapper!
           https://github.com/chartjs/Chart.js/issues/11005 -%>
         <div class="chart-wrapper mb-3" data-chart-wrapper="true" style="display: none; position: relative; width: 100%; aspect-ratio: <%= range_config[:chart_aspect_ratio] %>;">
         </div>
@@ -30,18 +30,18 @@
               (min = @facet_field.min) &&
               (max = @facet_field.max) %>
           <div class="distribution <%= 'chart_js' unless range_config[:chart_js] == false %>">
-            <!-- if  we already fetched segments from solr, display them
+            <!-- if we already fetched segments from solr, display them
                  here. Otherwise, display a link to fetch them, which JS
                  will AJAX fetch.  -->
             <% if @facet_field.range_queries.any? %>
               <%= render BlacklightRangeLimit::RangeSegmentsComponent.new(facet_field: @facet_field) %>
             <% else %>
-              <%= link_to(t('blacklight.range_limit.view_distribution'), range_limit_url(range_start: min, range_end: max), class: "load_distribution", "data-loading-message-html": t('blacklight.range_limit.loading_html')) %>
+              <%= link_to(t('blacklight.range_limit.view_distribution'), load_distribution_link, class: "load_distribution", "data-loading-message-html": t('blacklight.range_limit.loading_html')) %>
             <% end %>
           </div>
         <% end %>
 
-        <% if @facet_field.missing_facet_item && !request.xhr? && uses_distribution? %>
+        <% if range_config[:show_missing_link] && @facet_field.missing_facet_item && !request.xhr? && uses_distribution? %>
           <%= render BlacklightRangeLimit::RangeSegmentsComponent.new(facet_field: @facet_field, facet_items: [@facet_field.missing_facet_item], classes: ['missing', 'mt-3']) %>
         <% end %>
       <% end %>

data/app/components/blacklight_range_limit/range_facet_component.rb

@@ -31,5 +31,17 @@ module BlacklightRangeLimit
     def uses_distribution?
       range_config[:chart_js] || range_config[:textual_facets]
     end
+
+    # URL that will return the distribution list of range seguments
+    def load_distribution_link
+      # For open-ended ranges, the selected range should take priority for the boundary
+      # over actual response min/max. Matters for multi-valued fields.
+      min = @facet_field.selected_range_facet_item&.value&.begin || @facet_field.min
+      max = @facet_field.selected_range_facet_item&.value&.end || @facet_field.max
+
+      return nil unless (min && max)
+
+      range_limit_url(range_start: min, range_end: max)
+    end
   end
 end

data/app/components/blacklight_range_limit/range_form_component.html.erb

@@ -5,12 +5,22 @@
     <div class="d-flex justify-content-between align-items-end">
       <div class="d-flex flex-column mr-1 me-1">
         <%= label_tag(begin_input_name, t("blacklight.range_limit.range_begin_short"), class: 'text-muted small mb-1') %>
-        <%= number_field_tag(begin_input_name, begin_value_default, class: "form-control form-control-sm range_begin") %>
+        <%= number_field_tag(begin_input_name,
+                              begin_value_default,
+                              min: range_config[:min_value],
+                              max: range_config[:max_value],
+                              class: "form-control form-control-sm range_begin")
+        %>
       </div>
 
       <div class="d-flex flex-column ml-1 ms-1">
         <%= label_tag(end_input_name, t("blacklight.range_limit.range_end_short"), class: 'text-muted small mb-1') %>
-        <%= number_field_tag(end_input_name, end_value_default, class: "form-control form-control-sm range_end") %>
+        <%= number_field_tag(end_input_name,
+                              end_value_default,
+                              min: range_config[:min_value],
+                              max: range_config[:max_value],
+                              class: "form-control form-control-sm range_end")
+        %>
       </div>
     </div>
     <div class="d-flex justify-content-end mt-2">

data/app/presenters/blacklight_range_limit/facet_item_presenter.rb

@@ -8,6 +8,15 @@ module BlacklightRangeLimit
       label_for_range || super
     end
 
+    # Very hacky way to keep params used for ajax query for segments out
+    # of our generated facet links. Sorry this seems to be the best way!
+    #
+    # https://github.com/projectblacklight/blacklight_range_limit/issues/296
+    def href(path_options = {})
+      override_to_nil = BlacklightRangeLimit::ControllerOverride::RANGE_LIMIT_FIELDS.collect { |f| [f, nil] }.to_h
+      super(path_options.merge(override_to_nil))
+    end
+
     private
 
     def label_for_range

data/app/presenters/blacklight_range_limit/filter_field.rb

@@ -50,7 +50,13 @@ module BlacklightRangeLimit
     def values(except: [])
       params = search_state.params
       param_key = filters_key
-      range = if params.dig(param_key, config.key).is_a? Range
+      range = if !params.try(:dig, param_key).respond_to?(:dig)
+        # bad data, not a hash at all, correct it. Yes, it's bad form to mutate
+        # params here, but we found no better solution -- this only necessary in BL
+        # prior to 8.x, not sure why, but this branch can be omitted in BL 8.
+        params.delete(param_key)
+        nil
+      elsif params.dig(param_key, config.key).is_a? Range
         params.dig(param_key, config.key)
       elsif params.dig(param_key, config.key).is_a? Hash
         b_bound = params.dig(param_key, config.key, :begin).presence

data/lib/blacklight_range_limit/controller_override.rb

@@ -8,21 +8,18 @@ module BlacklightRangeLimit
 
     RANGE_LIMIT_FIELDS = [:range_end, :range_field, :range_start].freeze
 
-    included do
-      before_action do
-        # Blacklight 7.25+: Allow range limit params if necessary
-        if blacklight_config.search_state_fields
-          missing_keys = RANGE_LIMIT_FIELDS - blacklight_config.search_state_fields
-          blacklight_config.search_state_fields.concat(missing_keys)
-        end
-      end
-    end
-
     # Action method of our own!
     # Delivers a _partial_ that's a display of a single fields range facets.
     # Used when we need a second Solr query to get range facets, after the
     # first found min/max from result set.
     def range_limit
+      # The builder in this action will need our special range_limit fields, so we
+      # must allow them.
+      if blacklight_config.search_state_fields
+        missing_keys = RANGE_LIMIT_FIELDS - blacklight_config.search_state_fields
+        blacklight_config.search_state_fields.concat(missing_keys)
+      end
+
       @facet = blacklight_config.facet_fields[params[:range_field]]
       raise ActionController::RoutingError, 'Not Found' unless @facet&.range
 

data/lib/blacklight_range_limit/range_limit_builder.rb

@@ -26,13 +26,7 @@ module BlacklightRangeLimit
 
         selected_value = search_state.filter(config.key).values.first
 
-        range = if selected_value.is_a? Range
-          selected_value
-        elsif range_config[:assumed_boundaries]
-          Range.new(*range_config[:assumed_boundaries])
-        else
-          nil
-        end
+        range = bl_create_selected_range_value(selected_value, config)
 
         # If we have both ends of a range
         add_range_segments_to_solr!(solr_params, field_key, range.begin, range.end) if range && range.count != Float::INFINITY
@@ -98,5 +92,32 @@ module BlacklightRangeLimit
       end
     end
 
+    # @returns Range or nil
+    #
+    # Range created from a range value or from assumed boundaries if present, and clamped between min and max
+    def bl_create_selected_range_value(selected_value, field_config)
+      range_config = field_config.range_config
+
+      range = if selected_value.is_a? Range
+        selected_value
+      elsif range_config[:assumed_boundaries].is_a?(Range)
+        range_config[:assumed_boundaries]
+      elsif range_config[:assumed_boundaries] # Array of two things please
+        Range.new(*range_config[:assumed_boundaries])
+      else
+        nil
+      end
+
+      # clamp between config'd min and max
+      min = range_config[:min_value]
+      max = range_config[:max_value]
+
+      range = Range.new(
+        (range.begin.clamp(min, max) if range.begin),
+        (range.end.clamp(min, max) if range.end),
+      ) if range
+
+      range
+    end
   end
 end

data/lib/blacklight_range_limit.rb

@@ -27,10 +27,13 @@ module BlacklightRangeLimit
         chart_js: true,
         textual_facets: true,
         textual_facets_collapsible: true,
+        show_missing_link: true,
         chart_segment_border_color: 'rgb(54, 162, 235)',
         chart_segment_bg_color: 'rgba(54, 162, 235, 0.5)',
         chart_aspect_ratio: 2,
-        assumed_boundaries: nil
+        assumed_boundaries: nil,
+        min_value: -2_147_483_648, # solr intfield min and max
+        max_value: 2_147_483_648
       },
       filter_class: BlacklightRangeLimit::FilterField,
       presenter: BlacklightRangeLimit::FacetFieldPresenter,

data/lib/generators/blacklight_range_limit/install_generator.rb

@@ -4,10 +4,13 @@ module BlacklightRangeLimit
   class InstallGenerator < Rails::Generators::Base
     source_root File.expand_path('../templates', __FILE__)
 
+    class_option :'skip-assets', type: :boolean, default: false, desc: "Skip generation of assets into app"
     class_option :'builder-path', type: :string, default: 'app/models/search_builder.rb', aliases: "-b", desc: "Set the path, relative to Rails root, to the Blacklight app's search builder class"
 
     def generate_assets
-      generate 'blacklight_range_limit:assets'
+      unless options[:'skip-assets']
+        generate 'blacklight_range_limit:assets'
+      end
     end
 
     def install_catalog_controller_mixin

data/package.json

@@ -1,6 +1,6 @@
 {
   "name": "blacklight-range-limit",
-  "version": "9.0.0.beta1",
+  "version": "9.0.0-beta2",
   "description": "A range facet UI component plugin for blacklight",
   "type": "module",
 

data/spec/components/range_facet_component_spec.rb

@@ -106,7 +106,67 @@ RSpec.describe BlacklightRangeLimit::RangeFacetComponent, type: :component do
     it "renders a link to fetch distribution info" do
       # need request_url for routing of links generated
       with_request_url '/catalog' do
-        expect(rendered).to have_selector(".distribution a.load_distribution[href]")
+        load_link = rendered.find(".distribution a.load_distribution[href]")
+        expect(load_link).to be_present
+
+        expect(load_link["href"]).to be_present
+        params = Rack::Utils.parse_nested_query(load_link["href"].split("?").try(:last))
+        expect(params["range_field"]).to eq facet_field.key
+        expect(params["range_start"]).to eq facet_field_params[:min].to_s
+        expect(params["range_end"]).to eq facet_field_params[:max].to_s
+      end
+    end
+  end
+
+  context 'with open-ended query' do
+    let(:selected_max) { 200 }
+    let(:data_max) { 300 }
+
+    let(:facet_field) do
+      instance_double(
+        BlacklightRangeLimit::FacetFieldPresenter,
+        key: 'key',
+        active?: false,
+        collapsed?: false,
+        in_modal?: false,
+        label: 'My facet field',
+        selected_range: nil,
+        selected_range_facet_item: Blacklight::Solr::Response::Facets::FacetItem.new(..selected_max),
+        missing_facet_item: nil,
+        missing_selected?: false,
+        min: nil,
+        max: nil,
+        search_state: Blacklight::SearchState.new({}, nil),
+        range_config: BlacklightRangeLimit.default_range_config[:range_config],
+        modal_path: nil,
+        facet_field: facet_config,
+        **facet_field_params,
+        **extra_facet_field_params
+      )
+    end
+
+    let(:facet_field_params) do
+      {
+        range_queries: [],
+        min: 100,
+        max: data_max
+      }
+    end
+
+    # This can be relevant in multi-valued queries, where even though you limited to
+    # < 200, some items in search can ALSO have additional values greater than 200, but
+    # we don't want to include them in our range buckets.
+    it "renders fetch distribution with expressed boundaries taking priority" do
+      # need request_url for routing of links generated
+      with_request_url '/catalog' do
+        load_link = rendered.find(".distribution a.load_distribution[href]")
+        expect(load_link).to be_present
+
+        expect(load_link["href"]).to be_present
+        params = Rack::Utils.parse_nested_query(load_link["href"].split("?").try(:last))
+        expect(params["range_field"]).to eq facet_field.key
+        expect(params["range_start"]).to eq facet_field_params[:min].to_s
+        expect(params["range_end"]).to eq selected_max.to_s
       end
     end
   end

data/spec/features/run_through_spec.rb

@@ -136,14 +136,15 @@ describe 'Run through with javascript', js: true do
   end
 
   context 'when assumed boundaries configured' do
-    before do
-      CatalogController.blacklight_config.facet_fields['pub_date_si'].range_config = {
-        assumed_boundaries: start_range.to_i...end_range.to_i
-      }
-    end
+    around do |example|
+      original = CatalogController.blacklight_config.facet_fields['pub_date_si'].range_config
+      CatalogController.blacklight_config.facet_fields['pub_date_si'].range_config = original.merge({
+         :assumed_boundaries=>1900...2100,
+      })
+
+      example.run
 
-    after do
-      CatalogController.blacklight_config.facet_fields['pub_date_si'].range_config = {}
+      CatalogController.blacklight_config.facet_fields['pub_date_si'].range_config = original
     end
 
     it 'should show the range limit with set boundaries' do
@@ -154,4 +155,56 @@ describe 'Run through with javascript', js: true do
       expect(find("input#range_pub_date_si_end").value).to be_present
     end
   end
+
+  context 'when missing facet item is configured not to show' do
+    around do |example|
+      original = CatalogController.blacklight_config.facet_fields['pub_date_si'].range_config
+      CatalogController.blacklight_config.facet_fields['pub_date_si'].range_config = original.merge({
+        show_missing_link: false
+      })
+
+      example.run
+
+      CatalogController.blacklight_config.facet_fields['pub_date_si'].range_config = original
+    end
+
+    it 'should not show the missing facet item' do
+      visit search_catalog_path
+
+      within ".facet-limit.blacklight-pub_date_si" do
+        expect(page).not_to have_css("ul.missing")
+      end
+    end
+  end
+
+  context "Range Limit text facets" do
+    # Make sure it works with strict permitted params
+    around do |example|
+      original = ActionController::Parameters.action_on_unpermitted_parameters
+      ActionController::Parameters.action_on_unpermitted_parameters = :raise
+
+      example.run
+
+      ActionController::Parameters.action_on_unpermitted_parameters = original
+    end
+
+    it "work with strict permitted params" do
+      visit search_catalog_path
+
+      click_button 'Publication Date Sort'
+
+      from_val, to_val = nil, nil
+      within ".facet-limit.blacklight-pub_date_si" do
+        find("summary", text: "Range List").click
+
+        facet_link = first(".facet-values li a")
+        from_val = facet_link.find("span[data-blrl-begin]")["data-blrl-begin"]
+        to_val = facet_link.find("span[data-blrl-end]")["data-blrl-end"]
+
+        facet_link.click
+      end
+
+      expect(page).to have_css(".applied-filter", text: /Publication Date Sort.*#{from_val} to #{to_val}/)
+    end
+  end
 end

data/spec/requests/bad_param_requests_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+describe CatalogController, type: :request do
+  let(:range_facet_field) { "pub_date_si" }
+
+  let(:parsed_body) { Nokogiri::HTML(response.body) }
+
+  describe "bad params should not produce uncaught exception when" do
+    it "bad root range" do
+      get "/catalog?range=bad"
+
+      expect(response.code).to eq("200")
+      expect(parsed_body.css("span.applied-filter")).not_to be_present
+    end
+
+    it "facet params are ill structured" do
+      get "/catalog?#{  {"f" => { range_facet_field => [{"=Library&q="=>""}] } }.to_param  }"
+
+      expect(response.code).to eq("200")
+      expect(parsed_body.css("span.applied-filter")).not_to be_present
+    end
+
+    it "newline in range facet does not interupt facet" do
+      get "/catalog?#{ {"range"=>{ range_facet_field => {"begin"=>"1588\n", "end"=>"2020\n"}}}.to_param }"
+
+      expect(response.code).to eq("200")
+      expect(parsed_body.css("span.applied-filter")).to be_present
+      expect(parsed_body.css("span.applied-filter").collect(&:text)).to include(/1588.*to.*2020/)
+    end
+
+    it "weird attack in range value is ignored" do
+      param_hash = {"range"=>{"year_facet_isim"=>{"begin"=>"1989',(;))#- --", "end"=>"1989',(;))#- --"}}}
+      get "/catalog?#{ param_hash.to_param  }"
+
+      expect(response.code).to eq("200")
+      expect(parsed_body.css("span.applied-filter")).not_to be_present
+    end
+
+    it "empty range param is ignored" do
+      get "/catalog?#{ { "range" => { "year_facet_isim" => nil } }.to_param }"
+
+      expect(response.code).to eq("200")
+      expect(parsed_body.css("span.applied-filter")).not_to be_present
+    end
+
+    describe "out of bounds range config" do
+      let(:max) { BlacklightRangeLimit.default_range_config[:range_config][:max_value] }
+      let(:min) { BlacklightRangeLimit.default_range_config[:range_config][:min_value] }
+
+      let(:too_high) { max.abs * 2 }
+      let(:too_low) { min.abs * -2 }
+
+      it "does not error" do
+        get "/catalog?#{ {"range"=>{ range_facet_field => {"begin"=> too_low, "end"=> too_high }}}.to_param }"
+
+        expect(response.code).to eq("200")
+        expect(parsed_body.css("span.applied-filter")).to be_present
+      end
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: blacklight_range_limit
 version: !ruby/object:Gem::Version
-  version: 9.0.0.beta1
+  version: 9.0.0.beta2
 platform: ruby
 authors:
 - Jonathan Rochkind
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-11-14 00:00:00.000000000 Z
+date: 2024-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: blacklight
@@ -258,6 +258,7 @@ files:
 - spec/presenters/facet_field_presenter_spec.rb
 - spec/presenters/facet_item_presenter_spec.rb
 - spec/presenters/filter_field_spec.rb
+- spec/requests/bad_param_requests_spec.rb
 - spec/spec_helper.rb
 - spec/support/presenter_test_helpers.rb
 - spec/test_app_templates/Gemfile.extra
@@ -297,6 +298,7 @@ test_files:
 - spec/presenters/facet_field_presenter_spec.rb
 - spec/presenters/facet_item_presenter_spec.rb
 - spec/presenters/filter_field_spec.rb
+- spec/requests/bad_param_requests_spec.rb
 - spec/spec_helper.rb
 - spec/support/presenter_test_helpers.rb
 - spec/test_app_templates/Gemfile.extra