blacklight 8.12.3 → 8.13.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- checksums.yaml +4 -4
- data/.github/matrix.json +43 -26
- data/.github/workflows/test.yml +1 -2
- data/.rubocop.yml +151 -8
- data/.rubocop_todo.yml +65 -53
- data/VERSION +1 -1
- data/app/assets/javascripts/blacklight/blacklight.esm.js.map +1 -1
- data/app/assets/javascripts/blacklight/blacklight.js.map +1 -1
- data/app/components/blacklight/advanced_search_form_component.rb +2 -2
- data/app/components/blacklight/constraints_component.rb +2 -2
- data/app/components/blacklight/document/bookmark_component.rb +2 -2
- data/app/components/blacklight/document/more_like_this_component.rb +2 -2
- data/app/components/blacklight/icons/legacy_icon_component.rb +1 -1
- data/app/components/blacklight/metadata_field_plain_text_layout_component.rb +2 -2
- data/app/controllers/concerns/blacklight/bookmarks.rb +5 -5
- data/app/controllers/concerns/blacklight/search_context.rb +1 -1
- data/app/controllers/concerns/blacklight/search_history.rb +1 -1
- data/app/helpers/blacklight/configuration_helper_behavior.rb +2 -2
- data/app/helpers/blacklight/icon_helper_behavior.rb +3 -3
- data/app/helpers/blacklight/layout_helper_behavior.rb +2 -2
- data/app/models/blacklight/icon.rb +3 -2
- data/app/models/concerns/blacklight/user.rb +1 -0
- data/app/presenters/blacklight/facet_field_presenter.rb +2 -2
- data/app/presenters/blacklight/rendering/helper_method.rb +4 -4
- data/app/presenters/blacklight/rendering/join.rb +2 -2
- data/app/presenters/blacklight/rendering/microdata.rb +1 -0
- data/app/values/blacklight/types.rb +2 -2
- data/app/views/catalog/_email_form.html.erb +2 -2
- data/app/views/catalog/_sms_form.html.erb +2 -2
- data/blacklight.gemspec +1 -1
- data/lib/blacklight/abstract_repository.rb +2 -2
- data/lib/blacklight/configuration/context.rb +3 -3
- data/lib/blacklight/configuration/display_field.rb +1 -1
- data/lib/blacklight/configuration/field.rb +10 -10
- data/lib/blacklight/configuration/fields.rb +3 -3
- data/lib/blacklight/configuration/sort_field.rb +2 -2
- data/lib/blacklight/configuration/view_config.rb +2 -2
- data/lib/blacklight/configuration.rb +1 -1
- data/lib/blacklight/nested_open_struct_with_hash_access.rb +1 -1
- data/lib/blacklight/open_struct_with_hash_access.rb +5 -5
- data/lib/blacklight/parameters.rb +1 -1
- data/lib/blacklight/search_builder.rb +4 -4
- data/lib/blacklight/search_state/filter_field.rb +2 -2
- data/lib/blacklight/solr/request.rb +1 -1
- data/lib/blacklight/solr/response/facets.rb +2 -2
- data/lib/blacklight/solr/response/group_response.rb +2 -2
- data/lib/blacklight/solr/response.rb +4 -1
- data/lib/blacklight.rb +1 -1
- data/lib/generators/blacklight/assets/importmap_generator.rb +28 -3
- data/lib/generators/blacklight/search_builder_generator.rb +1 -1
- data/lib/generators/blacklight/templates/solr/conf/schema.xml +264 -178
- data/lib/generators/blacklight/templates/solr/conf/solrconfig.xml +6 -18
- data/package.json +1 -1
- data/spec/components/blacklight/document/action_component_spec.rb +1 -1
- data/spec/components/blacklight/document/group_component_spec.rb +1 -1
- data/spec/components/blacklight/document_component_spec.rb +9 -9
- data/spec/components/blacklight/facet_component_spec.rb +2 -2
- data/spec/components/blacklight/facet_field_list_component_spec.rb +1 -1
- data/spec/controllers/catalog_controller_spec.rb +2 -2
- data/spec/features/advanced_search_spec.rb +12 -12
- data/spec/features/bookmarks_spec.rb +12 -12
- data/spec/features/did_you_mean_spec.rb +17 -17
- data/spec/features/facet_missing_spec.rb +3 -3
- data/spec/features/modal_spec.rb +1 -1
- data/spec/features/record_view_spec.rb +14 -14
- data/spec/features/search_context_spec.rb +7 -7
- data/spec/features/search_filters_spec.rb +12 -12
- data/spec/features/search_formats_spec.rb +2 -2
- data/spec/features/search_history_spec.rb +11 -11
- data/spec/features/search_pagination_spec.rb +9 -9
- data/spec/features/search_results_spec.rb +3 -3
- data/spec/features/search_sort_spec.rb +4 -4
- data/spec/features/search_spec.rb +15 -15
- data/spec/helpers/blacklight/url_helper_behavior_spec.rb +14 -14
- data/spec/helpers/blacklight_helper_spec.rb +6 -0
- data/spec/helpers/catalog_helper_spec.rb +6 -6
- data/spec/lib/blacklight/open_struct_with_hash_access_spec.rb +7 -0
- data/spec/lib/blacklight/search_state/pivot_filter_field_spec.rb +1 -1
- data/spec/models/record_mailer_spec.rb +5 -5
- data/spec/models/solr_document_spec.rb +5 -1
- data/spec/presenters/blacklight/index_presenter_spec.rb +1 -0
- data/spec/presenters/blacklight/rendering/pipeline_spec.rb +1 -0
- data/spec/presenters/blacklight/show_presenter_spec.rb +1 -0
- data/spec/presenters/blacklight/thumbnail_presenter_spec.rb +1 -0
- data/spec/views/catalog/_document.html.erb_spec.rb +4 -4
- data/spec/views/catalog/_search_header.erb_spec.rb +2 -2
- data/spec/views/catalog/_sort_and_per_page.html.erb_spec.rb +5 -5
- data/spec/views/catalog/facet.html.erb_spec.rb +1 -1
- data/spec/views/catalog/index.html.erb_spec.rb +2 -2
- data/spec/views/catalog/show.html.erb_spec.rb +3 -3
- metadata +6 -6
checksums.yaml
CHANGED
|
@@ -1,7 +1,7 @@
|
|
|
1
1
|
---
|
|
2
2
|
SHA256:
|
|
3
|
-
metadata.gz:
|
|
4
|
-
data.tar.gz:
|
|
3
|
+
metadata.gz: 3806d03fd90598754cbf0f4d2cc5437788d456bbe8a81bc6367cd5e80e1391f1
|
|
4
|
+
data.tar.gz: 7fe3bb2c4f9c3a5ec1793f10e19c7ab23d91f611a8d811614b2c76b2e8f88835
|
|
5
5
|
SHA512:
|
|
6
|
-
metadata.gz:
|
|
7
|
-
data.tar.gz:
|
|
6
|
+
metadata.gz: ded030f5290a59ee5a60f4d6517bb1a2364cc9a6410959b4f0ebe64c5d2ab381b3d19d612918425a7e68d3b3d68703e722f266b38d0197f863d7d2f2a484391a
|
|
7
|
+
data.tar.gz: 1c0de5ef22aff907b3ec2d5031418aa7d41111b81f3f3288522c82e7e03ece7d68c9d972873a487a4741e5c87355ad83ffbe4f7094cdacf3bd58c8e949714395
|
data/.github/matrix.json
CHANGED
|
@@ -3,8 +3,8 @@
|
|
|
3
3
|
"3.3"
|
|
4
4
|
],
|
|
5
5
|
"rails_version": [
|
|
6
|
-
"7.1.
|
|
7
|
-
"7.2.
|
|
6
|
+
"7.1.6",
|
|
7
|
+
"7.2.3.1"
|
|
8
8
|
],
|
|
9
9
|
"bootstrap_version": [
|
|
10
10
|
null
|
|
@@ -23,68 +23,85 @@
|
|
|
23
23
|
],
|
|
24
24
|
"include": [
|
|
25
25
|
{
|
|
26
|
-
"ruby": "3.
|
|
27
|
-
"rails_version": "8.0.
|
|
26
|
+
"ruby": "3.4",
|
|
27
|
+
"rails_version": "8.0.5",
|
|
28
28
|
"additional_engine_cart_rails_options": "--css=bootstrap"
|
|
29
29
|
},
|
|
30
30
|
{
|
|
31
|
-
"ruby": "3.
|
|
32
|
-
"rails_version": "8.0.
|
|
31
|
+
"ruby": "3.4",
|
|
32
|
+
"rails_version": "8.0.5",
|
|
33
33
|
"additional_engine_cart_rails_options": "--css=bootstrap --js=esbuild",
|
|
34
34
|
"additional_name": "| esbuild"
|
|
35
35
|
},
|
|
36
36
|
{
|
|
37
|
-
"ruby": "3.
|
|
38
|
-
"rails_version": "8.0.
|
|
37
|
+
"ruby": "3.4",
|
|
38
|
+
"rails_version": "8.0.5",
|
|
39
39
|
"view_component_version": "~> 4.0",
|
|
40
40
|
"additional_engine_cart_rails_options": "--css=bootstrap",
|
|
41
41
|
"additional_name": "| ViewComponent 4"
|
|
42
42
|
},
|
|
43
43
|
{
|
|
44
|
-
"ruby": "3.
|
|
45
|
-
"rails_version": "8.0.
|
|
44
|
+
"ruby": "3.4",
|
|
45
|
+
"rails_version": "8.0.5",
|
|
46
46
|
"view_component_version": "~> 4.0",
|
|
47
47
|
"additional_engine_cart_rails_options": "--css=bootstrap --js=esbuild",
|
|
48
48
|
"additional_name": "| esbuild, ViewComponent 4"
|
|
49
49
|
},
|
|
50
50
|
{
|
|
51
|
-
"ruby": "3.
|
|
52
|
-
"rails_version": "
|
|
53
|
-
"
|
|
54
|
-
"additional_name": "Solr 8.11.2"
|
|
51
|
+
"ruby": "3.4",
|
|
52
|
+
"rails_version": "8.1.3",
|
|
53
|
+
"additional_engine_cart_rails_options": "--css=bootstrap"
|
|
55
54
|
},
|
|
56
55
|
{
|
|
57
|
-
"ruby": "3.
|
|
58
|
-
"rails_version": "
|
|
56
|
+
"ruby": "3.4",
|
|
57
|
+
"rails_version": "8.1.3",
|
|
58
|
+
"bootstrap_version": "~> 4.0",
|
|
59
|
+
"additional_engine_cart_rails_options": "--css=bootstrap",
|
|
60
|
+
"additional_name": "| Bootstrap 4"
|
|
61
|
+
},
|
|
62
|
+
{
|
|
63
|
+
"ruby": "3.3",
|
|
64
|
+
"rails_version": "8.0.5",
|
|
65
|
+
"additional_name": "| Importmap + Sprockets"
|
|
59
66
|
},
|
|
60
67
|
{
|
|
61
|
-
"ruby": "3.
|
|
62
|
-
"rails_version": "7.1.
|
|
68
|
+
"ruby": "3.3",
|
|
69
|
+
"rails_version": "7.1.6",
|
|
70
|
+
"solr_version": "9",
|
|
71
|
+
"additional_name": "| Solr 9"
|
|
72
|
+
},
|
|
73
|
+
{
|
|
74
|
+
"ruby": "3.2",
|
|
75
|
+
"rails_version": "7.1.6"
|
|
76
|
+
},
|
|
77
|
+
{
|
|
78
|
+
"ruby": "3.2",
|
|
79
|
+
"rails_version": "7.1.6",
|
|
63
80
|
"view_component_version": "~> 2.74",
|
|
64
81
|
"additional_name": "| ViewComponent 2"
|
|
65
82
|
},
|
|
66
83
|
{
|
|
67
|
-
"ruby": "3.
|
|
68
|
-
"rails_version": "7.1.
|
|
84
|
+
"ruby": "3.2",
|
|
85
|
+
"rails_version": "7.1.6",
|
|
69
86
|
"additional_name": "| Propshaft",
|
|
70
87
|
"additional_engine_cart_rails_options": "-a propshaft --css=bootstrap"
|
|
71
88
|
},
|
|
72
89
|
{
|
|
73
|
-
"ruby": "3.
|
|
74
|
-
"rails_version": "7.1.
|
|
90
|
+
"ruby": "3.2",
|
|
91
|
+
"rails_version": "7.1.6",
|
|
75
92
|
"bootstrap_version": "~> 4.0",
|
|
76
93
|
"additional_name": "| Bootstrap 4"
|
|
77
94
|
},
|
|
78
95
|
{
|
|
79
|
-
"ruby": "3.
|
|
80
|
-
"rails_version": "7.1.
|
|
96
|
+
"ruby": "3.4",
|
|
97
|
+
"rails_version": "7.1.6",
|
|
81
98
|
"api": "true",
|
|
82
99
|
"additional_engine_cart_rails_options": "--api --skip-yarn",
|
|
83
100
|
"additional_name": "| API"
|
|
84
101
|
},
|
|
85
102
|
{
|
|
86
|
-
"ruby": "3.
|
|
87
|
-
"rails_version": "7.2.
|
|
103
|
+
"ruby": "3.4",
|
|
104
|
+
"rails_version": "7.2.3.1",
|
|
88
105
|
"additional_engine_cart_rails_options": "-a propshaft --css=bootstrap --js=esbuild",
|
|
89
106
|
"additional_name": "| Propshaft, esbuild"
|
|
90
107
|
}
|
data/.github/workflows/test.yml
CHANGED
|
@@ -4,7 +4,7 @@ on:
|
|
|
4
4
|
ref:
|
|
5
5
|
required: false
|
|
6
6
|
type: string
|
|
7
|
-
default:
|
|
7
|
+
default: ""
|
|
8
8
|
description: The branch or reference to run the workflow against
|
|
9
9
|
ruby:
|
|
10
10
|
required: false
|
|
@@ -48,7 +48,6 @@ jobs:
|
|
|
48
48
|
- name: Set up Ruby
|
|
49
49
|
uses: ruby/setup-ruby@v1
|
|
50
50
|
with:
|
|
51
|
-
bundler: "latest"
|
|
52
51
|
ruby-version: ${{ matrix.ruby }}
|
|
53
52
|
- name: Change permissions
|
|
54
53
|
run: "chmod -f -R o-w /opt/hostedtoolcache/Ruby/3.2.5/x64/lib/ruby/gems/3.2.0/gems | :"
|
data/.rubocop.yml
CHANGED
|
@@ -1,4 +1,4 @@
|
|
|
1
|
-
|
|
1
|
+
plugins:
|
|
2
2
|
- rubocop-capybara
|
|
3
3
|
- rubocop-rspec
|
|
4
4
|
- rubocop-rspec_rails
|
|
@@ -10,8 +10,8 @@ inherit_from:
|
|
|
10
10
|
|
|
11
11
|
AllCops:
|
|
12
12
|
DisplayCopNames: true
|
|
13
|
-
TargetRubyVersion: 3.
|
|
14
|
-
TargetRailsVersion:
|
|
13
|
+
TargetRubyVersion: 3.3
|
|
14
|
+
TargetRailsVersion: 7.2
|
|
15
15
|
Exclude:
|
|
16
16
|
- "lib/generators/blacklight/templates/**/*"
|
|
17
17
|
- "blacklight.gemspec"
|
|
@@ -75,7 +75,7 @@ Naming/MethodParameterName:
|
|
|
75
75
|
- of
|
|
76
76
|
- by
|
|
77
77
|
|
|
78
|
-
Naming/
|
|
78
|
+
Naming/PredicatePrefix:
|
|
79
79
|
ForbiddenPrefixes:
|
|
80
80
|
- is_
|
|
81
81
|
|
|
@@ -89,6 +89,9 @@ Rails/ApplicationMailer:
|
|
|
89
89
|
Style/AccessModifierDeclarations:
|
|
90
90
|
Enabled: false
|
|
91
91
|
|
|
92
|
+
Style/FormatStringToken:
|
|
93
|
+
EnforcedStyle: template
|
|
94
|
+
|
|
92
95
|
Style/MissingRespondToMissing:
|
|
93
96
|
Exclude:
|
|
94
97
|
- "lib/blacklight/nested_open_struct_with_hash_access.rb"
|
|
@@ -457,11 +460,11 @@ Style/SuperWithArgsParentheses: # new in 1.58
|
|
|
457
460
|
Enabled: true
|
|
458
461
|
Style/YAMLFileRead: # new in 1.53
|
|
459
462
|
Enabled: true
|
|
460
|
-
Capybara/
|
|
463
|
+
Capybara/AssertStyle: # new in 2.17
|
|
461
464
|
Enabled: true
|
|
462
|
-
Capybara/MatchStyle:
|
|
465
|
+
Capybara/RSpec/MatchStyle:
|
|
463
466
|
Enabled: true
|
|
464
|
-
Capybara/NegationMatcher: # new in 2.14
|
|
467
|
+
Capybara/RSpec/NegationMatcher: # new in 2.14
|
|
465
468
|
Enabled: true
|
|
466
469
|
Exclude:
|
|
467
470
|
- "spec/models/**/*"
|
|
@@ -471,7 +474,7 @@ Capybara/SpecificActions: # new in 2.14
|
|
|
471
474
|
Enabled: true
|
|
472
475
|
Capybara/SpecificFinders: # new in 2.13
|
|
473
476
|
Enabled: true
|
|
474
|
-
Capybara/SpecificMatcher: # new in 2.12
|
|
477
|
+
Capybara/RSpec/SpecificMatcher: # new in 2.12
|
|
475
478
|
Enabled: true
|
|
476
479
|
Capybara/RSpec/HaveSelector: # new in 2.19
|
|
477
480
|
Enabled: true
|
|
@@ -585,3 +588,143 @@ Rails/WhereRange: # new in 2.25
|
|
|
585
588
|
Enabled: true
|
|
586
589
|
Gemspec/AddRuntimeDependency: # new in 1.65
|
|
587
590
|
Enabled: true
|
|
591
|
+
Lint/ArrayLiteralInRegexp: # new in 1.71
|
|
592
|
+
Enabled: true
|
|
593
|
+
Lint/ConstantReassignment: # new in 1.70
|
|
594
|
+
Enabled: true
|
|
595
|
+
Lint/DuplicateSetElement: # new in 1.67
|
|
596
|
+
Enabled: true
|
|
597
|
+
Lint/HashNewWithKeywordArgumentsAsDefault: # new in 1.69
|
|
598
|
+
Enabled: true
|
|
599
|
+
Lint/NumericOperationWithConstantResult: # new in 1.69
|
|
600
|
+
Enabled: true
|
|
601
|
+
Lint/SharedMutableDefault: # new in 1.70
|
|
602
|
+
Enabled: true
|
|
603
|
+
Lint/UnescapedBracketInRegexp: # new in 1.68
|
|
604
|
+
Enabled: true
|
|
605
|
+
Lint/UselessDefined: # new in 1.69
|
|
606
|
+
Enabled: true
|
|
607
|
+
Lint/UselessNumericOperation: # new in 1.66
|
|
608
|
+
Enabled: true
|
|
609
|
+
Style/AmbiguousEndlessMethodDefinition: # new in 1.68
|
|
610
|
+
Enabled: true
|
|
611
|
+
Style/BitwisePredicate: # new in 1.68
|
|
612
|
+
Enabled: true
|
|
613
|
+
Style/CombinableDefined: # new in 1.68
|
|
614
|
+
Enabled: true
|
|
615
|
+
Style/DigChain: # new in 1.69
|
|
616
|
+
Enabled: true
|
|
617
|
+
Style/FileNull: # new in 1.69
|
|
618
|
+
Enabled: true
|
|
619
|
+
Style/FileTouch: # new in 1.69
|
|
620
|
+
Enabled: true
|
|
621
|
+
Style/HashSlice: # new in 1.71
|
|
622
|
+
Enabled: true
|
|
623
|
+
Style/ItAssignment: # new in 1.70
|
|
624
|
+
Enabled: true
|
|
625
|
+
Style/KeywordArgumentsMerging: # new in 1.68
|
|
626
|
+
Enabled: true
|
|
627
|
+
Style/RedundantInterpolationUnfreeze: # new in 1.66
|
|
628
|
+
Enabled: true
|
|
629
|
+
Style/SafeNavigationChainLength: # new in 1.68
|
|
630
|
+
Enabled: true
|
|
631
|
+
Rails/EnumSyntax: # new in 2.26
|
|
632
|
+
Enabled: true
|
|
633
|
+
Rails/MultipleRoutePaths: # new in 2.29
|
|
634
|
+
Enabled: true
|
|
635
|
+
Rails/StrongParametersExpect: # new in 2.29
|
|
636
|
+
Enabled: true
|
|
637
|
+
Lint/CopDirectiveSyntax: # new in 1.72
|
|
638
|
+
Enabled: true
|
|
639
|
+
Lint/RedundantTypeConversion: # new in 1.72
|
|
640
|
+
Enabled: true
|
|
641
|
+
Lint/SuppressedExceptionInNumberConversion: # new in 1.72
|
|
642
|
+
Enabled: true
|
|
643
|
+
Lint/UselessConstantScoping: # new in 1.72
|
|
644
|
+
Enabled: true
|
|
645
|
+
Style/ComparableBetween: # new in 1.74
|
|
646
|
+
Enabled: true
|
|
647
|
+
Style/HashFetchChain: # new in 1.75
|
|
648
|
+
Enabled: true
|
|
649
|
+
Style/ItBlockParameter: # new in 1.75
|
|
650
|
+
Enabled: true
|
|
651
|
+
Style/RedundantFormat: # new in 1.72
|
|
652
|
+
Enabled: true
|
|
653
|
+
Capybara/FindAllFirst: # new in 2.22
|
|
654
|
+
Enabled: true
|
|
655
|
+
Capybara/RSpec/NegationMatcherAfterVisit: # new in 2.22
|
|
656
|
+
Enabled: true
|
|
657
|
+
RSpec/IncludeExamples: # new in 3.6
|
|
658
|
+
Enabled: true
|
|
659
|
+
Lint/UselessDefaultValueArgument: # new in 1.76
|
|
660
|
+
Enabled: true
|
|
661
|
+
Lint/UselessOr: # new in 1.76
|
|
662
|
+
Enabled: true
|
|
663
|
+
Naming/PredicateMethod: # new in 1.76
|
|
664
|
+
Enabled: true
|
|
665
|
+
Style/EmptyStringInsideInterpolation: # new in 1.76
|
|
666
|
+
Enabled: true
|
|
667
|
+
Style/RedundantArrayFlatten: # new in 1.76
|
|
668
|
+
Enabled: true
|
|
669
|
+
Gemspec/AttributeAssignment: # new in 1.77
|
|
670
|
+
Enabled: true
|
|
671
|
+
Layout/EmptyLinesAfterModuleInclusion: # new in 1.79
|
|
672
|
+
Enabled: true
|
|
673
|
+
Lint/DataDefineOverride: # new in 1.85
|
|
674
|
+
Enabled: true
|
|
675
|
+
Lint/UnreachablePatternBranch: # new in 1.85
|
|
676
|
+
Enabled: true
|
|
677
|
+
Style/ArrayIntersectWithSingleElement: # new in 1.81
|
|
678
|
+
Enabled: true
|
|
679
|
+
Style/CollectionQuerying: # new in 1.77
|
|
680
|
+
Enabled: true
|
|
681
|
+
Style/EmptyClassDefinition: # new in 1.84
|
|
682
|
+
Enabled: true
|
|
683
|
+
Style/FileOpen: # new in 1.85
|
|
684
|
+
Enabled: true
|
|
685
|
+
Style/MapJoin: # new in 1.85
|
|
686
|
+
Enabled: true
|
|
687
|
+
Style/ModuleMemberExistenceCheck: # new in 1.82
|
|
688
|
+
Enabled: true
|
|
689
|
+
Style/NegativeArrayIndex: # new in 1.84
|
|
690
|
+
Enabled: true
|
|
691
|
+
Style/OneClassPerFile: # new in 1.85
|
|
692
|
+
Enabled: true
|
|
693
|
+
Style/PartitionInsteadOfDoubleSelect: # new in 1.85
|
|
694
|
+
Enabled: true
|
|
695
|
+
Style/PredicateWithKind: # new in 1.85
|
|
696
|
+
Enabled: true
|
|
697
|
+
Style/ReduceToHash: # new in 1.85
|
|
698
|
+
Enabled: true
|
|
699
|
+
Style/RedundantMinMaxBy: # new in 1.85
|
|
700
|
+
Enabled: true
|
|
701
|
+
Style/ReverseFind: # new in 1.84
|
|
702
|
+
Enabled: true
|
|
703
|
+
Style/SelectByKind: # new in 1.85
|
|
704
|
+
Enabled: true
|
|
705
|
+
Style/SelectByRange: # new in 1.85
|
|
706
|
+
Enabled: true
|
|
707
|
+
Style/TallyMethod: # new in 1.85
|
|
708
|
+
Enabled: true
|
|
709
|
+
Capybara/RSpec/CurrentPathExpectation: # new in 1.18
|
|
710
|
+
Enabled: true
|
|
711
|
+
Capybara/RSpec/HaveContent: # new in 2.23
|
|
712
|
+
Enabled: true
|
|
713
|
+
Capybara/RSpec/VisibilityMatcher: # new in 1.39
|
|
714
|
+
Enabled: true
|
|
715
|
+
RSpec/LeakyLocalVariable: # new in 3.8
|
|
716
|
+
Enabled: true
|
|
717
|
+
RSpec/Output: # new in 3.9
|
|
718
|
+
Enabled: true
|
|
719
|
+
RSpecRails/HttpStatusNameConsistency: # new in 2.32
|
|
720
|
+
Enabled: true
|
|
721
|
+
Rails/FindByOrAssignmentMemoization: # new in 2.33
|
|
722
|
+
Enabled: true
|
|
723
|
+
Rails/OrderArguments: # new in 2.33
|
|
724
|
+
Enabled: true
|
|
725
|
+
Rails/RedirectBackOrTo: # new in 2.34
|
|
726
|
+
Enabled: true
|
|
727
|
+
RSpec/DiscardedMatcher: # new in 3.10
|
|
728
|
+
Enabled: true
|
|
729
|
+
RSpec/MatchWithSimpleRegex: # new in 3.10
|
|
730
|
+
Enabled: true
|
data/.rubocop_todo.yml
CHANGED
|
@@ -1,6 +1,6 @@
|
|
|
1
1
|
# This configuration was generated by
|
|
2
2
|
# `rubocop --auto-gen-config`
|
|
3
|
-
# on
|
|
3
|
+
# on 2026-07-22 03:10:29 UTC using RuboCop version 1.88.2.
|
|
4
4
|
# The point is for the user to remove these configuration records
|
|
5
5
|
# one by one as the offenses are removed from the code base.
|
|
6
6
|
# Note that changes in the inspected code, or installation of new
|
|
@@ -8,12 +8,21 @@
|
|
|
8
8
|
|
|
9
9
|
# Offense count: 4
|
|
10
10
|
# This cop supports safe autocorrection (--autocorrect).
|
|
11
|
-
Capybara/CurrentPathExpectation:
|
|
11
|
+
Capybara/RSpec/CurrentPathExpectation:
|
|
12
12
|
Exclude:
|
|
13
13
|
- 'spec/features/alternate_controller_spec.rb'
|
|
14
14
|
|
|
15
|
+
# Offense count: 6
|
|
16
|
+
Capybara/RSpec/NegationMatcherAfterVisit:
|
|
17
|
+
Exclude:
|
|
18
|
+
- 'spec/features/facets_spec.rb'
|
|
19
|
+
- 'spec/features/modal_spec.rb'
|
|
20
|
+
- 'spec/features/record_view_spec.rb'
|
|
21
|
+
- 'spec/features/search_context_spec.rb'
|
|
22
|
+
- 'spec/features/sitelinks_search_box_spec.rb'
|
|
23
|
+
|
|
15
24
|
# Offense count: 13
|
|
16
|
-
Capybara/VisibilityMatcher:
|
|
25
|
+
Capybara/RSpec/VisibilityMatcher:
|
|
17
26
|
Exclude:
|
|
18
27
|
- 'spec/features/facets_spec.rb'
|
|
19
28
|
- 'spec/features/search_filters_spec.rb'
|
|
@@ -44,20 +53,12 @@ Lint/AmbiguousOperator:
|
|
|
44
53
|
- 'spec/models/blacklight/facet_paginator_spec.rb'
|
|
45
54
|
- 'spec/services/blacklight/search_service_spec.rb'
|
|
46
55
|
|
|
47
|
-
# Offense count:
|
|
56
|
+
# Offense count: 7
|
|
48
57
|
# This cop supports safe autocorrection (--autocorrect).
|
|
49
58
|
Lint/AmbiguousRegexpLiteral:
|
|
50
59
|
Exclude:
|
|
51
|
-
- 'spec/controllers/catalog_controller_spec.rb'
|
|
52
60
|
- 'spec/features/alternate_controller_spec.rb'
|
|
53
|
-
- 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
|
|
54
|
-
- 'spec/helpers/catalog_helper_spec.rb'
|
|
55
61
|
- 'spec/models/record_mailer_spec.rb'
|
|
56
|
-
- 'spec/views/catalog/_document.html.erb_spec.rb'
|
|
57
|
-
- 'spec/views/catalog/_search_header.erb_spec.rb'
|
|
58
|
-
- 'spec/views/catalog/_sort_and_per_page.html.erb_spec.rb'
|
|
59
|
-
- 'spec/views/catalog/index.html.erb_spec.rb'
|
|
60
|
-
- 'spec/views/catalog/show.html.erb_spec.rb'
|
|
61
62
|
|
|
62
63
|
# Offense count: 1
|
|
63
64
|
Lint/BinaryOperatorWithIdenticalOperands:
|
|
@@ -90,7 +91,7 @@ Lint/EmptyFile:
|
|
|
90
91
|
Exclude:
|
|
91
92
|
- 'spec/components/blacklight/document_metadata_component_spec.rb'
|
|
92
93
|
|
|
93
|
-
# Offense count:
|
|
94
|
+
# Offense count: 51
|
|
94
95
|
# Configuration parameters: AllowedParentClasses.
|
|
95
96
|
Lint/MissingSuper:
|
|
96
97
|
Enabled: false
|
|
@@ -105,12 +106,12 @@ Lint/ParenthesesAsGroupedExpression:
|
|
|
105
106
|
- 'spec/features/search_spec.rb'
|
|
106
107
|
- 'spec/models/blacklight/solr/repository_spec.rb'
|
|
107
108
|
|
|
108
|
-
# Offense count:
|
|
109
|
-
Lint/
|
|
109
|
+
# Offense count: 1
|
|
110
|
+
Lint/UselessDefined:
|
|
110
111
|
Exclude:
|
|
111
|
-
- 'spec/models/blacklight/
|
|
112
|
+
- 'spec/models/blacklight/solr/document_spec.rb'
|
|
112
113
|
|
|
113
|
-
# Offense count:
|
|
114
|
+
# Offense count: 82
|
|
114
115
|
# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
|
|
115
116
|
Metrics/AbcSize:
|
|
116
117
|
Max: 46
|
|
@@ -121,12 +122,12 @@ Metrics/AbcSize:
|
|
|
121
122
|
Metrics/BlockLength:
|
|
122
123
|
Max: 26
|
|
123
124
|
|
|
124
|
-
# Offense count:
|
|
125
|
+
# Offense count: 40
|
|
125
126
|
# Configuration parameters: AllowedMethods, AllowedPatterns.
|
|
126
127
|
Metrics/CyclomaticComplexity:
|
|
127
|
-
Max:
|
|
128
|
+
Max: 13
|
|
128
129
|
|
|
129
|
-
# Offense count:
|
|
130
|
+
# Offense count: 79
|
|
130
131
|
# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
|
|
131
132
|
Metrics/MethodLength:
|
|
132
133
|
Max: 27
|
|
@@ -141,7 +142,7 @@ Metrics/ModuleLength:
|
|
|
141
142
|
Metrics/ParameterLists:
|
|
142
143
|
Max: 6
|
|
143
144
|
|
|
144
|
-
# Offense count:
|
|
145
|
+
# Offense count: 34
|
|
145
146
|
# Configuration parameters: AllowedMethods, AllowedPatterns.
|
|
146
147
|
Metrics/PerceivedComplexity:
|
|
147
148
|
Max: 14
|
|
@@ -167,10 +168,19 @@ Naming/MethodParameterName:
|
|
|
167
168
|
- 'lib/blacklight/solr/document.rb'
|
|
168
169
|
- 'lib/blacklight/solr/search_builder_behavior.rb'
|
|
169
170
|
|
|
171
|
+
# Offense count: 3
|
|
172
|
+
# Configuration parameters: Mode, AllowedMethods, AllowedPatterns, AllowBangMethods, WaywardPredicates.
|
|
173
|
+
# AllowedMethods: call
|
|
174
|
+
# WaywardPredicates: infinite?, nonzero?
|
|
175
|
+
Naming/PredicateMethod:
|
|
176
|
+
Exclude:
|
|
177
|
+
- 'app/controllers/concerns/blacklight/catalog.rb'
|
|
178
|
+
- 'lib/blacklight/solr/repository.rb'
|
|
179
|
+
|
|
170
180
|
# Offense count: 9
|
|
171
181
|
# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
|
|
172
182
|
# SupportedStyles: snake_case, normalcase, non_integer
|
|
173
|
-
# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
|
|
183
|
+
# AllowedIdentifiers: TLS1_1, TLS1_2, capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
|
|
174
184
|
Naming/VariableNumber:
|
|
175
185
|
Exclude:
|
|
176
186
|
- 'spec/lib/blacklight/search_state_spec.rb'
|
|
@@ -184,13 +194,13 @@ RSpec/BeforeAfterAll:
|
|
|
184
194
|
- 'spec/models/blacklight/document/dublin_core_spec.rb'
|
|
185
195
|
- 'spec/models/blacklight/solr/document_spec.rb'
|
|
186
196
|
|
|
187
|
-
# Offense count:
|
|
197
|
+
# Offense count: 110
|
|
188
198
|
# Configuration parameters: Prefixes, AllowedPatterns.
|
|
189
199
|
# Prefixes: when, with, without
|
|
190
200
|
RSpec/ContextWording:
|
|
191
201
|
Enabled: false
|
|
192
202
|
|
|
193
|
-
# Offense count:
|
|
203
|
+
# Offense count: 149
|
|
194
204
|
# Configuration parameters: CountAsOne.
|
|
195
205
|
RSpec/ExampleLength:
|
|
196
206
|
Max: 33
|
|
@@ -217,6 +227,7 @@ RSpec/InstanceVariable:
|
|
|
217
227
|
- 'spec/views/catalog/index.atom.builder_spec.rb'
|
|
218
228
|
|
|
219
229
|
# Offense count: 4
|
|
230
|
+
# This cop supports safe autocorrection (--autocorrect).
|
|
220
231
|
RSpec/IteratedExpectation:
|
|
221
232
|
Exclude:
|
|
222
233
|
- 'spec/models/blacklight/solr/response/group_response_spec.rb'
|
|
@@ -255,22 +266,22 @@ RSpec/MessageSpies:
|
|
|
255
266
|
- 'spec/models/blacklight/suggest_search_spec.rb'
|
|
256
267
|
- 'spec/presenters/blacklight/field_presenter_spec.rb'
|
|
257
268
|
|
|
258
|
-
# Offense count:
|
|
269
|
+
# Offense count: 403
|
|
259
270
|
RSpec/MultipleExpectations:
|
|
260
271
|
Max: 16
|
|
261
272
|
|
|
262
|
-
# Offense count:
|
|
273
|
+
# Offense count: 296
|
|
263
274
|
# Configuration parameters: AllowSubject.
|
|
264
275
|
RSpec/MultipleMemoizedHelpers:
|
|
265
276
|
Max: 14
|
|
266
277
|
|
|
267
|
-
# Offense count:
|
|
278
|
+
# Offense count: 424
|
|
268
279
|
# Configuration parameters: EnforcedStyle, IgnoreSharedExamples.
|
|
269
280
|
# SupportedStyles: always, named_only
|
|
270
281
|
RSpec/NamedSubject:
|
|
271
282
|
Enabled: false
|
|
272
283
|
|
|
273
|
-
# Offense count:
|
|
284
|
+
# Offense count: 61
|
|
274
285
|
# Configuration parameters: AllowedGroups.
|
|
275
286
|
RSpec/NestedGroups:
|
|
276
287
|
Max: 5
|
|
@@ -293,7 +304,6 @@ RSpec/RepeatedExampleGroupDescription:
|
|
|
293
304
|
|
|
294
305
|
# Offense count: 1
|
|
295
306
|
# This cop supports safe autocorrection (--autocorrect).
|
|
296
|
-
# Configuration parameters: AutoCorrect.
|
|
297
307
|
RSpec/ScatteredLet:
|
|
298
308
|
Exclude:
|
|
299
309
|
- 'spec/views/catalog/index.atom.builder_spec.rb'
|
|
@@ -310,6 +320,7 @@ RSpec/StubbedMock:
|
|
|
310
320
|
- 'spec/presenters/blacklight/field_presenter_spec.rb'
|
|
311
321
|
|
|
312
322
|
# Offense count: 1
|
|
323
|
+
# This cop supports safe autocorrection (--autocorrect).
|
|
313
324
|
RSpec/SubjectDeclaration:
|
|
314
325
|
Exclude:
|
|
315
326
|
- 'spec/models/blacklight/document/cache_key_spec.rb'
|
|
@@ -324,10 +335,21 @@ RSpec/SubjectStub:
|
|
|
324
335
|
- 'spec/presenters/blacklight/document_presenter_spec.rb'
|
|
325
336
|
- 'spec/services/blacklight/search_service_spec.rb'
|
|
326
337
|
|
|
327
|
-
# Offense count:
|
|
338
|
+
# Offense count: 18
|
|
328
339
|
# Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
|
|
329
340
|
RSpec/VerifiedDoubles:
|
|
330
|
-
|
|
341
|
+
Exclude:
|
|
342
|
+
- 'spec/components/blacklight/search/facet_suggest_input_spec.rb'
|
|
343
|
+
- 'spec/components/blacklight/system/dropdown_component_spec.rb'
|
|
344
|
+
- 'spec/controllers/catalog_controller_spec.rb'
|
|
345
|
+
- 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
|
|
346
|
+
- 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
|
|
347
|
+
- 'spec/helpers/catalog_helper_spec.rb'
|
|
348
|
+
- 'spec/presenters/blacklight/document_presenter_spec.rb'
|
|
349
|
+
- 'spec/presenters/blacklight/field_presenter_spec.rb'
|
|
350
|
+
- 'spec/presenters/blacklight/thumbnail_presenter_spec.rb'
|
|
351
|
+
- 'spec/services/blacklight/search_service_spec.rb'
|
|
352
|
+
- 'spec/views/catalog/_document_list.html.erb_spec.rb'
|
|
331
353
|
|
|
332
354
|
# Offense count: 4
|
|
333
355
|
# This cop supports unsafe autocorrection (--autocorrect-all).
|
|
@@ -337,9 +359,7 @@ Rails/Date:
|
|
|
337
359
|
Exclude:
|
|
338
360
|
- 'spec/models/search_spec.rb'
|
|
339
361
|
|
|
340
|
-
# Offense count:
|
|
341
|
-
# Configuration parameters: Include.
|
|
342
|
-
# Include: app/helpers/**/*.rb
|
|
362
|
+
# Offense count: 22
|
|
343
363
|
Rails/HelperInstanceVariable:
|
|
344
364
|
Exclude:
|
|
345
365
|
- 'app/helpers/blacklight/catalog_helper_behavior.rb'
|
|
@@ -349,8 +369,6 @@ Rails/HelperInstanceVariable:
|
|
|
349
369
|
- 'app/helpers/blacklight/render_partials_helper_behavior.rb'
|
|
350
370
|
|
|
351
371
|
# Offense count: 2
|
|
352
|
-
# Configuration parameters: Include.
|
|
353
|
-
# Include: spec/**/*.rb, test/**/*.rb
|
|
354
372
|
Rails/I18nLocaleAssignment:
|
|
355
373
|
Exclude:
|
|
356
374
|
- 'spec/helpers/blacklight_helper_spec.rb'
|
|
@@ -360,7 +378,7 @@ Rails/OutputSafety:
|
|
|
360
378
|
Exclude:
|
|
361
379
|
- 'app/presenters/blacklight/rendering/join.rb'
|
|
362
380
|
|
|
363
|
-
# Offense count:
|
|
381
|
+
# Offense count: 15
|
|
364
382
|
Security/Eval:
|
|
365
383
|
Exclude:
|
|
366
384
|
- 'spec/models/blacklight/solr/response_spec.rb'
|
|
@@ -378,7 +396,7 @@ Style/Alias:
|
|
|
378
396
|
- 'lib/blacklight/solr/response.rb'
|
|
379
397
|
- 'lib/blacklight/solr/response/group_response.rb'
|
|
380
398
|
|
|
381
|
-
# Offense count:
|
|
399
|
+
# Offense count: 2
|
|
382
400
|
# This cop supports safe autocorrection (--autocorrect).
|
|
383
401
|
# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, AllowedMethods, AllowedPatterns, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
|
|
384
402
|
# SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
|
|
@@ -390,10 +408,12 @@ Style/BlockDelimiters:
|
|
|
390
408
|
- 'app/views/catalog/index.rss.builder'
|
|
391
409
|
- 'app/views/catalog/opensearch.xml.builder'
|
|
392
410
|
|
|
393
|
-
# Offense count:
|
|
411
|
+
# Offense count: 42
|
|
394
412
|
# This cop supports unsafe autocorrection (--autocorrect-all).
|
|
395
|
-
# Configuration parameters: EnforcedStyle.
|
|
413
|
+
# Configuration parameters: EnforcedStyle, EnforcedStyleForClasses, EnforcedStyleForModules.
|
|
396
414
|
# SupportedStyles: nested, compact
|
|
415
|
+
# SupportedStylesForClasses: ~, nested, compact
|
|
416
|
+
# SupportedStylesForModules: ~, nested, compact
|
|
397
417
|
Style/ClassAndModuleChildren:
|
|
398
418
|
Enabled: false
|
|
399
419
|
|
|
@@ -418,7 +438,7 @@ Style/DocumentDynamicEvalDefinition:
|
|
|
418
438
|
- 'app/builders/blacklight/action_builder.rb'
|
|
419
439
|
- 'lib/blacklight/configuration/fields.rb'
|
|
420
440
|
|
|
421
|
-
# Offense count:
|
|
441
|
+
# Offense count: 134
|
|
422
442
|
# Configuration parameters: AllowedConstants.
|
|
423
443
|
Style/Documentation:
|
|
424
444
|
Enabled: false
|
|
@@ -437,14 +457,6 @@ Style/ExpandPathArguments:
|
|
|
437
457
|
- 'lib/generators/blacklight/test_support_generator.rb'
|
|
438
458
|
- 'lib/generators/blacklight/user_generator.rb'
|
|
439
459
|
|
|
440
|
-
# Offense count: 16
|
|
441
|
-
# This cop supports safe autocorrection (--autocorrect).
|
|
442
|
-
# Configuration parameters: MaxUnannotatedPlaceholdersAllowed, AllowedMethods, AllowedPatterns.
|
|
443
|
-
# SupportedStyles: annotated, template, unannotated
|
|
444
|
-
# AllowedMethods: redirect
|
|
445
|
-
Style/FormatStringToken:
|
|
446
|
-
EnforcedStyle: template
|
|
447
|
-
|
|
448
460
|
# Offense count: 6
|
|
449
461
|
# This cop supports safe autocorrection (--autocorrect).
|
|
450
462
|
# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
|
|
@@ -456,7 +468,7 @@ Style/GuardClause:
|
|
|
456
468
|
- 'app/helpers/blacklight/catalog_helper_behavior.rb'
|
|
457
469
|
- 'lib/blacklight/solr/search_builder_behavior.rb'
|
|
458
470
|
|
|
459
|
-
# Offense count:
|
|
471
|
+
# Offense count: 30
|
|
460
472
|
# This cop supports safe autocorrection (--autocorrect).
|
|
461
473
|
Style/IfUnlessModifier:
|
|
462
474
|
Enabled: false
|
|
@@ -478,7 +490,7 @@ Style/MultipleComparison:
|
|
|
478
490
|
|
|
479
491
|
# Offense count: 2
|
|
480
492
|
# This cop supports unsafe autocorrection (--autocorrect-all).
|
|
481
|
-
# Configuration parameters: EnforcedStyle.
|
|
493
|
+
# Configuration parameters: EnforcedStyle, Recursive.
|
|
482
494
|
# SupportedStyles: literals, strict
|
|
483
495
|
Style/MutableConstant:
|
|
484
496
|
Exclude:
|
|
@@ -541,7 +553,7 @@ Style/RescueStandardError:
|
|
|
541
553
|
- 'lib/blacklight/configuration/fields.rb'
|
|
542
554
|
- 'lib/railties/blacklight.rake'
|
|
543
555
|
|
|
544
|
-
# Offense count:
|
|
556
|
+
# Offense count: 12
|
|
545
557
|
# This cop supports unsafe autocorrection (--autocorrect-all).
|
|
546
558
|
# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
|
|
547
559
|
# AllowedMethods: present?, blank?, presence, try, try!
|
|
@@ -570,7 +582,7 @@ Style/SoleNestedConditional:
|
|
|
570
582
|
Exclude:
|
|
571
583
|
- 'app/controllers/concerns/blacklight/controller.rb'
|
|
572
584
|
|
|
573
|
-
# Offense count:
|
|
585
|
+
# Offense count: 31
|
|
574
586
|
# This cop supports safe autocorrection (--autocorrect).
|
|
575
587
|
# Configuration parameters: MinSize.
|
|
576
588
|
# SupportedStyles: percent, brackets
|
data/VERSION
CHANGED
|
@@ -1 +1 @@
|
|
|
1
|
-
8.
|
|
1
|
+
8.13.0
|