blacklight 7.0.1 → 7.1.0.alpha

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1b48d282f24a3086daabbb88b766b5a1d76ff4230a6e6abff9d419b23b01289e
-  data.tar.gz: 31da35fbd6535f17a16803af0058b3734e5eb37c44352cc0fbacad8a7bf45142
+  metadata.gz: 9fe756dbe6e6b38431044bba1b30657153080d460efc11c93b834292a90997dc
+  data.tar.gz: 458c1152d21f9a2efde59f4ac97f6ceb569ccd7eeb1916d33563c95492f76ebd
 SHA512:
-  metadata.gz: c27bcde35299dcc9468f3684459664fe048d2e4c284701d30128e9f842fb18575905b934c806fb55290ac9eaaf434461b680b1ea3f2f7a626e627c05787391a5
-  data.tar.gz: 8478b902a2878b30091fc944dd3be890322a530eca1559f78c9867c03838f575bf46fd4cff2f7b88b00d035deaa0cc51274bc8b253c97626c9af059be7572fda
+  metadata.gz: 163e004de0439fc7d94c0beea0bf32f946987730c683e737f5dd4ee99914eaf9493f4b7d7af966101ddadb08dd2b5f905973f2e959677da566261024d50fe391
+  data.tar.gz: 9e49bb0e02d04074076f24c05be20d03c58803f12aea81faa80fa69cfe9ab9d7a1d2f82d44ab3fb6928cfd56284747a3449de53b299113f4cf540c78e0ab24fa

data/.rubocop_todo.yml

@@ -1,12 +1,13 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-10-31 21:34:01 -0500 using RuboCop version 0.60.0.
+# on 2019-01-18 23:13:39 -0600 using RuboCop version 0.63.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
 # Offense count: 4
+# Cop supports --auto-correct.
 Capybara/CurrentPathExpectation:
   Exclude:
     - 'spec/features/alternate_controller_spec.rb'
@@ -126,12 +127,11 @@ Layout/SpaceInsideParens:
     - 'app/views/catalog/_document.rss.builder'
     - 'app/views/catalog/index.atom.builder'
 
-# Offense count: 27
+# Offense count: 13
 # Cop supports --auto-correct.
 # Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
   Exclude:
-    - 'app/views/catalog/_document.atom.builder'
     - 'app/views/catalog/_document.rss.builder'
     - 'app/views/catalog/index.atom.builder'
 
@@ -151,7 +151,7 @@ Lint/AmbiguousOperator:
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 58
+# Offense count: 55
 Lint/AmbiguousRegexpLiteral:
   Exclude:
     - 'spec/controllers/catalog_controller_spec.rb'
@@ -211,7 +211,7 @@ Metrics/ClassLength:
 Metrics/CyclomaticComplexity:
   Max: 12
 
-# Offense count: 46
+# Offense count: 47
 # Configuration parameters: CountComments, ExcludedMethods.
 Metrics/MethodLength:
   Max: 35
@@ -271,11 +271,10 @@ Performance/TimesMap:
   Exclude:
     - 'spec/views/catalog/index.atom.builder_spec.rb'
 
-# Offense count: 3
+# Offense count: 2
 Performance/UnfreezeString:
   Exclude:
     - 'lib/generators/blacklight/install_generator.rb'
-    - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
     - 'spec/helpers/blacklight_helper_spec.rb'
 
 # Offense count: 9
@@ -309,7 +308,7 @@ RSpec/EmptyExampleGroup:
   Exclude:
     - 'spec/models/blacklight/solr/search_builder_spec.rb'
 
-# Offense count: 126
+# Offense count: 127
 # Configuration parameters: Max.
 RSpec/ExampleLength:
   Enabled: false
@@ -352,18 +351,33 @@ RSpec/MessageChain:
     - 'spec/presenters/blacklight/show_presenter_spec.rb'
     - 'spec/views/shared/_user_util_links.html.erb_spec.rb'
 
-# Offense count: 62
-# Configuration parameters: .
+# Offense count: 67
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: have_received, receive
 RSpec/MessageSpies:
-  Enabled: false
+  Exclude:
+    - 'spec/controllers/catalog_controller_spec.rb'
+    - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/suggest_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
+    - 'spec/helpers/blacklight_helper_spec.rb'
+    - 'spec/helpers/catalog_helper_spec.rb'
+    - 'spec/lib/blacklight/configuration/facet_field_spec.rb'
+    - 'spec/models/blacklight/search_builder_spec.rb'
+    - 'spec/models/blacklight/suggest_search_spec.rb'
+    - 'spec/presenters/blacklight/index_presenter_spec.rb'
+    - 'spec/presenters/blacklight/show_presenter_spec.rb'
+    - 'spec/presenters/thumbnail_presenter_spec.rb'
 
-# Offense count: 339
+# Offense count: 345
 # Configuration parameters: AggregateFailuresByDefault.
 RSpec/MultipleExpectations:
   Max: 16
 
-# Offense count: 326
+# Offense count: 328
+# Configuration parameters: IgnoreSharedExamples.
 RSpec/NamedSubject:
   Enabled: false
 
@@ -398,7 +412,7 @@ RSpec/SubjectStub:
     - 'spec/lib/blacklight/search_state_spec.rb'
     - 'spec/services/blacklight/search_service_spec.rb'
 
-# Offense count: 117
+# Offense count: 118
 # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
 RSpec/VerifiedDoubles:
   Enabled: false
@@ -408,13 +422,6 @@ RSpec/VoidExpect:
   Exclude:
     - 'spec/lib/blacklight/configuration/facet_field_spec.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: NilOrEmpty, NotPresent, UnlessPresent.
-Rails/Blank:
-  Exclude:
-    - 'lib/blacklight/solr/search_builder_behavior.rb'
-
 # Offense count: 4
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: strict, flexible
@@ -422,18 +429,6 @@ Rails/Date:
   Exclude:
     - 'spec/models/search_spec.rb'
 
-# Offense count: 13
-# Cop supports --auto-correct.
-# Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank.
-Rails/Present:
-  Exclude:
-    - 'app/controllers/concerns/blacklight/catalog.rb'
-    - 'app/helpers/blacklight/component_helper_behavior.rb'
-    - 'app/helpers/blacklight/facets_helper_behavior.rb'
-    - 'app/models/concerns/blacklight/document/email.rb'
-    - 'app/models/concerns/blacklight/document/sms.rb'
-    - 'lib/blacklight/solr/search_builder_behavior.rb'
-
 # Offense count: 1
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: strict, flexible
@@ -502,12 +497,6 @@ Style/ConditionalAssignment:
   Exclude:
     - 'lib/blacklight/solr/response/spelling.rb'
 
-# Offense count: 1
-# Configuration parameters: AllowCoercion.
-Style/DateTime:
-  Exclude:
-    - 'spec/models/blacklight/solr/search_builder_spec.rb'
-
 # Offense count: 93
 Style/Documentation:
   Enabled: false
@@ -548,15 +537,7 @@ Style/GuardClause:
     - 'app/helpers/blacklight/catalog_helper_behavior.rb'
     - 'lib/blacklight/solr/search_builder_behavior.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
-# SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
-Style/HashSyntax:
-  Exclude:
-    - 'app/helpers/blacklight/url_helper_behavior.rb'
-
-# Offense count: 39
+# Offense count: 40
 # Cop supports --auto-correct.
 Style/IfUnlessModifier:
   Enabled: false
@@ -652,7 +633,7 @@ Style/Semicolon:
     - 'spec/models/blacklight/solr/repository_spec.rb'
     - 'spec/views/catalog/_paginate_compact.html.erb_spec.rb'
 
-# Offense count: 32
+# Offense count: 31
 # Cop supports --auto-correct.
 # Configuration parameters: MinSize.
 # SupportedStyles: percent, brackets

data/.travis.yml

@@ -1,4 +1,4 @@
-dist: trusty
+dist: xenial
 addons:
   chrome: stable
 language: ruby
@@ -27,8 +27,8 @@ matrix:
   fast_finish: true
 
 before_install:
-  - gem update --system
-  - gem install bundler
+  - gem install chromedriver-helper --no-document
+  - chromedriver-update 73.0.3683.68
   - google-chrome-stable --headless --disable-gpu --no-sandbox --remote-debugging-port=9222 http://localhost &
 
 notifications:
@@ -41,7 +41,7 @@ global_env:
   - ENGINE_CART_RAILS_OPTIONS='--skip-git --skip-bundle --skip-listen --skip-spring --skip-yarn --skip-keeps --skip-action-cable --skip-coffee --skip-test'
   - CC_TEST_REPORTER_ID=5042c7358c96b0b926088a4cda3e132fffe7a66ce8047cdb1dc6f0b4b6676b79
 
-jdk: oraclejdk9
+jdk: openjdk11
 
 before_script:
   - curl -L https://codeclimate.com/downloads/test-reporter/test-reporter-latest-linux-amd64 > ./cc-test-reporter

data/VERSION

@@ -1 +1 @@
-7.0.1
+7.1.0.alpha

data/app/assets/javascripts/blacklight/blacklight.js

@@ -4,15 +4,14 @@ Blacklight = function () {
     onLoad: function (func) {
       buffer.push(func);
     },
-
     activate: function () {
       for (var i = 0; i < buffer.length; i++) {
         buffer[i].call();
       }
     },
-
     listeners: function () {
       var listeners = [];
+
       if (typeof Turbolinks !== 'undefined' && Turbolinks.supported) {
         // Turbolinks 5
         if (Turbolinks.BrowserAdapter) {
@@ -28,16 +27,15 @@ Blacklight = function () {
       return listeners;
     }
   };
-}();
-
-// turbolinks triggers page:load events on page transition
+}(); // turbolinks triggers page:load events on page transition
 // If app isn't using turbolinks, this event will never be triggered, no prob.
+
+
 Blacklight.listeners().forEach(function (listener) {
   document.addEventListener(listener, function () {
     Blacklight.activate();
   });
 });
-
 $('.no-js').removeClass('no-js').addClass('js');
 /*global Bloodhound */
 
@@ -46,11 +44,12 @@ Blacklight.onLoad(function () {
 
   $('[data-autocomplete-enabled="true"]').each(function () {
     var $el = $(this);
+
     if ($el.hasClass('tt-hint')) {
       return;
     }
-    var suggestUrl = $el.data().autocompletePath;
 
+    var suggestUrl = $el.data().autocompletePath;
     var terms = new Bloodhound({
       datumTokenizer: Bloodhound.tokenizers.obj.whitespace('value'),
       queryTokenizer: Bloodhound.tokenizers.whitespace,
@@ -59,9 +58,7 @@ Blacklight.onLoad(function () {
         wildcard: '%QUERY'
       }
     });
-
     terms.initialize();
-
     $el.typeahead({
       hint: true,
       highlight: true,
@@ -73,6 +70,7 @@ Blacklight.onLoad(function () {
     });
   });
 });
+
 (function ($) {
   //change form submit toggle to checkbox
   Blacklight.doBookmarkToggleBehavior = function () {
@@ -80,6 +78,7 @@ Blacklight.onLoad(function () {
       console.warn("do_bookmark_toggle_behavior is deprecated. Use doBookmarkToggleBehavior instead.");
       return Blacklight.do_bookmark_toggle_behavior();
     }
+
     $(Blacklight.doBookmarkToggleBehavior.selector).blCheckboxSubmit({
       // cssClass is added to elements added, plus used for id base
       cssClass: 'toggle-bookmark',
@@ -90,8 +89,8 @@ Blacklight.onLoad(function () {
       }
     });
   };
-  Blacklight.doBookmarkToggleBehavior.selector = 'form.bookmark-toggle';
 
+  Blacklight.doBookmarkToggleBehavior.selector = 'form.bookmark-toggle';
   Blacklight.onLoad(function () {
     Blacklight.doBookmarkToggleBehavior();
   });
@@ -126,39 +125,37 @@ Blacklight.onLoad(function () {
         }
    });
 */
+
+
 (function ($) {
   $.fn.blCheckboxSubmit = function (argOpts) {
     this.each(function () {
       var options = $.extend({}, $.fn.blCheckboxSubmit.defaults, argOpts);
-
       var form = $(this);
-      form.children().hide();
-      //We're going to use the existing form to actually send our add/removes
+      form.children().hide(); //We're going to use the existing form to actually send our add/removes
       //This works conveneintly because the exact same action href is used
       //for both bookmarks/$doc_id.  But let's take out the irrelevant parts
       //of the form to avoid any future confusion.
-      form.find('input[type=submit]').remove();
 
-      //View needs to set data-doc-id so we know a unique value
+      form.find('input[type=submit]').remove(); //View needs to set data-doc-id so we know a unique value
       //for making DOM id
-      var uniqueId = form.attr('data-doc-id') || Math.random();
-      // if form is currently using method delete to change state,
+
+      var uniqueId = form.attr('data-doc-id') || Math.random(); // if form is currently using method delete to change state,
       // then checkbox is currently checked
-      var checked = form.find('input[name=_method][value=delete]').length != 0;
 
+      var checked = form.find('input[name=_method][value=delete]').length != 0;
       var checkbox = $('<input type="checkbox">').addClass(options.cssClass).attr('id', options.cssClass + '_' + uniqueId);
       var label = $('<label>').addClass(options.cssClass).attr('for', options.cssClass + '_' + uniqueId).attr('title', form.attr('title') || '');
       var span = $('<span>');
-
       label.append(checkbox);
       label.append(' ');
       label.append(span);
-
       var checkboxDiv = $('<div class="checkbox" />').addClass(options.cssClass).append(label);
 
       function updateStateFor(state) {
         checkbox.prop('checked', state);
         label.toggleClass('checked', state);
+
         if (state) {
           //Set the Rails hidden field that fakes an HTTP verb
           //properly for current state action.
@@ -172,12 +169,10 @@ Blacklight.onLoad(function () {
 
       form.append(checkboxDiv);
       updateStateFor(checked);
-
       checkbox.click(function () {
         span.text(form.attr('data-inprogress'));
         label.attr('disabled', 'disabled');
         checkbox.attr('disabled', 'disabled');
-
         $.ajax({
           url: form.attr('action'),
           dataType: 'json',
@@ -204,11 +199,10 @@ Blacklight.onLoad(function () {
             }
           }
         });
-
         return false;
       }); //checkbox.click
-
     }); //this.each
+
     return this;
   };
 
@@ -219,8 +213,10 @@ Blacklight.onLoad(function () {
       alert("Error");
     },
     success: function () {} //callback
+
   };
 })(jQuery);
+
 (function ($) {
   Blacklight.onLoad(function () {
     // when clicking on a link that toggles the collapsing behavior, don't do anything
@@ -232,6 +228,7 @@ Blacklight.onLoad(function () {
 })(jQuery);
 /*global Blacklight */
 
+
 (function ($) {
   'use strict';
 
@@ -327,37 +324,33 @@ Blacklight.onLoad(function () {
 
   The data-blacklight-modal=close behavior is implemented with this event, see for example.
 */
-
 // We keep all our data in Blacklight.modal object.
 // Create lazily if someone else created first.
+
+
 if (Blacklight.modal === undefined) {
   Blacklight.modal = {};
-}
+} // a Bootstrap modal div that should be already on the page hidden
 
-// a Bootstrap modal div that should be already on the page hidden
-Blacklight.modal.modalSelector = '#blacklight-modal';
 
-// Trigger selectors identify forms or hyperlinks that should open
+Blacklight.modal.modalSelector = '#blacklight-modal'; // Trigger selectors identify forms or hyperlinks that should open
 // inside a modal dialog.
-Blacklight.modal.triggerLinkSelector = 'a[data-blacklight-modal~=trigger]';
-Blacklight.modal.triggerFormSelector = 'form[data-blacklight-modal~=trigger]';
 
-// preserve selectors identify forms or hyperlinks that, if activated already
+Blacklight.modal.triggerLinkSelector = 'a[data-blacklight-modal~=trigger]';
+Blacklight.modal.triggerFormSelector = 'form[data-blacklight-modal~=trigger]'; // preserve selectors identify forms or hyperlinks that, if activated already
 // inside a modal dialog, should have destinations remain inside the modal -- but
 // won't trigger a modal if not already in one.
 //
 // No need to repeat selectors from trigger selectors, those will already
 // be preserved. MUST be manually prefixed with the modal selector,
 // so they only apply to things inside a modal.
-Blacklight.modal.preserveLinkSelector = Blacklight.modal.modalSelector + ' a[data-blacklight-modal~=preserve]';
 
+Blacklight.modal.preserveLinkSelector = Blacklight.modal.modalSelector + ' a[data-blacklight-modal~=preserve]';
 Blacklight.modal.containerSelector = '[data-blacklight-modal~=container]';
-
-Blacklight.modal.modalCloseSelector = '[data-blacklight-modal~=close]';
-
-// Called on fatal failure of ajax load, function returns content
+Blacklight.modal.modalCloseSelector = '[data-blacklight-modal~=close]'; // Called on fatal failure of ajax load, function returns content
 // to show to user in modal.  Right now called only for extreme
 // network errors.
+
 Blacklight.modal.onFailure = function (data) {
   var contents = '<div class="modal-header">' + '<div class="modal-title">Network Error</div>' + '<button type="button" class="blacklight-modal-close close" data-dismiss="modal" aria-label="Close">' + '  <span aria-hidden="true">&times;</span>' + '</button>';
   $(Blacklight.modal.modalSelector).find('.modal-content').html(contents);
@@ -369,24 +362,22 @@ Blacklight.modal.receiveAjax = function (contents) {
   // important we don't execute script tags, we shouldn't.
   // code modelled off of JQuery ajax.load. https://github.com/jquery/jquery/blob/master/src/ajax/load.js?source=c#L62
   var container = $('<div>').append(jQuery.parseHTML(contents)).find(Blacklight.modal.containerSelector).first();
+
   if (container.length !== 0) {
     contents = container.html();
   }
 
-  $(Blacklight.modal.modalSelector).find('.modal-content').html(contents);
+  $(Blacklight.modal.modalSelector).find('.modal-content').html(contents); // send custom event with the modal dialog div as the target
 
-  // send custom event with the modal dialog div as the target
   var e = $.Event('loaded.blacklight.blacklight-modal');
-  $(Blacklight.modal.modalSelector).trigger(e);
-  // if they did preventDefault, don't show the dialog
-  if (e.isDefaultPrevented()) return;
+  $(Blacklight.modal.modalSelector).trigger(e); // if they did preventDefault, don't show the dialog
 
+  if (e.isDefaultPrevented()) return;
   $(Blacklight.modal.modalSelector).modal('show');
 };
 
 Blacklight.modal.modalAjaxLinkClick = function (e) {
   e.preventDefault();
-
   $.ajax({
     url: $(this).attr('href')
   }).fail(Blacklight.modal.onFailure).done(Blacklight.modal.receiveAjax);
@@ -394,11 +385,11 @@ Blacklight.modal.modalAjaxLinkClick = function (e) {
 
 Blacklight.modal.modalAjaxFormSubmit = function (e) {
   e.preventDefault();
-
   $.ajax({
     url: $(this).attr('action'),
     data: $(this).serialize(),
     type: $(this).attr('method') // POST
+
   }).fail(Blacklight.modal.onFailure).done(Blacklight.modal.receiveAjax);
 };
 
@@ -408,34 +399,29 @@ Blacklight.modal.setupModal = function () {
   // setup.
   var e = $.Event('setup.blacklight.blacklight-modal');
   $('body').trigger(e);
-  if (e.isDefaultPrevented()) return;
-
-  // Register both trigger and preserve selectors in ONE event handler, combining
+  if (e.isDefaultPrevented()) return; // Register both trigger and preserve selectors in ONE event handler, combining
   // into one selector with a comma, so if something matches BOTH selectors, it
   // still only gets the event handler called once.
-  $('body').on('click', Blacklight.modal.triggerLinkSelector + ', ' + Blacklight.modal.preserveLinkSelector, Blacklight.modal.modalAjaxLinkClick);
-  $('body').on('submit', Blacklight.modal.triggerFormSelector + ', ' + Blacklight.modal.preserveFormSelector, Blacklight.modal.modalAjaxFormSubmit);
 
-  // Catch our own custom loaded event to implement data-blacklight-modal=closed
-  $('body').on('loaded.blacklight.blacklight-modal', Blacklight.modal.checkCloseModal);
+  $('body').on('click', Blacklight.modal.triggerLinkSelector + ', ' + Blacklight.modal.preserveLinkSelector, Blacklight.modal.modalAjaxLinkClick);
+  $('body').on('submit', Blacklight.modal.triggerFormSelector + ', ' + Blacklight.modal.preserveFormSelector, Blacklight.modal.modalAjaxFormSubmit); // Catch our own custom loaded event to implement data-blacklight-modal=closed
 
-  // we support doing data-dismiss=modal on a <a> with a href for non-ajax
+  $('body').on('loaded.blacklight.blacklight-modal', Blacklight.modal.checkCloseModal); // we support doing data-dismiss=modal on a <a> with a href for non-ajax
   // use, we need to suppress following the a's href that's there for
   // non-JS contexts.
+
   $('body').on('click', Blacklight.modal.modalSelector + ' a[data-dismiss~=modal]', function (e) {
     e.preventDefault();
   });
-};
-
-// A function used as an event handler on loaded.blacklight.blacklight-modal
+}; // A function used as an event handler on loaded.blacklight.blacklight-modal
 // to catch contained data-blacklight-modal=closed directions
+
+
 Blacklight.modal.checkCloseModal = function (event) {
   if ($(event.target).find(Blacklight.modal.modalCloseSelector).length) {
     var modalFlashes = $(this).find('.flash_messages');
-
     $(event.target).modal('hide');
     event.preventDefault();
-
     var mainFlashes = $('#main-flashes');
     mainFlashes.append(modalFlashes);
     modalFlashes.fadeIn(500);
@@ -445,25 +431,27 @@ Blacklight.modal.checkCloseModal = function (event) {
 Blacklight.onLoad(function () {
   Blacklight.modal.setupModal();
 });
+
 (function ($) {
   Blacklight.doSearchContextBehavior = function () {
     if (typeof Blacklight.do_search_context_behavior == 'function') {
       console.warn("do_search_context_behavior is deprecated. Use doSearchContextBehavior instead.");
       return Blacklight.do_search_context_behavior();
     }
-    $('a[data-context-href]').on('click.search-context', Blacklight.handleSearchContextMethod);
-  };
 
-  // this is the $.rails.handleMethod with a couple adjustments, described inline:
+    $('a[data-context-href]').on('click.search-context', Blacklight.handleSearchContextMethod);
+  }; // this is the $.rails.handleMethod with a couple adjustments, described inline:
   // first, we're attaching this directly to the event handler, so we can check for meta-keys
+
+
   Blacklight.handleSearchContextMethod = function (event) {
     if (typeof Blacklight.handle_search_context_method == 'function') {
       console.warn("handle_search_context_method is deprecated. Use handleSearchContextMethod instead.");
       return Blacklight.handle_search_context_method(event);
     }
-    var link = $(this);
 
-    // instead of using the normal href, we need to use the context href instead
+    var link = $(this); // instead of using the normal href, we need to use the context href instead
+
     var href = link.data('context-href'),
         method = 'post',
         target = link.attr('target'),
@@ -471,9 +459,8 @@ Blacklight.onLoad(function () {
         csrfParam = $('meta[name=csrf-param]').attr('content'),
         form = $('<form method="post" action="' + href + '"></form>'),
         metadataInput = '<input name="_method" value="' + method + '" type="hidden" />',
-        redirectHref = '<input name="redirect" value="' + link.attr('href') + '" type="hidden" />';
+        redirectHref = '<input name="redirect" value="' + link.attr('href') + '" type="hidden" />'; // check for meta keys.. if set, we should open in a new tab
 
-    // check for meta keys.. if set, we should open in a new tab
     if (event.metaKey || event.ctrlKey) {
       target = '_blank';
     }
@@ -488,7 +475,6 @@ Blacklight.onLoad(function () {
 
     form.hide().append(metadataInput).append(redirectHref).appendTo('body');
     form.submit();
-
     return false;
   };