blacklight 7.0.0.rc1 → 7.0.0.rc2

Sign up to get free protection for your applications and to get access to all the features.
Files changed (259) hide show
  1. checksums.yaml +5 -5
  2. data/.rubocop.yml +30 -18
  3. data/.rubocop_todo.yml +308 -67
  4. data/.solr_wrapper.yml +8 -1
  5. data/.travis.yml +15 -13
  6. data/Gemfile +2 -0
  7. data/README.md +2 -2
  8. data/Rakefile +2 -0
  9. data/VERSION +1 -1
  10. data/Vagrantfile +2 -0
  11. data/app/assets/javascripts/blacklight/blacklight.js +17 -17
  12. data/app/assets/stylesheets/blacklight/_blacklight_base.scss +17 -16
  13. data/app/assets/stylesheets/blacklight/_facets.scss +2 -13
  14. data/app/assets/stylesheets/blacklight/_icons.scss +8 -2
  15. data/app/assets/stylesheets/blacklight/_search_form.scss +7 -0
  16. data/app/assets/stylesheets/blacklight/blacklight.scss +1 -1
  17. data/app/builders/blacklight/action_builder.rb +1 -0
  18. data/app/controllers/concerns/blacklight/bookmarks.rb +19 -13
  19. data/app/controllers/concerns/blacklight/catalog.rb +19 -7
  20. data/app/controllers/concerns/blacklight/controller.rb +12 -18
  21. data/app/controllers/concerns/blacklight/facet.rb +3 -0
  22. data/app/controllers/concerns/blacklight/search_context.rb +7 -3
  23. data/app/controllers/concerns/blacklight/search_history.rb +1 -6
  24. data/app/controllers/concerns/blacklight/token_based_user.rb +3 -1
  25. data/app/helpers/blacklight/blacklight_helper_behavior.rb +5 -1
  26. data/app/helpers/blacklight/configuration_helper_behavior.rb +5 -3
  27. data/app/helpers/blacklight/facets_helper_behavior.rb +15 -12
  28. data/app/helpers/blacklight/icon_helper_behavior.rb +2 -0
  29. data/app/helpers/blacklight/render_constraints_helper_behavior.rb +2 -0
  30. data/app/helpers/blacklight/render_partials_helper_behavior.rb +2 -2
  31. data/app/helpers/blacklight/search_history_constraints_helper_behavior.rb +1 -0
  32. data/app/helpers/blacklight/url_helper_behavior.rb +29 -14
  33. data/app/javascript/blacklight/checkbox_submit.js +9 -8
  34. data/app/javascript/blacklight/core.js +8 -6
  35. data/app/javascript/blacklight/modal.js +1 -3
  36. data/app/javascript/blacklight/search_context.js +0 -1
  37. data/app/models/blacklight/icon.rb +3 -0
  38. data/app/models/blacklight/suggest_search.rb +3 -14
  39. data/app/models/bookmark.rb +1 -1
  40. data/app/models/concerns/blacklight/document.rb +3 -1
  41. data/app/models/concerns/blacklight/solr/document.rb +1 -0
  42. data/app/models/concerns/blacklight/suggest/response.rb +5 -3
  43. data/app/models/concerns/blacklight/user.rb +1 -0
  44. data/app/models/search.rb +1 -0
  45. data/app/presenters/blacklight/document_presenter.rb +38 -0
  46. data/app/presenters/blacklight/field_presenter.rb +2 -0
  47. data/app/presenters/blacklight/index_presenter.rb +13 -5
  48. data/app/presenters/blacklight/json_presenter.rb +5 -12
  49. data/app/presenters/blacklight/link_alternate_presenter.rb +2 -0
  50. data/app/presenters/blacklight/rendering/abstract_step.rb +2 -0
  51. data/app/presenters/blacklight/rendering/helper_method.rb +2 -0
  52. data/app/presenters/blacklight/rendering/join.rb +2 -0
  53. data/app/presenters/blacklight/rendering/link_to_facet.rb +4 -0
  54. data/app/presenters/blacklight/rendering/microdata.rb +3 -0
  55. data/app/presenters/blacklight/rendering/pipeline.rb +2 -0
  56. data/app/presenters/blacklight/rendering/terminator.rb +2 -0
  57. data/app/presenters/blacklight/search_bar_presenter.rb +2 -0
  58. data/app/presenters/blacklight/show_presenter.rb +8 -5
  59. data/app/presenters/blacklight/thumbnail_presenter.rb +2 -0
  60. data/app/services/blacklight/document_factory.rb +2 -0
  61. data/app/services/blacklight/field_retriever.rb +2 -0
  62. data/app/services/blacklight/search_service.rb +7 -9
  63. data/app/values/blacklight/types.rb +3 -0
  64. data/app/views/bookmarks/index.html.erb +12 -13
  65. data/app/views/catalog/_citation.html.erb +4 -4
  66. data/app/views/catalog/_constraints.html.erb +2 -0
  67. data/app/views/catalog/_did_you_mean.html.erb +1 -1
  68. data/app/views/catalog/_document.atom.builder +17 -16
  69. data/app/views/catalog/_document.rss.builder +2 -0
  70. data/app/views/catalog/_facet_index_navigation.html.erb +5 -4
  71. data/app/views/catalog/_facet_layout.html.erb +3 -5
  72. data/app/views/catalog/_facets.html.erb +5 -4
  73. data/app/views/catalog/_field.json.jbuilder +10 -0
  74. data/app/views/catalog/_group.html.erb +1 -1
  75. data/app/views/catalog/_home_text.html.erb +5 -5
  76. data/app/views/catalog/_index.html.erb +5 -7
  77. data/app/views/catalog/_index_header.html.erb +1 -1
  78. data/app/views/catalog/_per_page_widget.html.erb +1 -1
  79. data/app/views/catalog/_results_pagination.html.erb +2 -2
  80. data/app/views/catalog/_search_form.html.erb +1 -1
  81. data/app/views/catalog/_search_results.html.erb +2 -2
  82. data/app/views/catalog/_show.html.erb +3 -5
  83. data/app/views/catalog/_show_more_like_this.html.erb +1 -1
  84. data/app/views/catalog/_show_sidebar.html.erb +1 -1
  85. data/app/views/catalog/_show_tools.html.erb +1 -1
  86. data/app/views/catalog/_sort_widget.html.erb +1 -1
  87. data/app/views/catalog/_zero_results.html.erb +1 -1
  88. data/app/views/catalog/citation.js.erb +1 -1
  89. data/app/views/catalog/facet.html.erb +5 -4
  90. data/app/views/catalog/facet.json.jbuilder +2 -0
  91. data/app/views/catalog/index.atom.builder +4 -2
  92. data/app/views/catalog/index.json.jbuilder +29 -10
  93. data/app/views/catalog/index.rss.builder +2 -0
  94. data/app/views/catalog/opensearch.xml.builder +3 -1
  95. data/app/views/catalog/show.json.jbuilder +21 -0
  96. data/app/views/kaminari/blacklight/_first_page.html.erb +1 -1
  97. data/app/views/kaminari/blacklight/_last_page.html.erb +1 -1
  98. data/app/views/kaminari/blacklight/_next_page.html.erb +3 -3
  99. data/app/views/kaminari/blacklight/_page.html.erb +4 -2
  100. data/app/views/kaminari/blacklight/_prev_page.html.erb +2 -2
  101. data/app/views/layouts/blacklight.html.erb +4 -4
  102. data/app/views/layouts/blacklight/base.html.erb +1 -9
  103. data/app/views/search_history/index.html.erb +3 -3
  104. data/app/views/shared/_header_navbar.html.erb +1 -1
  105. data/app/views/shared/_modal.html.erb +2 -2
  106. data/blacklight.gemspec +7 -6
  107. data/config/i18n-tasks.yml +17 -0
  108. data/config/locales/blacklight.de.yml +72 -57
  109. data/config/locales/blacklight.en.yml +11 -1
  110. data/config/locales/blacklight.es.yml +15 -1
  111. data/config/locales/blacklight.fr.yml +17 -8
  112. data/config/locales/blacklight.hu.yml +3 -1
  113. data/config/locales/blacklight.it.yml +16 -1
  114. data/config/locales/blacklight.nl.yml +3 -1
  115. data/config/locales/blacklight.pt-BR.yml +19 -2
  116. data/config/locales/blacklight.sq.yml +3 -1
  117. data/config/locales/blacklight.zh.yml +3 -1
  118. data/config/routes.rb +0 -1
  119. data/lib/blacklight.rb +3 -0
  120. data/lib/blacklight/abstract_repository.rb +12 -0
  121. data/lib/blacklight/configuration.rb +21 -3
  122. data/lib/blacklight/configuration/context.rb +11 -0
  123. data/lib/blacklight/configuration/fields.rb +31 -26
  124. data/lib/blacklight/configuration/null_field.rb +2 -0
  125. data/lib/blacklight/engine.rb +4 -1
  126. data/lib/blacklight/routes/exportable.rb +1 -3
  127. data/lib/blacklight/routes/searchable.rb +2 -3
  128. data/lib/blacklight/runtime_registry.rb +2 -0
  129. data/lib/blacklight/search_builder.rb +2 -0
  130. data/lib/blacklight/search_state.rb +2 -0
  131. data/lib/blacklight/solr/repository.rb +34 -0
  132. data/lib/blacklight/solr/response/spelling.rb +1 -0
  133. data/lib/generators/blacklight/assets_generator.rb +10 -9
  134. data/lib/generators/blacklight/controller_generator.rb +1 -1
  135. data/lib/generators/blacklight/install_generator.rb +7 -14
  136. data/lib/generators/blacklight/solr_generator.rb +8 -0
  137. data/lib/generators/blacklight/templates/alternate_controller.rb +4 -4
  138. data/lib/generators/blacklight/templates/catalog_controller.rb +7 -1
  139. data/lib/generators/blacklight/templates/solr/conf/schema.xml +20 -22
  140. data/lib/generators/blacklight/user_generator.rb +2 -0
  141. data/lib/railties/blacklight.rake +9 -13
  142. data/package-lock.json +544 -406
  143. data/package.json +3 -2
  144. data/spec/controllers/alternate_controller_spec.rb +4 -3
  145. data/spec/controllers/application_controller_spec.rb +0 -4
  146. data/spec/controllers/blacklight/base_spec.rb +5 -2
  147. data/spec/controllers/blacklight/catalog/component_configuration_spec.rb +4 -4
  148. data/spec/controllers/blacklight/facet_spec.rb +0 -1
  149. data/spec/controllers/blacklight/search_fields_spec.rb +25 -22
  150. data/spec/controllers/bookmarks_controller_spec.rb +45 -10
  151. data/spec/controllers/catalog_controller_spec.rb +206 -138
  152. data/spec/controllers/search_history_controller_spec.rb +4 -4
  153. data/spec/features/alternate_controller_spec.rb +3 -3
  154. data/spec/features/autocomplete_spec.rb +2 -0
  155. data/spec/features/did_you_mean_spec.rb +4 -3
  156. data/spec/features/facets_spec.rb +7 -7
  157. data/spec/features/record_view_spec.rb +11 -12
  158. data/spec/features/search_context_spec.rb +4 -5
  159. data/spec/features/search_crawler_spec.rb +3 -5
  160. data/spec/features/search_filters_spec.rb +44 -44
  161. data/spec/features/search_history_spec.rb +5 -3
  162. data/spec/features/search_pagination_spec.rb +3 -1
  163. data/spec/features/search_results_spec.rb +11 -8
  164. data/spec/features/search_spec.rb +3 -3
  165. data/spec/features/sitelinks_search_box.rb +4 -4
  166. data/spec/helpers/blacklight/configuration_helper_behavior_spec.rb +30 -30
  167. data/spec/helpers/blacklight/facets_helper_behavior_spec.rb +65 -59
  168. data/spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb +1 -1
  169. data/spec/helpers/blacklight/icon_helper_behavior_spec.rb +2 -0
  170. data/spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb +8 -3
  171. data/spec/helpers/blacklight/render_partials_helper_behavior_spec.rb +16 -4
  172. data/spec/helpers/blacklight/search_history_constraints_helper_behavior_spec.rb +21 -22
  173. data/spec/helpers/blacklight/suggest_helper_behavior_spec.rb +6 -1
  174. data/spec/helpers/blacklight/url_helper_behavior_spec.rb +49 -43
  175. data/spec/helpers/blacklight_helper_spec.rb +28 -12
  176. data/spec/helpers/catalog_helper_spec.rb +50 -47
  177. data/spec/i18n_spec.rb +18 -0
  178. data/spec/integration/generators/blacklight/solr_generator_spec.rb +18 -10
  179. data/spec/lib/blacklight/configuration/facet_field_spec.rb +2 -0
  180. data/spec/lib/blacklight/configuration/field_spec.rb +3 -0
  181. data/spec/lib/blacklight/open_struct_with_hash_access_spec.rb +15 -20
  182. data/spec/lib/blacklight/parameters_spec.rb +3 -1
  183. data/spec/lib/blacklight/search_state_spec.rb +51 -34
  184. data/spec/lib/blacklight_spec.rb +13 -14
  185. data/spec/lib/tasks/blacklight_task_spec.rb +3 -5
  186. data/spec/models/blacklight/configurable_spec.rb +11 -13
  187. data/spec/models/blacklight/configuration/context_spec.rb +9 -10
  188. data/spec/models/blacklight/configuration_spec.rb +103 -91
  189. data/spec/models/blacklight/document/active_model_shim_spec.rb +5 -6
  190. data/spec/models/blacklight/document/cache_key_spec.rb +9 -2
  191. data/spec/models/blacklight/document/dublin_core_spec.rb +16 -19
  192. data/spec/models/blacklight/document/email_spec.rb +9 -9
  193. data/spec/models/blacklight/document/sms_spec.rb +9 -9
  194. data/spec/models/blacklight/document_spec.rb +9 -8
  195. data/spec/models/blacklight/facet_paginator_spec.rb +40 -30
  196. data/spec/models/blacklight/icon_spec.rb +12 -2
  197. data/spec/models/blacklight/search_builder_spec.rb +12 -3
  198. data/spec/models/blacklight/solr/document_spec.rb +216 -219
  199. data/spec/models/blacklight/solr/facet_paginator_spec.rb +6 -4
  200. data/spec/models/blacklight/solr/repository_spec.rb +37 -34
  201. data/spec/models/blacklight/solr/request_spec.rb +17 -18
  202. data/spec/models/blacklight/solr/response/facets_spec.rb +58 -58
  203. data/spec/models/blacklight/solr/response/group_response_spec.rb +16 -22
  204. data/spec/models/blacklight/solr/response/group_spec.rb +18 -25
  205. data/spec/models/blacklight/solr/response_spec.rb +48 -50
  206. data/spec/models/blacklight/solr/search_builder_spec.rb +120 -121
  207. data/spec/models/blacklight/suggest/response_spec.rb +6 -4
  208. data/spec/models/blacklight/suggest_search_spec.rb +9 -16
  209. data/spec/models/blacklight/user_spec.rb +9 -11
  210. data/spec/models/bookmark_spec.rb +6 -5
  211. data/spec/models/record_mailer_spec.rb +22 -20
  212. data/spec/models/search_spec.rb +18 -17
  213. data/spec/models/solr_document_spec.rb +6 -2
  214. data/spec/presenters/blacklight/document_presenter_spec.rb +86 -0
  215. data/spec/presenters/blacklight/index_presenter_spec.rb +186 -0
  216. data/spec/presenters/blacklight/json_presenter_spec.rb +59 -0
  217. data/spec/presenters/blacklight/link_alternate_presenter_spec.rb +3 -0
  218. data/spec/presenters/blacklight/search_bar_presenter_spec.rb +7 -0
  219. data/spec/presenters/{show_presenter_spec.rb → blacklight/show_presenter_spec.rb} +138 -91
  220. data/spec/presenters/pipeline_spec.rb +15 -8
  221. data/spec/presenters/thumbnail_presenter_spec.rb +5 -2
  222. data/spec/routing/catalog_routing_spec.rb +12 -14
  223. data/spec/services/blacklight/search_service_spec.rb +112 -70
  224. data/spec/spec_helper.rb +6 -2
  225. data/spec/support/features.rb +1 -1
  226. data/spec/support/features/session_helpers.rb +4 -4
  227. data/spec/test_app_templates/lib/generators/test_app_generator.rb +12 -13
  228. data/spec/views/catalog/_constraints.html.erb_spec.rb +2 -3
  229. data/spec/views/catalog/_constraints_element.html.erb_spec.rb +9 -5
  230. data/spec/views/catalog/_document.html.erb_spec.rb +4 -4
  231. data/spec/views/catalog/_document_list.html.erb_spec.rb +1 -0
  232. data/spec/views/catalog/_facet_index_navigation.html.erb_spec.rb +4 -4
  233. data/spec/views/catalog/_facet_layout.html.erb_spec.rb +3 -3
  234. data/spec/views/catalog/_facets.html.erb_spec.rb +8 -10
  235. data/spec/views/catalog/_index.html.erb_spec.rb +13 -14
  236. data/spec/views/catalog/_index_header.html.erb_spec.rb +5 -8
  237. data/spec/views/catalog/_paginate_compact.html.erb_spec.rb +3 -3
  238. data/spec/views/catalog/_show.html.erb_spec.rb +12 -13
  239. data/spec/views/catalog/_show_sidebar.erb_spec.rb +4 -7
  240. data/spec/views/catalog/_show_tools.html.erb_spec.rb +2 -2
  241. data/spec/views/catalog/_sort_and_per_page.html.erb_spec.rb +0 -1
  242. data/spec/views/catalog/_sort_widget.html.erb_spec.rb +3 -1
  243. data/spec/views/catalog/_thumbnail.html.erb_spec.rb +6 -8
  244. data/spec/views/catalog/_view_type_group.html.erb_spec.rb +7 -9
  245. data/spec/views/catalog/email_success.html.erb_spec.rb +0 -1
  246. data/spec/views/catalog/facet.html.erb_spec.rb +3 -2
  247. data/spec/views/catalog/facet.json.jbuilder_spec.rb +3 -2
  248. data/spec/views/catalog/index.atom.builder_spec.rb +9 -4
  249. data/spec/views/catalog/index.html.erb_spec.rb +2 -1
  250. data/spec/views/catalog/index.json.jbuilder_spec.rb +84 -36
  251. data/spec/views/catalog/show.html.erb_spec.rb +6 -6
  252. data/spec/views/catalog/show.json.jbuilder_spec.rb +40 -0
  253. data/spec/views/catalog/sms_success.html.erb_spec.rb +0 -1
  254. data/spec/views/shared/_user_util_links.html.erb_spec.rb +1 -4
  255. data/tasks/blacklight.rake +6 -4
  256. data/template.demo.rb +2 -0
  257. metadata +50 -24
  258. data/app/javascript/blacklight/autofocus.js +0 -20
  259. data/spec/presenters/index_presenter_spec.rb +0 -150
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
- SHA256:
3
- metadata.gz: 01a2639c62ba9f670604f54a906e793a9a183149e572d46e613507553468211c
4
- data.tar.gz: f87ddb57e26cce7061ee95de773dc1d25b88afbf03d6f299ce2cb869224d94d8
2
+ SHA1:
3
+ metadata.gz: af6ab55f42cc41f6276e9f38879cbf1fd38b65b0
4
+ data.tar.gz: efc61fef740d8f3d9ffb6b596774da2ea2ac098b
5
5
  SHA512:
6
- metadata.gz: c5197a4917e13eb8026577584b0908115a5aed7a4b2cd800018256830fe7ca2956a3585a7dd1bed9781d29c3278a85156de3ee84c6602d260b5e98530bf82317
7
- data.tar.gz: 7a362f1d8c0d630d24211cfed184b6574876450d6af2bde8fee02c9f1d55954a186946773d7f96b8a31badc54dca2dd1b4bbb9aa1f127f80749971b4f8d3b896
6
+ metadata.gz: 772b8ee7ea1007184eff3498b3259f3e56edc624f4f1d769baa1f7218e81e70edb99adddd686b5392836168119f9f499b974a6b562a898ef6ce804c1d202bf4f
7
+ data.tar.gz: e26443f4779c02b83fb90989b828f15052ef853eb2809a0a6ac9a93a45858d7bbeffb81fd5f89e88539a743cf8113f85787dd783f649c478a9e5730c0161bd8b
@@ -5,18 +5,30 @@ inherit_from:
5
5
 
6
6
  AllCops:
7
7
  DisplayCopNames: true
8
+ TargetRubyVersion: 2.3
8
9
  Exclude:
9
10
  - "lib/generators/blacklight/templates/**/*"
10
- - "spec/**/*"
11
11
  - "blacklight.gemspec"
12
12
 
13
- Rails:
14
- Enabled: true
13
+ # engine_cart block includes conditional, not duplication
14
+ Bundler/DuplicatedGem:
15
+ Exclude:
16
+ - 'Gemfile'
17
+
18
+ # engine_cart block is following default Rails order
19
+ Bundler/OrderedGems:
20
+ Exclude:
21
+ - 'Gemfile'
22
+
23
+ Layout/IndentationConsistency:
24
+ EnforcedStyle: normal
15
25
 
16
26
  Metrics/BlockLength:
17
27
  Exclude:
28
+ - "app/views/catalog/index.json.jbuilder"
18
29
  - "lib/railties/blacklight.rake"
19
30
  - "tasks/blacklight.rake"
31
+ - "spec/**/*"
20
32
 
21
33
  Metrics/ClassLength:
22
34
  Exclude:
@@ -24,29 +36,29 @@ Metrics/ClassLength:
24
36
 
25
37
  Metrics/LineLength:
26
38
  Max: 200
39
+ Exclude:
40
+ - 'spec/**/*'
27
41
 
28
- Style/StringLiterals:
42
+ Naming/HeredocDelimiterNaming:
29
43
  Enabled: false
30
44
 
31
- Layout/IndentationConsistency:
32
- EnforcedStyle: normal
45
+ Naming/PredicateName:
46
+ NamePrefixBlacklist:
47
+ - is_
48
+
49
+ Rails:
50
+ Enabled: true
33
51
 
34
52
  Rails/OutputSafety:
35
53
  Enabled: false
36
54
 
37
- Style/MethodMissing:
38
- Exclude:
39
- - 'lib/blacklight/nested_open_struct_with_hash_access.rb'
40
-
41
- # engine_cart block includes conditional, not duplication
42
- Bundler/DuplicatedGem:
43
- Exclude:
44
- - 'Gemfile'
55
+ # https://github.com/rubocop-hq/rubocop/issues/6439
56
+ Style/AccessModifierDeclarations:
57
+ Enabled: false
45
58
 
46
- # engine_cart block is following default Rails order
47
- Bundler/OrderedGems:
59
+ Style/MissingRespondToMissing:
48
60
  Exclude:
49
- - 'Gemfile'
61
+ - 'lib/blacklight/nested_open_struct_with_hash_access.rb'
50
62
 
51
- Naming/HeredocDelimiterNaming:
63
+ Style/StringLiterals:
52
64
  Enabled: false
@@ -1,11 +1,16 @@
1
1
  # This configuration was generated by
2
2
  # `rubocop --auto-gen-config`
3
- # on 2018-03-28 15:21:19 -0700 using RuboCop version 0.54.0.
3
+ # on 2018-10-31 21:34:01 -0500 using RuboCop version 0.60.0.
4
4
  # The point is for the user to remove these configuration records
5
5
  # one by one as the offenses are removed from the code base.
6
6
  # Note that changes in the inspected code, or installation of new
7
7
  # versions of RuboCop, may require this file to be generated again.
8
8
 
9
+ # Offense count: 4
10
+ Capybara/CurrentPathExpectation:
11
+ Exclude:
12
+ - 'spec/features/alternate_controller_spec.rb'
13
+
9
14
  # Offense count: 2
10
15
  # Cop supports --auto-correct.
11
16
  # Configuration parameters: EnforcedStyle, IndentationWidth.
@@ -30,7 +35,7 @@ Layout/ClosingParenthesisIndentation:
30
35
  Exclude:
31
36
  - 'app/views/catalog/index.atom.builder'
32
37
 
33
- # Offense count: 95
38
+ # Offense count: 108
34
39
  # Cop supports --auto-correct.
35
40
  Layout/EmptyLineAfterMagicComment:
36
41
  Enabled: false
@@ -105,13 +110,6 @@ Layout/SpaceAfterComma:
105
110
  - 'app/views/catalog/index.atom.builder'
106
111
  - 'app/views/catalog/opensearch.xml.builder'
107
112
 
108
- # Offense count: 1
109
- # Cop supports --auto-correct.
110
- # Configuration parameters: AllowForAlignment.
111
- Layout/SpaceAroundOperators:
112
- Exclude:
113
- - 'app/views/catalog/index.atom.builder'
114
-
115
113
  # Offense count: 1
116
114
  # Cop supports --auto-correct.
117
115
  # Configuration parameters: AllowForAlignment.
@@ -121,6 +119,8 @@ Layout/SpaceBeforeFirstArg:
121
119
 
122
120
  # Offense count: 7
123
121
  # Cop supports --auto-correct.
122
+ # Configuration parameters: EnforcedStyle.
123
+ # SupportedStyles: space, no_space
124
124
  Layout/SpaceInsideParens:
125
125
  Exclude:
126
126
  - 'app/views/catalog/_document.rss.builder'
@@ -128,6 +128,7 @@ Layout/SpaceInsideParens:
128
128
 
129
129
  # Offense count: 27
130
130
  # Cop supports --auto-correct.
131
+ # Configuration parameters: AllowInHeredoc.
131
132
  Layout/TrailingWhitespace:
132
133
  Exclude:
133
134
  - 'app/views/catalog/_document.atom.builder'
@@ -139,48 +140,86 @@ Lint/AmbiguousBlockAssociation:
139
140
  Exclude:
140
141
  - 'lib/blacklight/solr/search_builder_behavior.rb'
141
142
 
142
- # Offense count: 6
143
- Lint/UselessAssignment:
143
+ # Offense count: 8
144
+ Lint/AmbiguousOperator:
145
+ Exclude:
146
+ - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
147
+ - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
148
+ - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
149
+ - 'spec/helpers/blacklight_helper_spec.rb'
150
+ - 'spec/models/blacklight/facet_paginator_spec.rb'
151
+ - 'spec/models/blacklight/solr/search_builder_spec.rb'
152
+ - 'spec/services/blacklight/search_service_spec.rb'
153
+
154
+ # Offense count: 58
155
+ Lint/AmbiguousRegexpLiteral:
156
+ Exclude:
157
+ - 'spec/controllers/catalog_controller_spec.rb'
158
+ - 'spec/features/alternate_controller_spec.rb'
159
+ - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
160
+ - 'spec/helpers/catalog_helper_spec.rb'
161
+ - 'spec/models/record_mailer_spec.rb'
162
+ - 'spec/views/catalog/_document.html.erb_spec.rb'
163
+ - 'spec/views/catalog/_search_header.erb_spec.rb'
164
+ - 'spec/views/catalog/_sort_and_per_page.html.erb_spec.rb'
165
+ - 'spec/views/catalog/_thumbnail.html.erb_spec.rb'
166
+ - 'spec/views/catalog/index.html.erb_spec.rb'
167
+ - 'spec/views/catalog/show.html.erb_spec.rb'
168
+
169
+ # Offense count: 30
170
+ Lint/ParenthesesAsGroupedExpression:
171
+ Exclude:
172
+ - 'spec/controllers/catalog_controller_spec.rb'
173
+ - 'spec/features/did_you_mean_spec.rb'
174
+ - 'spec/features/search_filters_spec.rb'
175
+ - 'spec/features/search_pagination_spec.rb'
176
+ - 'spec/features/search_spec.rb'
177
+ - 'spec/lib/blacklight/search_state_spec.rb'
178
+ - 'spec/models/blacklight/solr/repository_spec.rb'
179
+
180
+ # Offense count: 2
181
+ Lint/ShadowingOuterLocalVariable:
144
182
  Exclude:
145
- - 'app/controllers/concerns/blacklight/search_context.rb'
146
- - 'app/helpers/blacklight/facets_helper_behavior.rb'
147
- - 'app/models/bookmark.rb'
148
- - 'lib/blacklight/routes/exportable.rb'
149
- - 'lib/blacklight/routes/searchable.rb'
150
- - 'lib/railties/blacklight.rake'
183
+ - 'spec/models/blacklight/configuration_spec.rb'
184
+
185
+ # Offense count: 1
186
+ Lint/UselessComparison:
187
+ Exclude:
188
+ - 'spec/models/blacklight/document/active_model_shim_spec.rb'
151
189
 
152
- # Offense count: 56
190
+ # Offense count: 57
153
191
  Metrics/AbcSize:
154
- Max: 53
192
+ Max: 49
155
193
 
156
- # Offense count: 3
194
+ # Offense count: 2
157
195
  # Configuration parameters: CountComments, ExcludedMethods.
196
+ # ExcludedMethods: refine
158
197
  Metrics/BlockLength:
159
- Max: 42
198
+ Max: 30
160
199
 
161
200
  # Offense count: 1
162
201
  # Configuration parameters: CountBlocks.
163
202
  Metrics/BlockNesting:
164
203
  Max: 4
165
204
 
166
- # Offense count: 3
205
+ # Offense count: 2
167
206
  # Configuration parameters: CountComments.
168
207
  Metrics/ClassLength:
169
- Max: 189
208
+ Max: 169
170
209
 
171
210
  # Offense count: 19
172
211
  Metrics/CyclomaticComplexity:
173
212
  Max: 12
174
213
 
175
- # Offense count: 44
176
- # Configuration parameters: CountComments.
214
+ # Offense count: 46
215
+ # Configuration parameters: CountComments, ExcludedMethods.
177
216
  Metrics/MethodLength:
178
- Max: 39
217
+ Max: 35
179
218
 
180
- # Offense count: 7
219
+ # Offense count: 8
181
220
  # Configuration parameters: CountComments.
182
221
  Metrics/ModuleLength:
183
- Max: 209
222
+ Max: 215
184
223
 
185
224
  # Offense count: 1
186
225
  # Configuration parameters: CountKeywordArgs.
@@ -192,6 +231,8 @@ Metrics/PerceivedComplexity:
192
231
  Max: 14
193
232
 
194
233
  # Offense count: 4
234
+ # Configuration parameters: EnforcedStyleForLeadingUnderscores.
235
+ # SupportedStylesForLeadingUnderscores: disallowed, required, optional
195
236
  Naming/MemoizedInstanceVariableName:
196
237
  Exclude:
197
238
  - 'app/helpers/blacklight/blacklight_helper_behavior.rb'
@@ -199,27 +240,9 @@ Naming/MemoizedInstanceVariableName:
199
240
  - 'app/models/concerns/blacklight/document/semantic_fields.rb'
200
241
  - 'lib/blacklight/solr/response.rb'
201
242
 
202
- # Offense count: 8
203
- # Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist, MethodDefinitionMacros.
204
- # NamePrefix: is_, has_, have_
205
- # NamePrefixBlacklist: is_, has_, have_
206
- # NameWhitelist: is_a?
207
- # MethodDefinitionMacros: define_method, define_singleton_method
208
- Naming/PredicateName:
209
- Exclude:
210
- - 'spec/**/*'
211
- - 'app/controllers/concerns/blacklight/catalog.rb'
212
- - 'app/controllers/concerns/blacklight/controller.rb'
213
- - 'app/helpers/blacklight/catalog_helper_behavior.rb'
214
- - 'app/helpers/blacklight/configuration_helper_behavior.rb'
215
- - 'app/helpers/blacklight/facets_helper_behavior.rb'
216
- - 'app/models/concerns/blacklight/document.rb'
217
- - 'app/models/concerns/blacklight/solr/document.rb'
218
- - 'lib/generators/blacklight/assets_generator.rb'
219
-
220
- # Offense count: 12
243
+ # Offense count: 14
221
244
  # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
222
- # AllowedNames: io, id, to
245
+ # AllowedNames: io, id, to, by, on, in, at, ip, db
223
246
  Naming/UncommunicativeMethodParamName:
224
247
  Exclude:
225
248
  - 'app/models/blacklight/facet_paginator.rb'
@@ -229,6 +252,161 @@ Naming/UncommunicativeMethodParamName:
229
252
  - 'lib/blacklight/nested_open_struct_with_hash_access.rb'
230
253
  - 'lib/blacklight/search_state.rb'
231
254
  - 'lib/blacklight/solr/search_builder_behavior.rb'
255
+ - 'spec/features/search_context_spec.rb'
256
+ - 'spec/features/search_results_spec.rb'
257
+
258
+ # Offense count: 15
259
+ # Configuration parameters: EnforcedStyle.
260
+ # SupportedStyles: snake_case, normalcase, non_integer
261
+ Naming/VariableNumber:
262
+ Exclude:
263
+ - 'spec/views/catalog/_facets.html.erb_spec.rb'
264
+ - 'spec/views/catalog/_index.html.erb_spec.rb'
265
+ - 'spec/views/catalog/_show.html.erb_spec.rb'
266
+
267
+ # Offense count: 1
268
+ # Cop supports --auto-correct.
269
+ # Configuration parameters: AutoCorrect.
270
+ Performance/TimesMap:
271
+ Exclude:
272
+ - 'spec/views/catalog/index.atom.builder_spec.rb'
273
+
274
+ # Offense count: 3
275
+ Performance/UnfreezeString:
276
+ Exclude:
277
+ - 'lib/generators/blacklight/install_generator.rb'
278
+ - 'spec/helpers/blacklight/url_helper_behavior_spec.rb'
279
+ - 'spec/helpers/blacklight_helper_spec.rb'
280
+
281
+ # Offense count: 9
282
+ RSpec/BeforeAfterAll:
283
+ Exclude:
284
+ - 'spec/spec_helper.rb'
285
+ - 'spec/rails_helper.rb'
286
+ - 'spec/support/**/*.rb'
287
+ - 'spec/controllers/blacklight/search_fields_spec.rb'
288
+ - 'spec/controllers/search_history_controller_spec.rb'
289
+ - 'spec/helpers/blacklight/search_history_constraints_helper_behavior_spec.rb'
290
+ - 'spec/models/blacklight/configurable_spec.rb'
291
+ - 'spec/models/blacklight/document/dublin_core_spec.rb'
292
+ - 'spec/models/blacklight/document/email_spec.rb'
293
+ - 'spec/models/blacklight/document/sms_spec.rb'
294
+ - 'spec/models/blacklight/solr/document_spec.rb'
295
+
296
+ # Offense count: 70
297
+ # Configuration parameters: Prefixes.
298
+ # Prefixes: when, with, without
299
+ RSpec/ContextWording:
300
+ Enabled: false
301
+
302
+ # Offense count: 54
303
+ RSpec/DescribeClass:
304
+ Enabled: false
305
+
306
+ # Offense count: 1
307
+ # Configuration parameters: CustomIncludeMethods.
308
+ RSpec/EmptyExampleGroup:
309
+ Exclude:
310
+ - 'spec/models/blacklight/solr/search_builder_spec.rb'
311
+
312
+ # Offense count: 126
313
+ # Configuration parameters: Max.
314
+ RSpec/ExampleLength:
315
+ Enabled: false
316
+
317
+ # Offense count: 15
318
+ RSpec/ExpectInHook:
319
+ Exclude:
320
+ - 'spec/controllers/catalog_controller_spec.rb'
321
+ - 'spec/helpers/blacklight/configuration_helper_behavior_spec.rb'
322
+ - 'spec/helpers/blacklight/render_constraints_helper_behavior_spec.rb'
323
+ - 'spec/helpers/blacklight/suggest_helper_behavior_spec.rb'
324
+ - 'spec/helpers/catalog_helper_spec.rb'
325
+
326
+ # Offense count: 5
327
+ # Configuration parameters: CustomTransform, IgnoreMethods.
328
+ RSpec/FilePath:
329
+ Exclude:
330
+ - 'spec/controllers/blacklight/catalog/component_configuration_spec.rb'
331
+ - 'spec/helpers/blacklight/hash_as_hidden_fields_behavior_spec.rb'
332
+ - 'spec/models/blacklight/solr/search_builder_spec.rb'
333
+ - 'spec/presenters/pipeline_spec.rb'
334
+ - 'spec/presenters/thumbnail_presenter_spec.rb'
335
+
336
+ # Offense count: 194
337
+ # Configuration parameters: AssignmentOnly.
338
+ RSpec/InstanceVariable:
339
+ Enabled: false
340
+
341
+ # Offense count: 4
342
+ RSpec/IteratedExpectation:
343
+ Exclude:
344
+ - 'spec/models/blacklight/solr/response/group_response_spec.rb'
345
+ - 'spec/models/blacklight/solr/response/group_spec.rb'
346
+ - 'spec/models/blacklight/solr/response_spec.rb'
347
+
348
+ # Offense count: 8
349
+ RSpec/MessageChain:
350
+ Exclude:
351
+ - 'spec/controllers/bookmarks_controller_spec.rb'
352
+ - 'spec/presenters/blacklight/show_presenter_spec.rb'
353
+ - 'spec/views/shared/_user_util_links.html.erb_spec.rb'
354
+
355
+ # Offense count: 62
356
+ # Configuration parameters: .
357
+ # SupportedStyles: have_received, receive
358
+ RSpec/MessageSpies:
359
+ Enabled: false
360
+
361
+ # Offense count: 339
362
+ # Configuration parameters: AggregateFailuresByDefault.
363
+ RSpec/MultipleExpectations:
364
+ Max: 16
365
+
366
+ # Offense count: 326
367
+ RSpec/NamedSubject:
368
+ Enabled: false
369
+
370
+ # Offense count: 40
371
+ RSpec/NestedGroups:
372
+ Max: 5
373
+
374
+ # Offense count: 8
375
+ RSpec/RepeatedDescription:
376
+ Exclude:
377
+ - 'spec/features/search_results_spec.rb'
378
+ - 'spec/helpers/blacklight/facets_helper_behavior_spec.rb'
379
+ - 'spec/helpers/catalog_helper_spec.rb'
380
+ - 'spec/models/blacklight/solr/search_builder_spec.rb'
381
+
382
+ # Offense count: 4
383
+ RSpec/RepeatedExample:
384
+ Exclude:
385
+ - 'spec/features/search_filters_spec.rb'
386
+ - 'spec/models/blacklight/solr/document_spec.rb'
387
+
388
+ # Offense count: 4
389
+ RSpec/ScatteredLet:
390
+ Exclude:
391
+ - 'spec/helpers/catalog_helper_spec.rb'
392
+ - 'spec/models/blacklight/solr/search_builder_spec.rb'
393
+ - 'spec/views/catalog/index.atom.builder_spec.rb'
394
+
395
+ # Offense count: 4
396
+ RSpec/SubjectStub:
397
+ Exclude:
398
+ - 'spec/lib/blacklight/search_state_spec.rb'
399
+ - 'spec/services/blacklight/search_service_spec.rb'
400
+
401
+ # Offense count: 117
402
+ # Configuration parameters: IgnoreNameless, IgnoreSymbolicNames.
403
+ RSpec/VerifiedDoubles:
404
+ Enabled: false
405
+
406
+ # Offense count: 1
407
+ RSpec/VoidExpect:
408
+ Exclude:
409
+ - 'spec/lib/blacklight/configuration/facet_field_spec.rb'
232
410
 
233
411
  # Offense count: 1
234
412
  # Cop supports --auto-correct.
@@ -237,6 +415,13 @@ Rails/Blank:
237
415
  Exclude:
238
416
  - 'lib/blacklight/solr/search_builder_behavior.rb'
239
417
 
418
+ # Offense count: 4
419
+ # Configuration parameters: EnforcedStyle.
420
+ # SupportedStyles: strict, flexible
421
+ Rails/Date:
422
+ Exclude:
423
+ - 'spec/models/search_spec.rb'
424
+
240
425
  # Offense count: 13
241
426
  # Cop supports --auto-correct.
242
427
  # Configuration parameters: NotNilAndNotEmpty, NotBlank, UnlessBlank.
@@ -249,6 +434,18 @@ Rails/Present:
249
434
  - 'app/models/concerns/blacklight/document/sms.rb'
250
435
  - 'lib/blacklight/solr/search_builder_behavior.rb'
251
436
 
437
+ # Offense count: 1
438
+ # Configuration parameters: EnforcedStyle.
439
+ # SupportedStyles: strict, flexible
440
+ Rails/TimeZone:
441
+ Exclude:
442
+ - 'spec/models/blacklight/solr/search_builder_spec.rb'
443
+
444
+ # Offense count: 13
445
+ Security/Eval:
446
+ Exclude:
447
+ - 'spec/models/blacklight/solr/response_spec.rb'
448
+
252
449
  # Offense count: 9
253
450
  # Cop supports --auto-correct.
254
451
  # Configuration parameters: EnforcedStyle.
@@ -291,6 +488,12 @@ Style/BracesAroundHashParameters:
291
488
  Style/ClassAndModuleChildren:
292
489
  Enabled: false
293
490
 
491
+ # Offense count: 6
492
+ Style/CommentedKeyword:
493
+ Exclude:
494
+ - 'spec/controllers/catalog_controller_spec.rb'
495
+ - 'spec/services/blacklight/search_service_spec.rb'
496
+
294
497
  # Offense count: 1
295
498
  # Cop supports --auto-correct.
296
499
  # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
@@ -299,7 +502,13 @@ Style/ConditionalAssignment:
299
502
  Exclude:
300
503
  - 'lib/blacklight/solr/response/spelling.rb'
301
504
 
302
- # Offense count: 91
505
+ # Offense count: 1
506
+ # Configuration parameters: AllowCoercion.
507
+ Style/DateTime:
508
+ Exclude:
509
+ - 'spec/models/blacklight/solr/search_builder_spec.rb'
510
+
511
+ # Offense count: 93
303
512
  Style/Documentation:
304
513
  Enabled: false
305
514
 
@@ -339,12 +548,20 @@ Style/GuardClause:
339
548
  - 'app/helpers/blacklight/catalog_helper_behavior.rb'
340
549
  - 'lib/blacklight/solr/search_builder_behavior.rb'
341
550
 
342
- # Offense count: 33
551
+ # Offense count: 1
552
+ # Cop supports --auto-correct.
553
+ # Configuration parameters: EnforcedStyle, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
554
+ # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
555
+ Style/HashSyntax:
556
+ Exclude:
557
+ - 'app/helpers/blacklight/url_helper_behavior.rb'
558
+
559
+ # Offense count: 39
343
560
  # Cop supports --auto-correct.
344
561
  Style/IfUnlessModifier:
345
562
  Enabled: false
346
563
 
347
- # Offense count: 116
564
+ # Offense count: 124
348
565
  # Cop supports --auto-correct.
349
566
  # Configuration parameters: EnforcedStyle.
350
567
  # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
@@ -370,9 +587,24 @@ Style/MutableConstant:
370
587
  Exclude:
371
588
  - 'lib/blacklight/solr/request.rb'
372
589
 
590
+ # Offense count: 9
591
+ # Cop supports --auto-correct.
592
+ # Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
593
+ # SupportedStyles: predicate, comparison
594
+ Style/NumericPredicate:
595
+ Exclude:
596
+ - 'spec/**/*'
597
+ - 'app/helpers/blacklight/catalog_helper_behavior.rb'
598
+ - 'app/models/blacklight/solr/facet_paginator.rb'
599
+ - 'app/services/blacklight/search_service.rb'
600
+ - 'lib/blacklight/search_builder.rb'
601
+ - 'lib/blacklight/solr/response/facets.rb'
602
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
603
+ - 'lib/railties/blacklight.rake'
604
+
373
605
  # Offense count: 3
374
606
  # Cop supports --auto-correct.
375
- # Configuration parameters: AllowSafeAssignment.
607
+ # Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions.
376
608
  Style/ParenthesesAroundCondition:
377
609
  Exclude:
378
610
  - 'app/views/catalog/_document.atom.builder'
@@ -386,14 +618,6 @@ Style/PercentLiteralDelimiters:
386
618
  - 'lib/blacklight/engine.rb'
387
619
  - 'lib/blacklight/solr/request.rb'
388
620
 
389
- # Offense count: 2
390
- # Cop supports --auto-correct.
391
- # Configuration parameters: EnforcedStyle, AllowInnerSlashes.
392
- # SupportedStyles: slashes, percent_r, mixed
393
- Style/RegexpLiteral:
394
- Exclude:
395
- - 'app/views/catalog/_document.atom.builder'
396
-
397
621
  # Offense count: 7
398
622
  # Cop supports --auto-correct.
399
623
  # Configuration parameters: EnforcedStyle.
@@ -405,15 +629,32 @@ Style/RescueStandardError:
405
629
  - 'lib/blacklight/configuration/fields.rb'
406
630
  - 'lib/railties/blacklight.rake'
407
631
 
408
- # Offense count: 14
632
+ # Offense count: 12
633
+ # Cop supports --auto-correct.
634
+ # Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
635
+ # Whitelist: present?, blank?, presence, try, try!
636
+ Style/SafeNavigation:
637
+ Exclude:
638
+ - 'app/controllers/concerns/blacklight/bookmarks.rb'
639
+ - 'app/controllers/concerns/blacklight/controller.rb'
640
+ - 'app/services/blacklight/field_retriever.rb'
641
+ - 'lib/blacklight.rb'
642
+ - 'lib/blacklight/configuration/facet_field.rb'
643
+ - 'lib/blacklight/configuration/search_field.rb'
644
+ - 'lib/blacklight/search_state.rb'
645
+ - 'lib/blacklight/solr/search_builder_behavior.rb'
646
+
647
+ # Offense count: 3
648
+ # Cop supports --auto-correct.
649
+ # Configuration parameters: AllowAsExpressionSeparator.
650
+ Style/Semicolon:
651
+ Exclude:
652
+ - 'spec/models/blacklight/solr/repository_spec.rb'
653
+ - 'spec/views/catalog/_paginate_compact.html.erb_spec.rb'
654
+
655
+ # Offense count: 32
409
656
  # Cop supports --auto-correct.
410
657
  # Configuration parameters: MinSize.
411
658
  # SupportedStyles: percent, brackets
412
659
  Style/SymbolArray:
413
660
  EnforcedStyle: brackets
414
-
415
- # Offense count: 1
416
- # Cop supports --auto-correct.
417
- Style/UnneededInterpolation:
418
- Exclude:
419
- - 'app/views/catalog/opensearch.xml.builder'