blacklight 6.19.0 → 6.19.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f8c4e84017c1688f0bcd1f5d99438369b1ac18bda293369d65422d732b401755
-  data.tar.gz: 7c7dc8aaa1ceb8aa086ffdeecd6dd1c086952298f4a626c927df495f64958086
+  metadata.gz: 51a58afc62bfdc6dfd3b7796e75ecdfef49a7d831fbd66cb2b4a34a483ff79bd
+  data.tar.gz: 696d0e82c3adc9e0728c98452b7588d7235f5cc649ac0a259ae122001b5b78dd
 SHA512:
-  metadata.gz: de725df92b158a47778ae9f7d0fe54b1055ca1679d68995d5dee0653cfb637bef524b3011d62fa2ec57289abae7f1e2158e38e160a32848112783531af0d1507
-  data.tar.gz: '02385cf07bd6d5c1296d8a5521acf481c42a6ec3046e3a2dbc5d21cba5a624dddec3d68e8f0cff8b885537a76b15a5d3ca7bf1729d167b64fadc5cad2e555e33'
+  metadata.gz: 4830158f0d709f43a5d2d4388e29843f3ab02404cacd7abf0ba0965b58873a0f01c75e0bfbf2d32f7f467fbd4a98cdf121d2205b9e0de07e7ed28a40047e997f
+  data.tar.gz: af430dcbe8775706d3c9436b197bcd2fb9b8212ab46cac4ea33b14fd07e3c012293683b94993e4d431214d8a929828e12c8f5154bcd3f841904b68479a461c61

data/VERSION

@@ -1 +1 @@
-6.19.0
+6.19.1

data/app/presenters/blacklight/index_presenter.rb

@@ -53,13 +53,17 @@ module Blacklight
     # @option options [String] :value
     def field_value field_or_name, options = {}
       field = case field_or_name
+              when Blacklight::Configuration::Field
+                field_or_name
               when String, Symbol
-                Deprecation.warn(self, "You provided a String or Symbol value to IndexPresenter#field_value " \
-                "Provide a Blacklight::Configuration::Field instead. field_value() will not accept " \
-                "strings or symbols in Blacklight 7")
+                Deprecation.warn(self, "You provided a #{field_or_name.class} value to IndexPresenter#field_value " \
+                "Provide a Blacklight::Configuration::Field instead. This behavior is deprecated in Blacklight 7")
                 field_config(field_or_name)
               else
-                field_or_name
+                Deprecation.warn(self, "You provided a #{field_or_name.class} value to IndexPresenter#field_value. " \
+                "This will be silently ignored and will be an error in Blacklight 7.")
+
+                Configuration::NullField.new
               end
       field_values(field, options)
     end

data/spec/presenters/index_presenter_spec.rb

@@ -58,6 +58,15 @@ describe Blacklight::IndexPresenter do
           expect(subject).to eq 'document qwer value'
         end
       end
+
+      context 'with a name as an integer' do
+        subject { presenter.field_value 123 }
+
+        it 'raises a deprecation' do
+          expect(Deprecation).to receive(:warn)
+          expect(subject).to eq ''
+        end
+      end
     end
 
     context 'when an explicit value is provided' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: blacklight
 version: !ruby/object:Gem::Version
-  version: 6.19.0
+  version: 6.19.1
 platform: ruby
 authors:
 - Jonathan Rochkind
@@ -17,7 +17,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-12-17 00:00:00.000000000 Z
+date: 2018-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails