blacklight 6.15.0 → 6.16.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 06d38d95ca2b94c85c6bfe14077f338c8fa276f8
-  data.tar.gz: f35d49bcdf90238709a06a7f16dfa898dd38a761
+SHA256:
+  metadata.gz: 63001a68b4ad9bebe9b5d93dfcd5efc8b8e519353c9850d5ebfcb7c42128bab4
+  data.tar.gz: ffc3ded7e79c7f50a8c5147ec3cf2df3d99cb6127b3febf154c456f10a6923a4
 SHA512:
-  metadata.gz: 3562e9f56ffb61d1c5995f9312f138384b5f47d7d0ce150fcbcf348fe91e3cd3fc9584f021e3e21e53728da1bf97d10408f5b5f4346bc213c6a9b274607d959c
-  data.tar.gz: 1584a23ffb76aabe4b21a6260be9fafe46dadeae7fd96834c79ad2c223b2714073d69b838acce7af65fc58955b585e80828efd3db702523d5635dcafecf6a93b
+  metadata.gz: 0d47c5102ac6643bf0e4d566a5640409b106f94acf3b51b4a8a75005809a7fbfa6e1b15eedb99d120129e18e0afbeaf106227747b0fee194da55687e23784177
+  data.tar.gz: 9710b7761291373f725c866d8187e862be11053b50d84745442fb6acb9d826c0946a62f8f7fbae7cae7a8e32101b5eaf205ed7e7d2d7335257f512f2734a7e52

data/VERSION

@@ -1 +1 @@
-6.15.0
+6.16.0

data/app/assets/javascripts/blacklight/blacklight.js

@@ -5,13 +5,13 @@
 //
 // These javascript files are compiled in via the Rails asset pipeline:
 //= require blacklight/core
-//= require blacklight/autofocus
+//= require blacklight/autocomplete
 //= require blacklight/bookmark_toggle
-//= require blacklight/ajax_modal
-//= require blacklight/search_context
 //= require blacklight/collapsable
 //= require blacklight/facet_load
-//= require blacklight/autocomplete
+//= require blacklight/ajax_modal
+//= require blacklight/search_context
+//= require blacklight/autofocus
 //
 //Bootstrap JS for providing collapsable tablet/mobile menu/alert boxes
 //= require bootstrap/transition

data/app/assets/javascripts/blacklight/checkbox_submit.js

@@ -97,7 +97,6 @@
                 data: form.serialize(),
                 error: function() {
                    alert("Error");
-                   update_state_for(checked);
                    label.removeAttr("disabled");
                    checkbox.removeAttr("disabled");
                 },
@@ -112,7 +111,6 @@
                     options.success.call(form, checked, xhr.responseJSON);
                   } else {
                     alert("Error");
-                    update_state_for(checked);
                     label.removeAttr("disabled");
                     checkbox.removeAttr("disabled");
                   }

data/app/controllers/concerns/blacklight/controller.rb

@@ -133,6 +133,10 @@ module Blacklight::Controller
     def discard_flash_if_xhr
       flash.discard if request.xhr?
     end
+    deprecation_deprecate discard_flash_if_xhr: "Discarding flash messages on XHR requests is deprecated.
+      If you wish to continue this behavior, add this method to your ApplicationController with an
+      after_action :discard_flash_if_xhr filter. To disable this behavior now and remove this warning, add
+      a skip_after_action :discard_flash_if_xhr to your ApplicationController."
 
     ##
     #

data/app/presenters/blacklight/index_presenter.rb

@@ -48,12 +48,20 @@ module Blacklight
     #
     # Allow an extention point where information in the document
     # may drive the value of the field
-    # @param [String] field
+    # @param [Configuration::Field, String] field_or_name
     # @param [Hash] options
     # @option options [String] :value
-    def field_value field, options = {}
-      field_config = field_config(field)
-      field_values(field_config, options)
+    def field_value field_or_name, options = {}
+      field = case field_or_name
+              when String
+                Deprecation.warn(self, "You provided a String value to IndexPresenter#field_value " \
+                "Provide a Blacklight::Configuration::Field instead. field_value() will not accept " \
+                "strings in Blacklight 7")
+                field_config(field_or_name)
+              else
+                field_or_name
+              end
+      field_values(field, options)
     end
 
     # @deprecated

data/app/presenters/blacklight/show_presenter.rb

@@ -74,10 +74,19 @@ module Blacklight
     #
     # Allow an extention point where information in the document
     # may drive the value of the field
-    # @param [String] field
+    # @param [Configuration::Field, String] field_or_name
     # @param [Hash] options
     # @option options [String] :value
-    def field_value field, options={}
+    def field_value field_or_name, options={}
+      field = case field_or_name
+              when String
+                Deprecation.warn(self, "You provided a String value to ShowPresenter#field_value " \
+                "Provide a Blacklight::Configuration::Field instead. field_value() will not accept " \
+                "strings in Blacklight 7")
+                field_config(field_or_name)
+              else
+                field_or_name
+              end
       field_values(field_config(field), options)
     end
 

data/app/views/catalog/_facet_layout.html.erb

@@ -1,5 +1,5 @@
 <div class="panel panel-default facet_limit blacklight-<%= facet_field.key.parameterize %> <%= 'facet_limit-active' if facet_field_in_params?(facet_field.key) %>">
-  <div class="<%= "collapsed" if should_collapse_facet?(facet_field) %> collapse-toggle panel-heading" data-toggle="collapse" data-target="#<%= facet_field_id(facet_field) %>">
+  <div class="<%= "collapsed" if should_collapse_facet?(facet_field) %> collapse-toggle panel-heading" aria-expanded="false" data-toggle="collapse" data-target="#<%= facet_field_id(facet_field) %>">
     <h3 class="panel-title facet-field-heading">
       <%= link_to facet_field_label(facet_field.key), "#", :"data-turbolinks" => false, :"data-no-turbolink" => true %>
     </h3>

data/app/views/catalog/_index_default.html.erb

@@ -1,11 +1,11 @@
-<% doc_presenter = index_presenter(document) %> 
+<% doc_presenter = index_presenter(document) %>
 <%# default partial to display solr document fields in catalog index view -%>
 <dl class="document-metadata dl-horizontal dl-invert">
-  
+
   <% index_fields(document).each do |field_name, field| -%>
     <% if should_render_index_field? document, field %>
 	    <dt class="blacklight-<%= field_name.parameterize %>"><%= render_index_field_label document, field: field_name %></dt>
-	    <dd class="blacklight-<%= field_name.parameterize %>"><%= doc_presenter.field_value field_name %></dd>
+	    <dd class="blacklight-<%= field_name.parameterize %>"><%= doc_presenter.field_value field %></dd>
     <% end -%>
   <% end -%>
 

data/app/views/catalog/_per_page_widget.html.erb

@@ -2,7 +2,7 @@
 
   <span class="sr-only"><%= t('blacklight.search.per_page.title') %></span>
 <div id="per_page-dropdown" class="btn-group">
-  <button type="button" class="btn btn-default dropdown-toggle" data-toggle="dropdown">
+  <button type="button" class="btn btn-default dropdown-toggle" data-toggle="dropdown" aria-expanded="false">
     <%= t(:'blacklight.search.per_page.button_label', :count => current_per_page) %> <span class="caret"></span>
   </button>
   <ul class="dropdown-menu" role="menu">

data/app/views/catalog/_show_default.html.erb

@@ -4,7 +4,7 @@
   <% document_show_fields(document).each do |field_name, field| -%>
     <% if should_render_show_field? document, field %>
 	    <dt class="blacklight-<%= field_name.parameterize %>"><%= render_document_show_field_label document, field: field_name %></dt>
-	    <dd class="blacklight-<%= field_name.parameterize %>"><%= doc_presenter.field_value field_name %></dd>
+	    <dd class="blacklight-<%= field_name.parameterize %>"><%= doc_presenter.field_value field %></dd>
     <% end -%>
   <% end -%>
 </dl>

data/app/views/catalog/_sort_widget.html.erb

@@ -1,6 +1,6 @@
 <% if show_sort_and_per_page? and active_sort_fields.many? %>
 <div id="sort-dropdown" class="btn-group">
-  <button type="button" class="btn btn-default dropdown-toggle" data-toggle="dropdown">
+  <button type="button" class="btn btn-default dropdown-toggle" data-toggle="dropdown" aria-expanded="false">
       <%= t('blacklight.search.sort.label', :field =>sort_field_label(current_sort_field.key)) %> <span class="caret"></span>
   </button>
 

data/spec/presenters/index_presenter_spec.rb

@@ -16,103 +16,136 @@ describe Blacklight::IndexPresenter do
     SolrDocument.new(id: 1,
                      'link_to_search_true' => 'x',
                      'link_to_search_named' => 'x',
-                     'qwer' => 'document qwer value',
-                     'mnbv' => 'document mnbv value')
+                     'qwer' => 'document qwer value')
   end
 
   before do
     allow(request_context).to receive(:search_state).and_return(search_state)
   end
 
-  describe "field_value" do
+  describe '#field_value' do
+    subject { presenter.field_value field }
+
+    let(:field) { config.index_fields[field_name] }
+    let(:field_name) { 'asdf' }
     let(:config) do
       Blacklight::Configuration.new.configure do |config|
         config.add_index_field 'qwer'
-        config.add_index_field 'asdf', :helper_method => :render_asdf_index_field
-        config.add_index_field 'link_to_search_true', :link_to_search => true
-        config.add_index_field 'link_to_search_named', :link_to_search => :some_field
-        config.add_index_field 'highlight', :highlight => true
-        config.add_index_field 'solr_doc_accessor', :accessor => true
-        config.add_index_field 'explicit_accessor', :accessor => :solr_doc_accessor
-        config.add_index_field 'explicit_accessor_with_arg', :accessor => :solr_doc_accessor_with_arg
+        config.add_index_field 'asdf', helper_method: :render_asdf_index_field
+        config.add_index_field 'link_to_search_true', link_to_search: true
+        config.add_index_field 'link_to_search_named', link_to_search: :some_field
+        config.add_index_field 'highlight', highlight: true
+        config.add_index_field 'solr_doc_accessor', accessor: true
+        config.add_index_field 'explicit_accessor', accessor: :solr_doc_accessor
         config.add_index_field 'alias', field: 'qwer'
         config.add_index_field 'with_default', default: 'value'
       end
     end
-    it "checks for an explicit value" do
-      value = subject.field_value 'asdf', :value => 'asdf'
-      expect(value).to eq 'asdf'
-    end
 
-    it "checks for a helper method to call" do
-      allow(request_context).to receive(:render_asdf_index_field).and_return('custom asdf value')
-      value = subject.field_value 'asdf'
-      expect(value).to eq 'custom asdf value'
+    context 'when a name is provided' do
+      subject { presenter.field_value 'qwer' }
+
+      it 'raises a deprecation' do
+        expect(Deprecation).to receive(:warn)
+        expect(subject).to eq 'document qwer value'
+      end
     end
 
-    it "checks for a link_to_search" do
-      allow(request_context).to receive(:search_action_path).with('f' => { 'link_to_search_true' => ['x'] }).and_return('/foo')
-      allow(request_context).to receive(:link_to).with("x", '/foo').and_return('bar')
-      value = subject.field_value 'link_to_search_true'
-      expect(value).to eq 'bar'
+    context 'when an explicit value is provided' do
+      subject { presenter.field_value field, value: 'asdf' }
+
+      it { is_expected.to eq 'asdf' }
     end
 
-    it "checks for a link_to_search with a field name" do
-      allow(request_context).to receive(:search_action_path).with('f' => { 'some_field' => ['x'] }).and_return('/foo')
-      allow(request_context).to receive(:link_to).with("x", '/foo').and_return('bar')
-      value = subject.field_value 'link_to_search_named'
-      expect(value).to eq 'bar'
+    context 'when field has a helper method' do
+      before do
+        allow(request_context).to receive(:render_asdf_index_field).and_return('custom asdf value')
+      end
+
+      it { is_expected.to eq 'custom asdf value' }
     end
 
-    it "gracefully handles when no highlight field is available" do
-      allow(document).to receive(:has_highlight_field?).and_return(false)
-      value = subject.field_value 'highlight'
-      expect(value).to be_blank
+    context 'when field has link_to_search with true' do
+      before do
+        allow(request_context).to receive(:search_action_path).with('f' => { 'link_to_search_true' => ['x'] }).and_return('/foo')
+        allow(request_context).to receive(:link_to).with("x", '/foo').and_return('bar')
+      end
+
+      let(:field_name) { 'link_to_search_true' }
+
+      it { is_expected.to eq 'bar' }
     end
 
-    it "checks for a highlighted field" do
-      allow(document).to receive(:has_highlight_field?).and_return(true)
-      allow(document).to receive(:highlight_field).with('highlight').and_return(['<em>highlight</em>'.html_safe])
-      value = subject.field_value 'highlight'
-      expect(value).to eq '<em>highlight</em>'
+    context 'when field has link_to_search with a field name' do
+      before do
+        allow(request_context).to receive(:search_action_path).with('f' => { 'some_field' => ['x'] }).and_return('/foo')
+        allow(request_context).to receive(:link_to).with("x", '/foo').and_return('bar')
+      end
+
+      let(:field_name) { 'link_to_search_named' }
+
+      it { is_expected.to eq 'bar' }
     end
 
-    it "checks the document field value" do
-      value = subject.field_value 'qwer'
-      expect(value).to eq 'document qwer value'
+    context 'when no highlight field is available' do
+      before do
+        allow(document).to receive(:has_highlight_field?).and_return(false)
+      end
+
+      let(:field_name) { 'highlight' }
+
+      it { is_expected.to be_blank }
     end
 
-    it "works with index fields that aren't explicitly defined" do
-      value = subject.field_value 'mnbv'
-      expect(value).to eq 'document mnbv value'
+    context 'when highlight field is available' do
+      before do
+        allow(document).to receive(:has_highlight_field?).and_return(true)
+        allow(document).to receive(:highlight_field).with('highlight').and_return(['<em>highlight</em>'.html_safe])
+      end
+
+      let(:field_name) { 'highlight' }
+
+      it { is_expected.to eq '<em>highlight</em>' }
     end
 
-    it "calls an accessor on the solr document" do
-      allow(document).to receive_messages(solr_doc_accessor: "123")
-      value = subject.field_value 'solr_doc_accessor'
-      expect(value).to eq "123"
+    context 'when no options are provided' do
+      let(:field_name) { 'qwer' }
+
+      it "checks the document field value" do
+        expect(subject).to eq 'document qwer value'
+      end
     end
 
-    it "calls an explicit accessor on the solr document" do
-      allow(document).to receive_messages(solr_doc_accessor: "123")
-      value = subject.field_value 'explicit_accessor'
-      expect(value).to eq "123"
+    context 'when accessor is true' do
+      before do
+        allow(document).to receive_messages(solr_doc_accessor: "123")
+      end
+
+      let(:field_name) { 'solr_doc_accessor' }
+
+      it { is_expected.to eq '123' }
     end
 
-    it "calls an accessor on the solr document with the field as an argument" do
-      allow(document).to receive(:solr_doc_accessor_with_arg).with('explicit_accessor_with_arg').and_return("123")
-      value = subject.field_value 'explicit_accessor_with_arg'
-      expect(value).to eq "123"
+    context 'when accessor is set to a value' do
+      let(:field_name) { 'explicit_accessor' }
+
+      it 'calls the accessor with the field_name as the argument' do
+        expect(document).to receive(:solr_doc_accessor).with('explicit_accessor').and_return("123")
+
+        expect(subject).to eq '123'
+      end
     end
 
-    it "supports solr field configuration" do
-      value = subject.field_value 'alias'
-      expect(value).to eq "document qwer value"
+    context 'when the field is an alias' do
+      let(:field_name) { 'alias' }
+
+      it { is_expected.to eq 'document qwer value' }
     end
 
-    it "supports default values in the field configuration" do
-      value = subject.field_value 'with_default'
-      expect(value).to eq "value"
+    context 'when the field has a default' do
+      let(:field_name) { 'with_default' }
+
+      it { is_expected.to eq 'value' }
     end
   end
 
@@ -170,4 +203,3 @@ describe Blacklight::IndexPresenter do
     end
   end
 end
-

data/spec/presenters/show_presenter_spec.rb

@@ -16,8 +16,7 @@ describe Blacklight::ShowPresenter do
     SolrDocument.new(id: 1,
                      'link_to_search_true' => 'x',
                      'link_to_search_named' => 'x',
-                     'qwer' => 'document qwer value',
-                     'mnbv' => 'document mnbv value')
+                     'qwer' => 'document qwer value')
   end
 
   before do
@@ -97,118 +96,155 @@ describe Blacklight::ShowPresenter do
     end
   end
 
-  describe "field_value" do
+  describe '#field_value' do
+    subject { presenter.field_value field }
+
+    let(:field) { config.show_fields[field_name] }
+    let(:field_name) { 'asdf' }
     let(:config) do
       Blacklight::Configuration.new.configure do |config|
         config.add_show_field 'qwer'
-        config.add_show_field 'asdf', :helper_method => :render_asdf_document_show_field
-        config.add_show_field 'link_to_search_true', :link_to_search => true
-        config.add_show_field 'link_to_search_named', :link_to_search => :some_field
-        config.add_show_field 'highlight', :highlight => true
-        config.add_show_field 'solr_doc_accessor', :accessor => true
-        config.add_show_field 'explicit_accessor', :accessor => :solr_doc_accessor
-        config.add_show_field 'explicit_array_accessor', :accessor => [:solr_doc_accessor, :some_method]
-        config.add_show_field 'explicit_accessor_with_arg', :accessor => :solr_doc_accessor_with_arg
+        config.add_show_field 'asdf', helper_method: :render_asdf_document_show_field
+        config.add_show_field 'link_to_search_true', link_to_search: true
+        config.add_show_field 'link_to_search_named', link_to_search: :some_field
+        config.add_show_field 'highlight', highlight: true
+        config.add_show_field 'solr_doc_accessor', accessor: true
+        config.add_show_field 'explicit_accessor', accessor: :solr_doc_accessor
+        config.add_show_field 'explicit_array_accessor', accessor: [:solr_doc_accessor, :some_method]
       end
     end
 
-    it 'html-escapes values' do
-      value = subject.field_value 'asdf', value: '<b>val1</b>'
-      expect(value).to eq '&lt;b&gt;val1&lt;/b&gt;'
-    end
+    context 'when a name is provided' do
+      subject { presenter.field_value 'qwer' }
 
-    it 'joins multivalued valued fields' do
-      value = subject.field_value 'asdf', value: ['<a', 'b']
-      expect(value).to eq '&lt;a and b'
+      it 'raises a deprecation' do
+        expect(Deprecation).to receive(:warn)
+        expect(subject).to eq 'document qwer value'
+      end
     end
 
-    it 'joins multivalued valued fields' do
-      value = subject.field_value 'asdf', value: ['a', 'b', 'c']
-      expect(value).to eq 'a, b, and c'
-    end
+    context 'when an explicit html value is provided' do
+      subject { presenter.field_value field, value: '<b>val1</b>' }
 
-    it "checks for an explicit value" do
-      expect(request_context).to_not receive(:render_asdf_document_show_field)
-      value = subject.field_value 'asdf', :value => 'val1'
-      expect(value).to eq 'val1'
+      it { is_expected.to eq '&lt;b&gt;val1&lt;/b&gt;' }
     end
 
-    it "checks for a helper method to call" do
-      allow(request_context).to receive(:render_asdf_document_show_field).and_return('custom asdf value')
-      value = subject.field_value 'asdf'
-      expect(value).to eq 'custom asdf value'
+    context 'when an explicit array value with unsafe characters is provided' do
+      subject { presenter.field_value field, value: ['<a', 'b'] }
+
+      it { is_expected.to eq '&lt;a and b' }
     end
 
-    it "checks for a link_to_search" do
-      allow(request_context).to receive(:search_action_path).and_return('/foo')
-      allow(request_context).to receive(:link_to).with("x", '/foo').and_return('bar')
-      value = subject.field_value 'link_to_search_true'
-      expect(value).to eq 'bar'
+    context 'when an explicit array value is provided' do
+      subject { presenter.field_value field, value: %w[a b c] }
+
+      it { is_expected.to eq 'a, b, and c' }
     end
 
-    it "checks for a link_to_search with a field name" do
-      allow(request_context).to receive(:search_action_path).and_return('/foo')
-      allow(request_context).to receive(:link_to).with("x", '/foo').and_return('bar')
-      value = subject.field_value 'link_to_search_named'
-      expect(value).to eq 'bar'
+    context 'when an explicit value is provided' do
+      subject { presenter.field_value field, value: 'val1' }
+
+      it { is_expected.to eq 'val1' }
     end
 
-    context "when no highlight field is available" do
+    context 'when field has a helper method' do
       before do
-        allow(document).to receive(:has_highlight_field?).and_return(false)
+        allow(request_context).to receive(:render_asdf_document_show_field).and_return('custom asdf value')
       end
-      let(:value) { subject.field_value 'highlight' }
-      it "is blank" do
-        expect(value).to be_blank
+
+      it { is_expected.to eq 'custom asdf value' }
+    end
+
+    context 'when field has link_to_search with true' do
+      before do
+        allow(request_context).to receive(:search_action_path).with('f' => { 'link_to_search_true' => ['x'] }).and_return('/foo')
+        allow(request_context).to receive(:link_to).with("x", '/foo').and_return('bar')
       end
+
+      let(:field_name) { 'link_to_search_true' }
+
+      it { is_expected.to eq 'bar' }
     end
 
-    it "checks for a highlighted field" do
-      allow(document).to receive(:has_highlight_field?).and_return(true)
-      allow(document).to receive(:highlight_field).with('highlight').and_return(['<em>highlight</em>'.html_safe])
-      value = subject.field_value 'highlight'
-      expect(value).to eq '<em>highlight</em>'
+    context 'when field has link_to_search with a field name' do
+      before do
+        allow(request_context).to receive(:search_action_path).with('f' => { 'some_field' => ['x'] }).and_return('/foo')
+        allow(request_context).to receive(:link_to).with("x", '/foo').and_return('bar')
+      end
+
+      let(:field_name) { 'link_to_search_named' }
+
+      it { is_expected.to eq 'bar' }
     end
 
-    it 'respects the HTML-safeness of multivalued highlight fields' do
-      allow(document).to receive(:has_highlight_field?).and_return(true)
-      allow(document).to receive(:highlight_field).with('highlight').and_return(['<em>highlight</em>'.html_safe, '<em>other highlight</em>'.html_safe])
-      value = subject.field_value 'highlight'
-      expect(value).to eq '<em>highlight</em> and <em>other highlight</em>'
+    context 'when no highlight field is available' do
+      before do
+        allow(document).to receive(:has_highlight_field?).and_return(false)
+      end
+
+      let(:field_name) { 'highlight' }
+
+      it { is_expected.to be_blank }
     end
 
-    it "checks the document field value" do
-      value = subject.field_value 'qwer'
-      expect(value).to eq 'document qwer value'
+    context 'when highlight field is available' do
+      before do
+        allow(document).to receive(:has_highlight_field?).and_return(true)
+        allow(document).to receive(:highlight_field).with('highlight').and_return(['<em>highlight</em>'.html_safe])
+      end
+
+      let(:field_name) { 'highlight' }
+
+      it { is_expected.to eq '<em>highlight</em>' }
     end
 
-    it "works with show fields that aren't explicitly defined" do
-      value = subject.field_value 'mnbv'
-      expect(value).to eq 'document mnbv value'
+    context 'when highlight returns multiple values' do
+      before do
+        allow(document).to receive(:has_highlight_field?).and_return(true)
+        allow(document).to receive(:highlight_field).with('highlight').and_return(['<em>highlight</em>'.html_safe, '<em>other highlight</em>'.html_safe])
+      end
+
+      let(:field_name) { 'highlight' }
+
+      it { is_expected.to eq '<em>highlight</em> and <em>other highlight</em>' }
     end
 
-    it "calls an accessor on the solr document" do
-      allow(document).to receive_messages(solr_doc_accessor: "123")
-      value = subject.field_value 'solr_doc_accessor'
-      expect(value).to eq "123"
+    context 'when no options are provided' do
+      let(:field_name) { 'qwer' }
+
+      it "checks the document field value" do
+        expect(subject).to eq 'document qwer value'
+      end
     end
 
-    it "calls an explicit accessor on the solr document" do
-      allow(document).to receive_messages(solr_doc_accessor: "123")
-      value = subject.field_value 'explicit_accessor'
-      expect(value).to eq "123"
+    context 'when accessor is true' do
+      before do
+        allow(document).to receive_messages(solr_doc_accessor: "123")
+      end
+
+      let(:field_name) { 'solr_doc_accessor' }
+
+      it { is_expected.to eq '123' }
     end
 
-    it "calls an explicit array-style accessor on the solr document" do
-      allow(document).to receive_message_chain(:solr_doc_accessor, some_method: "123")
-      value = subject.field_value 'explicit_array_accessor'
-      expect(value).to eq "123"
+    context 'when accessor is set to a value' do
+      let(:field_name) { 'explicit_accessor' }
+
+      it 'calls the accessor with the field_name as the argument' do
+        expect(document).to receive(:solr_doc_accessor).with('explicit_accessor').and_return("123")
+
+        expect(subject).to eq '123'
+      end
     end
 
-    it "calls an accessor on the solr document with the field as an argument" do
-      allow(document).to receive(:solr_doc_accessor_with_arg).with('explicit_accessor_with_arg').and_return("123")
-      value = subject.field_value 'explicit_accessor_with_arg'
-      expect(value).to eq "123"
+    context 'when accessor is set to an array' do
+      let(:field_name) { 'explicit_array_accessor' }
+
+      it 'calls the accessors on the return of the preceeding' do
+        allow(document).to receive_message_chain(:solr_doc_accessor, some_method: "123")
+
+        expect(subject).to eq '123'
+      end
     end
   end
 
@@ -310,4 +346,3 @@ describe Blacklight::ShowPresenter do
     end
   end
 end
-

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: blacklight
 version: !ruby/object:Gem::Version
-  version: 6.15.0
+  version: 6.16.0
 platform: ruby
 authors:
 - Jonathan Rochkind
@@ -17,7 +17,7 @@ authors:
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-04-26 00:00:00.000000000 Z
+date: 2018-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -765,7 +765,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Blacklight provides a discovery interface for any Solr (http://lucene.apache.org/solr)