blacklight-gallery 1.6.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 14925720da8a37bde4f1e05a13ff9063898600c81887dd30ef6294a46762b8bf
-  data.tar.gz: 5e9ccf945bf9e2c495d5babfa85144d60a5ec5f58a068e7e987631e43f5176e6
+  metadata.gz: 88f1e7482c4ccd593780df7fe914534583e803b8cb7586a98db381f425ca3326
+  data.tar.gz: f91d53c9e4d750ab085d7ba97c1a67f7d26e2dde31541b273e7195098453fedb
 SHA512:
-  metadata.gz: af850e569c98cc5b4797262b01be871d3b9136173be1281618e09d6f3ffb3b35bd537002df36911718e3671f79d4bd434f4a33e190e757544c701b92ee9460bd
-  data.tar.gz: 571fe4f304a47dfda6f58b720d7878ee192f94b0d0cf1ab1ae24d2b9d4da0b15b241165ae175e22530e5ef628b535ba839693e17bd6fabef36d334eb7203ba8f
+  metadata.gz: 5ed81094a38b233941ad06c6b62e5555a407809151d87b902c9d5422fbe3953f9a58691510253c407f3f7e756b9d703ab4da4515558ecb9caf3cdbe6fdd986ce
+  data.tar.gz: 05cca47ed3750c5c3b8663b910a106d1d1b2437d36e46972c7a52a215659966c0b1798f16dabb35601674f9234b3cb87777afafd426e71566a03ade868d485dd

data/app/assets/stylesheets/blacklight_gallery/_gallery.scss

@@ -17,7 +17,6 @@
     -ms-flex: 1;
     flex: 1;
 
-    min-width: 250px;
     min-height: 250px;
     -webkit-flex: 1 0 250px;
   }
@@ -45,7 +44,6 @@
       clear: none;
       text-align: left;
       margin: 0;
-      padding: 0;
     }
 
   }

data/app/assets/stylesheets/blacklight_gallery/_masonry.scss

@@ -6,11 +6,11 @@
     background-color: $gray-300;
     min-height: 70px;
 
-    .thumbnail {
-      border: 0;
+    .img-thumbnail {
+      border-radius: 0;
       padding: 0;
-      margin-bottom: 0;
     }
+
     .caption {
       &:first-child { display: block; } // To display captions when there is no image
       a {

data/app/views/catalog/_index_gallery.html.erb

@@ -1,6 +1,12 @@
 <div class="document col-6 col-md-4">
   <div class="thumbnail">
-    <%= render_thumbnail_tag(document, { class: 'img-thumbnail' }, :counter => document_counter_with_offset(document_counter)) %>
+    <%= render_thumbnail_tag(
+          document,
+          { class: 'img-thumbnail', alt: '' },
+          counter: document_counter_with_offset(document_counter),
+          'aria-hidden': true,
+          tabindex: -1
+        ) %>
     <div class="caption">
       <%= render_document_partials document, blacklight_config.view_config(:gallery).partials, :document_counter => document_counter %>
     </div>

data/app/views/catalog/_index_masonry.html.erb

@@ -1,6 +1,6 @@
 <div class="masonry document col-6 col-md-3">
   <div class="thumbnail">
-    <%= render_thumbnail_tag(document, { class: 'img-thumbnail' }, counter: document_counter_with_offset(document_counter)) %>
+    <%= render_thumbnail_tag(document, { class: 'img-thumbnail', alt: index_presenter(document).heading }, counter: document_counter_with_offset(document_counter)) %>
     <div class="caption">
       <%= render_document_partials document, blacklight_config.view_config(:masonry).partials, :document_counter => document_counter %>
     </div>

data/lib/blacklight/gallery/version.rb

@@ -1,5 +1,5 @@
 module Blacklight
   module Gallery
-    VERSION = "1.6.0"
+    VERSION = "1.7.0"
   end
 end

data/spec/views/catalog/_index_gallery.html.erb_spec.rb

@@ -13,7 +13,7 @@ describe "catalog/_index_gallery.html.erb", :type => :view do
   end
 
   it "should have thumbnail and caption" do
-    expect(view).to receive(:render_thumbnail_tag).with(document, { class: 'img-thumbnail' }, hash_including(:counter)).and_return('Thumbnail')
+    expect(view).to receive(:render_thumbnail_tag).with(document, { class: 'img-thumbnail', alt: '' }, hash_including(:counter)).and_return('Thumbnail')
     expect(view).to receive(:render_document_partials).with(document, ['a', 'b'], document_counter: 3).and_return('Z')
     render
     expect(rendered).to have_selector '.thumbnail', text: 'Thumbnail'

data/spec/views/catalog/_index_masonry.html.erb_spec.rb

@@ -3,8 +3,10 @@ require 'spec_helper'
 describe "catalog/_document_masonry.html.erb", :type => :view do
   let(:blacklight_config) { Blacklight::Configuration.new }
   let(:documents) { [stub_model(::SolrDocument), stub_model(::SolrDocument)] }
+  let(:presenter) { instance_double(Blacklight::IndexPresenter, heading: 'xyz')}
   before do
     allow(view).to receive_messages(blacklight_config: blacklight_config)
+    allow(view).to receive_messages(index_presenter: presenter)
     allow(view).to receive_messages(documents: documents)
     allow(view).to receive_messages(document_counter: 1)
     allow(view).to receive_messages(document_counter_with_offset: 1)
@@ -23,6 +25,7 @@ describe "catalog/_document_masonry.html.erb", :type => :view do
 
   it 'should render the thumbnail' do
     expect(rendered).to have_css('.thumbnail', text: 'Thumbnail')
+    expect(view).to have_received(:render_thumbnail_tag).with(documents.first, { class: 'img-thumbnail', alt: 'xyz' }, counter: 1)
   end
 
   it 'should render the caption' do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: blacklight-gallery
 version: !ruby/object:Gem::Version
-  version: 1.6.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Chris Beer
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-04 00:00:00.000000000 Z
+date: 2020-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -330,7 +330,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.1
 signing_key: 
 specification_version: 4
 summary: Gallery display for Blacklight