bixby 2.0.0.pre.beta1 → 3.0.0

Sign up to get free protection for your applications and to get access to all the features.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 746a55d52af52d8d2dc66624cb90df7f99483ea1a1c5abcd42d229db8dd6064c
4
- data.tar.gz: 8ccfe8bd8507449103ec1fa39c49e342ff3b9e49e219e6f131f47ab2f4528b18
3
+ metadata.gz: 816a4b20f59bf9321a5449d153b36487d072052590eae7be0ea6bf5870862180
4
+ data.tar.gz: b321e14e38bdb9d103d682299a39885276af239b6932dbaae07add8063e04ca5
5
5
  SHA512:
6
- metadata.gz: faa7c26aa8307040a0633ed5abe8f100ae4a485b4b126e39a70767df26bbfff632016bb06332783011e9d06010f27d16efabf33786eec92ce769448f866e8385
7
- data.tar.gz: a06ce2feddcf1b599e0e00307070d6d0b69b912574616941f9232c47fab0eff79b44f34a6cb742dd8752007076c655a6997c2dd3594ce3b487adbbbdbb512758
6
+ metadata.gz: 5ea4b4b301f02e3108ba3b249cea6a315d346649402ae4fca5dc9d775557b55cbcbaaddc2a06399765e3181dbaad205e22262bbe36c0cbb8564bc291a3f65249
7
+ data.tar.gz: 143335699e262695d8a5adcc1f98441a8d2c949b05b26e2a2ac12c0a53a13d2d69ba5a4ce2c8dd756d39a84d01ecb3aac159e1c81c59f26729f75bfee632319b
@@ -0,0 +1,55 @@
1
+ version: 2.1
2
+
3
+ orbs:
4
+ samvera: samvera/circleci-orb@0
5
+
6
+ jobs:
7
+ bundle_lint_test:
8
+ parameters:
9
+ ruby_version:
10
+ type: string
11
+ project:
12
+ type: string
13
+ bundler_version:
14
+ type: string
15
+ default: 1.17.3
16
+
17
+ executor:
18
+ name: 'samvera/ruby'
19
+ ruby_version: << parameters.ruby_version >>
20
+
21
+ steps:
22
+ - samvera/cached_checkout
23
+
24
+ - samvera/bundle_for_gem:
25
+ ruby_version: << parameters.ruby_version >>
26
+ bundler_version: << parameters.bundler_version >>
27
+ project: << parameters.project >>
28
+ cache_version: '2'
29
+
30
+ - samvera/rubocop
31
+
32
+ workflows:
33
+ version: 2
34
+ ci:
35
+ jobs:
36
+ - bundle_lint_test:
37
+ project: bixby
38
+ name: ruby2-4
39
+ ruby_version: 2.4.10
40
+
41
+ - bundle_lint_test:
42
+ project: bixby
43
+ name: ruby2-5
44
+ ruby_version: 2.5.8
45
+
46
+ - bundle_lint_test:
47
+ project: bixby
48
+ name: ruby2-6
49
+ ruby_version: 2.6.6
50
+
51
+ - bundle_lint_test:
52
+ project: bixby
53
+ name: ruby2-7
54
+ ruby_version: 2.7.1
55
+
@@ -0,0 +1,2 @@
1
+ unreleased=true
2
+ future-release=3.0.0
data/.gitignore CHANGED
@@ -48,3 +48,4 @@ build-iPhoneSimulator/
48
48
 
49
49
  # unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
50
50
  .rvmrc
51
+ Gemfile.lock
@@ -0,0 +1,161 @@
1
+ # Changelog
2
+
3
+ ## [3.0.0](https://github.com/samvera-labs/bixby/tree/3.0.0) (2020-06-10)
4
+
5
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v3.0.0.pre3...3.0.0)
6
+
7
+ **Merged pull requests:**
8
+
9
+ - Prep for 3.0.0.pre3 release [\#42](https://github.com/samvera-labs/bixby/pull/42) ([bess](https://github.com/bess))
10
+
11
+ ## [v3.0.0.pre3](https://github.com/samvera-labs/bixby/tree/v3.0.0.pre3) (2020-06-10)
12
+
13
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v3.0.0.pre2...v3.0.0.pre3)
14
+
15
+ **Merged pull requests:**
16
+
17
+ - Disable Rails/DynamicFindBy [\#41](https://github.com/samvera-labs/bixby/pull/41) ([bess](https://github.com/bess))
18
+
19
+ ## [v3.0.0.pre2](https://github.com/samvera-labs/bixby/tree/v3.0.0.pre2) (2020-06-10)
20
+
21
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v3.0.0.pre1...v3.0.0.pre2)
22
+
23
+ **Merged pull requests:**
24
+
25
+ - Prep for 3.0.0.pre2 release [\#40](https://github.com/samvera-labs/bixby/pull/40) ([bess](https://github.com/bess))
26
+ - 3.0.0 fixup [\#39](https://github.com/samvera-labs/bixby/pull/39) ([no-reply](https://github.com/no-reply))
27
+
28
+ ## [v3.0.0.pre1](https://github.com/samvera-labs/bixby/tree/v3.0.0.pre1) (2020-06-10)
29
+
30
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v3.0.0.pre.pre1...v3.0.0.pre1)
31
+
32
+ **Merged pull requests:**
33
+
34
+ - Fix gem version [\#38](https://github.com/samvera-labs/bixby/pull/38) ([bess](https://github.com/bess))
35
+
36
+ ## [v3.0.0.pre.pre1](https://github.com/samvera-labs/bixby/tree/v3.0.0.pre.pre1) (2020-06-10)
37
+
38
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v2.1.0...v3.0.0.pre.pre1)
39
+
40
+ **Implemented enhancements:**
41
+
42
+ - Request to promote this Gem to samvera [\#33](https://github.com/samvera-labs/bixby/issues/33)
43
+
44
+ **Merged pull requests:**
45
+
46
+ - Prep for 3.0.0-pre1 release [\#37](https://github.com/samvera-labs/bixby/pull/37) ([bess](https://github.com/bess))
47
+ - Prepares the Gem for promotion [\#34](https://github.com/samvera-labs/bixby/pull/34) ([jrgriffiniii](https://github.com/jrgriffiniii))
48
+
49
+ ## [v2.1.0](https://github.com/samvera-labs/bixby/tree/v2.1.0) (2020-06-09)
50
+
51
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v2.0.0...v2.1.0)
52
+
53
+ **Merged pull requests:**
54
+
55
+ - Prep for 2.1.0 release [\#36](https://github.com/samvera-labs/bixby/pull/36) ([bess](https://github.com/bess))
56
+ - Upgrade rubocop and dependencies [\#35](https://github.com/samvera-labs/bixby/pull/35) ([bess](https://github.com/bess))
57
+ - Prep for 2.0 release [\#31](https://github.com/samvera-labs/bixby/pull/31) ([bess](https://github.com/bess))
58
+
59
+ ## [v2.0.0](https://github.com/samvera-labs/bixby/tree/v2.0.0) (2019-12-10)
60
+
61
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v2.0.0.pre.beta1...v2.0.0)
62
+
63
+ **Closed issues:**
64
+
65
+ - Upgrade for new rubocop [\#26](https://github.com/samvera-labs/bixby/issues/26)
66
+ - Update rubocop-rspec [\#25](https://github.com/samvera-labs/bixby/issues/25)
67
+ - Lint/BlockAlignment has the wrong namespace - should be Layout [\#24](https://github.com/samvera-labs/bixby/issues/24)
68
+ - Add Lint/RescueWithoutErrorClass [\#23](https://github.com/samvera-labs/bixby/issues/23)
69
+
70
+ **Merged pull requests:**
71
+
72
+ - Skipping node\_modules directory when running cops [\#30](https://github.com/samvera-labs/bixby/pull/30) ([cgalarza](https://github.com/cgalarza))
73
+
74
+ ## [v2.0.0.pre.beta1](https://github.com/samvera-labs/bixby/tree/v2.0.0.pre.beta1) (2019-02-14)
75
+
76
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/1.0.0...v2.0.0.pre.beta1)
77
+
78
+ **Merged pull requests:**
79
+
80
+ - Bixby 2.0 [\#28](https://github.com/samvera-labs/bixby/pull/28) ([no-reply](https://github.com/no-reply))
81
+
82
+ ## [1.0.0](https://github.com/samvera-labs/bixby/tree/1.0.0) (2018-02-13)
83
+
84
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v1.0.0-rc1...1.0.0)
85
+
86
+ **Merged pull requests:**
87
+
88
+ - Prepare Release 1.0.0 [\#22](https://github.com/samvera-labs/bixby/pull/22) ([no-reply](https://github.com/no-reply))
89
+
90
+ ## [v1.0.0-rc1](https://github.com/samvera-labs/bixby/tree/v1.0.0-rc1) (2018-02-09)
91
+
92
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v0.3.1...v1.0.0-rc1)
93
+
94
+ **Closed issues:**
95
+
96
+ - Disable `RSpec/MulitpleExpectations` [\#19](https://github.com/samvera-labs/bixby/issues/19)
97
+ - Add tmp dir to AllCops exclusion [\#18](https://github.com/samvera-labs/bixby/issues/18)
98
+ - Warning: unrecognized cop Naming/BinaryOperatorParameter found in ~/.gem/ruby/2.4.2/gems/bixby-0.3.0/bixby\_default.yml [\#14](https://github.com/samvera-labs/bixby/issues/14)
99
+ - Resolve new cops/changes is in rubocop-rspec 0.18.0. [\#11](https://github.com/samvera-labs/bixby/issues/11)
100
+ - Resolve new cops/changes in RuboCop 0.50.0 [\#10](https://github.com/samvera-labs/bixby/issues/10)
101
+ - Bixby not compatible with latest Rubocop [\#6](https://github.com/samvera-labs/bixby/issues/6)
102
+
103
+ **Merged pull requests:**
104
+
105
+ - Bump version to 1.0.0-rc1 [\#21](https://github.com/samvera-labs/bixby/pull/21) ([no-reply](https://github.com/no-reply))
106
+ - Support newer versions of `rubocop`, `rubocop-rspec`, and Ruby [\#20](https://github.com/samvera-labs/bixby/pull/20) ([no-reply](https://github.com/no-reply))
107
+ - Remove Lint/InvalidCharacterLiteral, fixes \#15 [\#16](https://github.com/samvera-labs/bixby/pull/16) ([hackmastera](https://github.com/hackmastera))
108
+ - Update READEME.md to discuss versioning strategy [\#13](https://github.com/samvera-labs/bixby/pull/13) ([no-reply](https://github.com/no-reply))
109
+ - Lock versions to `rubocop` 0.50.0 and `rubocop-rspec` 1.18.0 [\#12](https://github.com/samvera-labs/bixby/pull/12) ([no-reply](https://github.com/no-reply))
110
+
111
+ ## [v0.3.1](https://github.com/samvera-labs/bixby/tree/v0.3.1) (2017-10-04)
112
+
113
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v0.3.0...v0.3.1)
114
+
115
+ **Closed issues:**
116
+
117
+ - Error: The `Lint/InvalidCharacterLiteral` cop has been removed since it was never being actually triggered. \(obsolete configuration found in /home/ubuntu/valkyrie/valkyrie/vendor/valk\_bundle/ruby/2.3.0/gems/bixby-0.3.0/bixby\_default.yml, please update it\) [\#15](https://github.com/samvera-labs/bixby/issues/15)
118
+
119
+ **Merged pull requests:**
120
+
121
+ - Remove Lint/InvalidCharacterLiteral, fixes \#15 [\#17](https://github.com/samvera-labs/bixby/pull/17) ([hackmastera](https://github.com/hackmastera))
122
+
123
+ ## [v0.3.0](https://github.com/samvera-labs/bixby/tree/v0.3.0) (2017-10-03)
124
+
125
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v0.2.2...v0.3.0)
126
+
127
+ **Merged pull requests:**
128
+
129
+ - Prepare Release v0.3.0 [\#9](https://github.com/samvera-labs/bixby/pull/9) ([no-reply](https://github.com/no-reply))
130
+ - Upgrade for RuboCop 0.50.0 compatibility [\#8](https://github.com/samvera-labs/bixby/pull/8) ([no-reply](https://github.com/no-reply))
131
+ - Allow deeper group nesting in RSpec [\#7](https://github.com/samvera-labs/bixby/pull/7) ([no-reply](https://github.com/no-reply))
132
+
133
+ ## [v0.2.2](https://github.com/samvera-labs/bixby/tree/v0.2.2) (2017-08-07)
134
+
135
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v0.2.1...v0.2.2)
136
+
137
+ **Closed issues:**
138
+
139
+ - Should we allow long blocks in CatalogController? [\#3](https://github.com/samvera-labs/bixby/issues/3)
140
+
141
+ **Merged pull requests:**
142
+
143
+ - Ignore block and class length on CatalogController [\#5](https://github.com/samvera-labs/bixby/pull/5) ([no-reply](https://github.com/no-reply))
144
+ - Include 'Capfile' in excluded filenames [\#4](https://github.com/samvera-labs/bixby/pull/4) ([mark-dce](https://github.com/mark-dce))
145
+
146
+ ## [v0.2.1](https://github.com/samvera-labs/bixby/tree/v0.2.1) (2017-06-01)
147
+
148
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/v0.2.0...v0.2.1)
149
+
150
+ **Merged pull requests:**
151
+
152
+ - Add bundler release tasks for easier gem management [\#2](https://github.com/samvera-labs/bixby/pull/2) ([bess](https://github.com/bess))
153
+ - Rubocop 0 49 fixes [\#1](https://github.com/samvera-labs/bixby/pull/1) ([bess](https://github.com/bess))
154
+
155
+ ## [v0.2.0](https://github.com/samvera-labs/bixby/tree/v0.2.0) (2017-03-30)
156
+
157
+ [Full Changelog](https://github.com/samvera-labs/bixby/compare/8f95541b23cfda44c8a89704127696262284215a...v0.2.0)
158
+
159
+
160
+
161
+ \* *This Changelog was automatically generated by [github_changelog_generator](https://github.com/github-changelog-generator/github-changelog-generator)*
@@ -0,0 +1,36 @@
1
+ The Samvera community is dedicated to providing a welcoming and
2
+ positive experience for all its members, whether they are at a formal
3
+ gathering, in a social setting, or taking part in activities online.
4
+ The Samvera community welcomes participation from people all over the
5
+ world and these members bring with them a wide variety of
6
+ professional, personal and social backgrounds; whatever these may be,
7
+ we treat colleagues with dignity and respect.
8
+
9
+ Community members communicate primarily in English, though for many of
10
+ them this is not their native language. We therefore strive to express
11
+ ourselves simply and clearly remembering that unnecessary use of
12
+ jargon and slang will be a barrier to understanding for many of our
13
+ colleagues. We are sensitive to the fact that the international
14
+ nature of the community means that we span many different social norms
15
+ around language and behaviour and we strive to conduct ourselves,
16
+ online and in person, in ways that are unlikely to cause offence.
17
+
18
+ Samvera conversations are often information-rich and intended to
19
+ generate discussion and debate. We discuss ideas from a standpoint of
20
+ mutual respect and reasoned argument.
21
+
22
+ Community members work together to promote a respectful and safe
23
+ community. In the event that someone’s conduct is causing offence or
24
+ distress, Samvera has a detailed
25
+ [Anti-Harassment Policy and Protocol](https://wiki.duraspace.org/display/samvera/Anti-Harassment+Policy)
26
+ which can be applied to address the problem. The first step in dealing
27
+ with any serious misconduct is to contact a local meeting organizer,
28
+ the
29
+ [Samvera community helpers](https://wiki.duraspace.org/display/samvera/Samvera+Community+Helpers)
30
+ ([email](mailto:helpers@samvera.org)), a community member you
31
+ trust, or the
32
+ [Samvera Steering Group](https://wiki.duraspace.org/display/samvera/Samvera+Steering+Group+membership)
33
+ immediately; at Samvera events, these people can be identified by
34
+ distinctive name badges. The
35
+ [Policy and Protocol](https://wiki.duraspace.org/display/samvera/Anti-Harassment+Policy)
36
+ should be consulted for fuller details.
@@ -0,0 +1,161 @@
1
+ # How to Contribute
2
+
3
+ We want your help to make the Samvera community great. There are a few guidelines
4
+ that we need contributors to follow so that we can have a chance of
5
+ keeping on top of things.
6
+
7
+ ## Code of Conduct
8
+
9
+ The Samvera Community is dedicated to providing a welcoming and positive
10
+ experience for all its members, whether they are at a formal gathering, in
11
+ a social setting, or taking part in activities online. Please see our
12
+ [Code of Conduct](CODE_OF_CONDUCT.md) for more information.
13
+
14
+ ## Samvera Community Intellectual Property Licensing and Ownership
15
+
16
+ All code contributors must have an Individual Contributor License Agreement
17
+ (iCLA) on file with the Samvera Steering Group. If the contributor works for
18
+ an institution, the institution must have a Corporate Contributor License
19
+ Agreement (cCLA) on file.
20
+
21
+ https://wiki.duraspace.org/display/samvera/Samvera+Community+Intellectual+Property+Licensing+and+Ownership
22
+
23
+ You should also add yourself to the `CONTRIBUTORS.md` file in the root of the project.
24
+
25
+ ## Contribution Tasks
26
+
27
+ * Reporting Issues
28
+ * Making Changes
29
+ * Documenting Code
30
+ * Committing Changes
31
+ * Submitting Changes
32
+ * Reviewing and Merging Changes
33
+
34
+ ### Reporting Issues
35
+
36
+ * Make sure you have a [GitHub account](https://github.com/signup/free)
37
+ * Submit a [Github issue](https://github.com/samvera/bixby/issues/) by:
38
+ * Clearly describing the issue
39
+ * Provide a descriptive summary
40
+ * Explain the expected behavior
41
+ * Explain the actual behavior
42
+ * Provide steps to reproduce the actual behavior
43
+
44
+ ### Making Changes
45
+
46
+ * Fork the repository on GitHub
47
+ * Create a topic branch from where you want to base your work.
48
+ * This is usually the master branch.
49
+ * To quickly create a topic branch based on master; `git branch fix/master/my_contribution master`
50
+ * Then checkout the new branch with `git checkout fix/master/my_contribution`.
51
+ * Please avoid working directly on the `master` branch.
52
+ * You may find the [hub suite of commands](https://github.com/defunkt/hub) helpful
53
+ * Make sure you have added sufficient tests and documentation for your changes.
54
+ * Test functionality with RSpec; Test features / UI with Capybara.
55
+ * Run _all_ the tests to assure nothing else was accidentally broken.
56
+
57
+ ### Documenting Code
58
+
59
+ * All new public methods, modules, and classes should include inline documentation in [YARD](http://yardoc.org/).
60
+ * Documentation should seek to answer the question "why does this code exist?"
61
+ * Document private / protected methods as desired.
62
+ * If you are working in a file with no prior documentation, do try to document as you gain understanding of the code.
63
+ * If you don't know exactly what a bit of code does, it is extra likely that it needs to be documented. Take a stab at it and ask for feedback in your pull request. You can use the 'blame' button on GitHub to identify the original developer of the code and @mention them in your comment.
64
+ * This work greatly increases the usability of the code base and supports the on-ramping of new committers.
65
+ * We will all be understanding of one another's time constraints in this area.
66
+ * [Getting started with YARD](http://www.rubydoc.info/gems/yard/file/docs/GettingStarted.md)
67
+
68
+ ### Committing changes
69
+
70
+ * Make commits of logical units.
71
+ * Check for unnecessary whitespace with `git diff --check` before committing.
72
+ * Make sure your commit messages are [well formed](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html).
73
+ * If you created an issue, you can close it by including "Closes #issue" in your commit message. See [Github's blog post for more details](https://github.com/blog/1386-closing-issues-via-commit-messages)
74
+
75
+ ```
76
+ Present tense short summary (50 characters or less)
77
+
78
+ More detailed description, if necessary. It should be wrapped to 72
79
+ characters. Try to be as descriptive as you can, even if you think that
80
+ the commit content is obvious, it may not be obvious to others. You
81
+ should add such description also if it's already present in bug tracker,
82
+ it should not be necessary to visit a webpage to check the history.
83
+
84
+ Include Closes #<issue-number> when relavent.
85
+
86
+ Description can have multiple paragraphs and you can use code examples
87
+ inside, just indent it with 4 spaces:
88
+
89
+ class PostsController
90
+ def index
91
+ respond_to do |wants|
92
+ wants.html { render 'index' }
93
+ end
94
+ end
95
+ end
96
+
97
+ You can also add bullet points:
98
+
99
+ - you can use dashes or asterisks
100
+
101
+ - also, try to indent next line of a point for readability, if it's too
102
+ long to fit in 72 characters
103
+ ```
104
+
105
+ * Make sure you have added the necessary tests for your changes.
106
+ * Run _all_ the tests to assure nothing else was accidentally broken.
107
+ * When you are ready to submit a pull request
108
+
109
+ ### Submitting Changes
110
+
111
+ * Read the article ["Using Pull Requests"](https://help.github.com/articles/using-pull-requests) on GitHub.
112
+ * Make sure your branch is up to date with its parent branch (i.e. master)
113
+ * `git checkout master`
114
+ * `git pull --rebase`
115
+ * `git checkout <your-branch>`
116
+ * `git rebase master`
117
+ * It is a good idea to run your tests again.
118
+ * If you've made more than one commit take a moment to consider whether squashing commits together would help improve their logical grouping.
119
+ * [Detailed Walkthrough of One Pull Request per Commit](http://ndlib.github.io/practices/one-commit-per-pull-request/)
120
+ * `git rebase --interactive master` ([See Github help](https://help.github.com/articles/interactive-rebase))
121
+ * Squashing your branch's changes into one commit is "good form" and helps the person merging your request to see everything that is going on.
122
+ * Push your changes to a topic branch in your fork of the repository.
123
+ * Submit a pull request from your fork to the project.
124
+
125
+ ### Reviewing and Merging Changes
126
+
127
+ We adopted [Github's Pull Request Review](https://help.github.com/articles/about-pull-request-reviews/) for our repositories.
128
+ Common checks that may occur in our repositories:
129
+
130
+ 1. Travis CI - where our automated tests are running
131
+ 2. Approval Required - Github enforces at least one person approve a pull request. Also, all reviewers that have chimed in must approve.
132
+
133
+ If one or more of the required checks failed (or are incomplete), the code should not be merged (and the UI will not allow it). If all of the checks have passed, then anyone on the project (including the pull request submitter) may merge the code.
134
+
135
+ *Example: Carolyn submits a pull request, Justin reviews the pull request and approves. However, Justin is still waiting on other checks (Travis CI is usually the culprit), so he does not merge the pull request. Eventually, all of the checks pass. At this point, Carolyn or anyone else may merge the pull request.*
136
+
137
+ #### Things to Consider When Reviewing
138
+
139
+ First, the person contributing the code is putting themselves out there. Be mindful of what you say in a review.
140
+
141
+ * Ask clarifying questions
142
+ * State your understanding and expectations
143
+ * Provide example code or alternate solutions, and explain why
144
+
145
+ This is your chance for a mentoring moment of another developer. Take time to give an honest and thorough review of what has changed. Things to consider:
146
+
147
+ * Does the commit message explain what is going on?
148
+ * Does the code changes have tests? _Not all changes need new tests, some changes are refactorings_
149
+ * Do new or changed methods, modules, and classes have documentation?
150
+ * Does the commit contain more than it should? Are two separate concerns being addressed in one commit?
151
+ * Does the description of the new/changed specs match your understanding of what the spec is doing?
152
+ * Did the Travis tests complete successfully?
153
+
154
+ If you are uncertain, bring other contributors into the conversation by assigning them as a reviewer.
155
+
156
+ # Additional Resources
157
+
158
+ * [General GitHub documentation](http://help.github.com/)
159
+ * [GitHub pull request documentation](https://help.github.com/articles/about-pull-requests/)
160
+ * [Pro Git](http://git-scm.com/book) is both a free and excellent book about Git.
161
+ * [A Git Config for Contributing](http://ndlib.github.io/practices/my-typical-per-project-git-config/)
data/Gemfile ADDED
@@ -0,0 +1,5 @@
1
+ # frozen_string_literal: true
2
+
3
+ source 'https://rubygems.org'
4
+
5
+ gemspec
data/README.md CHANGED
@@ -4,6 +4,7 @@ Bixby: I'd buy that for a dollar!
4
4
  [![Apache 2.0 License](http://img.shields.io/badge/APACHE2-license-blue.svg)](./LICENSE)
5
5
  [![Gem Version](https://badge.fury.io/rb/bixby.svg)](https://badge.fury.io/rb/bixby)
6
6
 
7
+
7
8
  <p align="left">
8
9
  <img src="https://raw.githubusercontent.com/curationexperts/hycop/master/logo/murphy.jpg" alt="Murphy Sketch"/>
9
10
  </p>
@@ -35,6 +36,18 @@ Our goal is to insulate downstream projects from breakage due to pre-1.0 version
35
36
 
36
37
  Bixby is available under [the Apache 2.0 license](LICENSE.md).
37
38
 
39
+ ## Releasing
40
+
41
+ 1. `bundle install`
42
+ 1. Increase the version number in `bixby.gemspec`
43
+ 1. Increase the same version number in `.github_changelog_generator`
44
+ 1. Update `CHANGELOG.md` by running this command:
45
+ ```
46
+ github_changelog_generator --user samvera-labs --project bixby --token YOUR_GITHUB_TOKEN_HERE
47
+ ```
48
+ 1. Commit these changes to the master branch
49
+ 1. Run `rake release`
50
+
38
51
  ## Acknowledgments
39
52
 
40
53
  This software has been developed by and is brought to you by the Samvera community. Learn more at the
data/Rakefile CHANGED
@@ -1 +1,3 @@
1
+ # frozen_string_literal: true
2
+
1
3
  require 'bundler/gem_tasks'
@@ -0,0 +1,5 @@
1
+ If you would like to report an issue, first search [the list of issues](https://github.com/samvera/bixby/issues/) to see if someone else has already reported it, and then feel free to [create a new issue](https://github.com/samvera/bixby/issues/new).
2
+
3
+ If you have questions or need help, please email [the Samvera community tech list](https://groups.google.com/forum/#!forum/samvera-tech) or stop by the #dev channel in [the Samvera community Slack team](https://wiki.duraspace.org/pages/viewpage.action?pageId=87460391#Getintouch!-Slack).
4
+
5
+ You can learn more about the various Samvera communication channels on the [Get in touch!](https://wiki.duraspace.org/pages/viewpage.action?pageId=87460391) wiki page.
@@ -1,6 +1,8 @@
1
+ # frozen_string_literal: true
2
+
1
3
  Gem::Specification.new do |spec|
2
4
  spec.authors = ['Tom Johnson']
3
- spec.email = ['tom@curationexperts.com']
5
+ spec.email = ['johnson.tom@gmail.com']
4
6
  spec.description = 'A Style Configuration for RuboCop'
5
7
  spec.summary = 'This is the recommended style configuration for use ' \
6
8
  'by Samvera Community projects.'
@@ -10,9 +12,13 @@ Gem::Specification.new do |spec|
10
12
  spec.name = 'bixby'
11
13
  spec.require_paths = ['lib']
12
14
 
13
- spec.version = '2.0.0-beta1'
15
+ spec.version = '3.0.0'
14
16
  spec.license = 'Apache-2.0'
15
17
 
16
- spec.add_dependency 'rubocop', '0.63.1'
17
- spec.add_dependency 'rubocop-rspec', '1.31.0'
18
+ spec.add_dependency 'rubocop', '0.85.1'
19
+ spec.add_dependency 'rubocop-performance'
20
+ spec.add_dependency 'rubocop-rails'
21
+ spec.add_dependency 'rubocop-rspec'
22
+
23
+ spec.add_development_dependency 'github_changelog_generator'
18
24
  end
@@ -1,5 +1,7 @@
1
+ require: rubocop-performance
2
+
1
3
  AllCops:
2
- TargetRubyVersion: 2.3
4
+ TargetRubyVersion: 2.6
3
5
  DisabledByDefault: true
4
6
  DisplayCopNames: true
5
7
  Exclude:
@@ -7,6 +9,7 @@ AllCops:
7
9
  - 'script/**/*'
8
10
  - 'tmp/**/*'
9
11
  - 'vendor/**/*'
12
+ - 'node_modules/**/*'
10
13
 
11
14
  inherit_from:
12
15
  - bixby_rails_enabled.yml
@@ -39,9 +42,6 @@ Style/BlockComments:
39
42
  Style/BlockDelimiters:
40
43
  Enabled: true
41
44
 
42
- Style/BracesAroundHashParameters:
43
- Enabled: true
44
-
45
45
  Style/CaseEquality:
46
46
  Enabled: true
47
47
 
@@ -280,9 +280,15 @@ Style/RedundantReturn:
280
280
  Style/RedundantSelf:
281
281
  Enabled: true
282
282
 
283
+ Style/RedundantSortBy:
284
+ Enabled: true
285
+
283
286
  Style/RescueModifier:
284
287
  Enabled: true
285
288
 
289
+ Style/Sample:
290
+ Enabled: true
291
+
286
292
  Style/SafeNavigation:
287
293
  Enabled: true
288
294
 
@@ -335,13 +341,13 @@ Style/TrivialAccessors:
335
341
  Style/UnlessElse:
336
342
  Enabled: true
337
343
 
338
- Style/UnneededCapitalW:
344
+ Style/RedundantCapitalW:
339
345
  Enabled: true
340
346
 
341
- Style/UnneededInterpolation:
347
+ Style/RedundantInterpolation:
342
348
  Enabled: true
343
349
 
344
- Style/UnneededPercentQ:
350
+ Style/RedundantPercentQ:
345
351
  Enabled: true
346
352
 
347
353
  Style/TrailingUnderscoreVariable:
@@ -365,13 +371,13 @@ Style/ZeroLengthPredicate:
365
371
 
366
372
  #################### Layout ###############################
367
373
 
368
- Layout/AlignArray:
374
+ Layout/ArrayAlignment:
369
375
  Enabled: true
370
376
 
371
- Layout/AlignHash:
377
+ Layout/HashAlignment:
372
378
  Enabled: true
373
379
 
374
- Layout/AlignParameters:
380
+ Layout/ParameterAlignment:
375
381
  Enabled: true
376
382
 
377
383
  Layout/BlockAlignment:
@@ -431,6 +437,9 @@ Layout/EndOfLine:
431
437
  Layout/ExtraSpacing:
432
438
  Enabled: true
433
439
 
440
+ Layout/IndentationStyle:
441
+ Enabled: true
442
+
434
443
  Layout/InitialIndentation:
435
444
  Enabled: true
436
445
 
@@ -441,18 +450,18 @@ Layout/IndentationConsistency:
441
450
  SupportedStyles:
442
451
  - normal
443
452
  - rails
444
- EnforcedStyle: rails
453
+ EnforcedStyle: normal
445
454
 
446
455
  Layout/IndentationWidth:
447
456
  Enabled: true
448
457
 
449
- Layout/IndentArray:
458
+ Layout/FirstArrayElementIndentation:
450
459
  Enabled: true
451
460
 
452
- Layout/IndentAssignment:
461
+ Layout/AssignmentIndentation:
453
462
  Enabled: true
454
463
 
455
- Layout/IndentHash:
464
+ Layout/FirstHashElementIndentation:
456
465
  Enabled: true
457
466
 
458
467
  Layout/SpaceInLambdaLiteral:
@@ -461,6 +470,12 @@ Layout/SpaceInLambdaLiteral:
461
470
  Layout/LeadingCommentSpace:
462
471
  Enabled: true
463
472
 
473
+ Layout/LineLength:
474
+ Enabled: true
475
+ Max: 200
476
+ Exclude:
477
+ - '**/*.gemspec'
478
+
464
479
  Layout/MultilineArrayBraceLayout:
465
480
  Enabled: true
466
481
 
@@ -554,10 +569,7 @@ Layout/SpaceInsideRangeLiteral:
554
569
  Layout/SpaceInsideStringInterpolation:
555
570
  Enabled: true
556
571
 
557
- Layout/Tab:
558
- Enabled: true
559
-
560
- Layout/TrailingBlankLines:
572
+ Layout/TrailingEmptyLines:
561
573
  Enabled: true
562
574
 
563
575
  Layout/TrailingWhitespace:
@@ -620,12 +632,6 @@ Metrics/ModuleLength:
620
632
  Metrics/CyclomaticComplexity:
621
633
  Enabled: true
622
634
 
623
- Metrics/LineLength:
624
- Enabled: true
625
- Max: 200
626
- Exclude:
627
- - '**/*.gemspec'
628
-
629
635
  Metrics/MethodLength:
630
636
  Enabled: true
631
637
  Max: 14
@@ -670,7 +676,7 @@ Lint/DuplicateCaseCondition:
670
676
  Lint/DuplicateMethods:
671
677
  Enabled: true
672
678
 
673
- Lint/DuplicatedKey:
679
+ Lint/DuplicateHashKey:
674
680
  Enabled: true
675
681
 
676
682
  Lint/EachWithObjectArgument:
@@ -692,9 +698,6 @@ Lint/EmptyInterpolation:
692
698
  Lint/EmptyWhen:
693
699
  Enabled: true
694
700
 
695
- Lint/EndInMethod:
696
- Enabled: true
697
-
698
701
  Lint/EnsureReturn:
699
702
  Enabled: true
700
703
 
@@ -707,7 +710,7 @@ Lint/FloatOutOfRange:
707
710
  Lint/FormatParameterMismatch:
708
711
  Enabled: true
709
712
 
710
- Lint/HandleExceptions:
713
+ Lint/SuppressedException:
711
714
  Enabled: true
712
715
 
713
716
  Lint/ImplicitStringConcatenation:
@@ -728,7 +731,7 @@ Lint/LiteralInInterpolation:
728
731
  Lint/Loop:
729
732
  Enabled: true
730
733
 
731
- Lint/MultipleCompare:
734
+ Lint/MultipleComparison:
732
735
  Enabled: true
733
736
 
734
737
  Lint/NestedMethodDefinition:
@@ -768,7 +771,7 @@ Lint/ShadowedException:
768
771
  Lint/ShadowingOuterLocalVariable:
769
772
  Enabled: true
770
773
 
771
- Lint/StringConversionInInterpolation:
774
+ Lint/RedundantStringCoercion:
772
775
  Enabled: true
773
776
 
774
777
  Lint/UnderscorePrefixedVariableName:
@@ -777,7 +780,7 @@ Lint/UnderscorePrefixedVariableName:
777
780
  Lint/UnifiedInteger:
778
781
  Enabled: true
779
782
 
780
- Lint/UnneededSplatExpansion:
783
+ Lint/RedundantSplatExpansion:
781
784
  Enabled: true
782
785
 
783
786
  Lint/UnusedBlockArgument:
@@ -821,8 +824,8 @@ Performance/Count:
821
824
  # This cop has known compatibility issues with `ActiveRecord` and other
822
825
  # frameworks. ActiveRecord's `count` ignores the block that is passed to it.
823
826
  # For more information, see the documentation in the cop itself.
824
- # If you understand the known risk, you can disable `SafeMode`.
825
- SafeMode: true
827
+ # If you understand the known risk, you can disable `SafeAutoCorrect`.
828
+ SafeAutoCorrect: true
826
829
  Enabled: true
827
830
 
828
831
  Performance/Detect:
@@ -830,7 +833,7 @@ Performance/Detect:
830
833
  # frameworks. `ActiveRecord` does not implement a `detect` method and `find`
831
834
  # has its own meaning. Correcting `ActiveRecord` methods with this cop
832
835
  # should be considered unsafe.
833
- SafeMode: true
836
+ SafeAutoCorrect: true
834
837
  Enabled: true
835
838
 
836
839
  Performance/DoubleStartEndWith:
@@ -854,9 +857,6 @@ Performance/FlatMap:
854
857
  # This can be dangerous since `flat_map` will only flatten 1 level, and
855
858
  # `flatten` without any parameters can flatten multiple levels.
856
859
 
857
- Performance/LstripRstrip:
858
- Enabled: true
859
-
860
860
  Performance/RangeInclude:
861
861
  Enabled: true
862
862
 
@@ -869,18 +869,12 @@ Performance/RedundantMatch:
869
869
  Performance/RedundantMerge:
870
870
  Enabled: true
871
871
 
872
- Performance/RedundantSortBy:
873
- Enabled: true
874
-
875
872
  Performance/RegexpMatch:
876
873
  Enabled: true
877
874
 
878
875
  Performance/ReverseEach:
879
876
  Enabled: true
880
877
 
881
- Performance/Sample:
882
- Enabled: true
883
-
884
878
  Performance/Size:
885
879
  Enabled: true
886
880
 
@@ -1,4 +1,6 @@
1
1
  ---
2
+ require: rubocop-rails
3
+
2
4
  Rails:
3
5
  Enabled: true
4
6
 
@@ -14,6 +16,12 @@ Rails/Delegate:
14
16
  Rails/DelegateAllowBlank:
15
17
  Enabled: true
16
18
 
19
+ # This one breaks things unexpectedly.
20
+ # E.g., it changes ISO_639.find_by_code(language_code) to ISO_639.find_by(code: language_code)
21
+ # which results in an error.
22
+ Rails/DynamicFindBy:
23
+ Enabled: false
24
+
17
25
  Rails/EnumUniqueness:
18
26
  Enabled: true
19
27
 
@@ -22,6 +30,7 @@ Rails/Exit:
22
30
 
23
31
  Rails/FilePath:
24
32
  Enabled: true
33
+ EnforcedStyle: arguments
25
34
 
26
35
  Rails/FindBy:
27
36
  Enabled: true
@@ -32,12 +41,21 @@ Rails/FindEach:
32
41
  Rails/HasAndBelongsToMany:
33
42
  Enabled: true
34
43
 
44
+ Rails/HelperInstanceVariable:
45
+ Enabled: false
46
+
35
47
  Rails/HttpPositionalArguments:
36
48
  Enabled: true
37
49
  Include:
38
50
  - 'spec/**/*'
39
51
  - 'test/**/*'
40
52
 
53
+ Rails/InverseOf:
54
+ Enabled: false
55
+
56
+ Rails/LexicallyScopedActionFilter:
57
+ Enabled: false
58
+
41
59
  Rails/NotNullColumn:
42
60
  Enabled: true
43
61
 
@@ -76,4 +94,3 @@ Rails/SkipsModelValidations:
76
94
 
77
95
  Rails/Validation:
78
96
  Enabled: true
79
-
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: bixby
3
3
  version: !ruby/object:Gem::Version
4
- version: 2.0.0.pre.beta1
4
+ version: 3.0.0
5
5
  platform: ruby
6
6
  authors:
7
7
  - Tom Johnson
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2019-02-14 00:00:00.000000000 Z
11
+ date: 2020-06-10 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: rubocop
@@ -16,39 +16,88 @@ dependencies:
16
16
  requirements:
17
17
  - - '='
18
18
  - !ruby/object:Gem::Version
19
- version: 0.63.1
19
+ version: 0.85.1
20
20
  type: :runtime
21
21
  prerelease: false
22
22
  version_requirements: !ruby/object:Gem::Requirement
23
23
  requirements:
24
24
  - - '='
25
25
  - !ruby/object:Gem::Version
26
- version: 0.63.1
26
+ version: 0.85.1
27
+ - !ruby/object:Gem::Dependency
28
+ name: rubocop-performance
29
+ requirement: !ruby/object:Gem::Requirement
30
+ requirements:
31
+ - - ">="
32
+ - !ruby/object:Gem::Version
33
+ version: '0'
34
+ type: :runtime
35
+ prerelease: false
36
+ version_requirements: !ruby/object:Gem::Requirement
37
+ requirements:
38
+ - - ">="
39
+ - !ruby/object:Gem::Version
40
+ version: '0'
41
+ - !ruby/object:Gem::Dependency
42
+ name: rubocop-rails
43
+ requirement: !ruby/object:Gem::Requirement
44
+ requirements:
45
+ - - ">="
46
+ - !ruby/object:Gem::Version
47
+ version: '0'
48
+ type: :runtime
49
+ prerelease: false
50
+ version_requirements: !ruby/object:Gem::Requirement
51
+ requirements:
52
+ - - ">="
53
+ - !ruby/object:Gem::Version
54
+ version: '0'
27
55
  - !ruby/object:Gem::Dependency
28
56
  name: rubocop-rspec
29
57
  requirement: !ruby/object:Gem::Requirement
30
58
  requirements:
31
- - - '='
59
+ - - ">="
32
60
  - !ruby/object:Gem::Version
33
- version: 1.31.0
61
+ version: '0'
34
62
  type: :runtime
35
63
  prerelease: false
36
64
  version_requirements: !ruby/object:Gem::Requirement
37
65
  requirements:
38
- - - '='
66
+ - - ">="
39
67
  - !ruby/object:Gem::Version
40
- version: 1.31.0
68
+ version: '0'
69
+ - !ruby/object:Gem::Dependency
70
+ name: github_changelog_generator
71
+ requirement: !ruby/object:Gem::Requirement
72
+ requirements:
73
+ - - ">="
74
+ - !ruby/object:Gem::Version
75
+ version: '0'
76
+ type: :development
77
+ prerelease: false
78
+ version_requirements: !ruby/object:Gem::Requirement
79
+ requirements:
80
+ - - ">="
81
+ - !ruby/object:Gem::Version
82
+ version: '0'
41
83
  description: A Style Configuration for RuboCop
42
84
  email:
43
- - tom@curationexperts.com
85
+ - johnson.tom@gmail.com
44
86
  executables: []
45
87
  extensions: []
46
88
  extra_rdoc_files: []
47
89
  files:
90
+ - ".circleci/config.yml"
91
+ - ".github_changelog_generator"
48
92
  - ".gitignore"
93
+ - CHANGELOG.md
94
+ - CODE_OF_CONDUCT.md
95
+ - CONTRIBUTING.md
96
+ - Gemfile
49
97
  - LICENSE
50
98
  - README.md
51
99
  - Rakefile
100
+ - SUPPORT.md
52
101
  - bixby.gemspec
53
102
  - bixby_default.yml
54
103
  - bixby_rails_enabled.yml
@@ -69,12 +118,11 @@ required_ruby_version: !ruby/object:Gem::Requirement
69
118
  version: '0'
70
119
  required_rubygems_version: !ruby/object:Gem::Requirement
71
120
  requirements:
72
- - - ">"
121
+ - - ">="
73
122
  - !ruby/object:Gem::Version
74
- version: 1.3.1
123
+ version: '0'
75
124
  requirements: []
76
- rubyforge_project:
77
- rubygems_version: 2.7.7
125
+ rubygems_version: 3.1.4
78
126
  signing_key:
79
127
  specification_version: 4
80
128
  summary: This is the recommended style configuration for use by Samvera Community