bittrex 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8dad1b17f535502441708ef65e4c5b83b7d8d6cb
-  data.tar.gz: 2d7a5d84190b5b8778a70164335e623181121a7e
+  metadata.gz: 62544601ad8147aab330ff85bd81e379005f5294
+  data.tar.gz: 836c1344730b59f7db4a34f22ba4e39abf4220ee
 SHA512:
-  metadata.gz: 7a1b15f16822ebd7e88d089c212f5d4562a7cbb04528b8cc15074008c0c83c91fab631b38a7adee526c4576958d8854cbbb5352fb646b8a2ff1fa95b8708ecfa
-  data.tar.gz: 1bfb9206a91e60559a5f8362400529a6999be713e7f6617270fe73f679e8b0bcc5539b5dfb7e799c1f5208fc243932da056a321cad6ecf3b97135b4727beec45
+  metadata.gz: d7d566fb25055c7e5d0de242333d7f5b0dc39369627af25a156f3ba4be621dbc488659961a295b86694bd44f518248601990cc0d89f57160426666a4729be386
+  data.tar.gz: 378601b6e8f2d7de06a104d9ed8cfb2fdace504175b94bd6ac553f109df162e94e3044b00941a89243c4a9954ee8ac8d3b6610a18a864be8d6c6644de1a7bd09

data/.ruby-version

@@ -1 +1,2 @@
-2.3.4
+2.4.2
+

data/lib/bittrex/deposit.rb

@@ -3,6 +3,7 @@ module Bittrex
     include Helpers
 
     attr_reader :id, :transaction_id, :address, :quantity, :currency, :confirmations, :executed_at
+    attr_reader :raw
 
     def initialize(attrs = {})
       @id = attrs['Id']
@@ -12,6 +13,7 @@ module Bittrex
       @currency = attrs['Currency']
       @confirmations = attrs['Confirmations']
       @executed_at = extract_timestamp(attrs['LastUpdated'])
+      @raw = attrs
     end
 
     def self.all

data/lib/bittrex/helpers.rb

@@ -1,8 +1,10 @@
+require 'date'
+
 module Bittrex
   module Helpers
     def extract_timestamp(value)
       return if value.nil? or value.strip.empty?
-      Time.parse value
+      DateTime.parse value
     end
   end
 end

data/lib/bittrex/summary.rb

@@ -3,19 +3,26 @@ module Bittrex
     include Helpers
 
     attr_reader :name, :high, :low, :volume, :last, :base_volume, :raw, :created_at
+    attr_reader :bid, :ask, :open_buy_orders, :open_sell_orders, :previous_day, :updated_at
 
     alias_method :vol, :volume
     alias_method :base_vol, :base_volume
 
     def initialize(attrs = {})
-      @name        = attrs['MarketName']
-      @high        = attrs['High']
-      @low         = attrs['Low']
-      @volume      = attrs['Volume']
-      @last        = attrs['Last']
-      @base_volume = attrs['BaseVolume']
-      @raw         = attrs
-      @created_at  = extract_timestamp(attrs['TimeStamp'])
+      @name             = attrs['MarketName']
+      @high             = attrs['High']
+      @low              = attrs['Low']
+      @volume           = attrs['Volume']
+      @last             = attrs['Last']
+      @base_volume      = attrs['BaseVolume']
+      @bid              = attrs['Bid']
+      @ask              = attrs['Ask']
+      @open_buy_orders  = attrs['OpenBuyOrders']
+      @open_sell_orders = attrs['OpenSellOrders']
+      @previous_day     = attrs['PrevDay']
+      @updated_at       = extract_timestamp(attrs['TimeStamp'])
+      @created_at       = extract_timestamp(attrs['Created'])
+      @raw              = attrs
     end
 
     def self.all

data/lib/bittrex/version.rb

@@ -1,3 +1,3 @@
 module Bittrex
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/fixtures/summary.json

@@ -9,7 +9,7 @@
   "Bid": 2.0E-7,
   "Ask": 2.3E-7,
   "OpenBuyOrders": 7,
-  "OpenSellOrders": 7,
+  "OpenSellOrders": 8,
   "PrevDay": 2.2E-7,
   "Created": "2014-03-01T21:00:00",
   "DisplayMarketName": null

data/spec/models/deposit_spec.rb

@@ -11,6 +11,6 @@ describe Bittrex::Deposit do
     it { should_assign_attribute(subject, :address, '17m3mcA3wo5kk637TgEysxxx2c89SDCRZDB') }
     it { should_assign_attribute(subject, :transaction_id, '416ba84218c178e7befbe22b23bf1123a23ec2bc68678586a27cebdxxxb6') }
     it { should_assign_attribute(subject, :confirmations, 2) }
-    it { should_assign_attribute(subject, :executed_at, Time.parse('2014-06-16T22:57:17.457')) }
+    it { should_assign_attribute(subject, :executed_at, DateTime.parse('2014-06-16T22:57:17.457')) }
   end
 end

data/spec/models/helper_spec.rb

@@ -0,0 +1,36 @@
+require 'spec_helper'
+
+describe Bittrex::Helpers do
+  include Bittrex::Helpers
+  describe '#extract_timestamp' do
+    context 'when the argument is empty' do
+      it 'returns nil' do
+        expect(extract_timestamp(nil)).to be(nil)
+    	end
+		end
+
+    context 'when the argument is an empty string' do
+      it 'returns nil' do
+        expect(extract_timestamp('')).to be(nil)
+      end
+    end
+
+    context 'when the argument is a string of spaces' do
+      it 'returns nil' do
+        expect(extract_timestamp('   ')).to be(nil)
+      end
+    end
+
+    context 'when the argument is datetime string' do
+      it 'returns a datetime object' do
+        expected_time_object = DateTime.now
+        time_string = expected_time_object.to_s
+        strftime_format = '%B %d, %Y %H %M %S'
+        expect(extract_timestamp(time_string).class).to eql(DateTime)
+        expect(
+                extract_timestamp(time_string).strftime(strftime_format)
+        ).to eql(expected_time_object.strftime(strftime_format))
+      end
+    end
+  end
+end

data/spec/models/market_spec.rb

@@ -12,6 +12,6 @@ describe Bittrex::Market do
     it { should_assign_attribute(subject, :base_name, 'Bitcoin') }
     it { should_assign_attribute(subject, :minimum_trade, 0.01) }
     it { should_assign_attribute(subject, :active, true) }
-    it { should_assign_attribute(subject, :created_at, Time.parse('2014-02-13T00:00:00')) }
+    it { should_assign_attribute(subject, :created_at, DateTime.parse('2014-02-13T00:00:00')) }
   end
 end

data/spec/models/order_spec.rb

@@ -17,7 +17,7 @@ describe Bittrex::Order do
       it { should_assign_attribute(subject, :price, 0.0) }
       it { should_assign_attribute(subject, :total, nil) }
       it { should_assign_attribute(subject, :fill, nil) }
-      it { should_assign_attribute(subject, :executed_at, Time.parse('2014-06-21T04:08:08.75')) }
+      it { should_assign_attribute(subject, :executed_at, DateTime.parse('2014-06-21T04:08:08.75')) }
       it { should_assign_attribute(subject, :opened_at, nil) }
       it { should_assign_attribute(subject, :closed_at, nil) }
     end
@@ -38,8 +38,8 @@ describe Bittrex::Order do
       it { should_assign_attribute(subject, :total, nil) }
       it { should_assign_attribute(subject, :fill, nil) }
       it { should_assign_attribute(subject, :executed_at, nil) }
-      it { should_assign_attribute(subject, :opened_at, Time.parse('2014-06-21T04:08:08.75')) }
-      it { should_assign_attribute(subject, :closed_at, Time.parse('2014-06-22T04:08:08.75')) }
+      it { should_assign_attribute(subject, :opened_at, DateTime.parse('2014-06-21T04:08:08.75')) }
+      it { should_assign_attribute(subject, :closed_at, DateTime.parse('2014-06-22T04:08:08.75')) }
     end
   end
 end

data/spec/models/summary_spec.rb

@@ -11,6 +11,12 @@ describe Bittrex::Summary do
     it { should_assign_attribute(subject, :volume, 1406611.43827056) }
     it { should_assign_attribute(subject, :last, 0.00000020) }
     it { should_assign_attribute(subject, :base_volume, 0.30179011) }
-    it { should_assign_attribute(subject, :created_at, Time.parse('2014-06-26T05:22:57.673')) }
+    it { should_assign_attribute(subject, :ask, 2.3e-07) }
+    it { should_assign_attribute(subject, :bid, 2.0e-07) }
+    it { should_assign_attribute(subject, :open_buy_orders, 7) }
+    it { should_assign_attribute(subject, :open_sell_orders, 8) }
+    it { should_assign_attribute(subject, :previous_day, 2.2e-07) }
+    it { should_assign_attribute(subject, :updated_at, DateTime.parse('2014-06-26T05:22:57.673')) }
+    it { should_assign_attribute(subject, :created_at, DateTime.parse('2014-03-01T21:00:00.000')) }
   end
 end

data/spec/models/withdrawal_spec.rb

@@ -15,6 +15,6 @@ describe Bittrex::Withdrawal do
     it { should_assign_attribute(subject, :invalid_address, false) }
     it { should_assign_attribute(subject, :transaction_cost, 0.0002) }
     it { should_assign_attribute(subject, :transaction_id, '0b34fc4xxx102d0f80efddafexxx6b77c6ce170100b2a579ab5b5f493a383392') }
-    it { should_assign_attribute(subject, :executed_at, Time.parse('2014-06-26T05:37:55.083')) }
+    it { should_assign_attribute(subject, :executed_at, DateTime.parse('2014-06-26T05:37:55.083')) }
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bittrex
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Matthew Werner
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-01 00:00:00.000000000 Z
+date: 2017-12-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday
@@ -163,6 +163,7 @@ files:
 - spec/models/configuration_spec.rb
 - spec/models/currency_spec.rb
 - spec/models/deposit_spec.rb
+- spec/models/helper_spec.rb
 - spec/models/market_spec.rb
 - spec/models/order_spec.rb
 - spec/models/quote_spec.rb
@@ -208,6 +209,7 @@ test_files:
 - spec/models/configuration_spec.rb
 - spec/models/currency_spec.rb
 - spec/models/deposit_spec.rb
+- spec/models/helper_spec.rb
 - spec/models/market_spec.rb
 - spec/models/order_spec.rb
 - spec/models/quote_spec.rb