bits_service_client 0.2.2.pre.3 → 0.2.2.pre.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 24438351abfc5c8ce8c9022bf2fb9b8d08506057
-  data.tar.gz: ba0a4f08f78a8eb0c3aeea205886aa3da1da8563
+  metadata.gz: 0afab030e8087f4633b60c3a2a9b425abec6fd75
+  data.tar.gz: 043730165351c7c7937a9dd995403157e16d8a52
 SHA512:
-  metadata.gz: 034f70674f93c16ef5fa8b5230f1fdad06cc539940b65cd8c50cd765e7655e37bf11121067d91370805645a2ea6ef453d6e2e11bb70b158a3d263cbec93c009b
-  data.tar.gz: ca5861d1afc2814da10ea289b8c2437a5b1f50b9703325d10611488fc8a881ece5991abbe7a008dbaa9a06c335f1b254264fdf56b0828b8939a36faffa8a0548
+  metadata.gz: 0d3139a75921c1a57c9205cca2f012f4d74006dad95cdbece06b60f7d6486459f00c647ee7288a894e99d218a2a8096d90f3fee77c88eb1cdfb9e58c6c148d50
+  data.tar.gz: f20904efc5f39267e1b402ac442e649eb1177d64e9f69f953e79ad7536dbc84543ac30e759d746249f087a7290fbbbf4abd2f3497eafa38f85b789ee35538108

data/.rubocop.yml

@@ -0,0 +1,159 @@
+AllCops:
+  TargetRubyVersion: 2.3
+  Include:
+    - '**/Gemfile'
+    - '**/Rakefile'
+    - '*.gemspec'
+  Exclude:
+    - vendor/**/*
+    - db/migrations/**/*
+
+Lint/AmbiguousRegexpLiteral:
+  Enabled: false
+
+Lint/HandleExceptions:
+  Enabled: true
+
+Lint/UnusedBlockArgument:
+  Enabled: false
+
+Lint/UnusedMethodArgument:
+  Enabled: false
+
+Metrics/AbcSize:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/CyclomaticComplexity:
+  Max: 12
+
+Metrics/LineLength:
+  Max: 180
+
+Metrics/MethodLength:
+  Max: 60
+
+Metrics/ModuleLength:
+  Enabled: false
+
+Metrics/ParameterLists:
+  Enabled: false
+
+Metrics/PerceivedComplexity:
+  Enabled: false
+
+Performance/Casecmp:
+  Enabled: false
+
+Performance/Sample:
+  Enabled: false
+
+Style/Alias:
+  EnforcedStyle: prefer_alias_method
+
+Style/AlignParameters:
+  Enabled: false
+
+Style/BlockDelimiters:
+  Enabled: false
+
+Style/BracesAroundHashParameters:
+  Enabled: false
+
+Style/ClassAndModuleChildren:
+  Enabled: false
+
+Style/ClosingParenthesisIndentation:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Style/DotPosition:
+  EnforcedStyle: trailing
+
+Style/DoubleNegation:
+  Enabled: false
+
+Style/EachWithObject:
+  Enabled: false
+
+Style/FormatString:
+  EnforcedStyle: sprintf
+
+Style/GuardClause:
+  Enabled: false
+
+Style/IfUnlessModifier:
+  Enabled: false
+
+Style/IndentArray:
+  EnforcedStyle: consistent
+
+Style/IndentHash:
+  Enabled: false
+
+Style/Lambda:
+  Enabled: false
+
+Style/MultilineBlockChain:
+  Enabled: false
+
+Style/MultilineBlockLayout:
+  Enabled: false
+
+Style/MultilineOperationIndentation:
+  Enabled: false
+
+Style/NegatedIf:
+  Enabled: false
+
+Style/Next:
+  Enabled: false
+
+Style/NumericLiterals:
+  Enabled: false
+
+Style/PredicateName:
+  Enabled: false
+
+Style/RaiseArgs:
+  EnforcedStyle: compact
+
+Style/RedundantSelf:
+  Enabled: false
+
+Style/RescueModifier:
+  Enabled: false
+
+Style/SignalException:
+  Enabled: false
+
+Style/SingleLineBlockParams:
+  Enabled: false
+
+Style/SpaceAroundEqualsInParameterDefault:
+  EnforcedStyle: no_space
+
+Style/StructInheritance:
+  Enabled: false
+
+Style/TrailingCommaInArguments:
+  Enabled: false
+
+Style/TrailingCommaInLiteral:
+  Enabled: false
+
+Style/TrailingUnderscoreVariable:
+  Enabled: false
+
+Style/TrivialAccessors:
+  Enabled: false
+
+Style/WordArray:
+  Enabled: false
+
+Style/ZeroLengthPredicate:
+  Enabled: false

data/Gemfile

@@ -1,2 +1,3 @@
+# frozen_string_literal: true
 source 'https://rubygems.org'
 gemspec

data/Guardfile

@@ -16,3 +16,8 @@ guard :rspec, cmd: 'bundle exec rspec' do
   watch(%r{^lib/bits_service_client/client.rb$}){|m| "spec/unit/bits_service_client/bits_service_client_spec.rb"}
   watch('spec/spec_helper.rb')  { 'spec' }
 end
+
+guard :rubocop do
+  watch(%r{.+\.rb$})
+  watch(%r{(?:.+/)?\.rubocop\.yml$}) { |m| File.dirname(m[0]) }
+end

data/README.md

@@ -4,9 +4,24 @@ Ruby client for [bits-service](https://github.com/cloudfoundry-incubator/bits-se
 
 # Changelog
 
+* 0.2.1:
+  - Update list of authors
+
 * 0.2.0:
   - Add `vcap_request_id` to `BitsService::Client` and `BitsService::ResourcePool`
   - Add `request_timeout_in_seconds` to `BitsService::ResourcePool`
   - Move unit tests from CloudController to this gem
 
 * 0.1.0: Initial version
+
+# Bump
+
+The gem is automatically built and published to [rubygems.org](https://rubygems.org/gems/bits_service_client) in the [flintstone](https://flintstone.ci.cf-app.com) CI pipeline.
+
+In order to release a new version of the gem, the following steps should be taken:
+
+1. Update the change log above
+1. Update [`version.rb`](lib/bits_service_client/version.rb) with the new version
+1. Check in the changes and push them to `origin`.
+
+The pipeline will pick up the changes and will, if `version.rb` has changed, tag the release in git and publish the new version of the gem.

data/Rakefile

@@ -1,6 +1,9 @@
+# frozen_string_literal: true
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
+require 'rubocop/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
+RuboCop::RakeTask.new
 
-task :default => :spec
+task default: ['rubocop:auto_correct', 'spec']

data/bits_service_client.gemspec

@@ -1,32 +1,36 @@
 # coding: utf-8
+# frozen_string_literal: true
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'bits_service_client/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "bits_service_client"
+  spec.name          = 'bits_service_client'
   spec.version       = BitsServiceClient::VERSION
   spec.authors       = ['Rizwan Reza', 'Steffen Uhlig', 'Peter Goetz']
-  spec.email         = ["rizwanreza@gmail.com", 'steffen.uhlig@de.ibm.com', 'peter.gtz@gmail.com']
+  spec.email         = ['rizwanreza@gmail.com', 'steffen.uhlig@de.ibm.com', 'peter.gtz@gmail.com']
 
-  spec.summary       = %q{Bits Services client for Cloud Foundry}
-  spec.homepage      = "http://github.com/cloudfoundry/bits_service_client"
+  spec.summary       = 'Bits Services client for Cloud Foundry'
+  spec.homepage      = 'https://github.com/cloudfoundry-incubator/bits-service-client'
 
   spec.files         = `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_dependency "steno"
-  spec.add_dependency "activesupport"
+  spec.add_dependency 'steno'
+  spec.add_dependency 'activesupport'
 
-  spec.add_development_dependency "bundler", "~> 1.11"
-  spec.add_development_dependency "rake", "~> 10.0"
-  spec.add_development_dependency "rspec", "~> 3.0"
-  spec.add_development_dependency "webmock", '= 1.20.4'
-  spec.add_development_dependency "multipart-post"
-  spec.add_development_dependency "rack-test"
-  spec.add_development_dependency "guard"
-  spec.add_development_dependency "guard-bundler"
-  spec.add_development_dependency "guard-rspec"
+  spec.add_development_dependency 'bundler', '~> 1.11'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'webmock', '= 1.20.4'
+  spec.add_development_dependency 'multipart-post'
+  spec.add_development_dependency 'rack-test'
+  spec.add_development_dependency 'guard'
+  spec.add_development_dependency 'guard-bundler'
+  spec.add_development_dependency 'guard-rspec'
   spec.add_development_dependency 'terminal-notifier-guard'
   spec.add_development_dependency 'terminal-notifier'
+  spec.add_development_dependency 'rb-readline'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'guard-rubocop'
 end

data/lib/bits_service_client/blob.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
 module BitsService
   class Blob
-    attr_reader :guid, :public_download_url, :internal_download_url
+    attr_reader :guid, :public_download_url, :internal_download_url, :public_upload_url
 
-    def initialize(guid:, public_download_url:, internal_download_url:)
+    def initialize(guid:, public_download_url:, internal_download_url:, public_upload_url:)
       @guid = guid
       @public_download_url = public_download_url
       @internal_download_url = internal_download_url
+      @public_upload_url = public_upload_url
     end
 
     def attributes(*_)

data/lib/bits_service_client/client.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 require 'active_support/inflector'
 require 'bits_service_client/logging_http_client'
 
@@ -44,6 +45,11 @@ module BitsService
       FileUtils.mkdir_p(File.dirname(destination_path))
       File.open(destination_path, 'wb') do |file|
         response = @private_http_client.get(resource_path(source_key), @vcap_request_id)
+
+        if response.code == '302'
+          response = Net::HTTP.get_response(URI(response['location']))
+        end
+
         validate_response_code!(200, response)
         file.write(response.body)
         file.chmod(mode) if mode
@@ -66,20 +72,31 @@ module BitsService
     end
 
     def blob(key)
-      response = @private_http_client.get('/sign' + resource_path(key), @vcap_request_id, {username: @username, password: @password})
-      validate_response_code!([200, 302], response)
-
-      response.tap do |response|
-        response.body = response['location'] if response.code.to_i == 302
-      end
-
       Blob.new(
         guid: key,
-        public_download_url: response.body,
+        public_download_url: signed_url(key),
+        public_upload_url: signed_url(key, verb: 'put'),
         internal_download_url: generate_private_url(key)
       )
     end
 
+    def signed_url(key, verb: nil)
+      query = if verb.nil?
+                ''
+              else
+                "?verb=#{verb}"
+              end
+
+      response = @private_http_client.get("/sign#{resource_path(key)}#{query}", @vcap_request_id, { username: @username, password: @password })
+      validate_response_code!([200, 302], response)
+
+      response.tap do |result|
+        result.body = result['location'] if result.code.to_i == 302
+      end
+
+      response.body
+    end
+
     def delete_blob(blob)
       delete(blob.guid)
     end

data/lib/bits_service_client/errors.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module BitsService
   module Errors
     class Error < StandardError; end

data/lib/bits_service_client/logging_http_client.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module BitsService
   class LoggingHttpClient
     def initialize(http_client)
@@ -40,6 +41,5 @@ module BitsService
         @logger.info('Response', { code: response.code, vcap_request_id: vcap_request_id })
       end
     end
-
   end
 end

data/lib/bits_service_client/resource_pool.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module BitsService
   class ResourcePool
     def initialize(endpoint:, request_timeout_in_seconds:, vcap_request_id: '')

data/lib/bits_service_client/version.rb

@@ -1,3 +1,4 @@
+# frozen_string_literal: true
 module BitsServiceClient
-  VERSION = '0.2.2.pre.3'
+  VERSION = '0.2.2.pre.4'
 end

data/lib/bits_service_client.rb

@@ -1,11 +1,12 @@
+# frozen_string_literal: true
 require 'json'
 require 'net/http/post/multipart'
 
-require "bits_service_client/version"
-require "bits_service_client/blob"
-require "bits_service_client/errors"
-require "bits_service_client/client"
-require "bits_service_client/resource_pool"
+require 'bits_service_client/version'
+require 'bits_service_client/blob'
+require 'bits_service_client/errors'
+require 'bits_service_client/client'
+require 'bits_service_client/resource_pool'
 
 module BitsService
   BlobstoreError = Class.new(StandardError)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bits_service_client
 version: !ruby/object:Gem::Version
-  version: 0.2.2.pre.3
+  version: 0.2.2.pre.4
 platform: ruby
 authors:
 - Rizwan Reza
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-11-21 00:00:00.000000000 Z
+date: 2016-12-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: steno
@@ -194,6 +194,48 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rb-readline
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: 
 email:
 - rizwanreza@gmail.com
@@ -205,6 +247,7 @@ extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - Gemfile
 - Guardfile
 - README.md
@@ -217,7 +260,7 @@ files:
 - lib/bits_service_client/logging_http_client.rb
 - lib/bits_service_client/resource_pool.rb
 - lib/bits_service_client/version.rb
-homepage: http://github.com/cloudfoundry/bits_service_client
+homepage: https://github.com/cloudfoundry-incubator/bits-service-client
 licenses: []
 metadata: {}
 post_install_message: