bitpay-sdk 2.4.1 → 2.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6a0b02cec388fe32a5afd21b0a9ad92340818107
-  data.tar.gz: d539b63ee8a0dca065562a5a5ebb6f539fb8d240
+  metadata.gz: 23d0eaf35772b8730fa1fa237052df27ac12c91c
+  data.tar.gz: 5d5c43a56d3302bf6e9b39826f6bd4c2eb28b57f
 SHA512:
-  metadata.gz: 4fd3cb6688d3ba5387fccdf67c0cd9f044e7e5fd8978147d3d024831f2dc657ae751afd961418bc3cbfa35992438281bbc624e961bb88b5455cb72e8f55f9769
-  data.tar.gz: ad97799266a00b43413ccb956296ce27121a55201e7d8d7fdff1a4d3bb5295c35898ca56a65145c143f329820df1a3e180f25ad414e3e821a421248feb74a753
+  metadata.gz: d98a7d9382a372c1724cf595297bc6212c46a5ad6d188c299cbf2e6831172a9a12d78a9ea4bcc8100910c8dc22b858c86590b6f7c0889a07ebceaa0812ea5091
+  data.tar.gz: 11d777f508beea52465341d1d4904d2c43a5d0cc8a39d8f5febf880d48c7fa7901d16b6a9f5f093b42f4356698d6910acffc1c7c829339097e4de3d36852ebbf

data/CHANGELOG.md

@@ -2,6 +2,10 @@
 All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [2.4.2] - 2015-03-11
+### Fixed
+- GitHub issue 39: handling post paths that include a ? and require a token. A workaround exists for this issue.
+
 ## [2.4.1] - 2015-03-11
 ### Fixed
 - GitHub issue 40: error for endpoints that did not return a 'data' field

data/lib/bitpay/rest_connector.rb

@@ -18,7 +18,8 @@ module BitPay
 
     def get(path:, token: nil, public: false)
       urlpath = '/' + path
-      urlpath = urlpath + '?token=' + token if token
+      token_prefix = if urlpath.include? '?' then '&token=' else '?token=' end
+      urlpath = urlpath + token_prefix + token if token
       request = Net::HTTP::Get.new urlpath
       unless public
         request['X-Signature'] = KeyUtils.sign(@uri.to_s + urlpath, @priv_key) 

data/lib/bitpay/version.rb

@@ -3,5 +3,5 @@
 # or https://github.com/bitpay/php-bitpay-client/blob/master/LICENSE
 
 module BitPay
-  VERSION = '2.4.1'
+  VERSION = '2.4.2'
 end

data/spec/client_spec.rb

@@ -61,6 +61,13 @@ describe BitPay::SDK::Client do
         bitpay_client.send_request("GET", "whatever", facade: "merchant")
         expect(WebMock).to have_requested(:get, "#{BitPay::TEST_API_URI}/whatever?token=MERCHANT_TOKEN") 
       end
+      
+      it 'should handle query parameters gracefully' do
+        stub_request(:get, /#{BitPay::TEST_API_URI}\/ledgers.*/).to_return(:body => '{"awesome": "json"}')
+        bitpay_client.send_request("GET", "ledgers/BTC?startDate=2015-01-01&endDate=2015-02-01", facade: "merchant")
+        expect(WebMock).to have_requested(:get, "#{BitPay::TEST_API_URI}/ledgers/BTC?startDate=2015-01-01&endDate=2015-02-01&token=MERCHANT_TOKEN")
+      end
+      
     end
 
     context "POST" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bitpay-sdk
 version: !ruby/object:Gem::Version
-  version: 2.4.1
+  version: 2.4.2
 platform: ruby
 authors:
 - Bitpay, Inc.
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-03-13 00:00:00.000000000 Z
+date: 2015-03-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: json
@@ -221,7 +221,6 @@ files:
 - LICENSE.md
 - README.md
 - Rakefile
-- bitpay-sdk-2.4.0.gem
 - bitpay-sdk.gemspec
 - config/capybara.rb
 - config/constants.rb