bitopro 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 400df4fabd57efac65d8ce91cf6b8b1f6f5175dfecd142e0639f7134cb83a466
-  data.tar.gz: '06871ef22a043496f61aac115ecdd869d2187749864cdd725c44e0a87f2554fb'
+  metadata.gz: 702e22156760e7587f16f08495dc420e32fe2ff085c153486c152ba6378e3e2e
+  data.tar.gz: '074962b5a5f02e99f9acd29d530d9f4ed742eb12795f54c39280fc833d8bba66'
 SHA512:
-  metadata.gz: a7a76aaf65109f2a8273c1234189c6fef9ab649e2e70d07bf25058622c4fb06a33d6046a29432a4b42f5bf7ef29a8ac6b916d7cfa50ef950e2d3eaf0355272f2
-  data.tar.gz: c2aab8d98acbf5b6ea015ec41596f6902c53dc57d5fbf47f7980a29c96869cef6c0858f5b2251bb8a5e8689b87a9a7fd803d07088df6b3f9b5988cc4ea1f7997
+  metadata.gz: 4ca8a92af4cf42936837c3713a6c8a27fdace328e242d27c9a6b6311017202573ad3d1e5157ca6a94517112d3d8f2368406c02cca4e8b87f91dbebe854d85ab7
+  data.tar.gz: df9a9757c3c53db3e536fa8d0ab30bca53d7334d2a095819282d68e4c0865b0d8ce01ad833cef7d0a0636deb1a6cc5df7ac8b28cc8307de26488874159550c8a

data/lib/bitopro/api/public.rb

@@ -1,14 +1,22 @@
 module Bitopro
   module Public
+    class Error < StandardError; end
+
     def order_book(currency_pair)
+      raise Error, "currency_pair is required" unless currency_pair
+
       get("/order-book/#{currency_pair}")
     end
 
-    def ticker(currency_pair)
-      get("/ticker/#{currency_pair}")
+    def tickers(currency_pair)
+      raise Error, "currency_pair is required" unless currency_pair
+
+      get("/tickers/#{currency_pair}")
     end
 
     def recent_trades(currency_pair)
+      raise Error, "currency_pair is required" unless currency_pair
+
       get("/trades/#{currency_pair}")
     end
   end

data/lib/bitopro/client.rb

@@ -4,7 +4,7 @@ require_relative './api/order'
 
 module Bitopro
   class Client
-    class BitoproSetupError < StandardError; end
+    class SetupError < StandardError; end
 
     BASE_URL = "https://api.bitopro.com/v2".freeze
 
@@ -23,7 +23,7 @@ module Bitopro
     end
 
     def authenticated_get(url, params = {})
-      raise BitoproSetupError, "Must be set configure before call authenticate action" unless Bitopro.configured?
+      raise SetupError, "Must be set configure before call authenticate action" unless Bitopro.configured?
 
       complete_url = build_url(url)
 
@@ -41,7 +41,7 @@ module Bitopro
     end
 
     def authenticated_post(url, params = {})
-      raise BitoproSetupError, "Must be set configure before call authenticate action" unless Bitopro.configured?
+      raise SetupError, "Must be set configure before call authenticate action" unless Bitopro.configured?
 
       complete_url = build_url(url)
 

data/lib/bitopro/version.rb

@@ -1,3 +1,3 @@
 module Bitopro
-  VERSION = "1.0.0".freeze
+  VERSION = "1.0.1".freeze
 end

data/spec/bitopro/client_spec.rb

@@ -0,0 +1,72 @@
+require "spec_helper"
+
+RSpec.describe Bitopro::Client do
+  describe "#order_book" do
+    subject { Bitopro::Client.new.order_book(currency_pair) }
+
+    context "when currency pair is empty" do
+      let(:currency_pair) { nil }
+
+      it { is_expected_block.to raise_error Bitopro::Public::Error }
+    end
+
+    context "when api succeeds" do
+      let(:currency_pair) { "btc_twd" }
+      let!(:request_stub) do
+        stub_request(:get, "#{Bitopro::BASE_URL}/order-book/#{currency_pair}")
+          .to_return(status: 200, body: json_fixture('order-book'))
+      end
+
+      it "return parsed json order book" do
+        subject
+        expect(request_stub).to have_been_requested
+      end
+    end
+  end
+
+  describe "#ticker" do
+    subject { Bitopro::Client.new.ticker(currency_pair) }
+
+    context "when currency pair is empty" do
+      let(:currency_pair) { nil }
+
+      it { is_expected_block.to raise_error Bitopro::Public::Error }
+    end
+
+    context "when api succeeds" do
+      let(:currency_pair) { "btc_twd" }
+      let!(:request_stub) do
+        stub_request(:get, "#{Bitopro::BASE_URL}/ticker/#{currency_pair}")
+          .to_return(status: 200, body: json_fixture('ticker'))
+      end
+
+      it "return parsed json order book" do
+        subject
+        expect(request_stub).to have_been_requested
+      end
+    end
+  end
+
+  describe "#recent_trades" do
+    subject { Bitopro::Client.new.recent_trades(currency_pair) }
+
+    context "when currency pair is empty" do
+      let(:currency_pair) { nil }
+
+      it { is_expected_block.to raise_error Bitopro::Public::Error }
+    end
+
+    context "when api succeeds" do
+      let(:currency_pair) { "btc_twd" }
+      let!(:request_stub) do
+        stub_request(:get, "#{Bitopro::BASE_URL}/trades/#{currency_pair}")
+          .to_return(status: 200, body: json_fixture('recent_trades'))
+      end
+
+      it "return parsed json order book" do
+        subject
+        expect(request_stub).to have_been_requested
+      end
+    end
+  end
+end

data/spec/bitopro/config_spec.rb

@@ -0,0 +1,21 @@
+require "spec_helper"
+
+RSpec.describe Bitopro::Config do
+  describe ".configure" do
+    before do
+      described_class.instance = described_class.new
+    end
+
+    it "makes Bitopro configured" do
+      expect(Bitopro).not_to be_configured
+
+      Bitopro.configure do |config|
+        config.email = "bitopro@ruby.rspec"
+        config.key = "1"
+        config.secret = "2"
+      end
+
+      expect(Bitopro).to be_configured
+    end
+  end
+end

data/spec/bitopro/version_spec.rb

@@ -0,0 +1,7 @@
+require "spec_helper"
+
+RSpec.describe Bitopro do
+  it "has a version number" do
+    expect(described_class::VERSION).not_to be nil
+  end
+end

data/spec/fixtures/recent_trades.json

@@ -0,0 +1,16 @@
+{
+  "data": [
+    {
+      "amount": "0.11000000",
+      "isBuyer": false,
+      "price": "126709.00000000",
+      "timestamp": 1551753875
+    },
+    {
+      "amount": "0.10000000",
+      "isBuyer": false,
+      "price": "126787.00000000",
+      "timestamp": 1551753796
+    }
+  ]
+}

data/spec/fixtures/ticker.json

@@ -0,0 +1,7 @@
+{
+  "high": "7000",
+  "lastPrice": "7000",
+  "low": "6000",
+  "timestamp": 1508753757000,
+  "volume": "16.7"
+}

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bitopro
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - niclin
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-04-18 00:00:00.000000000 Z
+date: 2019-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -108,8 +108,12 @@ files:
 - lib/bitopro/client.rb
 - lib/bitopro/config.rb
 - lib/bitopro/version.rb
-- spec/bitopro/api_spec.rb
+- spec/bitopro/client_spec.rb
+- spec/bitopro/config_spec.rb
+- spec/bitopro/version_spec.rb
 - spec/fixtures/order-book.json
+- spec/fixtures/recent_trades.json
+- spec/fixtures/ticker.json
 - spec/spec_helper.rb
 - spec/support/rspec_helpers.rb
 homepage: https://github.com/niclin/bitopro
@@ -137,9 +141,13 @@ rubyforge_project:
 rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
-summary: bitopro-1.0.0
+summary: bitopro-1.0.1
 test_files:
 - spec/spec_helper.rb
-- spec/bitopro/api_spec.rb
+- spec/bitopro/config_spec.rb
+- spec/bitopro/client_spec.rb
+- spec/bitopro/version_spec.rb
 - spec/support/rspec_helpers.rb
+- spec/fixtures/ticker.json
 - spec/fixtures/order-book.json
+- spec/fixtures/recent_trades.json

data/spec/bitopro/api_spec.rb

@@ -1,51 +0,0 @@
-require "spec_helper"
-
-RSpec.describe Bitopro do
-  it "has a version number" do
-    expect(Bitopro::VERSION).not_to be nil
-  end
-
-  describe ".configure" do
-    before do
-      Bitopro::Config.instance = Bitopro::Config.new
-    end
-
-    it "makes Bitopro configured" do
-      expect(described_class).not_to be_configured
-
-      described_class.configure do |config|
-        config.email = "bitopro@ruby.rspec"
-        config.key = "1"
-        config.secret = "2"
-      end
-
-      expect(described_class).to be_configured
-    end
-  end
-
-  describe "#order_book" do
-    let(:currency_pair) { "btc_twd" }
-
-    subject { Bitopro::Client.new.order_book(currency_pair) }
-
-    context "when currency pair is empty" do
-
-    end
-
-    context "when api responds with error" do
-
-    end
-
-    context "when api succeeds" do
-      let!(:request_stub) do
-        stub_request(:get, "#{Bitopro::BASE_URL}/order-book/#{currency_pair}")
-          .to_return(status: 200, body: json_fixture('order-book'))
-      end
-
-      it "return parsed json order book" do
-        subject
-        expect(request_stub).to have_been_requested
-      end
-    end
-  end
-end