bitfinex-rb 0.0.5 → 0.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 685070e19c5fd5d873dfdbf4e913af07afca0dd2
-  data.tar.gz: 025b79fb12c285d334a4a78a1bb6f88815f187a5
+  metadata.gz: 20394641fe58898e7fa5501718f59ecec7e5a431
+  data.tar.gz: 49a23548584876b2b6d6970c1ce5336b9beb6648
 SHA512:
-  metadata.gz: 0b739604627de5dffc0210404db6dfa51c28ce37aaaa0c6355ee4c1e58ac72f163272c01eda225e664e5d825c7225755eb5677a9c4f084c1480a39a926438b7d
-  data.tar.gz: c67934b085c0c5d157e7a541510f03c5d1c04e37e16d52e5f400d6cc936cbe12defe79102ebf53bc44b3feb59f234cfdceff7b1d54f9053bdd017e192bcfdbfa
+  metadata.gz: 7f5e35855f8157c774498ab745ed8742371ace95c55bbbbb72733c6a846128fca0837aaee8020bf2306f91d59948c0540d41ce39e6f47bcf2c8b4211e0e00611
+  data.tar.gz: 340a63e8b1b9140b5d209dcadff434bbfc9c2f4cb604f3923305951dd5c61563841c6a334e890fa4592273fb3b27603b18f9d476f747de2c4caf591f393b4427

data/lib/bitfinex/connection.rb

@@ -32,7 +32,7 @@ module Bitfinex
 
     def new_rest_connection
       Faraday.new(url: base_api_endpoint) do |conn|
-        conn.use Faraday::Response::RaiseError
+        conn.use Bitfinex::CustomErrors
         conn.response :logger, Logger.new(STDOUT) , bodies: true  if config.debug_connection
         conn.use FaradayMiddleware::ParseJson, :content_type => /\bjson$/
         conn.adapter :net_http

data/lib/bitfinex/errors.rb

@@ -1,6 +1,33 @@
+require 'faraday'
+
 module Bitfinex
   class ClientError < Exception; end
   class ParamsError < ClientError; end
   class InvalidAuthKeyError < ClientError; end
   class BlockMissingError < ParamsError; end
+  class ServerError < Exception; end # Error reported back by Binfinex server
+  class BadRequestError < ServerError; end
+  class NotFoundError < ServerError; end
+  class ForbiddenError < ServerError; end
+  class UnauthorizedError < ServerError; end
+  class InternalServerError < ServerError; end
+
+  class CustomErrors < Faraday::Response::Middleware
+    def on_complete(env)
+      case env[:status]
+      when 400
+        raise BadRequestError, env.body['message']
+      when 401
+        raise UnauthorizedError
+      when 403
+        raise ForbiddenError
+      when 404
+        raise NotFoundError
+      when 500
+        raise InternalServerError
+      else
+        super
+      end
+    end
+  end
 end

data/lib/bitfinex/funding_book.rb

@@ -11,7 +11,7 @@ module Bitfinex
     #   client.funding_book
     def funding_book(currency="usd", params = {})
       check_params(params, %i{limit_bids limit_asks})
-      get("lendbook/#{currency}", params).body
+      get("lendbook/#{currency}", params: params).body
     end
 
   end

data/lib/bitfinex/lends.rb

@@ -11,7 +11,7 @@ module Bitfinex
     #   client.lends
     def lends(currency = "usd", params = {})
       check_params(params, %i{timestamp limit_lends})
-      get("lends/#{currency}", params).body
+      get("lends/#{currency}", params: params).body
     end
 
   end

data/lib/bitfinex/orderbook.rb

@@ -1,3 +1,4 @@
+# coding: utf-8
 module Bitfinex
   module OrderbookClient
 
@@ -12,7 +13,7 @@ module Bitfinex
     #   client.orderbook("btcusd")
     def orderbook(symbol="btcusd", params = {})
       check_params(params, %i{limit_bids limit_asks group})
-      get("book/#{symbol}",params).body
+      get("book/#{symbol}", params: params).body
     end
 
 

data/lib/bitfinex/orders.rb

@@ -19,7 +19,7 @@ module Bitfinex
       check_params(params, %i{is_hidden is_postonly ocoorder buy_price_oco})
 
       # for 'market' order, we need to pass a random positive price, not nil
-      price ||= 0.00001 if type == "market" || type == "exchange market"
+      price ||= 0.001 if type == "market" || type == "exchange market"
 
       params.merge!({
         symbol: symbol,
@@ -29,7 +29,6 @@ module Bitfinex
         exchange: 'bitfinex',
         price: price.to_s
       })
-
       authenticated_post("order/new", params: params).body
     end
 

data/lib/bitfinex/version.rb

@@ -1,3 +1,3 @@
 module Bitfinex
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/lib/bitfinex/wallet.rb

@@ -35,10 +35,10 @@ module Bitfinex
     #   client.transfer(10, 'btc', "exchange", "deposit")
     def transfer(amount, currency, wallet_from, wallet_to)
       params = {
-        amount: amount,
-        currency: currency,
-        wallet_from: wallet_from,
-        wallet_to: wallet_to
+        amount: amount.to_s,
+        currency: currency.upcase,
+        walletfrom: wallet_from.downcase,
+        walletto: wallet_to.downcase
       }
       authenticated_post("transfer", params: params).body
     end
@@ -71,8 +71,8 @@ module Bitfinex
     def withdraw(withdraw_type, walletselected, amount, params={})
       params.merge!({
         withdraw_type: withdraw_type,
-        walletselected: walletselected,
-        amount: amount})
+        walletselected: walletselected.downcase,
+        amount: amount.to_s})
 
       authenticated_post("withdraw", params: params).body
     end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bitfinex-rb
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
 platform: ruby
 authors:
 - Bitfinex
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-03-17 00:00:00.000000000 Z
+date: 2016-04-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday