bitfields 0.10.0 → 0.11.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e8b9ea867dfd7ea37a4ad699397315239dce854
-  data.tar.gz: f4263c4fe4dfc049937899bac0bf3c84082ab6ee
+  metadata.gz: dc824cf59452e64b1e34422e7416920dd725ea7d
+  data.tar.gz: 78a184dd4eda1d311ef1246f089babc00711a22b
 SHA512:
-  metadata.gz: fde65c3f487dc300d4b872b84f8d060698e56b19a46e239ba5982133958390cdf1c2128a2fef999978f9878778f4c1439c3ac6adf4d9d95dfa8c5d30b211269f
-  data.tar.gz: ed44379c4755e78d2481073960c2943f0954d4285fc4aad1f8ff6a48e4d377104e7522fef50219779e4dd1d7ddee41bb6599c9d9dbbd986dfd261ca839585eea
+  metadata.gz: 1e3d053623af2a5c60eb9d1818849d72b9e1d66801d2c9bb07fa12a63462770614f3a87e7b802470ca5cfd7609a0aab167d5fa2b3032c2477bdc7c48c86653ae
+  data.tar.gz: c45ced97d18462bf25ddfa2b4221b26e69ea1b75f293c6b200c457a415697c144f14d0c00e72dd781a24214f5e3b7e16236397103a8329a482a6a75eb4219726

data/Readme.md

@@ -15,6 +15,9 @@ user.my_bits # => 3
 
  - records bitfield_changes `user.bitfield_changes # => {"seller" => [false, true], "insane" => [false, true]}` (also `seller_was` / `seller_change` / `seller_changed?` / `seller_became_true?` / `seller_became_false?`)
    - Individual added methods (i.e, `seller_was`, `seller_changed?`, etc..) can be deactivated with `bitfield ..., added_instance_methods: false`
+   - **Note**: ActiveRecord 5.2 changes the behavior of `_was` and `_changed?` methods when used in the context of an `after_save` callback.
+     - ActiveRecord 5.1 will use the use the values that were _just_ changed.
+     - ActiveRecord 5.2, however, will return `nil` for `_was` and `false` for `_changed?` since the previous changes have been persisted.
  - adds scopes `User.seller.sensible.first` (deactivate with `bitfield ..., scopes: false`)
  - builds sql `User.bitfield_sql(insane: true, sensible: false) # => '(users.my_bits & 6) = 1'`
  - builds sql with OR condition `User.bitfield_sql({ insane: true, sensible: true }, query_mode: :bit_operator_or) # => '(users.my_bits & 2) = 2 OR (users.bits & 4) = 4'`
@@ -22,6 +25,18 @@ user.my_bits # => 3
  - builds update sql `User.set_bitfield_sql(insane: true, sensible: false) == 'my_bits = (my_bits | 6) - 4'`
  - **faster sql than any other bitfield lib** through combination of multiple bits into a single sql statement
  - gives access to bits `User.bitfields[:my_bits][:sensible] # => 4`
+ - [`ActiveRecord::AttributeMethods::Dirty`](https://api.rubyonrails.org/v5.1.7/classes/ActiveRecord/AttributeMethods/Dirty.html) and [`ActiveModel::Dirty`](https://api.rubyonrails.org/v5.1.7/classes/ActiveModel/Dirty.html) methods can be used on each bitfield:
+ ```ruby
+    user = User.new(seller: false)
+    user.seller = true
+    user.will_save_change_to_seller? # => true
+    user.seller_change_to_be_saved # => [false, true]
+
+    user.save
+
+    user.seller_before_last_save # => false
+    user.saved_change_to_seller # => [false, true]
+ ```
 
 Install
 =======
@@ -50,7 +65,7 @@ User.seller.not_sensible.update_all(User.set_bitfield_sql(seller: true, insane:
 Delete the shop when a user is no longer a seller
 
 ```ruby
-before_save :delete_shop, if: -> { |u| u.seller_change == [true, false]}
+before_save :delete_shop, if: -> { |u| u.seller_change == [true, false] }
 ```
 
 List fields and their respective values
@@ -104,6 +119,7 @@ Authors
  - [Justin Aiken](https://github.com/JustinAiken)
  - [szTheory](https://github.com/szTheory)
  - [Reed G. Law](https://github.com/reedlaw)
+ - [Rael Gugelmin Cunha](https://github.com/reedlaw)
 
 [Michael Grosser](http://grosser.it)<br/>
 michael@grosser.it<br/>

data/lib/bitfields.rb

@@ -82,22 +82,19 @@ module Bitfields
     def add_bitfield_methods(column, options)
       bitfields[column].keys.each do |bit_name|
         if options[:added_instance_methods] != false
+          attribute bit_name, :boolean, default: false
+
           define_method(bit_name) { bitfield_value(bit_name) }
           define_method("#{bit_name}?") { bitfield_value(bit_name) }
-          define_method("#{bit_name}=") { |value| set_bitfield_value(bit_name, value) }
-          define_method("#{bit_name}_was") { bitfield_value_was(bit_name) }
-          define_method("#{bit_name}_changed?") { bitfield_value_was(bit_name) != bitfield_value(bit_name) }
-          define_method("#{bit_name}_change") do
-            values = [bitfield_value_was(bit_name), bitfield_value(bit_name)]
-            values unless values[0] == values[1]
-          end
+          define_method("#{bit_name}=") { |value| super(value); set_bitfield_value(bit_name, value) }
+
           define_method("#{bit_name}_became_true?") do
             value = bitfield_value(bit_name)
-            value && bitfield_value_was(bit_name) != value
+            value && send("#{bit_name}_was") != value
           end
           define_method("#{bit_name}_became_false?") do
             value = bitfield_value(bit_name)
-            !value && bitfield_value_was(bit_name) != value
+            !value && send("#{bit_name}_was") != value
           end
         end
 

data/lib/bitfields/version.rb

@@ -1,3 +1,3 @@
 module Bitfields
-  Version = VERSION = "0.10.0"
+  Version = VERSION = "0.11.0"
 end

metadata

@@ -1,31 +1,31 @@
 --- !ruby/object:Gem::Specification
 name: bitfields
 version: !ruby/object:Gem::Version
-  version: 0.10.0
+  version: 0.11.0
 platform: ruby
 authors:
 - Michael Grosser
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-07 00:00:00.000000000 Z
+date: 2019-09-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: wwtd
+  name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: '5.1'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '5.1'
 - !ruby/object:Gem::Dependency
-  name: activerecord
+  name: wwtd
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="