bitcoiner 0.1.1 → 0.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3b537b4529a94f5eb6743a974cbbf5bf66fc77f71947af5d8b30079d316ed42a
-  data.tar.gz: c89ce942d0a5fb9072d3656531469b2dbbb018fe30bf3ed69a1d3b9bbc62d5f6
+  metadata.gz: ad08d3e5bdd0f0c8efe3e233bf08d0dd3ec4237b68766d0a1b08965cd24aff79
+  data.tar.gz: 5f66ea4a949376c7c1075bbd00b7de454cef939cc90961125ccb54bd5f106b7d
 SHA512:
-  metadata.gz: 1e14efc063187082d4c0f006d9773bfad5512b4602151351dc6db3c2e8bcf9e502c6ca50c1e19ad2f24835c07d537165246310a139b4fbb64f569abe0670ba0a
-  data.tar.gz: 0d74484270504eaf800db13ba09abe9fb545062ffc4b03a5895eaf220e3baff73e4e2d72f25e76b861e5b5961feee5a538c244b820d4cdd99455cc5382debad6
+  metadata.gz: 288fb5283f7b5d8b2f5c2812578cef7fdf8f368e146e3652bb2e7dc620208d75a83d2056a389ef1865b46d54faa1524352ccfa7c94c58140aa7b22d9b69ec57d
+  data.tar.gz: 637cdfc9dd689f257cc4690cb753789cdb807d3a9dd4272ab7b2e79394eac7bf8aa7ae9910ad80fd2d1f07d67cad5fba4a501d8eae7dce51e6dc1d3cbd6d2556

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rake/testtask'
 

data/bitcoiner.gemspec

@@ -1,4 +1,6 @@
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'bitcoiner/version'
 
@@ -17,6 +19,7 @@ Gem::Specification.new do |spec|
   end
   spec.require_paths = ['lib']
 
+  spec.add_dependency 'addressable'
   spec.add_dependency 'typhoeus', '~> 1.3.0'
 
   spec.add_development_dependency 'bundler', '~> 1.16'

data/lib/bitcoiner.rb

@@ -1,6 +1,9 @@
+# frozen_string_literal: true
+
 require 'bitcoiner/version'
 require 'typhoeus'
 require 'json'
+require 'addressable'
 
 %w[client account account_hash transaction].each do |f|
   require File.join(File.dirname(__FILE__), 'bitcoiner', f)

data/lib/bitcoiner/account.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Bitcoiner
   class Account
     attr_accessor :name

data/lib/bitcoiner/account_hash.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Bitcoiner
   class AccountHash < Hash
     def initialize(client, balance_hash)

data/lib/bitcoiner/client.rb

@@ -1,7 +1,14 @@
+# frozen_string_literal: true
+
 module Bitcoiner
   class Client
-    def initialize(user, pass, host = '127.0.0.1:8332')
-      @endpoint = "http://#{user}:#{pass}@#{host}"
+    attr_accessor :endpoint
+
+    def initialize(user, pass, host)
+      uri = Addressable::URI.heuristic_parse(host)
+      uri.user ||= user
+      uri.password ||= pass
+      self.endpoint = uri.to_s
     end
 
     def balance
@@ -15,16 +22,29 @@ module Bitcoiner
 
     def request(method, *args)
       post_body = { 'method' => method, 'params' => args, 'id' => 'jsonrpc' }.to_json
-      response = Typhoeus.post(@endpoint, body: post_body)
-      response_hash = JSON.parse response.body
+      response = Typhoeus.post(endpoint, body: post_body)
+      response_hash = parse_body(response)
       raise JSONRPCError, response_hash['error'] if response_hash['error']
       response_hash['result']
     end
 
     def inspect
-      "#<Bitcoiner::Client #{@endpoint.inspect} >"
+      "#<Bitcoiner::Client #{endpoint.inspect} >"
     end
 
     class JSONRPCError < RuntimeError; end
+
+    private
+
+    def parse_body(response)
+      if response.success?
+        JSON.parse(response.body)
+      else
+        error_message = %i[code return_code].map do |attr|
+          "#{attr}: `#{response.send(attr)}`"
+        end.join(', ')
+        raise JSONRPCError, "unsuccessful response; #{error_message}"
+      end
+    end
   end
 end

data/lib/bitcoiner/transaction.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Bitcoiner
   class Transaction
     attr_accessor :id, :account
@@ -14,7 +16,7 @@ module Bitcoiner
 
     def inspect
       "#<Bitcoiner::Transaction #{id} #{amount} to #{account.name} at #{time}>"
-    rescue
+    rescue StandardError
       "#<Bitcoiner::Transaction #{id} UNCONFIRMED>"
     end
 
@@ -23,7 +25,9 @@ module Bitcoiner
     end
 
     def confirmations
-      detail_hash['confirmations'] rescue 0
+      detail_hash['confirmations']
+    rescue StandardError
+      0
     end
 
     def time

data/lib/bitcoiner/version.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Bitcoiner
-  VERSION = '0.1.1'.freeze
+  VERSION = '0.1.2'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bitcoiner
 version: !ruby/object:Gem::Version
-  version: 0.1.1
+  version: 0.1.2
 platform: ruby
 authors:
 - Bryce Kerley
@@ -9,8 +9,22 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-02-05 00:00:00.000000000 Z
+date: 2018-04-17 00:00:00.000000000 Z
 dependencies:
+- !ruby/object:Gem::Dependency
+  name: addressable
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: typhoeus
   requirement: !ruby/object:Gem::Requirement