bitcoinaverage 0.0.1 → 0.0.2

data/.gitignore

@@ -1,5 +1,8 @@
 Gemfile.lock
+coverage
 coverage/*
+/coverage/
+coverage.data
 log/*
 *.gem
 mysession

data/.travis.yml

@@ -2,5 +2,5 @@ bundler_args: --without development
 language: ruby
 rvm:
   - 1.9.3-p374
-  - 2.0.0-rc1
+  - 2.0.0-p353
   - 2.1.0

data/Gemfile

@@ -1,8 +1,10 @@
 # A sample Gemfile
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
+gem 'rake'
 gem 'httparty'
 gem 'json'
+
 group :development do
   gem 'pry'
   gem 'pry-nav'
@@ -10,7 +12,7 @@ end
 
 group :test do
   gem 'rspec', '>= 2.14'
-  gem 'coveralls', require: false
+  gem 'coveralls', :require => false
   gem 'webmock'
   gem 'simplecov'
 end

data/README.md

@@ -1,15 +1,13 @@
 # Ruby wrapper for the BitcoinAverage API
 
-[![Gem Version]][gem]
+[![Gem Version](https://badge.fury.io/rb/bitcoinaverage.png)](http://badge.fury.io/rb/bitcoinaverage)
 [![Coverage Status](https://coveralls.io/repos/git-toni/bitcoinaverage/badge.png)](https://coveralls.io/r/git-toni/bitcoinaverage)
-[gem]: https://rubygems.org/gems/bitcoinaverage
-[travis]: https://github.com/git-toni/bitcoinaverage
+[![Build Status](https://travis-ci.org/git-toni/bitcoinaverage.png?branch=master)](https://travis-ci.org/git-toni/bitcoinaverage)
 
 
-
-Bitcoinaverage is an independent 'globally averaged bitcoin price' provider. They provide a **Global** price,
-based on the volume and price of BTC in all currencies, together with a **Market** price, which only takes into account
-the volume of BTC directly exchangeable through that specific currency.
+Bitcoinaverage is an independent 'globally averaged bitcoin price' provider. They provide on one hand a **Global** price,
+which is based on the volume and price of BTC in all currencies. And on the other hand they provide a **Market** price, which only takes into account
+the volume of BTC directly exchangeable using the chosen specific currency.
 For more information on the methods BitcoinAverage uses to calculate the price, please refer to their website, in
 particular [this page](https://bitcoinaverage.com/explain.htm).
 
@@ -23,7 +21,7 @@ The development of this gem has been *deeply* inspired by Erik Michaels-Ober's g
 ## Documentation
 TODO
 
-## Usage 
+## Usage
 ```ruby
 require 'rubygems'
 require 'bitcoinaverage'
@@ -49,11 +47,11 @@ BitcoinAverage.global.volume_percent
 ```
 
 ## Tested Ruby Versions
-This library aims to support and is [tested against][travis] the following Ruby
+This library aims to support and is [tested against](https://travis-ci.org/git-toni/bitcoinaverage) the following Ruby
 implementations:
 
 * ruby-1.9.3-p374
-* ruby-2.0.0-rc1
+* ruby-2.0.0-p353
 * ruby-2.1.0
 
 ## Contributing

data/Rakefile

@@ -0,0 +1,7 @@
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
+
+RSpec::Core::RakeTask.new(:spec)
+
+task :test => :spec
+task :default => :spec

data/bitcoinaverage.gemspec

@@ -1,16 +1,16 @@
-$:.push File.expand_path("../lib", __FILE__)
+$LOAD_PATH.push File.expand_path('../lib', __FILE__)
 require 'bitcoinaverage/version'
 
 Gem::Specification.new do |s|
   s.name        = 'bitcoinaverage'
   s.version     = BitcoinAverage::VERSION
-  s.summary     = "Ruby Wrapper for the Bitcoinaverage API"
+  s.summary     = 'Ruby Wrapper for the Bitcoinaverage API'
   s.description = "Ruby wrapper for the Bitcoinaverage API. Bitcoinaverage is an independent 'globally averaged bitcoin price' provider"
-  s.author      = ["Toni Urcola"]
+  s.author      = ['Toni Urcola']
   s.email       = 'unmail.toni@gmail.com'
   s.files       = `git ls-files`.split("\n")
   s.test_files  = `git ls-files -- {test,spec}/*`.split("\n")
-  s.require_paths = ["lib"]
+  s.require_paths = ['lib']
   s.required_ruby_version = '>= 1.9.3'
   s.add_dependency 'httparty'
   s.add_dependency 'json'

data/lib/bitcoinaverage.rb

@@ -2,10 +2,11 @@ require 'bitcoinaverage/market_ticker'
 require 'bitcoinaverage/global_ticker'
 
 module BitcoinAverage
-    def self.global(currency="USD")
-        GlobalTicker.instance.request_info currency
-    end
-    def self.market(currency="USD")
-        MarketTicker.instance.request_info currency
-    end
+  def self.global(currency = 'USD')
+    GlobalTicker.instance.request_info currency
+  end
+
+  def self.market(currency = 'USD')
+    MarketTicker.instance.request_info currency
+  end
 end

data/lib/bitcoinaverage/requester.rb

@@ -2,36 +2,22 @@ require 'httparty'
 
 module BitcoinAverage
   module Requester
-    def sendrequest(average,currency='USD')
-      raise "#{currency} is not a known currency" unless known_currency?(currency)
-      base_url='https://api.bitcoinaverage.com/ticker/'
-      avg_url= average == 'global'? average+'/' : ''
-      ccy_url=currency
-      final_url= base_url+avg_url+ccy_url
+    def get(average, currency = 'USD')
+      fail "#{currency} is not a known currency" unless known_currency?(currency)
+      base_url = 'https://api.bitcoinaverage.com/ticker/'
+      avg_url = average == 'global' ? average + '/' : ''
+      ccy_url = currency
+      final_url = base_url + avg_url + ccy_url
 
-      response=HTTParty.get final_url
+      HTTParty.get(final_url)
     end
 
     def known_currency?(currency)
-      av_currencies=File.open('lib/bitcoinaverage/available_currencies.csv','r')
-      .read
-      .parse_csv
-      true unless !av_currencies.include? currency
+      available_currencies.include?(currency)
     end
 
-    #Method to obtain all the available currencies
-    #
-    #Note: it's not run repeatedly, rather the result 
-    #was written to a file.
-    #Note 2: "require 'csv' " is necessary for this method
-    #
-    #
-    #def available_currencies
-    #  all_ccy=HTTParty.get 'https://api.bitcoinaverage.com/ticker/global/all'
-    #  all_ccy.map!{|k,v| k}
-    #  file= File.open 'currencies_file.csv','w'
-    #  file.write all_ccy[0..-2].to_csv
-    #  file.close
-    #end
+    def available_currencies
+      @available_currencies ||= File.open('lib/bitcoinaverage/available_currencies.csv', 'r').read.parse_csv
+    end
   end
 end

data/lib/bitcoinaverage/ticker.rb

@@ -6,20 +6,19 @@ module BitcoinAverage
     include BitcoinAverage::Requester
     attr_accessor :avg_24h, :ask, :bid, :last, :timestamp
 
-    def request_info currency='USD'
-      response= sendrequest self.avg_type, currency
+    def request_info(currency = 'USD')
+      response = get(avg_type, currency)
       if response.success?
-        #Small patch since an attribute can't be named "24h_avg"
-        response=JSON.load(response.to_s) unless response.is_a?(Hash)
-        self.avg_24h = response["24h_avg"] 
-        response.delete("24h_avg")
-        #binding.pry
-        response.each do |key,value|
-          send("#{key}=",value)
+        # Small patch since an attribute can't be named "24h_avg"
+        response = JSON.load(response.to_s) unless response.is_a?(Hash)
+        self.avg_24h = response['24h_avg']
+        response.delete('24h_avg')
+        response.each do |key, value|
+          send("#{key}=", value)
         end
         self
       else
-        raise "Error receiving response"#<- to be extended
+        fail 'Error receiving response' # TODO: extended
       end
     end
   end

data/lib/bitcoinaverage/version.rb

@@ -1,3 +1,3 @@
 module BitcoinAverage
-  VERSION = "0.0.1"
+  VERSION = '0.0.2'
 end

data/spec/bitcoinaverage_spec.rb

@@ -5,48 +5,48 @@ SimpleCov.start
 describe BitcoinAverage do
   describe '.global ' do
     before do
-      stub_request(:get, "https://api.bitcoinaverage.com/ticker/global/USD").
-        to_return(status:200, body: fixture('global_USD.json'),headers:{})
-      @response=BitcoinAverage.global
+      stub_request(:get, 'https://api.bitcoinaverage.com/ticker/global/USD').
+        to_return(:status => 200, :body => fixture('global_USD.json'), :headers => {})
+      @response = BitcoinAverage.global
     end
     it 'returns a GlobalTicker object properly filled' do
-      #binding.pry
-      #expect(BitcoinAverage.global).to be_a BitcoinAverage::GlobalTicker
+      # binding.pry
+      # expect(BitcoinAverage.global).to be_a BitcoinAverage::GlobalTicker
       expect(@response).to be_a BitcoinAverage::GlobalTicker
-      @response.avg_24h.should == 568.44
-      @response.ask.should == 566.15
-      @response.bid.should == 563.83
-      @response.last.should == 564.61
-      @response.timestamp.should == 'Fri, 21 Feb 2014 16:22:17 -0000'
-      @response.volume_btc.should == 100496.08
-      @response.volume_percent.should == 79.49
+      expect(@response.avg_24h).to eq(568.44)
+      expect(@response.ask).to eq(566.15)
+      expect(@response.bid).to eq(563.83)
+      expect(@response.last).to eq(564.61)
+      expect(@response.timestamp).to eq('Fri, 21 Feb 2014 16:22:17 -0000')
+      expect(@response.volume_btc).to eq(100496.08)
+      expect(@response.volume_percent).to eq(79.49)
     end
   end
   describe '.market ' do
     before do
-      stub_request(:get, "https://api.bitcoinaverage.com/ticker/USD").
-        to_return(status:200, body: fixture('market_USD.json'),headers:{})
-      @response=BitcoinAverage.market
+      stub_request(:get, 'https://api.bitcoinaverage.com/ticker/USD').
+        to_return(:status => 200, :body => fixture('market_USD.json'), :headers => {})
+      @response = BitcoinAverage.market
     end
     it 'returns a GlobalTicker object properly filled' do
-      #binding.pry
-      #expect(BitcoinAverage.global).to be_a BitcoinAverage::GlobalTicker
+      # binding.pry
+      # expect(BitcoinAverage.global).to be_a BitcoinAverage::GlobalTicker
       expect(@response).to be_a BitcoinAverage::MarketTicker
-      @response.avg_24h.should == 565.89
-      @response.ask.should == 562.54
-      @response.bid.should == 559.7
-      @response.last.should == 560.54
-      @response.timestamp.should == 'Fri, 21 Feb 2014 16:24:27 -0000'
-      @response.total_vol.should == 100667.13
+      expect(@response.avg_24h).to eq(565.89)
+      expect(@response.ask).to eq(562.54)
+      expect(@response.bid).to eq(559.7)
+      expect(@response.last).to eq(560.54)
+      expect(@response.timestamp).to eq('Fri, 21 Feb 2014 16:24:27 -0000')
+      expect(@response.total_vol).to eq(100667.13)
     end
   end
   describe 'unknown currency' do
     before do
-      stub_request(:get, "https://api.bitcoinaverage.com/ticker/EEE").
-        to_return(status:404, body:"", headers:{})
+      stub_request(:get, 'https://api.bitcoinaverage.com/ticker/EEE').
+        to_return(:status => 404, :body => '', :headers => {})
     end
     it 'raises an error' do
-      expect{BitcoinAverage.market('EEE')}.to raise_error("EEE is not a known currency")
+      expect { BitcoinAverage.market('EEE') }.to raise_error('EEE is not a known currency')
     end
   end
 end

data/spec/spec_helper.rb

@@ -1,23 +1,29 @@
-#require 'pry'
+# require 'pry'
 require 'simplecov'
 require 'coveralls'
 
-SimpleCov.start 
+SimpleCov.start
 SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
   SimpleCov::Formatter::HTMLFormatter,
   Coveralls::SimpleCov::Formatter
 ]
-#Coveralls.wear!
+# Coveralls.wear!
 
-
-require 'pry'
+require 'rubygems'
 require 'rspec'
 require 'webmock/rspec'
-WebMock.disable_net_connect!(allow:'coverwalls.io',allow_localhost:true)
+WebMock.disable_net_connect!(:allow => 'coverwalls.io', :allow_localhost => true)
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |c|
+    c.syntax = :expect
+  end
+end
 
 def fixture_path
   File.expand_path('../fixtures', __FILE__)
 end
+
 def fixture(file)
   File.new(fixture_path + '/' + file)
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bitcoinaverage
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-02-23 00:00:00.000000000 Z
+date: 2014-03-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -82,40 +82,13 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .bitcoinaverage.gemspec.swp
 - .gitignore
 - .travis.yml
 - Gemfile
 - LICENSE
 - README.md
+- Rakefile
 - bitcoinaverage.gemspec
-- coverage/.last_run.json
-- coverage/.resultset.json
-- coverage/assets/0.8.0/application.css
-- coverage/assets/0.8.0/application.js
-- coverage/assets/0.8.0/colorbox/border.png
-- coverage/assets/0.8.0/colorbox/controls.png
-- coverage/assets/0.8.0/colorbox/loading.gif
-- coverage/assets/0.8.0/colorbox/loading_background.png
-- coverage/assets/0.8.0/favicon_green.png
-- coverage/assets/0.8.0/favicon_red.png
-- coverage/assets/0.8.0/favicon_yellow.png
-- coverage/assets/0.8.0/loading.gif
-- coverage/assets/0.8.0/magnify.png
-- coverage/assets/0.8.0/smoothness/images/ui-bg_flat_0_aaaaaa_40x100.png
-- coverage/assets/0.8.0/smoothness/images/ui-bg_flat_75_ffffff_40x100.png
-- coverage/assets/0.8.0/smoothness/images/ui-bg_glass_55_fbf9ee_1x400.png
-- coverage/assets/0.8.0/smoothness/images/ui-bg_glass_65_ffffff_1x400.png
-- coverage/assets/0.8.0/smoothness/images/ui-bg_glass_75_dadada_1x400.png
-- coverage/assets/0.8.0/smoothness/images/ui-bg_glass_75_e6e6e6_1x400.png
-- coverage/assets/0.8.0/smoothness/images/ui-bg_glass_95_fef1ec_1x400.png
-- coverage/assets/0.8.0/smoothness/images/ui-bg_highlight-soft_75_cccccc_1x100.png
-- coverage/assets/0.8.0/smoothness/images/ui-icons_222222_256x240.png
-- coverage/assets/0.8.0/smoothness/images/ui-icons_2e83ff_256x240.png
-- coverage/assets/0.8.0/smoothness/images/ui-icons_454545_256x240.png
-- coverage/assets/0.8.0/smoothness/images/ui-icons_888888_256x240.png
-- coverage/assets/0.8.0/smoothness/images/ui-icons_cd0a0a_256x240.png
-- coverage/index.html
 - lib/bitcoinaverage.rb
 - lib/bitcoinaverage/available_currencies.csv
 - lib/bitcoinaverage/global_ticker.rb
@@ -123,7 +96,6 @@ files:
 - lib/bitcoinaverage/requester.rb
 - lib/bitcoinaverage/ticker.rb
 - lib/bitcoinaverage/version.rb
-- mysession
 - spec/bitcoinaverage_spec.rb
 - spec/fixtures/global_EUR.json
 - spec/fixtures/global_USD.json