bit_wallet 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e3906097f190977399d9e67c58d06f1ff0a966b2
-  data.tar.gz: 955806fced4ca7f1021a65b8b244c02e4ff981f9
+  metadata.gz: fce5a76715e28fb69f0391e3a763a2db3c2c1e48
+  data.tar.gz: 26a75f592cecd3e15341b33477058d3508c79d6b
 SHA512:
-  metadata.gz: 63af80885ebf86afdef1303b1e79f2ab487717a5eb9a11581e10fb545a48a6a53cb3a53d9f82db3b66fbaf120c3775ec5e68237ad05490982ef0c827464f27e8
-  data.tar.gz: fdbf0c48e1f9eaadb2e4dab80c5eda5705a0b8aab0ae26a87736c9bf0a1d53e0b41392d77e2118bb15e38d9ec791f095e5bb056fbd916a8b020fd4d52672ed4d
+  metadata.gz: 3517c5fa85d12f6b5715f05455a7effc6c31f2bbb0138295a1650f96d5fedc1dcde0a6940f51bd525066ec5ecff78651bcb181c666f6c6bd57baa439902d3014
+  data.tar.gz: a290f020b07faf475546d10e036eeb983c039202b3cea87f9681e437563752b50d12fdc43cad35c4c9c44de7cdecfa436b2e40358be7cb6d5d429c14e84e92dd

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# v0.7.3
+
+- [#3](https://github.com/ramontayag/bit_wallet/issues/3): no longer fetch list of accounts during initialization
+
 # v0.7.2
 
 - Raise error when an account name is nil

data/lib/bit_wallet/accounts.rb

@@ -10,31 +10,15 @@ module BitWallet
 
     def initialize(wallet)
       @wallet = wallet
-
-      existing_accounts.each do |name|
-        self.new(name)
-      end
     end
 
     def new(name)
-      if self.includes_account_name?(name)
-        account = self.find {|a| a.name == name}
-      else
-        account = BitWallet::Account.new(wallet, name)
-        self << account
-      end
+      account = self.find {|a| a.name == name}
+      return account if account
+      account = BitWallet::Account.new(wallet, name)
+      self << account
       account
     end
 
-    def includes_account_name?(account_name)
-      self.find {|a| a.name == account_name}.present?
-    end
-
-    private
-
-    def existing_accounts
-      client.listaccounts.keys
-    end
-
   end
 end

data/lib/bit_wallet/version.rb

@@ -1,3 +1,3 @@
 module BitWallet
-  VERSION = '0.7.2'
+  VERSION = '0.7.3'
 end

data/spec/bit_wallet/account_spec.rb

@@ -19,8 +19,7 @@ describe BitWallet::Account, vcr: {record: :once}, bitcoin_cleaner: true do
                                                   :port,
                                                   :password))
       account = wallet.accounts.new('nona')
-
-      wallet.accounts.includes_account_name?('nona').should be_true
+      expect(account.name).to eq "nona"
     end
 
     context 'when the account name already exists' do
@@ -28,7 +27,7 @@ describe BitWallet::Account, vcr: {record: :once}, bitcoin_cleaner: true do
         wallet = BitWallet::Wallet.new(Config.slice(:username,
                                                     :port,
                                                     :password))
-        account = wallet.accounts.new('nona')
+        wallet.accounts.new('nona')
 
         expect {
           wallet.accounts.new('nona')

data/spec/bit_wallet/accounts_spec.rb

@@ -21,20 +21,13 @@ module BitWallet
       end
     end
 
-    describe '#includes_account_name?(account)' do
-      it 'should return true if the array includes the account' do
-        account = subject.new('accountname')
-        subject.includes_account_name?('accountname').should == true
-      end
-    end
-
     describe '.with_balance' do
       it 'should return accounts with a balance > 0' do
         default_account = subject.new('')
         account_1 = subject.new('nomoney')
         account_2 = subject.new('moneyd')
 
-        default_account.send_amount 10, to: account_2.addresses.first
+        default_account.send_amount 5, to: account_2.addresses.first
 
         accounts_with_balance = subject.with_balance
         accounts_with_balance.should include(default_account)

data/spec/fixtures/vcr_cassettes/BitWallet_Account/_balance/should_be_able_to_override_the_min_conf.yml

@@ -1,81 +1,5 @@
 ---
 http_interactions:
-- request:
-    method: post
-    uri: http://bitcoinrpc:thisisjustapasswordfortesting@localhost:19001/
-    body:
-      encoding: UTF-8
-      string: '{"method":"listaccounts","params":[1],"id":"jsonrpc"}'
-    headers:
-      Accept:
-      - "*/*; q=0.5, application/xml"
-      Accept-Encoding:
-      - gzip, deflate
-      Content-Type:
-      - application/json
-      Content-Length:
-      - '53'
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Sat, 23 Aug 2014 09:44:35 +0000
-      Connection:
-      - keep-alive
-      Content-Length:
-      - '56'
-      Content-Type:
-      - application/json
-      Server:
-      - bitcoin-json-rpc/v0.9.2.1-g354c0f3-beta
-    body:
-      encoding: UTF-8
-      string: |
-        {"result":{"":50.00000000},"error":null,"id":"jsonrpc"}
-    http_version: 
-  recorded_at: Sat, 23 Aug 2014 09:44:35 GMT
-- request:
-    method: post
-    uri: http://bitcoinrpc:thisisjustapasswordfortesting@localhost:19001/
-    body:
-      encoding: UTF-8
-      string: '{"method":"getnewaddress","params":[""],"id":"jsonrpc"}'
-    headers:
-      Accept:
-      - "*/*; q=0.5, application/xml"
-      Accept-Encoding:
-      - gzip, deflate
-      Content-Type:
-      - application/json
-      Content-Length:
-      - '55'
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Sat, 23 Aug 2014 09:44:35 +0000
-      Connection:
-      - keep-alive
-      Content-Length:
-      - '76'
-      Content-Type:
-      - application/json
-      Server:
-      - bitcoin-json-rpc/v0.9.2.1-g354c0f3-beta
-    body:
-      encoding: UTF-8
-      string: |
-        {"result":"n1V9qhf9PbNXF2NE2iFkKiHFv3owW3trkb","error":null,"id":"jsonrpc"}
-    http_version: 
-  recorded_at: Sat, 23 Aug 2014 09:44:35 GMT
 - request:
     method: post
     uri: http://bitcoinrpc:thisisjustapasswordfortesting@localhost:19001/
@@ -99,7 +23,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sat, 23 Aug 2014 09:44:35 +0000
+      - Sun, 24 Aug 2014 06:47:18 +0000
       Connection:
       - keep-alive
       Content-Length:
@@ -111,7 +35,7 @@ http_interactions:
     body:
       encoding: UTF-8
       string: |
-        {"result":"mfkAkryGgB9BW28NNY212Fu27WzuLTf1V1","error":null,"id":"jsonrpc"}
+        {"result":"mgajLc8bC4TMsqEiRS2irxbMW29EWMcq43","error":null,"id":"jsonrpc"}
     http_version: 
-  recorded_at: Sat, 23 Aug 2014 09:44:35 GMT
+  recorded_at: Sun, 24 Aug 2014 06:47:18 GMT
 recorded_with: VCR 2.8.0

data/spec/fixtures/vcr_cassettes/BitWallet_Account/_balance/should_default_to_the_config_min_conf.yml

@@ -1,81 +1,5 @@
 ---
 http_interactions:
-- request:
-    method: post
-    uri: http://bitcoinrpc:thisisjustapasswordfortesting@localhost:19001/
-    body:
-      encoding: UTF-8
-      string: '{"method":"listaccounts","params":[1],"id":"jsonrpc"}'
-    headers:
-      Accept:
-      - "*/*; q=0.5, application/xml"
-      Accept-Encoding:
-      - gzip, deflate
-      Content-Type:
-      - application/json
-      Content-Length:
-      - '53'
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Sat, 23 Aug 2014 09:44:28 +0000
-      Connection:
-      - keep-alive
-      Content-Length:
-      - '56'
-      Content-Type:
-      - application/json
-      Server:
-      - bitcoin-json-rpc/v0.9.2.1-g354c0f3-beta
-    body:
-      encoding: UTF-8
-      string: |
-        {"result":{"":50.00000000},"error":null,"id":"jsonrpc"}
-    http_version: 
-  recorded_at: Sat, 23 Aug 2014 09:44:28 GMT
-- request:
-    method: post
-    uri: http://bitcoinrpc:thisisjustapasswordfortesting@localhost:19001/
-    body:
-      encoding: UTF-8
-      string: '{"method":"getnewaddress","params":[""],"id":"jsonrpc"}'
-    headers:
-      Accept:
-      - "*/*; q=0.5, application/xml"
-      Accept-Encoding:
-      - gzip, deflate
-      Content-Type:
-      - application/json
-      Content-Length:
-      - '55'
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Sat, 23 Aug 2014 09:44:28 +0000
-      Connection:
-      - keep-alive
-      Content-Length:
-      - '76'
-      Content-Type:
-      - application/json
-      Server:
-      - bitcoin-json-rpc/v0.9.2.1-g354c0f3-beta
-    body:
-      encoding: UTF-8
-      string: |
-        {"result":"mh8e67FEbWhyf13TbvSuvzrGjrWBWChqsp","error":null,"id":"jsonrpc"}
-    http_version: 
-  recorded_at: Sat, 23 Aug 2014 09:44:28 GMT
 - request:
     method: post
     uri: http://bitcoinrpc:thisisjustapasswordfortesting@localhost:19001/
@@ -99,7 +23,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sat, 23 Aug 2014 09:44:28 +0000
+      - Sun, 24 Aug 2014 06:47:10 +0000
       Connection:
       - keep-alive
       Content-Length:
@@ -111,7 +35,7 @@ http_interactions:
     body:
       encoding: UTF-8
       string: |
-        {"result":"mn3fo5zLS5jqFpwNVa9dYuEsmnvZF1HNLY","error":null,"id":"jsonrpc"}
+        {"result":"mrQVZdWQWUGEPJVdubb1YBwopRHmwrxQVh","error":null,"id":"jsonrpc"}
     http_version: 
-  recorded_at: Sat, 23 Aug 2014 09:44:28 GMT
+  recorded_at: Sun, 24 Aug 2014 06:47:10 GMT
 recorded_with: VCR 2.8.0

data/spec/fixtures/vcr_cassettes/BitWallet_Account/_balance/should_return_the_balance_of_the_account.yml

@@ -1,81 +1,5 @@
 ---
 http_interactions:
-- request:
-    method: post
-    uri: http://bitcoinrpc:thisisjustapasswordfortesting@localhost:19001/
-    body:
-      encoding: UTF-8
-      string: '{"method":"listaccounts","params":[1],"id":"jsonrpc"}'
-    headers:
-      Accept:
-      - "*/*; q=0.5, application/xml"
-      Accept-Encoding:
-      - gzip, deflate
-      Content-Type:
-      - application/json
-      Content-Length:
-      - '53'
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Sat, 23 Aug 2014 09:44:42 +0000
-      Connection:
-      - keep-alive
-      Content-Length:
-      - '56'
-      Content-Type:
-      - application/json
-      Server:
-      - bitcoin-json-rpc/v0.9.2.1-g354c0f3-beta
-    body:
-      encoding: UTF-8
-      string: |
-        {"result":{"":50.00000000},"error":null,"id":"jsonrpc"}
-    http_version: 
-  recorded_at: Sat, 23 Aug 2014 09:44:42 GMT
-- request:
-    method: post
-    uri: http://bitcoinrpc:thisisjustapasswordfortesting@localhost:19001/
-    body:
-      encoding: UTF-8
-      string: '{"method":"getnewaddress","params":[""],"id":"jsonrpc"}'
-    headers:
-      Accept:
-      - "*/*; q=0.5, application/xml"
-      Accept-Encoding:
-      - gzip, deflate
-      Content-Type:
-      - application/json
-      Content-Length:
-      - '55'
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Sat, 23 Aug 2014 09:44:42 +0000
-      Connection:
-      - keep-alive
-      Content-Length:
-      - '76'
-      Content-Type:
-      - application/json
-      Server:
-      - bitcoin-json-rpc/v0.9.2.1-g354c0f3-beta
-    body:
-      encoding: UTF-8
-      string: |
-        {"result":"mgZ6eXazQ367vVfuvHSgi8VQD8YK8wQPBg","error":null,"id":"jsonrpc"}
-    http_version: 
-  recorded_at: Sat, 23 Aug 2014 09:44:42 GMT
 - request:
     method: post
     uri: http://bitcoinrpc:thisisjustapasswordfortesting@localhost:19001/
@@ -99,7 +23,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sat, 23 Aug 2014 09:44:42 +0000
+      - Sun, 24 Aug 2014 06:47:03 +0000
       Connection:
       - keep-alive
       Content-Length:
@@ -111,9 +35,9 @@ http_interactions:
     body:
       encoding: UTF-8
       string: |
-        {"result":"mgfhj6ZKRfBWH8BrtuzaWimMsQYCG2Yakn","error":null,"id":"jsonrpc"}
+        {"result":"n2pYkqqAr6jYPqahnVjLMezeWPGvAddAB3","error":null,"id":"jsonrpc"}
     http_version: 
-  recorded_at: Sat, 23 Aug 2014 09:44:42 GMT
+  recorded_at: Sun, 24 Aug 2014 06:47:03 GMT
 - request:
     method: post
     uri: http://bitcoinrpc:thisisjustapasswordfortesting@localhost:19001/
@@ -137,7 +61,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sat, 23 Aug 2014 09:44:42 +0000
+      - Sun, 24 Aug 2014 06:47:03 +0000
       Connection:
       - keep-alive
       Content-Length:
@@ -151,7 +75,7 @@ http_interactions:
       string: |
         {"result":0.00000000,"error":null,"id":"jsonrpc"}
     http_version: 
-  recorded_at: Sat, 23 Aug 2014 09:44:42 GMT
+  recorded_at: Sun, 24 Aug 2014 06:47:03 GMT
 - request:
     method: post
     uri: http://bitcoinrpc:thisisjustapasswordfortesting@localhost:19001/
@@ -175,7 +99,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sat, 23 Aug 2014 09:44:42 +0000
+      - Sun, 24 Aug 2014 06:47:03 +0000
       Connection:
       - keep-alive
       Content-Length:
@@ -189,5 +113,5 @@ http_interactions:
       string: |
         {"result":0.00000000,"error":null,"id":"jsonrpc"}
     http_version: 
-  recorded_at: Sat, 23 Aug 2014 09:44:42 GMT
+  recorded_at: Sun, 24 Aug 2014 06:47:03 GMT
 recorded_with: VCR 2.8.0