bit_wallet 0.6.1 → 0.7.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZTAwZTc0MjQyZGNhNDU3NWVjMzVlMGVjZjdjNmYyMjFmMjdhOTJjNQ==
+    OGMwMmY5MDYyNDg3ZjY0YzM1MDNiMTgyZDBkOTAyNDg5ODNjYTBmNg==
   data.tar.gz: !binary |-
-    OTJjMDBjYzZkYTVjMGE0NzAyNmQ0ZTU3ZjJiNTNlOWM1NGViMDViYQ==
+    NzYyMzJjYzI0M2I0NWFkNGY1ZjE4ZjBkZmUwODE1MjhlYTM1ZWQ4NQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    ZjhhOTkxY2QxNWUzZjVmMjVlZGE1YTE0ODE2ODAwN2Y3YzE0OWQwZTQ2M2Qz
-    ZGM5ZWUxMDE4NGRkNjI5OWYyMmE5ZjFkZjdjNWFiM2M3MGRmMjU0OWNiZTcz
-    MTEyMjhlZTMzY2U3M2MyZTAwZjY5NzhkMGNhMTFjN2JhMjE2MGQ=
+    NjJlMjA2ZDJiZTU3MGU4Y2I1NDFhZWI1YjczYTdmMmRkMGNhNDhlNDFlYzAz
+    NmE1MzlhMjdmOTk1ZTYxMTgxMjc0Y2RlYjAyMTIxNDgyMWM2NjA0MjJhNTkx
+    ZjQ2OTI0OTZkMzcxMjY2YWQ5YjNhNGE5NDY1OTYwNmY5ZGI2NDY=
   data.tar.gz: !binary |-
-    OWUyNDAzNGNkNDc3NDQ0ZjMxMGFhYmE3Y2UyNGY4YjZmMzRiNzNmYTg2N2Jl
-    OTA2MGJlYzcxOTg4NWE3NDY1OWU1MjkwOTY0Y2E3NzI3NTRkZjllMTQ2N2M3
-    Mzk2MmNjN2U1OWEyYzIwMDRjYWViOTFiZWYyMzVmYjQ0NTg3NjY=
+    MjdhZmE1YzZiMDY1M2M4NGRjOGNhZTcwZWNkM2IyNTVkMTE0ZWUwMDcwNDg4
+    ZDU4ZTFlYTNiMjhlY2UyNzQxMjVjMDJjMzYzNDdhOGUzNTM2OGZjZDEzZGQ1
+    NGY1ODVkNDMyODFkOTQ2MGEzNzE0MGFjYzJkM2ZjMDNkZjhjOGQ=

data/.ruby-version

@@ -1 +1 @@
-ruby-1.9.3-p286
+ruby-2.1.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# v0.7.0
+
+- `min_conf` is configurable directly via `BitWallet.min_conf` instead of `BitWallet.config.min_conf`
+
 # v0.6.1
 
 - Fix warning where Wallet#client was being accessed but it was private

data/README.md

@@ -19,7 +19,7 @@ Or install it yourself as:
 ## Usage
 
     wallet = BitWallet.new(:username => 'username', :password => 'password')
-    # You can also pass :port and :host
+    # You can also pass :port, :host, :ssl (Boolean)
 
     wallet.accounts.with_balance # returns array of the accounts with balance > 0
     account = wallet.accounts.new('account name')
@@ -56,8 +56,12 @@ A transaction has the following methods:
 
 ## Contributing
 
+I suggest you do your development in this [Vagrant box](https://github.com/ramontayag/ruby-bitcoin-box). I use it for my development.
+
 1. Fork it
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)
 5. Create new Pull Request
+
+If you find this useful, consider sharing some BTC love: `1PwQWijmJ39hWXk9X3CdAhEdExdkANEAPk`

data/lib/bit_wallet/account.rb

@@ -14,7 +14,7 @@ module BitWallet
       @addresses ||= Addresses.new(self)
     end
 
-    def balance(min_conf=BitWallet.config.min_conf)
+    def balance(min_conf=BitWallet.min_conf)
       client.getbalance(self.name, min_conf)
     end
 
@@ -28,13 +28,13 @@ module BitWallet
       client.sendfrom(self.name,
                       options[:to],
                       amount,
-                      BitWallet.config.min_conf)
+                      BitWallet.min_conf)
     rescue Bitcoin::Errors::RPCError => e
       parse_error e.message
     end
 
     def total_received
-      client.getreceivedbyaccount(self.name, BitWallet.config.min_conf)
+      client.getreceivedbyaccount(self.name, BitWallet.min_conf)
     end
 
     def ==(other_account)
@@ -57,7 +57,7 @@ module BitWallet
 
       txid = client.send_many(self.name,
                               addresses_values,
-                              BitWallet.config.min_conf)
+                              BitWallet.min_conf)
       txid
     rescue => e
       parse_error e.message

data/lib/bit_wallet/address.rb

@@ -15,7 +15,7 @@ module BitWallet
     end
 
     def total_received
-      client.getreceivedbyaddress(self.address, BitWallet.config.min_conf)
+      client.getreceivedbyaddress(self.address, BitWallet.min_conf)
     end
 
     def ==(other_address)

data/lib/bit_wallet/version.rb

@@ -1,3 +1,3 @@
 module BitWallet
-  VERSION = '0.6.1'
+  VERSION = '0.7.0'
 end

data/lib/bit_wallet/wallet.rb

@@ -19,7 +19,7 @@ module BitWallet
     def move(from_account,
              to_account,
              amount,
-             min_conf=BitWallet.config.min_conf,
+             min_conf=BitWallet.min_conf,
              comment=nil)
 
       from_account_str = if from_account.respond_to?(:name)

data/lib/bit_wallet.rb

@@ -19,8 +19,11 @@ require 'bit_wallet/handles_error'
 
 module BitWallet
 
-  mattr_accessor :config
-  @@config = OpenStruct.new
+  mattr_writer :min_conf
+
+  def self.min_conf
+    @@min_conf || 0
+  end
 
   def self.at(*args)
     Wallet.new(*args)

data/spec/bit_wallet/account_spec.rb

@@ -42,11 +42,11 @@ describe BitWallet::Account, vcr: true do
 
     it 'should return the balance of the account' do
       subject.balance.should ==
-        subject.client.getbalance(subject.name, BitWallet.config.min_conf)
+        subject.client.getbalance(subject.name, BitWallet.min_conf)
     end
 
     it 'should default to the config min_conf' do
-      BitWallet.config.min_conf = 2
+      BitWallet.min_conf = 2
       subject.client.should_receive(:getbalance).with(subject.name, 2)
       subject.balance(2)
     end
@@ -95,7 +95,7 @@ describe BitWallet::Account, vcr: true do
   describe '#total_received' do
     it 'should return the total amount received by the address' do
       subject.client.stub(:getreceivedbyaccount).
-        with(subject.name, BitWallet.config.min_conf).
+        with(subject.name, BitWallet.min_conf).
         and_return(2.1)
       subject.total_received.should == 2.1
     end
@@ -138,9 +138,10 @@ describe BitWallet::Account, vcr: true do
       account_2 = wallet.accounts.new('account_2')
       account_2_address = account_2.addresses.first
 
-      default_account.send_many(account_1_address_str => 0.4,
-                                account_2_address => 2.323)
+      tx_id = default_account.send_many(account_1_address_str => 0.4,
+                                        account_2_address => 2.323)
 
+      expect(tx_id).to be_a(String)
       account_1.balance.should == 0.4
       account_2.balance.should == 2.323
     end

data/spec/bit_wallet/address_spec.rb

@@ -28,7 +28,7 @@ describe BitWallet::Address, vcr: true do
   describe '#total_received' do
     it 'should return the total amount received by the address' do
       subject.client.stub(:getreceivedbyaddress).
-        with(subject.address, BitWallet.config.min_conf).
+        with(subject.address, BitWallet.min_conf).
         and_return(2.1)
       subject.total_received.should == 2.1
     end

data/spec/bit_wallet_spec.rb

@@ -2,10 +2,17 @@ require 'spec_helper'
 
 describe BitWallet do
 
-  describe '.config' do
-    it 'should be a configurable object' do
-      described_class.config.min_conf = 22
-      described_class.config.min_conf.should == 22
+  describe "#min_conf" do
+    it "can be set" do
+      described_class.min_conf = 2
+      expect(described_class.min_conf).to eq 2
+    end
+
+    context "it is nil" do
+      it "is 0" do
+        described_class.min_conf = nil
+        expect(described_class.min_conf).to eq 0
+      end
     end
   end
 

data/spec/spec_helper.rb

@@ -33,7 +33,7 @@ RSpec.configure do |config|
   config.include FactoryGirl::Syntax::Methods
 
   config.before(:each) do
-    BitWallet.config.min_conf = 0
+    BitWallet.min_conf = 0
   end
 
   config.order = "random"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bit_wallet
 version: !ruby/object:Gem::Version
-  version: 0.6.1
+  version: 0.7.0
 platform: ruby
 authors:
 - Ramon Tayag
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-03-04 00:00:00.000000000 Z
+date: 2014-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bitcoin-client