bit_wallet 0.6.0 → 0.6.1

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZTdmOGQyNGU2NWI4ZDAyNjc4OTE2ZTYyMTE2YjlkMGIwZjA1ZTA1NQ==
+    ZTAwZTc0MjQyZGNhNDU3NWVjMzVlMGVjZjdjNmYyMjFmMjdhOTJjNQ==
   data.tar.gz: !binary |-
-    Njg5YzcxMzUyZjIzNWU2NWYyMDUxMWI0ZWM3N2RkZGZiYzMwMTM5ZA==
+    OTJjMDBjYzZkYTVjMGE0NzAyNmQ0ZTU3ZjJiNTNlOWM1NGViMDViYQ==
 !binary "U0hBNTEy":
   metadata.gz: !binary |-
-    ZTFmYTEzOTAxMTZjM2Y1YTFlYjhiMGYyN2Q5NGUzNTM1YzdkMGVjZDY2ZTI2
-    OTVjOGI3NWE1NWIzOGYwMzRlMGZmZmEwZDY2ZTc1Y2ViNWIzNGUwZTZhODA4
-    ZTE3ZmRlZjhmYzUxZThkYjMzNjliYzhlNDQzYTM4OTQ1MzhiMTA=
+    ZjhhOTkxY2QxNWUzZjVmMjVlZGE1YTE0ODE2ODAwN2Y3YzE0OWQwZTQ2M2Qz
+    ZGM5ZWUxMDE4NGRkNjI5OWYyMmE5ZjFkZjdjNWFiM2M3MGRmMjU0OWNiZTcz
+    MTEyMjhlZTMzY2U3M2MyZTAwZjY5NzhkMGNhMTFjN2JhMjE2MGQ=
   data.tar.gz: !binary |-
-    ZjkwYTU5MDE0MzE2ZmMxYzk2ZTMxODE0YmY3MzQyMjE2OGIxODgyY2ViNjMx
-    NDc3ZDFiMDgxYmE2MGU1MjZhNmRkZGU3ODY0OWMxZmVhMWJlZGQ3NWU2Zjg3
-    ZDAzNTlhNDIxYTMwOWU0NThhNGFlNjQ5MzdkYzJjYzQxNjVhODA=
+    OWUyNDAzNGNkNDc3NDQ0ZjMxMGFhYmE3Y2UyNGY4YjZmMzRiNzNmYTg2N2Jl
+    OTA2MGJlYzcxOTg4NWE3NDY1OWU1MjkwOTY0Y2E3NzI3NTRkZjllMTQ2N2M3
+    Mzk2MmNjN2U1OWEyYzIwMDRjYWViOTFiZWYyMzVmYjQ0NTg3NjY=

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# v0.6.1
+
+- Fix warning where Wallet#client was being accessed but it was private
+
 # v0.6.0
 
 - Handle error -6 (invalid address)

data/bit_wallet.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'activesupport'
   gem.add_development_dependency 'rspec', '~> 2.12'
   gem.add_development_dependency 'factory_girl', '4.2.0'
-  gem.add_development_dependency 'bitcoin_testnet', '0.5.0'
+  gem.add_development_dependency 'bitcoin_testnet', '0.5.1'
   gem.add_development_dependency 'vcr', '~> 2.4'
   gem.add_development_dependency 'webmock', '1.9.0'
 end

data/lib/bit_wallet/version.rb

@@ -1,3 +1,3 @@
 module BitWallet
-  VERSION = '0.6.0'
+  VERSION = '0.6.1'
 end

data/lib/bit_wallet/wallet.rb

@@ -39,8 +39,6 @@ module BitWallet
                   comment)
     end
 
-    private
-
     def client
       @client ||= InstantiatesBitcoinClient.execute(@config)
     end

data/spec/bit_wallet/accounts_spec.rb

@@ -1,45 +1,47 @@
 require 'spec_helper'
 
-describe BitWallet::Accounts, vcr: {record: :once} do
+module BitWallet
+  describe Accounts, vcr: {record: :once} do
 
-  let(:wallet) do
-    build(:wallet)
-  end
+    let(:wallet) do
+      build(:wallet)
+    end
 
-  subject do
-    BitWallet::Accounts.new(wallet)
-  end
+    subject do
+      Accounts.new(wallet)
+    end
 
-  its(:wallet) { should == wallet }
+    its(:wallet) { should == wallet }
 
-  describe '#new' do
-    it 'should create a new BitWallet::Account with a default address' do
-      account = wallet.accounts.new('accountname')
-      account.should be_kind_of(BitWallet::Account)
-      account.addresses.count.should == 1
+    describe '#new' do
+      it 'should create a new BitWallet::Account with a default address' do
+        account = wallet.accounts.new('accountname')
+        account.should be_kind_of(Account)
+        account.addresses.count.should == 1
+      end
     end
-  end
 
-  describe '#includes_account_name?(account)' do
-    it 'should return true if the array includes the account' do
-      account = subject.new('accountname')
-      subject.includes_account_name?('accountname').should == true
+    describe '#includes_account_name?(account)' do
+      it 'should return true if the array includes the account' do
+        account = subject.new('accountname')
+        subject.includes_account_name?('accountname').should == true
+      end
     end
-  end
 
-  describe '.with_balance' do
-    it 'should return accounts with a balance > 0' do
-      default_account = subject.new('')
-      account_1 = subject.new('nomoney')
-      account_2 = subject.new('moneyd')
+    describe '.with_balance' do
+      it 'should return accounts with a balance > 0' do
+        default_account = subject.new('')
+        account_1 = subject.new('nomoney')
+        account_2 = subject.new('moneyd')
 
-      default_account.send_amount 10, to: account_2.addresses.first
+        default_account.send_amount 10, to: account_2.addresses.first
 
-      accounts_with_balance = subject.with_balance
-      accounts_with_balance.should include(default_account)
-      accounts_with_balance.should_not include(account_1)
-      accounts_with_balance.should include(account_2)
+        accounts_with_balance = subject.with_balance
+        accounts_with_balance.should include(default_account)
+        accounts_with_balance.should_not include(account_1)
+        accounts_with_balance.should include(account_2)
+      end
     end
-  end
 
+  end
 end

data/spec/bit_wallet/wallet_spec.rb

@@ -1,49 +1,65 @@
 require 'spec_helper'
 
-describe BitWallet::Wallet, vcr: true do
+module BitWallet
+  describe Wallet, vcr: true do
 
-  describe '#accounts' do
-    it 'should return array of BitWallet::Accounts' do
-      wallet = build(:wallet)
-      wallet.accounts.should be_kind_of(BitWallet::Accounts)
+    describe '#accounts' do
+      it 'should return array of BitWallet::Accounts' do
+        wallet = build(:wallet)
+        wallet.accounts.should be_kind_of(Accounts)
+      end
     end
-  end
 
-  describe '#recent_transactions' do
-    it 'should return the most recent transactions of all accounts defaulting to 10 transactions' do
-      wallet = build(:wallet)
-      default_account = wallet.accounts.new('')
-      account_1 = wallet.accounts.new('1')
+    describe '#recent_transactions' do
+      it 'should return the most recent transactions of all accounts defaulting to 10 transactions' do
+        wallet = build(:wallet)
+        default_account = wallet.accounts.new('')
+        account_1 = wallet.accounts.new('1')
+
+        1.upto(11).each do |n|
+          default_account.send_amount n, to: account_1.addresses.first
+        end
 
-      1.upto(11).each do |n|
-        default_account.send_amount n, to: account_1.addresses.first
+        wallet.recent_transactions.size.should == 10
       end
 
-      wallet.recent_transactions.size.should == 10
-    end
+      it 'should allow overriding of the transaction limit' do
+        wallet = build(:wallet)
+        default_account = wallet.accounts.new('')
+        account_1 = wallet.accounts.new('1')
 
-    it 'should allow overriding of the transaction limit' do
-      wallet = build(:wallet)
-      default_account = wallet.accounts.new('')
-      account_1 = wallet.accounts.new('1')
+        1.upto(11).each do |n|
+          default_account.send_amount n, to: account_1.addresses.first
+        end
 
-      1.upto(11).each do |n|
-        default_account.send_amount n, to: account_1.addresses.first
+        wallet.recent_transactions(limit: 5).size.should == 5
       end
+    end
 
-      wallet.recent_transactions(limit: 5).size.should == 5
+    describe '#move' do
+      it 'should move funds from one account to another' do
+        wallet = build(:wallet)
+        default_account = wallet.accounts.new('')
+        account_1 = wallet.accounts.new('1')
+        wallet.move '', '1', 1.1
+        wallet.move default_account, account_1, 0.5
+        account_1.balance.should == 1.6
+      end
     end
-  end
 
-  describe '#move' do
-    it 'should move funds from one account to another' do
-      wallet = build(:wallet)
-      default_account = wallet.accounts.new('')
-      account_1 = wallet.accounts.new('1')
-      wallet.move '', '1', 1.1
-      wallet.move default_account, account_1, 0.5
-      account_1.balance.should == 1.6
+    describe "#client" do
+      it "returns the client created by InstantiatesBitcoinClient" do
+        client = double
+        config = {some: "config"}
+        allow(InstantiatesBitcoinClient).
+          to receive(:execute).with(config).
+          and_return(client)
+
+        wallet = described_class.new(config)
+
+        expect(wallet.client).to eq(client)
+      end
     end
-  end
 
+  end
 end

data/spec/fixtures/vcr_cassettes/BitWallet_Account/_balance/should_be_able_to_override_the_min_conf.yml

@@ -11,6 +11,8 @@ http_interactions:
       - ! '*/*; q=0.5, application/xml'
       Accept-Encoding:
       - gzip, deflate
+      Content-Type:
+      - application/json
       Content-Length:
       - '53'
       User-Agent:
@@ -21,22 +23,22 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sun, 07 Apr 2013 10:00:51 +0000
+      - Tue, 04 Mar 2014 14:05:10 +0000
       Connection:
       - keep-alive
       Content-Length:
-      - '109'
+      - '58'
       Content-Type:
       - application/json
       Server:
       - bitcoin-json-rpc/v0.7.2-beta
     body:
       encoding: US-ASCII
-      string: ! '{"result":{"":8502.99850000,"1":0.00000000,"name":0.00000000,"nona":0.00000000},"error":null,"id":"jsonrpc"}
+      string: ! '{"result":{"":8800.00000000},"error":null,"id":"jsonrpc"}
 
 '
     http_version: 
-  recorded_at: Sun, 07 Apr 2013 10:00:51 GMT
+  recorded_at: Tue, 04 Mar 2014 14:05:10 GMT
 - request:
     method: post
     uri: http://admin1:123@localhost:19001/
@@ -48,45 +50,10 @@ http_interactions:
       - ! '*/*; q=0.5, application/xml'
       Accept-Encoding:
       - gzip, deflate
-      Content-Length:
-      - '55'
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Sun, 07 Apr 2013 10:00:51 +0000
-      Connection:
-      - keep-alive
-      Content-Length:
-      - '76'
       Content-Type:
       - application/json
-      Server:
-      - bitcoin-json-rpc/v0.7.2-beta
-    body:
-      encoding: US-ASCII
-      string: ! '{"result":"n23DGsJT8vnsU8B4phPNj2RGdZZGmG8BLq","error":null,"id":"jsonrpc"}
-
-'
-    http_version: 
-  recorded_at: Sun, 07 Apr 2013 10:00:52 GMT
-- request:
-    method: post
-    uri: http://admin1:123@localhost:19001/
-    body:
-      encoding: US-ASCII
-      string: ! '{"method":"getnewaddress","params":["1"],"id":"jsonrpc"}'
-    headers:
-      Accept:
-      - ! '*/*; q=0.5, application/xml'
-      Accept-Encoding:
-      - gzip, deflate
       Content-Length:
-      - '56'
+      - '55'
       User-Agent:
       - Ruby
   response:
@@ -95,7 +62,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sun, 07 Apr 2013 10:00:52 +0000
+      - Tue, 04 Mar 2014 14:05:10 +0000
       Connection:
       - keep-alive
       Content-Length:
@@ -106,59 +73,24 @@ http_interactions:
       - bitcoin-json-rpc/v0.7.2-beta
     body:
       encoding: US-ASCII
-      string: ! '{"result":"moKwpivcfe6ZLixVdxKhF66EFgp829Hawg","error":null,"id":"jsonrpc"}
+      string: ! '{"result":"mi487X6jj8ggY6FAoG8ibv7qomcq9TXL1U","error":null,"id":"jsonrpc"}
 
 '
     http_version: 
-  recorded_at: Sun, 07 Apr 2013 10:00:52 GMT
+  recorded_at: Tue, 04 Mar 2014 14:05:10 GMT
 - request:
     method: post
     uri: http://admin1:123@localhost:19001/
     body:
       encoding: US-ASCII
-      string: ! '{"method":"getnewaddress","params":["name"],"id":"jsonrpc"}'
+      string: ! '{"method":"getnewaddress","params":["nona"],"id":"jsonrpc"}'
     headers:
       Accept:
       - ! '*/*; q=0.5, application/xml'
       Accept-Encoding:
       - gzip, deflate
-      Content-Length:
-      - '59'
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Sun, 07 Apr 2013 10:00:52 +0000
-      Connection:
-      - keep-alive
-      Content-Length:
-      - '76'
       Content-Type:
       - application/json
-      Server:
-      - bitcoin-json-rpc/v0.7.2-beta
-    body:
-      encoding: US-ASCII
-      string: ! '{"result":"mkxFkuJ8ZTumdGhD4tE81ty7GjSXTWJP11","error":null,"id":"jsonrpc"}
-
-'
-    http_version: 
-  recorded_at: Sun, 07 Apr 2013 10:00:52 GMT
-- request:
-    method: post
-    uri: http://admin1:123@localhost:19001/
-    body:
-      encoding: US-ASCII
-      string: ! '{"method":"getnewaddress","params":["nona"],"id":"jsonrpc"}'
-    headers:
-      Accept:
-      - ! '*/*; q=0.5, application/xml'
-      Accept-Encoding:
-      - gzip, deflate
       Content-Length:
       - '59'
       User-Agent:
@@ -169,7 +101,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sun, 07 Apr 2013 10:00:52 +0000
+      - Tue, 04 Mar 2014 14:05:10 +0000
       Connection:
       - keep-alive
       Content-Length:
@@ -180,9 +112,9 @@ http_interactions:
       - bitcoin-json-rpc/v0.7.2-beta
     body:
       encoding: US-ASCII
-      string: ! '{"result":"msGD3CP21pssyDqzQhZvfSNZGnuZBHC5m2","error":null,"id":"jsonrpc"}
+      string: ! '{"result":"mkwWW2pnqFkDfH5esHxXBNARTN7GnUDpsv","error":null,"id":"jsonrpc"}
 
 '
     http_version: 
-  recorded_at: Sun, 07 Apr 2013 10:00:52 GMT
-recorded_with: VCR 2.4.0
+  recorded_at: Tue, 04 Mar 2014 14:05:10 GMT
+recorded_with: VCR 2.8.0

data/spec/fixtures/vcr_cassettes/BitWallet_Account/_balance/should_default_to_the_config_min_conf.yml

@@ -11,6 +11,8 @@ http_interactions:
       - ! '*/*; q=0.5, application/xml'
       Accept-Encoding:
       - gzip, deflate
+      Content-Type:
+      - application/json
       Content-Length:
       - '53'
       User-Agent:
@@ -21,22 +23,22 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sun, 07 Apr 2013 10:00:46 +0000
+      - Tue, 04 Mar 2014 14:05:14 +0000
       Connection:
       - keep-alive
       Content-Length:
-      - '109'
+      - '58'
       Content-Type:
       - application/json
       Server:
       - bitcoin-json-rpc/v0.7.2-beta
     body:
       encoding: US-ASCII
-      string: ! '{"result":{"":8502.99850000,"1":0.00000000,"name":0.00000000,"nona":0.00000000},"error":null,"id":"jsonrpc"}
+      string: ! '{"result":{"":8800.00000000},"error":null,"id":"jsonrpc"}
 
 '
     http_version: 
-  recorded_at: Sun, 07 Apr 2013 10:00:46 GMT
+  recorded_at: Tue, 04 Mar 2014 14:05:14 GMT
 - request:
     method: post
     uri: http://admin1:123@localhost:19001/
@@ -48,45 +50,10 @@ http_interactions:
       - ! '*/*; q=0.5, application/xml'
       Accept-Encoding:
       - gzip, deflate
-      Content-Length:
-      - '55'
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Sun, 07 Apr 2013 10:00:46 +0000
-      Connection:
-      - keep-alive
-      Content-Length:
-      - '76'
       Content-Type:
       - application/json
-      Server:
-      - bitcoin-json-rpc/v0.7.2-beta
-    body:
-      encoding: US-ASCII
-      string: ! '{"result":"mzExDTWuKRwMBchjMDhc6G8DtGWw9u1Xn3","error":null,"id":"jsonrpc"}
-
-'
-    http_version: 
-  recorded_at: Sun, 07 Apr 2013 10:00:46 GMT
-- request:
-    method: post
-    uri: http://admin1:123@localhost:19001/
-    body:
-      encoding: US-ASCII
-      string: ! '{"method":"getnewaddress","params":["1"],"id":"jsonrpc"}'
-    headers:
-      Accept:
-      - ! '*/*; q=0.5, application/xml'
-      Accept-Encoding:
-      - gzip, deflate
       Content-Length:
-      - '56'
+      - '55'
       User-Agent:
       - Ruby
   response:
@@ -95,7 +62,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sun, 07 Apr 2013 10:00:46 +0000
+      - Tue, 04 Mar 2014 14:05:14 +0000
       Connection:
       - keep-alive
       Content-Length:
@@ -106,59 +73,24 @@ http_interactions:
       - bitcoin-json-rpc/v0.7.2-beta
     body:
       encoding: US-ASCII
-      string: ! '{"result":"mx1o3s4pwQEZGo7Tn4gnK6Yc7ssEWE7Ts6","error":null,"id":"jsonrpc"}
+      string: ! '{"result":"mi487X6jj8ggY6FAoG8ibv7qomcq9TXL1U","error":null,"id":"jsonrpc"}
 
 '
     http_version: 
-  recorded_at: Sun, 07 Apr 2013 10:00:46 GMT
+  recorded_at: Tue, 04 Mar 2014 14:05:14 GMT
 - request:
     method: post
     uri: http://admin1:123@localhost:19001/
     body:
       encoding: US-ASCII
-      string: ! '{"method":"getnewaddress","params":["name"],"id":"jsonrpc"}'
+      string: ! '{"method":"getnewaddress","params":["nona"],"id":"jsonrpc"}'
     headers:
       Accept:
       - ! '*/*; q=0.5, application/xml'
       Accept-Encoding:
       - gzip, deflate
-      Content-Length:
-      - '59'
-      User-Agent:
-      - Ruby
-  response:
-    status:
-      code: 200
-      message: OK
-    headers:
-      Date:
-      - Sun, 07 Apr 2013 10:00:46 +0000
-      Connection:
-      - keep-alive
-      Content-Length:
-      - '76'
       Content-Type:
       - application/json
-      Server:
-      - bitcoin-json-rpc/v0.7.2-beta
-    body:
-      encoding: US-ASCII
-      string: ! '{"result":"n35X4Gno3GUzhSdoWaLtbGFCMKJ4pxrzZW","error":null,"id":"jsonrpc"}
-
-'
-    http_version: 
-  recorded_at: Sun, 07 Apr 2013 10:00:46 GMT
-- request:
-    method: post
-    uri: http://admin1:123@localhost:19001/
-    body:
-      encoding: US-ASCII
-      string: ! '{"method":"getnewaddress","params":["nona"],"id":"jsonrpc"}'
-    headers:
-      Accept:
-      - ! '*/*; q=0.5, application/xml'
-      Accept-Encoding:
-      - gzip, deflate
       Content-Length:
       - '59'
       User-Agent:
@@ -169,7 +101,7 @@ http_interactions:
       message: OK
     headers:
       Date:
-      - Sun, 07 Apr 2013 10:00:46 +0000
+      - Tue, 04 Mar 2014 14:05:14 +0000
       Connection:
       - keep-alive
       Content-Length:
@@ -180,9 +112,9 @@ http_interactions:
       - bitcoin-json-rpc/v0.7.2-beta
     body:
       encoding: US-ASCII
-      string: ! '{"result":"mtWxCLZY62c8twij3DKX5cCy1ye5znvEv6","error":null,"id":"jsonrpc"}
+      string: ! '{"result":"mkwWW2pnqFkDfH5esHxXBNARTN7GnUDpsv","error":null,"id":"jsonrpc"}
 
 '
     http_version: 
-  recorded_at: Sun, 07 Apr 2013 10:00:46 GMT
-recorded_with: VCR 2.4.0
+  recorded_at: Tue, 04 Mar 2014 14:05:14 GMT
+recorded_with: VCR 2.8.0