bit_core 1.4.7 → 2.0.0.beta1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 83988d5bc1ed3fb5a2f1279b14b3dd3928bfc774
-  data.tar.gz: c85a209a18638f3d7ef8d263858fd25bba245b64
+  metadata.gz: 720c15056ce284cef90e3a0da4de5e4a49facadc
+  data.tar.gz: 96ac706ae8a7643791f9310e5a940f9e3fbe3893
 SHA512:
-  metadata.gz: c2ad64b39006c828af0315f7a96f39e3e62c7a4775f09bd731c2c8f96fbb4d1c331769d010f6fcc3e7da5762b5a775ed9a1b78d17f10f0ee464409c586907478
-  data.tar.gz: 5a7293edf55653af0318fbb5cc6eac0867a204a6dd9f6887dfe7f1869d05cfb14511a0837b99191ac6acf1f37341b8ead1924569e4db87ed689bed63b5b29d2f
+  metadata.gz: c7c06eda74f9facea4759c38653d8d6a731da64ad9c056e2f73fcb99f889a7f16e1bf6cb256b7bfb151a1565768955a7a9bb8ca02b18acd067a2bd4fc1a9a1ef
+  data.tar.gz: 87044fdf380eec58f6e1169d381a00c4c93d7286af38d86cce5cb6adc09a56bcaca9cb7c49482f8dac00fbcc2210a8c68afdd0bd6724ae98f94815e2390d4459

data/README.md

@@ -1,22 +1,26 @@
-## Installation
+# Bit Core Rails engine
 
-In order to run migrations, you will need to create a 'schema.rb' file (it is in the .gitignore).
-```console
-  touch spec/dummy/db/schema.rb
-```
+This engine provides basic models and logic for slideshows.
+
+## Version 2.0.x
+
+Please note that version 2.0.x supports only Ruby 2.3.0 and Rails 5. If you need
+support for Rails 4, please use the latest 1.x version.
 
 ## Dependencies
+
 The host application will need to specify an Arm class 'app/models/arm.rb'
+
 ```ruby
-  # app/models/arm.rb
-  class Arm
-    ...
-  end
+# app/models/arm.rb
+class Arm
+  ...
+end
 ```
 
 ## Running Specs
 
 ```console
-  bin/rake app:db:drop app:db:create app:db:migrate RAILS_ENV=test
-  bin/rspec
+bin/rake app:db:drop app:db:create app:db:migrate RAILS_ENV=test
+bin/rake
 ```

data/Rakefile

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 begin
   require "bundler/setup"
 rescue LoadError
@@ -11,7 +10,7 @@ load "rails/tasks/engine.rake"
 
 Bundler::GemHelper.install_tasks
 
-Dir[File.join(File.dirname(__FILE__), "tasks/**/*.rake")].each { |f| load f }
+Dir[File.join(File.dirname(__FILE__), "tasks/**/*.rake")].each {|f| load f }
 
 require "rspec/core"
 require "rspec/core/rake_task"

data/app/models/bit_core/audio_slide.rb

@@ -1,6 +1,6 @@
-# frozen_string_literal: true
 module BitCore
   # A Slide with audio content.
   class AudioSlide < Slide
+    serialize :options
   end
 end

data/app/models/bit_core/content_module.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module BitCore
   # A logical unit of content, possibly containing mixed provider types.
   class ContentModule < ActiveRecord::Base
@@ -19,7 +18,7 @@ module BitCore
     # Returns the `ContentProvider` at the given position, or a `Null`
     # `ContentProvider` if none exists.
     def provider(position)
-      content_providers.find_by(position: position) ||
+      content_providers.where(position: position).first ||
         ContentProviders::Null.new(self, position)
     end
 

data/app/models/bit_core/content_provider.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module BitCore
   # Modeled after the presenter pattern. Ties data layer to view layer.
   class ContentProvider < ActiveRecord::Base
@@ -44,7 +43,7 @@ module BitCore
     # Returns a human readable string extracted from the ContentProvider class
     # name.
     def pretty_label
-      self.class.to_s.split("::").last.underscore.tr("_", " ")
+      self.class.to_s.split("::").last.underscore.gsub(/_/, " ")
     end
 
     private
@@ -53,14 +52,14 @@ module BitCore
       path = File.join(Rails.root, "app", "views", template_path || "")
       return if Dir.exist?(path)
 
-      errors.add(:template_path, "not found at #{path}")
+      errors.add(:template_path, "not found at #{ path }")
     end
 
     def data_class_exists
       return unless data_class_name && !data_class
 
       errors.add(:data_class_name,
-                 "unable to find class '#{data_class_name}'")
+                 "unable to find class '#{ data_class_name }'")
     end
 
     # rubocop:disable Metrics/AbcSize
@@ -73,7 +72,7 @@ module BitCore
       return if unknown_attrs.count == 0
 
       errors.add(:data_attributes, "must be attributes on the model class " \
-                 "(unrecognized: #{unknown_attrs.join(', ')})")
+                 "(unrecognized: #{ unknown_attrs.join(', ') })")
     end
     # rubocop:enable Metrics/AbcSize
   end

data/app/models/bit_core/content_providers/null.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module BitCore
   module ContentProviders
     # The default provider.
@@ -11,7 +10,7 @@ module BitCore
       end
 
       def render_current(_options)
-        "Content Module #{@content_module.title}: Oops, did you expect a
+        "Content Module #{ @content_module.title }: Oops, did you expect a
         content provider here?"
       end
 

data/app/models/bit_core/content_providers/slideshow_provider.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module BitCore
   module ContentProviders
     # Defines presentation logic for a Slideshow.
@@ -17,7 +16,7 @@ module BitCore
       end
 
       def slide(position)
-        slideshow.slides.find_by(position: position) ||
+        slideshow.slides.where(position: position).first ||
           BitCore::Slide.new(body: "no slides")
       end
 

data/app/models/bit_core/slide.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 require "redcarpet"
 
 module BitCore
@@ -13,11 +12,8 @@ module BitCore
     validates :position, numericality: { greater_than_or_equal_to: 1 }
     validates :position, uniqueness: { scope: :bit_core_slideshow_id }
 
-    before_validation :normalize_options
     after_destroy :update_slide_positions
 
-    serialize :options
-
     def render_body
       return "" if body.nil?
 
@@ -32,13 +28,9 @@ module BitCore
 
     private
 
-    def normalize_options
-      self.options = options.try(:to_h)
-    end
-
     def update_slide_positions
       slideshow.reload
-               .sort(slideshow.slide_ids)
+        .sort(slideshow.slide_ids)
     end
   end
 end

data/app/models/bit_core/slideshow.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 require "redcarpet"
 
 module BitCore

data/app/models/bit_core/tool.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module BitCore
   # A section of an application.
   class Tool < ActiveRecord::Base

data/app/models/bit_core/video_slide.rb

@@ -1,6 +1,6 @@
-# frozen_string_literal: true
 module BitCore
   # A Slide with video content.
   class VideoSlide < Slide
+    serialize :options
   end
 end

data/lib/bit_core/engine.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 module BitCore
   # Mountable engine with isolated namespace.
   class Engine < ::Rails::Engine

data/lib/bit_core/version.rb

@@ -1,5 +1,4 @@
-# frozen_string_literal: true
 # nodoc
 module BitCore
-  VERSION = "1.4.7"
+  VERSION = "2.0.0.beta1"
 end

data/lib/bit_core.rb

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 require "bit_core/engine"
 
 # nodoc

data/lib/tasks/bit_core_tasks.rake

@@ -1,4 +1,3 @@
-# frozen_string_literal: true
 # desc "Explaining what the task does"
 # task :bit_core do
 #   # Task goes here

data/spec/dummy/config/application.rb

@@ -2,11 +2,7 @@ require File.expand_path('../boot', __FILE__)
 
 # Pick the frameworks you want:
 require "active_record/railtie"
-require "action_controller/railtie"
-require "action_mailer/railtie"
 require "action_view/railtie"
-require "sprockets/railtie"
-# require "rails/test_unit/railtie"
 
 Bundler.require(*Rails.groups)
 require "bit_core"

data/spec/dummy/config/environments/development.rb

@@ -14,7 +14,7 @@ Rails.application.configure do
   config.action_controller.perform_caching = false
 
   # Don't care if the mailer can't send.
-  config.action_mailer.raise_delivery_errors = false
+  # config.action_mailer.raise_delivery_errors = false
 
   # Print deprecation notices to the Rails logger.
   config.active_support.deprecation = :log

data/spec/dummy/config/environments/test.rb

@@ -13,8 +13,8 @@ Rails.application.configure do
   config.eager_load = false
 
   # Configure static asset server for tests with Cache-Control for performance.
-  config.serve_static_files  = true
-  config.static_cache_control = 'public, max-age=3600'
+  config.public_file_server.enabled = true
+  config.public_file_server.headers = { 'Cache-Control' => 'public, max-age=3600' }
 
   # Show full error reports and disable caching.
   config.consider_all_requests_local       = true
@@ -29,7 +29,7 @@ Rails.application.configure do
   # Tell Action Mailer not to deliver emails to the real world.
   # The :test delivery method accumulates sent emails in the
   # ActionMailer::Base.deliveries array.
-  config.action_mailer.delivery_method = :test
+  # config.action_mailer.delivery_method = :test
 
   # Print deprecation notices to the stderr.
   config.active_support.deprecation = :stderr

data/spec/dummy/db/schema.rb

@@ -31,10 +31,9 @@ ActiveRecord::Schema.define(version: 20160311210938) do
     t.datetime "updated_at"
     t.string   "type"
     t.boolean  "is_viz",           default: false, null: false
+    t.index ["bit_core_tool_id", "position"], name: "bit_core_content_module_position", unique: true, using: :btree
   end
 
-  add_index "bit_core_content_modules", ["bit_core_tool_id", "position"], name: "bit_core_content_module_position", unique: true, using: :btree
-
   create_table "bit_core_content_providers", force: :cascade do |t|
     t.string   "type",                                       null: false
     t.string   "source_content_type"
@@ -48,10 +47,9 @@ ActiveRecord::Schema.define(version: 20160311210938) do
     t.text     "data_attributes"
     t.boolean  "show_next_nav",              default: false, null: false
     t.text     "locals"
+    t.index ["bit_core_content_module_id", "position"], name: "bit_core_content_provider_position", unique: true, using: :btree
   end
 
-  add_index "bit_core_content_providers", ["bit_core_content_module_id", "position"], name: "bit_core_content_provider_position", unique: true, using: :btree
-
   create_table "bit_core_slides", force: :cascade do |t|
     t.string   "title",                                null: false
     t.text     "body",                                 null: false
@@ -62,10 +60,9 @@ ActiveRecord::Schema.define(version: 20160311210938) do
     t.datetime "created_at"
     t.datetime "updated_at"
     t.text     "options"
+    t.index ["bit_core_slideshow_id", "position"], name: "bit_core_slide_position", unique: true, using: :btree
   end
 
-  add_index "bit_core_slides", ["bit_core_slideshow_id", "position"], name: "bit_core_slide_position", unique: true, using: :btree
-
   create_table "bit_core_slideshows", force: :cascade do |t|
     t.string   "title",      null: false
     t.datetime "created_at"
@@ -80,10 +77,9 @@ ActiveRecord::Schema.define(version: 20160311210938) do
     t.datetime "updated_at"
     t.integer  "arm_id",                 null: false
     t.string   "type"
+    t.index ["position"], name: "bit_core_tool_position", unique: true, using: :btree
   end
 
-  add_index "bit_core_tools", ["position"], name: "bit_core_tool_position", unique: true, using: :btree
-
   add_foreign_key "bit_core_content_modules", "bit_core_tools", name: "fk_content_modules_tools"
   add_foreign_key "bit_core_content_providers", "bit_core_content_modules", name: "fk_content_providers_modules"
   add_foreign_key "bit_core_slides", "bit_core_slideshows", name: "fk_slideshows_slides"