bit_converter 0.1.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2eb71713960145a2fe047edbc7c843b1e775852c06dfc7a37c71ef56332c02cf
-  data.tar.gz: 28d8d6b891f47da00e1c1c19ff2a04838ecbb02238ba6fe5ccd077acf5054592
+  metadata.gz: f1a694eae2812a06c1783fe29508c91b00b7dadde2061208f638f530e64fb2b0
+  data.tar.gz: b828330e5307abeb9299debf3b357bbdb9f8e0c89725f1bcc69b6079e8caca0c
 SHA512:
-  metadata.gz: 1dfa7bae7efeb747ae7512a5615bef83393aacb86a57abfd439f39ad5bff88a6e276d9adb6a0d0e4f6e18fef3f6bfe7b3aa67a9f70e2bf1b083f613d85b06709
-  data.tar.gz: 7dd06299c898310fe5084c6cd784e92edc4344dd83d4b9d12ce1bcd18feb163add099e5ef8ce9ff3aa696f8abb174de40cd842be0c1a7abb294d84aba3b74197
+  metadata.gz: e3b89e69e7e706cdf64602c768e090f87b6fbe14ba8abb9b6f414c6821df603b6884bc5123173010e0ef6786a1676818f1b4d09a7ec5a48e40c91075f0fe5526
+  data.tar.gz: c73eb322fc963fc2f4c56f1e9a01b7554802ff751fdc2bddd2bd86f61e4260c97d85f15dcc9176c0a027a6f538140829631abae91b0a1c62b519ae806625e548

data/.gitignore

@@ -5,6 +5,7 @@
 /InstalledFiles
 /pkg/
 /spec/reports/
+.rspec_status
 /spec/examples.txt
 /test/tmp/
 /test/version_tmp/

data/Gemfile

@@ -4,3 +4,5 @@ source "https://rubygems.org"
 
 # Specify your gem's dependencies in bit_converter.gemspec
 gemspec
+
+gem "rake", "~> 13.0"

data/Gemfile.lock

@@ -2,19 +2,24 @@ PATH
   remote: .
   specs:
     bit_converter (0.1.0)
-      httparty (~> 0.18.1)
-      money (~> 6.16)
-      rake (~> 13.0)
+      actionview (~> 6.1, >= 6.1.4.1)
       thor
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (4.2.10)
-      i18n (~> 0.7)
-      minitest (~> 5.1)
-      thread_safe (~> 0.3, >= 0.3.4)
-      tzinfo (~> 1.1)
+    actionview (6.1.4.1)
+      activesupport (= 6.1.4.1)
+      builder (~> 3.1)
+      erubi (~> 1.4)
+      rails-dom-testing (~> 2.0)
+      rails-html-sanitizer (~> 1.1, >= 1.2.0)
+    activesupport (6.1.4.1)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (>= 1.6, < 2)
+      minitest (>= 5.1)
+      tzinfo (~> 2.0)
+      zeitwerk (~> 2.3)
     addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
     aruba (2.0.0)
@@ -25,12 +30,12 @@ GEM
       rspec-expectations (~> 3.4)
       thor (~> 1.0)
     builder (3.2.4)
-    byebug (11.1.3)
     childprocess (4.1.0)
     concurrent-ruby (1.1.9)
     contracts (0.16.1)
     crack (0.4.5)
       rexml
+    crass (1.0.6)
     cucumber (7.0.0)
       builder (~> 3.2, >= 3.2.4)
       cucumber-core (~> 10.0, >= 10.0.1)
@@ -63,22 +68,28 @@ GEM
       cucumber-cucumber-expressions (~> 12.1, >= 12.1.1)
       cucumber-messages (~> 17.0, >= 17.0.1)
     diff-lcs (1.4.4)
+    erubi (1.10.0)
     ffi (1.15.3)
     hashdiff (1.0.1)
-    httparty (0.18.1)
-      mime-types (~> 3.0)
-      multi_xml (>= 0.5.2)
-    i18n (0.9.5)
+    i18n (1.8.10)
       concurrent-ruby (~> 1.0)
+    loofah (2.10.0)
+      crass (~> 1.0.2)
+      nokogiri (>= 1.5.9)
     mime-types (3.3.1)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2021.0704)
     minitest (5.14.4)
-    money (6.16.0)
-      i18n (>= 0.6.4, <= 2)
     multi_test (0.1.2)
-    multi_xml (0.6.0)
+    nokogiri (1.11.7-x86_64-darwin)
+      racc (~> 1.4)
     public_suffix (4.0.6)
+    racc (1.5.2)
+    rails-dom-testing (2.0.3)
+      activesupport (>= 4.2.0)
+      nokogiri (>= 1.6)
+    rails-html-sanitizer (1.3.0)
+      loofah (~> 2.3)
     rake (13.0.6)
     rexml (3.2.5)
     rspec (3.10.0)
@@ -97,23 +108,22 @@ GEM
     sys-uname (1.2.2)
       ffi (~> 1.1)
     thor (1.1.0)
-    thread_safe (0.3.6)
-    tzinfo (1.2.9)
-      thread_safe (~> 0.1)
+    tzinfo (2.0.4)
+      concurrent-ruby (~> 1.0)
     webmock (3.14.0)
       addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
+    zeitwerk (2.4.2)
 
 PLATFORMS
   x86_64-darwin-19
 
 DEPENDENCIES
-  activesupport (~> 4.2.0)
   aruba
   bit_converter!
-  byebug (~> 11.1, >= 11.1.3)
   cucumber
+  rake (~> 13.0)
   rspec (~> 3.2)
   webmock (~> 3.14)
 

data/README.md

@@ -1,13 +1,9 @@
 # BitConverter
 
-Welcome to your new gem! In this directory, you'll find the files you need to be able to package up your Ruby library into a gem. Put your Ruby code in the file `lib/bit_converter`. To experiment with that code, run `bin/console` for an interactive prompt.
-
-TODO: Delete this and the text above, and describe your gem
+A simple crypto and fiat currency converter which can also serve as a minimal portfolio tracker. Exchange rate data are from [CoinBase](https://developers.coinbase.com/api/v2).
 
 ## Installation
 
-Add this line to your application's Gemfile:
-
 ```ruby
 gem 'bit_converter'
 ```
@@ -22,7 +18,18 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+```
+❯ bit -h
+Commands:
+  bit convert AMOUNT FROM TO  # Converts between fiat and crypto currencies
+
+❯ bit convert 1 btc usd
+48,840.005
+
+❯ bit convert 3142 doge btc
+0.020981663970713434
+```
+
 
 ## Development
 
@@ -32,34 +39,8 @@ To install this gem onto your local machine, run `bundle exec rake install`. To
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/[USERNAME]/bit_converter.
+Bug reports and pull requests are welcome on GitHub at https://github.com/tuang3142/bit-converter.
 
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
-
-
-# bit-converter
-
-crypto and fiat CLI converter
-
-# todo
-
-- [ ] cache data to make it faster
-- [ ] better test organize
-- [ ] one import to rule them all?
-- [ ] currency format
-- [ ] portfolio
-- [x] basic convert pairs: fiat-fait, coin-coin, coin-fait
-- [x] export as rubygem
-
-# learn
-
-- make gem
-- fully tdd
-- command line
-- wrap api call (binance, and one more)
-- design pattern
-
-- in hindsignt, should have know how to organzie files, how does rails link
-it all together without having to explicitly require

data/Rakefile

@@ -2,7 +2,14 @@
 
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
+require "cucumber/rake/task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task default: :spec
+desc "Default: run the specs, features, and standard ."
+task default: %w[spec features]
+
+Cucumber::Rake::Task.new(:features) do |t|
+  t.fork = true
+  t.cucumber_opts = ["--format", (ENV["CUCUMBER_FORMAT"] || "progress")]
+end

data/bit_converter.gemspec

@@ -14,29 +14,24 @@ Gem::Specification.new do |spec|
   spec.homepage      = "https://github.com/tuang3142/bit-converter"
   spec.license       = "MIT"
 
-  spec.metadata["homepage_uri"]    = spec.homepage
-  spec.metadata["source_code_uri"] = spec.homepage
+  spec.metadata["allowed_push_host"] = "https://rubygems.org"
+  spec.metadata["homepage_uri"]      = spec.homepage
+  spec.metadata["source_code_uri"]   = spec.homepage
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
   spec.files = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{\A(?:test|spec|features)/}) }
   end
-  spec.bindir        = "exe"
+  spec.bindir        = "bin"
   spec.executables   = spec.files.grep(%r{\Aexe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
   spec.required_ruby_version = ">= 2.4.0"
-  spec.add_dependency "httparty", "~> 0.18.1"
   spec.add_dependency "thor"
-  spec.add_dependency "rake", "~> 13.0"
-  spec.add_dependency "money", "~> 6.16"
+  spec.add_dependency "actionview", "~> 6.1", ">= 6.1.4.1"
   spec.add_development_dependency "rspec", "~> 3.2"
   spec.add_development_dependency "cucumber"
   spec.add_development_dependency "aruba"
   spec.add_development_dependency "webmock", "~> 3.14"
-  spec.add_development_dependency "byebug", "~> 11.1", ">= 11.1.3"
-
-  # for the pluralize method in dummy test
-  spec.add_development_dependency "activesupport", "~> 4.2.0"
 end

data/lib/bit_converter.rb

@@ -2,7 +2,7 @@
 
 require_relative "bit_converter/convert"
 require_relative "bit_converter/coinbase_wrapper"
-require_relative "bit_converter/food"
+require_relative "bit_converter/ping"
 require_relative "bit_converter/version"
 
 module BitConverter; end

data/lib/bit_converter/cli.rb

@@ -1,24 +1,27 @@
+# frozen_string_literal: true
+
 require "thor"
 require "bit_converter"
 
 module BitConverter
   class CLI < Thor
-    desc "portray ITEM", "Determines if a piece of food is gross or delicious"
-    def portray(name)
-      puts BitConverter::Food.portray(name)
-    end
-
-    desc "pluralize", "Pluralizes a word"
-    method_option :word, :aliases => :word
-    def pluralize
-      puts BitConverter::Food.pluralize(options[:word])
+    desc "ping", "pong!"
+    def ping
+      puts BitConverter::Ping.ping
     end
 
     desc "convert AMOUNT FROM TO", "Converts between fiat and cypto currencies"
     def convert(amount, from, to)
-      puts BitConverter::Convert.convert(amount: amount.to_f,
-                                         from: from,
-                                         to: to)
+      puts BitConverter::Convert.pretty_convert(amount: amount.to_f,
+                                                from: from,
+                                                to: to)
+    rescue RuntimeError => e
+      puts e.message
+    end
+
+    desc "rate FROM TO", "Get exchange rate between fiat and crypto currencies"
+    def rate(from, to)
+      convert(1, from, to)
     end
   end
 end

data/lib/bit_converter/coinbase_wrapper.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
-require "httparty"
+require "net/http"
+require "json"
+
 module BitConverter
   class CoinbaseWrapper
     class << self
@@ -11,10 +13,10 @@ module BitConverter
       private
 
       def get_exchange_rates(coin)
-        url = "https://api.coinbase.com/v2/exchange-rates?currency=#{coin}"
-        response = HTTParty.get(url)
+        uri = URI("https://api.coinbase.com/v2/exchange-rates?currency=#{coin}")
+        response = Net::HTTP.get(uri)
 
-        JSON.parse(response.body)["data"]["rates"]
+        JSON.parse(response)["data"]["rates"]
       end
 
     end

data/lib/bit_converter/convert.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require "action_view"
+
 module BitConverter
   class Convert
     class << self
@@ -7,14 +9,28 @@ module BitConverter
         rate_of(to.upcase) / rate_of(from.upcase) * amount
       end
 
+      def pretty_convert(amount:, from:, to:)
+        result = convert(amount: amount, from: from, to: to)
+
+        helper.number_to_currency(result, unit: "")
+      end
+
       private
 
+      def helper
+        @helper ||= Class.new do
+          include ActionView::Helpers::NumberHelper
+        end.new
+      end
+
       def rate_of(currency)
+        raise "Currencies #{currency} unavailable" if rates[currency].nil?
+
         rates[currency].to_f
       end
 
       def rates
-        CoinbaseWrapper.usd_exchange_rates
+        @rates ||= CoinbaseWrapper.usd_exchange_rates
       end
     end
   end

data/lib/bit_converter/ping.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+module BitConverter
+  class Ping
+    def self.ping
+      "pong!"
+    end
+  end
+end

data/lib/bit_converter/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module BitConverter
-  VERSION = "0.1.0"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,29 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: bit_converter
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Tuan Nguyen
 autorequire:
-bindir: exe
+bindir: bin
 cert_chain: []
 date: 2021-08-21 00:00:00.000000000 Z
 dependencies:
-- !ruby/object:Gem::Dependency
-  name: httparty
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.18.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.18.1
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
@@ -39,33 +25,25 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: actionview
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '13.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '13.0'
-- !ruby/object:Gem::Dependency
-  name: money
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
+        version: '6.1'
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '6.16'
+        version: 6.1.4.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '6.16'
+        version: '6.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 6.1.4.1
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -122,72 +100,37 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.14'
-- !ruby/object:Gem::Dependency
-  name: byebug
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '11.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 11.1.3
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '11.1'
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 11.1.3
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.2.0
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 4.2.0
 description: A simple crypto and fiat currency converter which can also serve as a
   minimal portfolio tracker.
 email:
 - hi@tuanguyen.com
-executables:
-- bit
+executables: []
 extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
 - ".rspec"
-- ".rspec_status"
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
+- bin/bit
 - bin/console
 - bin/setup
 - bit_converter.gemspec
 - cucumber.yml
-- exe/bit
 - lib/bit_converter.rb
 - lib/bit_converter/cli.rb
 - lib/bit_converter/coinbase_wrapper.rb
 - lib/bit_converter/convert.rb
-- lib/bit_converter/food.rb
+- lib/bit_converter/ping.rb
 - lib/bit_converter/version.rb
 homepage: https://github.com/tuang3142/bit-converter
 licenses:
 - MIT
 metadata:
+  allowed_push_host: https://rubygems.org
   homepage_uri: https://github.com/tuang3142/bit-converter
   source_code_uri: https://github.com/tuang3142/bit-converter
 post_install_message:

data/.rspec_status

@@ -1,10 +0,0 @@
-example_id                                           | status | run_time        |
----------------------------------------------------- | ------ | --------------- |
-./spec/bit_converter/coinbase_wrapper_spec.rb[1:1:1] | passed | 0.01462 seconds |
-./spec/bit_converter/convert_spec.rb[1:1:2]          | passed | 0.00349 seconds |
-./spec/bit_converter/convert_spec.rb[1:1:3]          | passed | 0.00376 seconds |
-./spec/bit_converter/convert_spec.rb[1:1:4]          | passed | 0.00404 seconds |
-./spec/bit_converter/food_spec.rb[1:1]               | passed | 0.00116 seconds |
-./spec/bit_converter/food_spec.rb[1:2]               | passed | 0.00007 seconds |
-./spec/bit_converter/food_spec.rb[1:3]               | passed | 0.0001 seconds  |
-./spec/bit_converter_spec.rb[1:1]                    | passed | 0.00124 seconds |

data/lib/bit_converter/food.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-require "active_support/inflector"
-
-module BitConverter
-  class Food
-    def self.portray(food)
-      if food.downcase == "broccoli"
-        "Gross!"
-      else
-        "Delicious!"
-      end
-    end
-
-    def self.pluralize(food)
-      food.pluralize
-    end
-  end
-end