biryani 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4ccf97951b31acac8912b7286f6377dedae6e404aab32e8c0eb619ef223d7349
-  data.tar.gz: 94563414ccb1a066ca85a9dc553541ea3772bc398e3d80a970e9f26b68d7f31b
+  metadata.gz: be854e5993fe96b137d1d4db219551155b3103b213a97058c64f756ad2971ba3
+  data.tar.gz: 2256eea9aee63134060398084d904651a1d0fde583564dc211e13ddb5b134e78
 SHA512:
-  metadata.gz: c5e5cf9d6fc22cfe738483638b414bf0a82575030d9b4c0e400d5beab27da13b5b826390b563b972eca7fca8f5cbc44e8f693bf44abeab6eb360d9b09a91a3bd
-  data.tar.gz: f961a868e92ba46f300784f12568b0cd47cebc1cda484008b870480c22f63d5de66bf3d76fcddcbc96e192179c2d493a0fb1fbfc0b6cc189ba2852ee99af009a
+  metadata.gz: 0abdc8a1ce8d2b0a4d149830e14c0435e08b884950c026ab7d67af0726aeff53eff9d8dc06da83c4819badd967d6e1f0f2fb0b5833432c508ec3874c117ceaf8
+  data.tar.gz: e11b1fdde4debd807fb8ddfd7c9b7eaec3be56510be8758e1c42b815589418c5711848ae2ded681247578509aad0f20951558ee54a0b0d6d92825f7704bb3256

data/lib/biryani/connection.rb

@@ -349,7 +349,7 @@ module Biryani
 
       ctx.content << data
       if ctx.half_closed_remote?
-        obj = http_request(ctx.fragment.string, ctx.content.string, decoder)
+        obj = http_request(ctx.fragment, ctx.content, decoder)
         return obj if Biryani.err?(obj)
 
         ctx.stream.rx << obj
@@ -370,7 +370,7 @@ module Biryani
     def self.handle_headers(headers, ctx, decoder)
       ctx.fragment << headers.fragment
       if ctx.half_closed_remote?
-        obj = http_request(ctx.fragment.string, ctx.content.string, decoder)
+        obj = http_request(ctx.fragment, ctx.content, decoder)
         return [obj] if Biryani.err?(obj)
 
         ctx.stream.rx << obj

data/lib/biryani/data_buffer.rb

@@ -8,7 +8,7 @@ module Biryani
     # @param data [String]
     def store(stream_id, data)
       @buffer[stream_id] = '' unless @buffer.key?(stream_id)
-      @buffer[stream_id] += data
+      @buffer[stream_id] << data
     end
 
     # @param send_window [Window]

data/lib/biryani/frame/continuation.rb

@@ -32,16 +32,13 @@ module Biryani
       end
 
       # @param s [String]
+      # @param flags [Integer]
+      # @param stream_id [Integer]
       #
       # @return [Continuation]
-      def self.read(s)
-        payload_length, _, flags, stream_id = Frame.read_header(s)
-        return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if s[9..].bytesize != payload_length
-
+      def self.read(s, flags, stream_id)
         end_headers = Frame.read_end_headers(flags)
-        fragment = s[9..]
-
-        Continuation.new(end_headers, stream_id, fragment)
+        Continuation.new(end_headers, stream_id, s)
       end
     end
   end

data/lib/biryani/frame/data.rb

@@ -41,26 +41,23 @@ module Biryani
       end
 
       # @param s [String]
+      # @param flags [Integer]
+      # @param stream_id [Integer]
       #
       # @return [Data]
-      def self.read(s)
-        payload_length, _, flags, stream_id = Frame.read_header(s)
-        return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if s[9..].bytesize != payload_length
-
+      def self.read(s, flags, stream_id)
         padded = Frame.read_padded(flags)
         end_stream = Frame.read_end_stream(flags)
 
         if padded
-          pad_length = s[9].unpack1('C')
-          data_length = payload_length - pad_length - 1
-          data = s[10...10 + data_length]
-          padding = s[10 + data_length..]
-          return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if pad_length >= payload_length
+          io = IO::Buffer.for(s)
+          pad_length = io.get_value(:U8, 0)
+          data_length = s.bytesize - pad_length - 1
+          data = io.get_string(1, data_length)
+          padding = io.get_string(1 + data_length)
           return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if padding.bytesize != pad_length
         else
-          data = s[9..]
-          padding = nil
-          return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if data.bytesize != payload_length
+          data = s
         end
 
         Data.new(end_stream, stream_id, data, padding)

data/lib/biryani/frame/goaway.rb

@@ -28,14 +28,14 @@ module Biryani
       end
 
       # @param s [String]
+      # @param _flags [Integer]
+      # @param stream_id [Integer]
       #
       # @return [Goaway]
-      def self.read(s)
-        payload_length, _, _, stream_id = Frame.read_header(s)
-        return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if s[9..].bytesize != payload_length
-
-        last_stream_id, error_code = s[9..16].unpack('NN')
-        debug = s[17..]
+      def self.read(s, _flags, stream_id)
+        io = IO::Buffer.for(s)
+        last_stream_id, error_code = io.get_values(%i[U32 U32], 0)
+        debug = io.get_string(8)
 
         Goaway.new(stream_id, last_stream_id, error_code, debug)
       end

data/lib/biryani/frame/headers.rb

@@ -58,50 +58,57 @@ module Biryani
       end
 
       # @param s [String]
+      # @param flags [Integer]
+      # @param stream_id [Integer]
       #
       # @return [Headers]
       # rubocop: disable Metrics/AbcSize
       # rubocop: disable Metrics/CyclomaticComplexity
+      # rubocop: disable Metrics/MethodLength
       # rubocop: disable Metrics/PerceivedComplexity
-      def self.read(s)
-        payload_length, _, flags, stream_id = Frame.read_header(s)
-        return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if s[9..].bytesize != payload_length
-
+      def self.read(s, flags, stream_id)
         priority = Frame.read_priority(flags)
         padded = Frame.read_padded(flags)
         end_headers = Frame.read_end_headers(flags)
         end_stream = Frame.read_end_stream(flags)
 
         if priority && padded
-          pad_length, stream_dependency, weight = s[9..14].unpack('CNC')
-          fragment_length = payload_length - pad_length - 6
+          io = IO::Buffer.for(s)
+          pad_length, stream_dependency, weight = io.get_values(%i[U8 U32 U8], 0)
+          fragment_length = s.bytesize - pad_length - 6
           # exclusive = (stream_dependency / 2**31).positive?
           stream_dependency %= 2**31
-          fragment = s[15...15 + fragment_length]
-          padding = s[15 + fragment_length..]
+          return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'cannot depend on itself') if stream_dependency == stream_id
+
+          fragment = io.get_string(6, fragment_length)
+          padding = io.get_string(6 + fragment_length)
           return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'invalid frame') if padding.bytesize != pad_length
         elsif priority
-          stream_dependency, weight = s[9..13].unpack('NC')
+          io = IO::Buffer.for(s)
+          stream_dependency, weight = io.get_values(%i[U32 U8], 0)
           # exclusive = (stream_dependency / 2**31).positive?
           stream_dependency %= 2**31
-          fragment = s[14..]
-          return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'invalid frame') if fragment.bytesize + 5 != payload_length
+          return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'cannot depend on itself') if stream_dependency == stream_id
+
+          fragment = io.get_string(5)
+          return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'invalid frame') if fragment.bytesize + 5 != s.bytesize
         elsif padded
-          pad_length = s[9].unpack1('C')
-          fragment_length = payload_length - pad_length - 1
-          fragment = s[10...10 + fragment_length]
-          padding = s[10 + fragment_length..]
-          return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if pad_length >= payload_length
+          io = IO::Buffer.for(s)
+          pad_length = io.get_value(:U8, 0)
+          fragment_length = s.bytesize - pad_length - 1
+          fragment = io.get_string(1, fragment_length)
+          padding = io.get_string(1 + fragment_length)
+          return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if pad_length >= s.bytesize
           return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if padding.bytesize != pad_length
         else
-          fragment = s[9..]
-          return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if fragment.bytesize != payload_length
+          fragment = s
         end
 
         Headers.new(end_headers, end_stream, stream_id, stream_dependency, weight, fragment, padding)
       end
       # rubocop: enable Metrics/AbcSize
       # rubocop: enable Metrics/CyclomaticComplexity
+      # rubocop: enable Metrics/MethodLength
       # rubocop: enable Metrics/PerceivedComplexity
     end
   end

data/lib/biryani/frame/ping.rb

@@ -32,17 +32,15 @@ module Biryani
       end
 
       # @param s [String]
+      # @param flags [Integer]
+      # @param stream_id [Integer]
       #
       # @return [Ping]
-      def self.read(s)
-        payload_length, _, flags, stream_id = Frame.read_header(s)
-        return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if s[9..].bytesize != payload_length
-        return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'PING payload length MUST be 8') if s[9..].bytesize != 8
+      def self.read(s, flags, stream_id)
+        return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'PING payload length MUST be 8') if s.bytesize != 8
 
         ack = Frame.read_ack(flags)
-        opaque = s[9..]
-
-        Ping.new(ack, stream_id, opaque)
+        Ping.new(ack, stream_id, s)
       end
     end
   end

data/lib/biryani/frame/priority.rb

@@ -27,15 +27,16 @@ module Biryani
       end
 
       # @param s [String]
+      # @param _flags [Integer]
+      # @param stream_id [Integer]
       #
       # @return [Priority]
-      def self.read(s)
-        payload_length, _, _, stream_id = Frame.read_header(s)
-        return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if s[9..].bytesize != payload_length
-        return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'PRIORITY payload length MUST be 5') if payload_length != 5
+      def self.read(s, _flags, stream_id)
+        return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'PRIORITY payload length MUST be 5') if s.bytesize != 5
 
-        stream_dependency, weight = s[9..13].unpack('NC')
+        stream_dependency, weight = s.unpack('NC')
         stream_dependency %= 2**31
+        return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'cannot depend on itself') if stream_dependency == stream_id
 
         Priority.new(stream_id, stream_dependency, weight)
       end

data/lib/biryani/frame/push_promise.rb

@@ -43,33 +43,32 @@ module Biryani
       end
 
       # @param s [String]
+      # @param flags [Integer]
+      # @param stream_id [Integer]
       #
       # @return [PushPromise]
-      # rubocop: disable Metrics/AbcSize
-      def self.read(s)
-        payload_length, _, flags, stream_id = Frame.read_header(s)
-        return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if s[9..].bytesize != payload_length
-
+      def self.read(s, flags, stream_id)
         padded = Frame.read_padded(flags)
         end_headers = Frame.read_end_headers(flags)
 
+        io = IO::Buffer.for(s)
         if padded
-          pad_length = s[9].unpack1('C')
-          promised_stream_id = s[10..13].unpack1('N')
-          fragment_length = payload_length - pad_length - 5
-          fragment = s[14...14 + fragment_length]
-          padding = s[14 + fragment_length..]
-          return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if pad_length >= payload_length
+          pad_length, promised_stream_id = io.get_values(%i[U8 U32], 0)
+          promised_stream_id %= 2**31 # Promised Stream ID (31)
+          fragment_length = s.bytesize - pad_length - 5
+          fragment = io.get_string(5, fragment_length)
+          padding = io.get_string(5 + fragment_length)
+          return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if pad_length >= s.bytesize
           return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if padding.bytesize != pad_length
         else
-          promised_stream_id = s[9..12].unpack1('N')
-          fragment = s[13..]
-          return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if fragment.bytesize + 4 != payload_length
+          promised_stream_id = io.get_value(:U32, 0)
+          promised_stream_id %= 2**31 # Promised Stream ID (31)
+          fragment = io.get_string(4)
+          return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if fragment.bytesize + 4 != s.bytesize
         end
 
         PushPromise.new(end_headers, stream_id, promised_stream_id, fragment, padding)
       end
-      # rubocop: enable Metrics/AbcSize
     end
   end
 end

data/lib/biryani/frame/rst_stream.rb

@@ -25,14 +25,14 @@ module Biryani
       end
 
       # @param s [String]
+      # @param _flags [Integer]
+      # @param stream_id [Integer]
       #
       # @return [RstStream]
-      def self.read(s)
-        payload_length, _, _, stream_id = Frame.read_header(s)
-        return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if s[9..].bytesize != payload_length
-        return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'RST_STREAM payload length MUST be 4') if s[9..].bytesize != 4
+      def self.read(s, _flags, stream_id)
+        return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'RST_STREAM payload length MUST be 4') if s.bytesize != 4
 
-        error_code = s[9..].unpack1('N')
+        error_code = s.unpack1('N')
         RstStream.new(stream_id, error_code)
       end
     end

data/lib/biryani/frame/settings.rb

@@ -33,18 +33,18 @@ module Biryani
       end
 
       # @param s [String]
+      # @param flags [Integer]
+      # @param stream_id [Integer]
       #
       # @return [Settings]
       # rubocop: disable Metrics/AbcSize
       # rubocop: disable Metrics/CyclomaticComplexity
       # rubocop: disable Metrics/PerceivedComplexity
-      def self.read(s)
-        payload_length, _, flags, stream_id = Frame.read_header(s)
-        return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if s[9..].bytesize != payload_length
-        return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'SETTINGS payload length MUST be a multiple of 6') if payload_length % 6 != 0
+      def self.read(s, flags, stream_id)
+        return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'SETTINGS payload length MUST be a multiple of 6') if s.bytesize % 6 != 0
 
         ack = Frame.read_ack(flags)
-        setting = s[9..].unpack('nN' * (payload_length / 6)).each_slice(2).to_h
+        setting = s.unpack('nN' * (s.bytesize / 6)).each_slice(2).to_h
         return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'SETTINGS MUST NOT have setting with ack') \
           if ack && setting.any?
         return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid SETTINGS_ENABLE_PUSH') \

data/lib/biryani/frame/unknown.rb

@@ -25,18 +25,6 @@ module Biryani
 
         Frame.to_binary_s_header(payload_length, @f_type, flags, @stream_id) + @payload
       end
-
-      # @param s [String]
-      #
-      # @return [Unknown]
-      def self.read(s)
-        payload_length, f_type, flags, stream_id = Frame.read_header(s)
-        return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if s[9..].bytesize != payload_length
-
-        payload = s[9..]
-
-        Unknown.new(f_type, flags, stream_id, payload)
-      end
     end
   end
 end

data/lib/biryani/frame/window_update.rb

@@ -25,14 +25,14 @@ module Biryani
       end
 
       # @param s [String]
+      # @param _flags [Integer]
+      # @param stream_id [Integer]
       #
       # @return [WindowUpdate]
-      def self.read(s)
-        payload_length, _, _, stream_id = Frame.read_header(s)
-        return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if s[9..].bytesize != payload_length
-        return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'WINDOW_UPDATE payload length MUST be 4') if s[9..].bytesize != 4
+      def self.read(s, _flags, stream_id)
+        return ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'WINDOW_UPDATE payload length MUST be 4') if s.bytesize != 4
 
-        window_size_increment = s[9..].unpack1('N')
+        window_size_increment = s.unpack1('N')
         return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'WINDOW_UPDATE invalid window size increment 0') if window_size_increment.zero?
         return ConnectionError.new(ErrorCode::FLOW_CONTROL_ERROR, 'WINDOW_UPDATE invalid window size increment greater than 2^31-1') if window_size_increment > 2**31 - 1
 

data/lib/biryani/frame.rb

@@ -37,11 +37,11 @@ module Biryani
     # @return [Integer]
     # @return [Integer]
     def self.read_header(s)
-      b0, b1, b2, f_type, uint8 = s[0..4].bytes
+      b0, b1, b2, f_type, flags, stream_id = s.unpack('CCCCCN')
       payload_length = (b0 << 16) | (b1 << 8) | b2
-      stream_id = s[5..8].unpack1('N') % 2**31 # Stream Identifier (31)
+      stream_id %= 2**31 # Stream Identifier (31)
 
-      [payload_length, f_type, uint8, stream_id]
+      [payload_length, f_type, flags, stream_id]
     end
 
     # @param uint8 [Integer]
@@ -136,9 +136,10 @@ module Biryani
 
       payload_length, f_type, flags, stream_id = read_header(s)
       payload = io.read(payload_length)
+      return ConnectionError.new(ErrorCode::PROTOCOL_ERROR, 'invalid frame') if payload.bytesize != payload_length
       return Frame::Unknown.new(f_type, flags, stream_id, payload) unless FRAME_MAP.key?(f_type)
 
-      FRAME_MAP[f_type].read(s + payload)
+      FRAME_MAP[f_type].read(payload, flags, stream_id)
     rescue StandardError
       ConnectionError.new(ErrorCode::FRAME_SIZE_ERROR, 'invalid frame')
     end

data/lib/biryani/hpack/field.rb

@@ -98,7 +98,7 @@ module Biryani
         "\x40#{String.encode(name)}#{String.encode(value)}"
       end
 
-      # @param s [String]
+      # @param io [IO::Buffer]
       # @param cursor [Integer]
       # @param dynamic_table [DynamicTable]
       #
@@ -106,24 +106,24 @@ module Biryani
       # @return [Integer]
       # rubocop: disable Metrics/CyclomaticComplexity
       # rubocop: disable Metrics/PerceivedComplexity
-      def self.decode(s, cursor, dynamic_table)
-        byte = s.getbyte(cursor)
+      def self.decode(io, cursor, dynamic_table)
+        byte = io.get_value(:U8, cursor)
         if (byte & 0b10000000).positive?
-          decode_indexed(s, cursor, dynamic_table)
+          decode_indexed(io, cursor, dynamic_table)
         elsif byte == 0b01000000
-          decode_literal_field_incremental_indexing(s, cursor, dynamic_table)
+          decode_literal_field_incremental_indexing(io, cursor, dynamic_table)
         elsif (byte & 0b01000000).positive?
-          decode_literal_value_incremental_indexing(s, cursor, dynamic_table)
+          decode_literal_value_incremental_indexing(io, cursor, dynamic_table)
         elsif (byte & 0b00100000).positive?
-          decode_dynamic_table_size_update(s, cursor, dynamic_table)
+          decode_dynamic_table_size_update(io, cursor, dynamic_table)
         elsif byte == 0b00010000
-          decode_literal_field_never_indexed(s, cursor)
+          decode_literal_field_never_indexed(io, cursor)
         elsif (byte & 0b00010000).positive?
-          decode_literal_value_never_indexed(s, cursor, dynamic_table)
+          decode_literal_value_never_indexed(io, cursor, dynamic_table)
         elsif byte.zero?
-          decode_literal_field_without_indexing(s, cursor)
+          decode_literal_field_without_indexing(io, cursor)
         elsif (byte & 0b11110000).zero?
-          decode_literal_value_without_indexing(s, cursor, dynamic_table)
+          decode_literal_value_without_indexing(io, cursor, dynamic_table)
         else
           raise 'unreachable'
         end
@@ -137,14 +137,14 @@ module Biryani
       # +---+---------------------------+
       # https://datatracker.ietf.org/doc/html/rfc7541#section-6.1
       #
-      # @param s [String]
+      # @param io [IO::Buffer]
       # @param cursor [Integer]
       # @param dynamic_table [DynamicTable]
       #
       # @return [Array]
       # @return [Integer]
-      def self.decode_indexed(s, cursor, dynamic_table)
-        index, c = Integer.decode(s, 7, cursor)
+      def self.decode_indexed(io, cursor, dynamic_table)
+        index, c = Integer.decode(io, 7, cursor)
         raise Error::HPACKDecodeError if index.zero?
         raise Error::HPACKDecodeError if index > STATIC_TABLE_SIZE + dynamic_table.count_entries
 
@@ -171,15 +171,15 @@ module Biryani
       # +-------------------------------+
       # https://datatracker.ietf.org/doc/html/rfc7541#section-6.2.1
       #
-      # @param s [String]
+      # @param io [IO::Buffer]
       # @param cursor [Integer]
       # @param dynamic_table [DynamicTable]
       #
       # @return [Array]
       # @return [Integer]
-      def self.decode_literal_field_incremental_indexing(s, cursor, dynamic_table)
-        name, c = String.decode(s, cursor + 1)
-        value, c = String.decode(s, c)
+      def self.decode_literal_field_incremental_indexing(io, cursor, dynamic_table)
+        name, c = String.decode(io, cursor + 1)
+        value, c = String.decode(io, c)
         dynamic_table.store(name, value)
 
         [[name, value], c]
@@ -195,14 +195,14 @@ module Biryani
       # +-------------------------------+
       # https://datatracker.ietf.org/doc/html/rfc7541#section-6.2.1
       #
-      # @param s [String]
+      # @param io [IO::Buffer]
       # @param cursor [Integer]
       # @param dynamic_table [DynamicTable]
       #
       # @return [Array]
       # @return [Integer]
-      def self.decode_literal_value_incremental_indexing(s, cursor, dynamic_table)
-        index, c = Integer.decode(s, 6, cursor)
+      def self.decode_literal_value_incremental_indexing(io, cursor, dynamic_table)
+        index, c = Integer.decode(io, 6, cursor)
         raise Error::HPACKDecodeError if index.zero?
         raise Error::HPACKDecodeError if index > STATIC_TABLE_SIZE + dynamic_table.count_entries
 
@@ -211,7 +211,7 @@ module Biryani
                else
                  dynamic_table[index - 1 - STATIC_TABLE_SIZE][0]
                end
-        value, c = String.decode(s, c)
+        value, c = String.decode(io, c)
         dynamic_table.store(name, value)
 
         [[name, value], c]
@@ -223,16 +223,16 @@ module Biryani
       # +---+---------------------------+
       # https://datatracker.ietf.org/doc/html/rfc7541#section-6.3
       #
-      # @param s [String]
+      # @param io [IO::Buffer]
       # @param cursor [Integer]
       # @param dynamic_table [DynamicTable]
       #
       # @return [nil]
       # @return [Integer]
-      def self.decode_dynamic_table_size_update(s, cursor, dynamic_table)
-        raise Error::HPACKDecodeError unless cursor.zero? || (s.getbyte(0) & 0b00100000).positive? && Integer.decode(s, 5, 0)[1] == cursor
+      def self.decode_dynamic_table_size_update(io, cursor, dynamic_table)
+        raise Error::HPACKDecodeError unless cursor.zero? || (io.get_value(:U8, 0) & 0b00100000).positive? && Integer.decode(io, 5, 0)[1] == cursor
 
-        max_size, c = Integer.decode(s, 5, cursor)
+        max_size, c = Integer.decode(io, 5, cursor)
         raise Error::HPACKDecodeError if max_size > dynamic_table.limit
 
         dynamic_table.chomp!(max_size)
@@ -253,14 +253,14 @@ module Biryani
       # +-------------------------------+
       # https://datatracker.ietf.org/doc/html/rfc7541#section-6.2.3
       #
-      # @param s [String]
+      # @param io [IO::Buffer]
       # @param cursor [Integer]
       #
       # @return [Array]
       # @return [Integer]
-      def self.decode_literal_field_never_indexed(s, cursor)
-        name, c = String.decode(s, cursor + 1)
-        value, c = String.decode(s, c)
+      def self.decode_literal_field_never_indexed(io, cursor)
+        name, c = String.decode(io, cursor + 1)
+        value, c = String.decode(io, c)
 
         [[name, value], c]
       end
@@ -275,14 +275,14 @@ module Biryani
       # +-------------------------------+
       # https://datatracker.ietf.org/doc/html/rfc7541#section-6.2.3
       #
-      # @param s [String]
+      # @param io [IO::Buffer]
       # @param cursor [Integer]
       # @param dynamic_table [DynamicTable]
       #
       # @return [Array]
       # @return [Integer]
-      def self.decode_literal_value_never_indexed(s, cursor, dynamic_table)
-        index, c = Integer.decode(s, 4, cursor)
+      def self.decode_literal_value_never_indexed(io, cursor, dynamic_table)
+        index, c = Integer.decode(io, 4, cursor)
         raise Error::HPACKDecodeError if index.zero?
         raise Error::HPACKDecodeError if index > STATIC_TABLE_SIZE + dynamic_table.count_entries
 
@@ -291,7 +291,7 @@ module Biryani
                else
                  dynamic_table[index - 1 - STATIC_TABLE_SIZE][0]
                end
-        value, c = String.decode(s, c)
+        value, c = String.decode(io, c)
 
         [[name, value], c]
       end
@@ -310,14 +310,14 @@ module Biryani
       # +-------------------------------+
       # https://datatracker.ietf.org/doc/html/rfc7541#section-6.2.2
       #
-      # @param s [String]
+      # @param io [IO::Buffer]
       # @param cursor [Integer]
       #
       # @return [Array]
       # @return [Integer]
-      def self.decode_literal_field_without_indexing(s, cursor)
-        name, c = String.decode(s, cursor + 1)
-        value, c = String.decode(s, c)
+      def self.decode_literal_field_without_indexing(io, cursor)
+        name, c = String.decode(io, cursor + 1)
+        value, c = String.decode(io, c)
 
         [[name, value], c]
       end
@@ -331,14 +331,14 @@ module Biryani
       # | Value String (Length octets)  |
       # +-------------------------------+
       #
-      # @param s [String]
+      # @param io [IO::Buffer]
       # @param cursor [Integer]
       # @param dynamic_table [DynamicTable]
       #
       # @return [Array]
       # @return [Integer]
-      def self.decode_literal_value_without_indexing(s, cursor, dynamic_table)
-        index, c = Integer.decode(s, 4, cursor)
+      def self.decode_literal_value_without_indexing(io, cursor, dynamic_table)
+        index, c = Integer.decode(io, 4, cursor)
         raise Error::HPACKDecodeError if index.zero?
         raise Error::HPACKDecodeError if index > STATIC_TABLE_SIZE + dynamic_table.count_entries
 
@@ -347,7 +347,7 @@ module Biryani
                else
                  dynamic_table[index - 1 - STATIC_TABLE_SIZE][0]
                end
-        value, c = String.decode(s, c)
+        value, c = String.decode(io, c)
 
         [[name, value], c]
       end

data/lib/biryani/hpack/fields.rb

@@ -14,10 +14,11 @@ module Biryani
       #
       # @return [Array]
       def self.decode(s, dynamic_table)
+        io = IO::Buffer.for(s)
         cursor = 0
         fields = []
         while cursor < s.bytesize
-          field, cursor = Field.decode(s, cursor, dynamic_table)
+          field, cursor = Field.decode(io, cursor, dynamic_table)
           fields << field unless field.nil?
         end