bing_ads_ruby_sdk 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 1b8c8ea369c5e217bbcf2f35fe0c1225d119ced4
-  data.tar.gz: cd88b1d04577c366e05295dfafcab96882c1dfc4
+SHA256:
+  metadata.gz: 89dc5300add7a826e0b81dde909dfa4fea569158cbc69262fc88df6aaa3be605
+  data.tar.gz: f6532c9e322b4b3fdf152360f18c372e481dd192a17e3cb0f93832e3a162cfff
 SHA512:
-  metadata.gz: 335e4444c0a1ce0ed3a17211373cf8cdcbcf8036e84672f87f7da363f0f62fc2c2f41c49a6278b67d3eb05f241f53ddddfbaaf7c3abcbaaa249b23d6ee709db2
-  data.tar.gz: 85cc37120c77bab6522eb72922d77801060581616d804279a41caffa9057b9202af01e46d603d4f632ee39aa22d973efbca9467489236efd49c80c5655a591be
+  metadata.gz: 46ccf557939fcc6310d94e0db8747e9a597e7107f7ce4782892118c2515b8b264612cae449c5c6630df63dccb9308024d0c3b742672fb5731688925c916ee526
+  data.tar.gz: 3edfd79352c1b33cb19e81115287c9b3e19722045660d887591e3b70345e88f831c3baca62fba50bfaaaaf055652996e006dbc7d46179619d5928cbf05ae984c

data/README.md

@@ -72,6 +72,10 @@ BingAdsRubySdk.configure do |conf|
   conf.pretty_print_xml = true
   # to filter sensitive data before logging
   conf.filters = ["AuthenticationToken", "DeveloperToken"]
+  
+  # Optionally allow ActiveSupport::Notifications to be emitted by Excon.
+  # These notifications can then be sent on to your profiling system
+  # conf.instrumentor = ActiveSupport::Notifications 
 end
 ```
 
@@ -102,9 +106,9 @@ Here's how to run the tests:
 * Put your Client ID, Developer Token, and Parent Customer ID in the methods 
     with the same names in `spec/examples/examples.rb`
 * Run the specs in order, for example:
-  * `bundle exec spec spec/examples/1_...`, at the end of the spec there will be
+  * `bundle exec rspec spec/examples/1_...`, at the end of the spec there will be
     a message at the end about copying an ID into `spec/examples/examples.rb`
-  * `bundle exec spec spec/examples/2_...` 
+  * `bundle exec rspec spec/examples/2_...` 
   * keep repeating until you have run all the specs in `spec/examples`
 
 ## Contributing

data/changelog.md

@@ -1,3 +1,6 @@
+## V1.3.0 Release
+Allow instrumentation of HTTP requests via ActiveSupport::Notifications
+
 ## V1.2.0 Release
 Replaced Live connect auth with Microsoft Identity as it is now the default from Bing.
 

data/lib/bing_ads_ruby_sdk/configuration.rb

@@ -2,13 +2,14 @@
 
 module BingAdsRubySdk
   class Configuration
-    attr_accessor :pretty_print_xml, :filters, :log
+    attr_accessor :pretty_print_xml, :filters, :log, :instrumentor
     attr_writer :logger
 
     def initialize
       @log = false
       @pretty_print_xml = false
       @filters = []
+      @instrumentor = nil
     end
 
     def logger

data/lib/bing_ads_ruby_sdk/http_client.rb

@@ -11,6 +11,17 @@ module BingAdsRubySdk
     HTTP_RETRY_COUNT_ON_TIMEOUT = 2
     HTTP_INTERVAL_RETRY_COUNT_ON_TIMEOUT = 1
     HTTP_ERRORS = [ Net::HTTPServerError, Net::HTTPClientError ]
+    CONNECTION_SETTINGS = {
+      persistent: true,
+      tcp_nodelay: true,
+      retry_limit: HTTP_RETRY_COUNT_ON_TIMEOUT,
+      idempotent: true,
+      retry_interval: HTTP_INTERVAL_RETRY_COUNT_ON_TIMEOUT,
+      connect_timeout: HTTP_OPEN_TIMEOUT,
+      read_timeout: HTTP_READ_TIMEOUT,
+      ssl_version: :TLSv1_2,
+      ciphers: "TLSv1.2:!aNULL:!eNULL",
+    }
 
     class << self
       def post(request)
@@ -46,18 +57,17 @@ module BingAdsRubySdk
         HTTP_ERRORS.any? { |http_error_class| response.class <= http_error_class }
       end
 
+      def connection_settings
+        CONNECTION_SETTINGS.tap do |args|
+          instrumentor = BingAdsRubySdk.config.instrumentor
+          args[:instrumentor] = instrumentor if instrumentor
+        end
+      end
+
       def connection(host)
         self.http_connections[host] ||= Excon.new(
           host,
-          persistent: true,
-          tcp_nodelay: true,
-          retry_limit: HTTP_RETRY_COUNT_ON_TIMEOUT,
-          idempotent: true,
-          retry_interval: HTTP_INTERVAL_RETRY_COUNT_ON_TIMEOUT,
-          connect_timeout: HTTP_OPEN_TIMEOUT,
-          read_timeout: HTTP_READ_TIMEOUT,
-          ssl_version: :TLSv1_2,
-          ciphers: "TLSv1.2:!aNULL:!eNULL",
+          connection_settings
         )
       end
     end

data/lib/bing_ads_ruby_sdk/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
 module BingAdsRubySdk
-  VERSION = '1.2.0'.freeze
+  VERSION = '1.3.0'.freeze
   DEFAULT_SDK_VERSION = :v13
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bing_ads_ruby_sdk
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Effilab
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-18 00:00:00.000000000 Z
+date: 2019-07-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: signet
@@ -340,8 +340,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.11
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Bing Ads Ruby SDK