bing-content-api 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 62c2988a5c692651b3f62b750fce936dbddf0cd5
-  data.tar.gz: 822431fe79be49a95d517d5aca227bf58e95d6b2
+  metadata.gz: c3417f15cf9af8dfd72b7ee034ba801a83ab51a2
+  data.tar.gz: f6def0a10b0637e1e20922144117ac3814dd1727
 SHA512:
-  metadata.gz: 2e6c2bb9f77498417ccf8ae54a3c2aedc6f4c61260c15e6e9cf390038c903aa8a921c1bcca165cb62619a91da8de8d946074e4a730d7eff646c98a740cf0071f
-  data.tar.gz: 1241ad6361b2011431b410de23aa62a9a0e7eea60d3da1c148ace11a84f3b28a54a1e8a0fdc691bd36b0b4dcbccfec5036db1f146828e513ec3d6b8f56fdb01d
+  metadata.gz: dc732b9f5d0fae8606e63d95244f1f85677d3148b6ee708a2247e89f01f4829c0151e6da875b7f616cebf6facc3dd8413570ca7e1086c2a43405d6b2b781000d
+  data.tar.gz: 35c5e72981c5efd0839222544318f055ba8a2293ee1e11b857c952c19facbc9d25ecf4cfa976a05bd1a1e2df9b3297b52d0ed121ff962901ac272abd9d7d7f05

data/.codeclimate.yml

@@ -0,0 +1,15 @@
+engines:
+  bundler-audit:
+    enabled: true
+  fixme:
+    enabled: true
+  rubocop:
+    enabled: true
+
+ratings:
+   paths:
+   - Gemfile.lock
+   - "**.rb"
+
+exclude_paths:
+- "**/vendor/**/*"

data/.gitignore

@@ -1,9 +1,7 @@
 /.bundle/
 /.yardoc
-/Gemfile.lock
 /_yardoc/
 /coverage/
-/doc/
 /pkg/
 /spec/reports/
 /tmp/

data/.rubocop.yml

@@ -0,0 +1,78 @@
+require: rubocop-rspec
+
+AllCops:
+  Exclude:
+    - "**/vendor/**/*"
+
+Rails:
+  Enabled: true
+
+RSpec/NestedGroups:
+  Enabled: false
+
+Style/MultilineMethodCallIndentation:
+  Enabled: false
+
+# Because https://www.viget.com/articles/just-use-double-quoted-ruby-strings
+Style/StringLiterals:
+  Enabled: false
+
+# Because that way you avoid spurious Git diff touching already-present array elements.
+#
+# For example, if we have:
+#
+# [                  [
+#   item1,             item1,
+#   item2,    =>       item2,
+#                      item3,
+# ]                  ]
+#
+# See how item2 would have been "touched" if it didn't have a trailing comma.
+Style/TrailingCommaInLiteral:
+  Enabled: false
+
+# We have large monitors, yo.
+Metrics/LineLength:
+  Enabled: false
+
+Metrics/ClassLength:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false
+
+RSpec/ExampleLength:
+  Enabled: false
+
+# Stop moaning about missing class documentation comments.
+Documentation:
+  Enabled: false
+
+# These are from our Code Climate config.
+Lint/AssignmentInCondition:
+  Enabled: false
+Style/SpaceInsideHashLiteralBraces:
+  Enabled: false
+Style/EmptyLinesAroundClassBody:
+  Enabled: false
+Style/EmptyLinesAroundBlockBody:
+  Enabled: false
+Style/SpaceInsideParens:
+  Enabled: false
+Style/SpaceInsideBrackets:
+  Enabled: false
+Style/SpaceAroundEqualsInParameterDefault:
+  Enabled: false
+Style/NegatedIf:
+  Enabled: false
+Metrics/BlockLength:
+  Enabled: false
+Metrics/MethodLength:
+  Enabled: false
+Metrics/AbcSize:
+  Enabled: false
+  Max: 20
+Rails/HttpPositionalArguments:
+  Enabled: false
+Style/FrozenStringLiteralComment:
+  Enabled: false

data/Gemfile.lock

@@ -0,0 +1,102 @@
+PATH
+  remote: .
+  specs:
+    bing-content-api (0.3.2)
+      httpi (~> 2.4, >= 2.4.2)
+      oauth2 (~> 1.3, >= 1.3.1)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activesupport (5.0.2)
+      concurrent-ruby (~> 1.0, >= 1.0.2)
+      i18n (~> 0.7)
+      minitest (~> 5.1)
+      tzinfo (~> 1.1)
+    addressable (2.5.1)
+      public_suffix (~> 2.0, >= 2.0.2)
+    ast (2.3.0)
+    concurrent-ruby (1.0.5)
+    crack (0.4.3)
+      safe_yaml (~> 1.0.0)
+    diff-lcs (1.3)
+    factory_girl (4.8.0)
+      activesupport (>= 3.0.0)
+    faraday (0.11.0)
+      multipart-post (>= 1.2, < 3)
+    hashdiff (0.3.2)
+    httpclient (2.8.3)
+    httpi (2.4.2)
+      rack
+      socksify
+    i18n (0.8.1)
+    jwt (1.5.6)
+    minitest (5.10.1)
+    multi_json (1.12.1)
+    multi_xml (0.6.0)
+    multipart-post (2.0.0)
+    oauth2 (1.3.1)
+      faraday (>= 0.8, < 0.12)
+      jwt (~> 1.0)
+      multi_json (~> 1.3)
+      multi_xml (~> 0.5)
+      rack (>= 1.2, < 3)
+    parser (2.4.0.0)
+      ast (~> 2.2)
+    powerpack (0.1.1)
+    public_suffix (2.0.5)
+    rack (2.0.1)
+    rainbow (2.2.2)
+      rake
+    rake (10.5.0)
+    rspec (3.5.0)
+      rspec-core (~> 3.5.0)
+      rspec-expectations (~> 3.5.0)
+      rspec-mocks (~> 3.5.0)
+    rspec-core (3.5.4)
+      rspec-support (~> 3.5.0)
+    rspec-expectations (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-mocks (3.5.0)
+      diff-lcs (>= 1.2.0, < 2.0)
+      rspec-support (~> 3.5.0)
+    rspec-support (3.5.0)
+    rubocop (0.48.1)
+      parser (>= 2.3.3.1, < 3.0)
+      powerpack (~> 0.1)
+      rainbow (>= 1.99.1, < 3.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (~> 1.0, >= 1.0.1)
+    rubocop-rspec (1.15.1)
+      rubocop (>= 0.42.0)
+    ruby-progressbar (1.8.1)
+    safe_yaml (1.0.4)
+    socksify (1.7.1)
+    thread_safe (0.3.6)
+    tzinfo (1.2.3)
+      thread_safe (~> 0.1)
+    unicode-display_width (1.2.1)
+    vcr (3.0.3)
+    webmock (3.0.1)
+      addressable (>= 2.3.6)
+      crack (>= 0.3.2)
+      hashdiff
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bing-content-api!
+  bundler (~> 1.14)
+  factory_girl (~> 4.0)
+  httpclient (~> 2.8, >= 2.8.3)
+  rake (~> 10.0)
+  rspec (~> 3.0)
+  rubocop
+  rubocop-rspec
+  vcr (~> 3.0, >= 3.0.3)
+  webmock (~> 3.0, >= 3.0.1)
+
+BUNDLED WITH
+   1.14.6

data/README.md

@@ -1,5 +1,8 @@
 # Bing::Content::Api
 
+[![Code Climate](https://codeclimate.com/github/redbubble/bing-content-api/badges/gpa.svg)](https://codeclimate.com/github/redbubble/bing-content-api)
+[![Build Status](https://travis-ci.org/redbubble/bing-content-api.svg?branch=master)](https://travis-ci.org/redbubble/bing-content-api)
+
 This Gem is intended to be an as-thin-as-possible wrapper around the
 Bing Ads Content API.
 
@@ -112,6 +115,19 @@ contributors are expected to adhere to
 the [Contributor Covenant](http://contributor-covenant.org) code of
 conduct.
 
+Maintainers
+-------
+
+
+
+[![](doc/redbubble.png)][redbubble]
+
+The Bing Content API gem is maintained and funded
+by [Redbubble][redbubble].
+
+paul.david@redbubble.com
+
+[redbubble]: https://www.redbubble.com
 
 ## License
 

data/Rakefile

@@ -3,4 +3,4 @@ require "rspec/core/rake_task"
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bing-content-api.gemspec

@@ -1,17 +1,18 @@
 # coding: utf-8
+
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'bing/content/api/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = 'bing-content-api'
-  spec.version       = Bing::Content::Api::VERSION
-  spec.authors       = ['Paul David']
-  spec.email         = ['paul.david@redbubble.com']
+  spec.name = 'bing-content-api'
+  spec.version = Bing::Content::Api::VERSION
+  spec.authors = ['Paul David']
+  spec.email = ['paul.david@redbubble.com']
 
-  spec.summary       = %q{Interface with Bing Content API for managing Shopping Ads.}
-  spec.homepage      = 'https://github.com/redbubble/bing-content-api'
-  spec.license       = 'WTFPL'
+  spec.summary = 'Interface with Bing Content API for managing Shopping Ads.'
+  spec.homepage = 'https://github.com/redbubble/bing-content-api'
+  spec.license = 'WTFPL'
 
   # Prevent pushing this gem to RubyGems.org. To allow pushes either set the 'allowed_push_host'
   # to allow pushing to a single host or delete this section to allow pushing to any host.
@@ -22,16 +23,18 @@ Gem::Specification.new do |spec|
       "public gem pushes."
   end
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
+  spec.files = `git ls-files -z`.split("\x0").reject do |f|
     f.match(%r{^(test|spec|features)/})
   end
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
+  spec.bindir = 'exe'
+  spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
   spec.add_development_dependency 'bundler', '~> 1.14'
   spec.add_development_dependency 'rake', '~> 10.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'vcr', '~> 3.0', '>= 3.0.3'
   spec.add_development_dependency 'factory_girl', '~> 4.0'
   spec.add_development_dependency 'httpclient', '~> 2.8', '>= 2.8.3'

data/lib/bing/content/api/batch.rb

@@ -23,7 +23,7 @@ module Bing
         end
 
         def all_products
-          @operations.map { |op| op.product }
+          @operations.map(&:product)
         end
 
         def product_by_batch_id(id)
@@ -31,10 +31,7 @@ module Bing
         end
 
         def to_body
-          json_operations = @operations.map do |op|
-            op.bing_operation
-          end
-
+          json_operations = @operations.map(&:bing_operation)
           { entries: json_operations }.to_json
         end
       end

data/lib/bing/content/api/batch_operation.rb

@@ -8,7 +8,7 @@ module Bing
         attr_reader :action
 
         def initialize(batch_id, product, action=:insert)
-          raise "Please select a valid operation." unless [:insert, :delete].include? action
+          raise "Please select a valid operation." unless %i(insert delete).include? action
 
           @batch_id = batch_id
           @product = product

data/lib/bing/content/api/batch_processor.rb

@@ -9,6 +9,7 @@ module Bing
         def execute(batch)
           post_body = batch.to_body
           http_response = @connector.post('/products/batch', post_body)
+          raise http_response.body if http_response.error?
           body = JSON.parse(http_response.body)
           entries = body["entries"]
 

data/lib/bing/content/api/client.rb

@@ -22,14 +22,15 @@ module Bing
 
         def generate_user_authorisation_url
           oauth_client.auth_code.authorize_url(
-            :state => "ArizonaIsAState",
-            :scope => "bingads.manage")
+            state: "ArizonaIsAState",
+            scope: "bingads.manage"
+          )
         end
 
         def fetch_token_with_code!(verified_url)
           @token = oauth_client.auth_code.get_token(
             extract_code(verified_url),
-            :redirect_uri => REDIRECT_URI
+            redirect_uri: REDIRECT_URI
           )
           self.refresh_token = @token.refresh_token
         end
@@ -44,6 +45,14 @@ module Bing
           JSON.parse(response.body)["resources"]
         end
 
+        def connector
+          refresh_token! unless @connector
+          @connector ||= Bing::Content::Api::Connector.new(@developer_token,
+                                                           @token.token,
+                                                           @merchant_id,
+                                                           @catalogue_id)
+        end
+
         private
 
         def refresh_token!
@@ -54,7 +63,7 @@ module Bing
         end
 
         def refresh_token=(value)
-          if @refresh_token_callback then
+          if @refresh_token_callback
             @refresh_token_callback.call(value)
           else
             puts "WARNING: this is the default refresh_token_callback."
@@ -69,21 +78,14 @@ module Bing
           /code=([0-9a-zA-Z\-]+)&/.match(redirected_url)[1]
         end
 
-        def connector
-          refresh_token! unless @connector
-          @connector ||= Bing::Content::Api::Connector.new(@developer_token,
-                                                           @token.token,
-                                                           @merchant_id,
-                                                           @catalogue_id)
-        end
-
         def oauth_client
-          @oauth_client ||= OAuth2::Client.new(@client_id,
+          @oauth_client ||= OAuth2::Client.new(
+            @client_id,
             nil, # client secret isn't applicable for our use
-            :site => 'https://login.live.com',
-            :authorize_url => '/oauth20_authorize.srf',
-            :token_url     => '/oauth20_token.srf',
-            :redirect_uri  => REDIRECT_URI
+            site: 'https://login.live.com',
+            authorize_url: '/oauth20_authorize.srf',
+            token_url: '/oauth20_token.srf',
+            redirect_uri: REDIRECT_URI
           )
         end
       end

data/lib/bing/content/api/response.rb

@@ -5,19 +5,19 @@ module Bing
         attr_reader :failures, :successes
 
         def initialize(response_entries, batch)
-          @failures = batch.all_products
+          @failures = []
           @successes = []
 
           response_entries.each do |entry|
             id = entry["batchId"].to_i
-            add_success(batch.product_by_batch_id(id))
+            error = entry["errors"]
+            if error
+              failures << { response: entry, product: batch.product_by_batch_id(id) }
+            else
+              successes << { response: entry, product: batch.product_by_batch_id(id) }
+            end
           end
         end
-
-        def add_success(product)
-          @failures.delete_if { |prod| prod.offer_id == product.offer_id }
-          @successes << product
-        end
       end
     end
   end

data/lib/bing/content/api/version.rb

@@ -1,7 +1,7 @@
 module Bing
   module Content
     module Api
-      VERSION = "0.3.1"
+      VERSION = "0.3.2".freeze
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bing-content-api
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Paul David
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-05-02 00:00:00.000000000 Z
+date: 2017-05-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -173,17 +201,21 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".codeclimate.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - ".travis.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
+- Gemfile.lock
 - LICENSE.txt
 - README.md
 - Rakefile
 - bin/console
 - bin/setup
 - bing-content-api.gemspec
+- doc/redbubble.png
 - lib/bing/content/api.rb
 - lib/bing/content/api/batch.rb
 - lib/bing/content/api/batch_operation.rb