bing-ads 0.1.7 → 0.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d23f93c7fe4f5efe90c04005f59e26b240d56bf5
-  data.tar.gz: 6d3cde8118e06a6b454284aadd01247f8d3bdfce
+  metadata.gz: fb865140e65821f31450432bb087cb89143455d2
+  data.tar.gz: 02b9ad77ad75865f776349d756a8db170379755f
 SHA512:
-  metadata.gz: 9a0d495a745ea1aab39f608e74add9d3792beab32fc5b0cb3e7e3e0acab71893bce1fd5a598d693045cb975cd1fecab2a1d47ea6fbfd0a49184f1363ea413f1f
-  data.tar.gz: 2998357b32c5c90760a4e8fec6a2b80dd43c4e6f1dd84e123d0a920f5753e9b6cdd2254c98c9227278a63917f086b6ae34b0f3a333ed6fc5175f8dffdc5dfac3
+  metadata.gz: f267aae4e994cab02ef1e910a51c10958b7f1c7da008088fddcc3a403b25fd910138477729cb1c21a9afa3b4ef1a4bce9ea1d8eded3506ac22a760d8b34962ad
+  data.tar.gz: 3190d86f5f162e44ac0700ff48c3cad6c26412e74dbe5db166e56fc5809f3bc5eedf9bebeb66612a4ad84fb08f3bcfae1f8a9ed68f0537f59464b65117e56ceb

data/lib/bing/ads/api/errors.rb

@@ -8,6 +8,9 @@ module Bing
         # Bing::Ads::API::Errors::AuthenticationTokenExpired
         class AuthenticationTokenExpired < RuntimeError; end;
 
+        # Bing::Ads::API::Errors::UnhandledSOAPFault
+        class UnhandledSOAPFault < RuntimeError; end;
+
         # Bing::Ads::API::Errors::LimitError
         class LimitError < RuntimeError
           def initialize(operation, limit, type)

data/lib/bing/ads/api/v11/services/base.rb

@@ -57,11 +57,20 @@ module Bing
                 elsif fault_detail.key?(:ad_api_fault_detail)
                   handle_soap_fault(operation, fault_detail, :ad_api_fault_detail)
                 else
-                  raise
+                  if retries_made < retry_attempts
+                    sleep(2**retries_made)
+                    retries_made += 1
+                    retry
+                  else
+                    raise Bing::Ads::API::Errors::UnhandledSOAPFault,
+                          "SOAP error (#{fault_detail.keys.join(', ')}) while calling #{operation}. #{error.message}"
+                  end
                 end
               rescue Savon::HTTPError => error
+                # TODO better handling
                 raise
               rescue Savon::InvalidResponseError => error
+                # TODO better handling
                 raise
               rescue
                 if retries_made < retry_attempts
@@ -112,7 +121,8 @@ module Bing
                 raise Bing::Ads::API::Errors::AuthenticationTokenExpired,
                       'renew authentication token or obtain a new one.'
               else
-                raise "SOAP error while calling #{operation}, #{fault_detail[key]}"
+                raise Bing::Ads::API::Errors::UnhandledSOAPFault,
+                      "SOAP error (#{fault_detail[key]}) while calling #{operation}."
               end
             end
           end

data/lib/bing/ads/version.rb

@@ -1,5 +1,5 @@
 module Bing
   module Ads
-    VERSION = '0.1.7'
+    VERSION = '0.1.10'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bing-ads
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.10
 platform: ruby
 authors:
 - oss92
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-08-28 00:00:00.000000000 Z
+date: 2017-09-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: savon