bind9mgr 0.3.16 → 0.3.17

data/History.txt

@@ -101,3 +101,7 @@
 === 0.3.16 / 2013-03-06
 
 * less debug messages in stdout
+
+=== 0.3.17 / 2013-03-06
+
+* owner can contain digits only (for reverse DNS PTR records)

data/lib/bind9mgr.rb

@@ -6,7 +6,7 @@ require File.join( File.dirname(__FILE__), 'resource_record' )
 require File.join( File.dirname(__FILE__), 'parser' )
 
 module Bind9mgr
-  VERSION = '0.3.16'
+  VERSION = '0.3.17'
 
   ZONES_BIND_SUBDIR = 'primary'
 

data/lib/resource_record.rb

@@ -17,8 +17,8 @@ module Bind9mgr
     def valid?
       @errors = []
       (@errors << "Base type_and_rdata_shouldnt_be_blank"; return false)   unless @type && @rdata
-      (@errors << "Rdata rdata_shouldnt_be_blank_string"; return false)    if @rdata.kind_of?(String) && @rdata.length < 1
-      (@errors << "Owner invalid")                                         if     @owner && ( !@owner.kind_of?(String) || (@owner.match(/^\d+$/)) || (@owner == 'localhost') )
+      (@errors << "Rdata rdata_shouldnt_be_blank_string"; return false)    if @rdata.kind_of?(String) && (@rdata.length < 1 || !@rdata.match(/[^\.\;\,]/))
+      (@errors << "Owner invalid")                                         if     @owner && ( !@owner.kind_of?(String) || (@owner == 'localhost') )
       (@errors << "Class invalid")                                         if     !klass.nil? && !KLASSES.include?( klass ) 
       (@errors << "Type not_supported")                                    unless ALLOWED_TYPES.include?( type )
 

data/spec/resource_record_spec.rb

@@ -56,13 +56,13 @@ describe Bind9mgr::ResourceRecord do
     it( "with nil owner"   ) { subject.new( nil, nil, 'IN', 'A', '192.168.1.1' ).should be_valid }
     
     it( "with '1' in all fields"     ) { subject.new( '1', '1', '1', 'A', '1' ).should_not be_valid }
-    it( "with digit in owner"        ) { subject.new( '1', nil, 'IN', 'A', '192.168.1.1' ).should_not be_valid }
-    it( "with double digit in owner" ) { subject.new( '11', nil, 'IN', 'A', '192.168.1.1' ).should_not be_valid }
+# bind ignores this, so we are #   it( "with digit in owner"        ) { subject.new( '1', nil, 'IN', 'A', '192.168.1.1' ).should_not be_valid }
+# bind ignores this, so we are #   it( "with double digit in owner" ) { subject.new( '11', nil, 'IN', 'A', '192.168.1.1' ).should_not be_valid }
     it( "with blank rdata"           ) { subject.new( 'sub', nil, 'IN', 'A', '' ).should_not be_valid }
     it( "with nil rdata"             ) { subject.new( 'sub', nil, 'IN', 'A', nil ).should_not be_valid }
-    it( "with digit in rdata"        ) { subject.new( '1', nil, 'IN', 'A', '1' ).should_not be_valid }
-    it( "with char in rdata"         ) { subject.new( '1', nil, 'IN', 'A', 's' ).should_not be_valid }
-    it( "with punctuation in rdata"  ) { subject.new( '1', nil, 'IN', 'A', ',;;;' ).should_not be_valid }
+#    it( "with digit in rdata"        ) { subject.new( 'qwe', nil, 'IN', 'A', '1' ).should_not be_valid }
+#    it( "with char in rdata"         ) { subject.new( 'qwe', nil, 'IN', 'A', 's' ).should_not be_valid }
+    it( "with punctuation in rdata"  ) { subject.new( 'qwe', nil, 'IN', 'A', ',;;;' ).should_not be_valid }
     it( "with wrong class"           ) { subject.new( 'sub', nil, 'IN222', 'A', '192.168.1.1' ).should_not be_valid }
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bind9mgr
 version: !ruby/object:Gem::Version
-  version: 0.3.16
+  version: 0.3.17
   prerelease: 
 platform: ruby
 authors: