binance_client 0.2.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1979b92bdf48a6a492d2c5f5c27647ff62de6b9fc76b0660aca4dba66883b4f2
-  data.tar.gz: 269d45355ff17b2aaca147f291a21d4020ebdfabca11320984431c1f28590a76
+  metadata.gz: 7f3905cb869b611e99b318cb5066477236ed55a9fc206681b7991c91c6bdaad3
+  data.tar.gz: a0f67542cf08ebaa538c4a740cf6ca4186ab619bc92a6b842ae3f3a5e1e039ef
 SHA512:
-  metadata.gz: c0d171109402441c2090aa2bd4f44d339cd95d1205ef5e0af0ed5365aa5f577a5b0ed8ba2647c84fc19c223b3404635dc147494f142844f2d0eff7f4418aea00
-  data.tar.gz: 528e987310452cf0b2d06d4313c2fb99170a9eb6f1cf35b087aa0c821b91cae8d8d150274f48f41fd9a734480c27acaa2caa8f21fde95991e3dad1679cd58cd1
+  metadata.gz: e57ec0318a7ed587a32154bd2c8de4c7ec5499137a33c46bb4cf166f1c89846c83cb8872037b87723a74c94c5c6ebef9aea0c72983b6a18cd4e4dae486400b18
+  data.tar.gz: e9a67ecd796b0a7baa21c8fc48e3b2e49ede84b3271f816a014bf007c0950d5255937242c8910af7d42c98659944cf1484ed59cc49977f4786f9fccd37cbc647

data/.github/workflows/ruby.yml

@@ -0,0 +1,31 @@
+# This workflow uses actions that are not certified by GitHub.
+# They are provided by a third-party and are governed by
+# separate terms of service, privacy policy, and support
+# documentation.
+# This workflow will download a prebuilt Ruby version, install dependencies and run tests with Rake
+# For more information see: https://github.com/marketplace/actions/setup-ruby-jruby-and-truffleruby
+
+name: Ruby
+
+on:
+  push:
+    branches: [ master ]
+  pull_request:
+    branches: [ master ]
+
+jobs:
+  test:
+
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v2
+    - uses: actions/setup-ruby@v1
+      with:
+        ruby-version: '2.7'
+    - name: Install dependencies
+      run: bundle install
+    - name: Setup config
+      run: cp spec/config.yml{.sample,}
+    - name: Run tests
+      run: bundle exec rspec

data/CHANGELOG.md

@@ -1,18 +1,22 @@
-<a name="v0.2.0"></a>
-### v0.2.0 (2020-09-14)
+# Changelog
+All notable changes to this project will be documented in this file.
 
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
-#### Features
+## [1.0.0]
+### Fixed
+- Avoid "Signature for this request is not valid" errors by using the same timestamp
+- Remove pry as a development dependency
 
-* enable vcr for other tests	 ([aaf2fbb](/../../commit/aaf2fbb))
-* add book_ticker endpoint	 ([bc7c896](/../../commit/bc7c896))
-* added get_all endpoint	 ([b22fa3f](/../../commit/b22fa3f))
-* add account_snapshot endpoint	 ([e64826a](/../../commit/e64826a))
-* add system_status endpoint	 ([fbc3c36](/../../commit/fbc3c36))
-
-
-#### Bug Fixes
-
-* ignore non deterministic part of the url	 ([647a822](/../../commit/647a822))
+## [0.2.0] - 2020-09-14
+### Added
 
+- [enable vcr for other tests](/../../commit/aaf2fbb))
+- [add book_ticker endpoint](/../../commit/bc7c896))
+- [added get_all endpoint](/../../commit/b22fa3f))
+- [add account_snapshot endpoint](/../../commit/e64826a))
+- [add system_status endpoint](/../../commit/fbc3c36))
 
+### Fixed
+- [ignore non deterministic part of the url](/../../commit/647a822))

data/Gemfile

@@ -5,3 +5,4 @@ gemspec
 
 gem "rake", "~> 12.0"
 gem "rspec", "~> 3.0"
+gem "pry-byebug"

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    binance_client (0.1.0)
+    binance_client (1.0.0)
       activesupport
       api_client_base
       typhoeus
@@ -9,7 +9,7 @@ PATH
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.0.3.3)
+    activesupport (6.0.3.4)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 0.7, < 2)
       minitest (~> 5.1)
@@ -25,6 +25,7 @@ GEM
       descendants_tracker (~> 0.0.4)
       ice_nine (~> 0.11.0)
       thread_safe (~> 0.3, >= 0.3.1)
+    byebug (11.1.3)
     coderay (1.1.3)
     coercible (1.0.0)
       descendants_tracker (~> 0.0.1)
@@ -48,6 +49,9 @@ GEM
     pry (0.13.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
+    pry-byebug (3.9.0)
+      byebug (~> 11.0)
+      pry (~> 0.13.0)
     public_suffix (4.0.6)
     rake (12.3.3)
     rspec (3.9.0)
@@ -67,7 +71,7 @@ GEM
     thread_safe (0.3.6)
     typhoeus (1.4.0)
       ethon (>= 0.9.0)
-    tzinfo (1.2.7)
+    tzinfo (1.2.8)
       thread_safe (~> 0.1)
     vcr (6.0.0)
     virtus (1.0.5)
@@ -79,14 +83,14 @@ GEM
       addressable (>= 2.3.6)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    zeitwerk (2.4.0)
+    zeitwerk (2.4.2)
 
 PLATFORMS
   ruby
 
 DEPENDENCIES
   binance_client!
-  pry
+  pry-byebug
   rake (~> 12.0)
   rspec (~> 3.0)
   vcr

data/README.md

@@ -47,7 +47,7 @@ Edit the `config.yml.sample` with your own credentials for testing
 
 ## Contributing
 
-Bug reports and pull requests are welcome on GitHub at https://github.com/iamajvillalobos/binance_client. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/iamajvillalobos/binance_client/blob/master/CODE_OF_CONDUCT.md).
+Bug reports and pull requests are welcome on GitHub at https://github.com/bloom-solutions/binance_client. This project is intended to be a safe, welcoming space for collaboration, and contributors are expected to adhere to the [code of conduct](https://github.com/bloom-solutions/binance_client/blob/master/CODE_OF_CONDUCT.md).
 
 
 ## License
@@ -56,4 +56,4 @@ The gem is available as open source under the terms of the [MIT License](https:/
 
 ## Code of Conduct
 
-Everyone interacting in the BinanceClient project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/iamajvillalobos/binance_client/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the BinanceClient project's codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/bloom-solutions/binance_client/blob/master/CODE_OF_CONDUCT.md).

data/binance_client.gemspec

@@ -8,13 +8,13 @@ Gem::Specification.new do |spec|
 
   spec.summary       = "Ruby wrapper for Binance API"
   spec.description   = "Ruby wrapper for Binance API"
-  spec.homepage      = "https://github.com/iamajvillalobos/binance_client-ruby"
+  spec.homepage      = "https://github.com/bloom-solutions/binance_client-ruby"
   spec.license       = "MIT"
   spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
 
   spec.metadata["homepage_uri"] = spec.homepage
-  spec.metadata["source_code_uri"] = "https://github.com/iamajvillalobos/binance_client-ruby"
-  spec.metadata["changelog_uri"] = "https://github.com/iamajvillalobos/binance_client-ruby/CHANGELOG.md"
+  spec.metadata["source_code_uri"] = "https://github.com/bloom-solutions/binance_client-ruby"
+  spec.metadata["changelog_uri"] = "https://github.com/bloom-solutions/binance_client-ruby/CHANGELOG.md"
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
@@ -28,8 +28,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency "api_client_base"
   spec.add_dependency "activesupport"
   spec.add_dependency "typhoeus"
-  
-  spec.add_development_dependency "pry"
+
   spec.add_development_dependency "vcr"
   spec.add_development_dependency "webmock"
 end

data/lib/binance_client/requests/base_request.rb

@@ -4,6 +4,7 @@ module BinanceClient
 
     attribute :api_key, String
     attribute :api_secret, String
+    attribute :timestamp, Integer, lazy: true, default: :default_timestamp
 
     def headers
       {
@@ -20,7 +21,7 @@ module BinanceClient
       )
     end
 
-    def timestamp
+    def default_timestamp
       DateTime.now.strftime("%Q")
     end
   end

data/lib/binance_client/requests/get_all_request.rb

@@ -7,14 +7,19 @@ module BinanceClient
     end
 
     def query
-      "timestamp=#{timestamp}"
+      uri = Addressable::URI.new(query_values: {
+        timestamp: timestamp,
+      })
+      uri.normalized_query
     end
 
     def params
-      [
-        query,
-        "signature=#{signature(query)}"
-      ].join("&")
+      uri = Addressable::URI.new(query: query)
+      uri.query_values = [
+        uri.query,
+        ["signature", signature(query)],
+      ]
+      uri.normalized_query
     end
   end
-end
+end

data/lib/binance_client/version.rb

@@ -1,3 +1,3 @@
 module BinanceClient
-  VERSION = "0.2.0"
+  VERSION = "1.0.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: binance_client
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 1.0.0
 platform: ruby
 authors:
 - AJ Villalobos
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2020-09-14 00:00:00.000000000 Z
+date: 2020-12-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: api_client_base
@@ -52,20 +52,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: vcr
   requirement: !ruby/object:Gem::Requirement
@@ -101,9 +87,9 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ruby.yml"
 - ".gitignore"
 - ".rspec"
-- ".travis.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
 - Gemfile
@@ -127,14 +113,14 @@ files:
 - lib/binance_client/responses/get_all_response.rb
 - lib/binance_client/responses/system_status_response.rb
 - lib/binance_client/version.rb
-homepage: https://github.com/iamajvillalobos/binance_client-ruby
+homepage: https://github.com/bloom-solutions/binance_client-ruby
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/iamajvillalobos/binance_client-ruby
-  source_code_uri: https://github.com/iamajvillalobos/binance_client-ruby
-  changelog_uri: https://github.com/iamajvillalobos/binance_client-ruby/CHANGELOG.md
-post_install_message: 
+  homepage_uri: https://github.com/bloom-solutions/binance_client-ruby
+  source_code_uri: https://github.com/bloom-solutions/binance_client-ruby
+  changelog_uri: https://github.com/bloom-solutions/binance_client-ruby/CHANGELOG.md
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -149,8 +135,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.0.8
+signing_key:
 specification_version: 4
 summary: Ruby wrapper for Binance API
 test_files: []

data/.travis.yml

@@ -1,6 +0,0 @@
----
-language: ruby
-cache: bundler
-rvm:
-  - 2.7.1
-before_install: gem install bundler -v 2.1.4