binance-ruby 1.2.1 → 1.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 124f7e539a6f6e6003bf7c2619ba039a6a930037976815729398e34adb4686a1
-  data.tar.gz: a6dc10be4aa7629143663260ce33111b96b8a2f50b64ffef88bd219ed282ca12
+  metadata.gz: f18e787ac97c75b40133c007e5e984c0406311b2194517ce069efe2a847f65cb
+  data.tar.gz: c18b5a8826485459a1039fd4b6ee3298ce93cae8afc274f146bb0cb656554401
 SHA512:
-  metadata.gz: 649dd4131cc420ae5b179616fdc4bc8d5b75e96ff864075c07ad47279b5a0819557f4f246a47a07e9367e1430fb8b48d063aa54ec7474397c065772be49d9481
-  data.tar.gz: 68c57f977409d0756df3a982c7a1c92a5b0af26b7c3c1fb3468bba855ac5057f9e0d925e5a81025edc1f78cdb27ac05df2b3d6a08d716e7f42d313014e5fb3db
+  metadata.gz: 5d47d23c9002fb4a8bc5621ca5d4d0928403c5eac520c180958c28039a9aec6eafc4b819a69293ab33b268c4564ff215a966f37bc400061bc52bff4b7a43fc3a
+  data.tar.gz: b97db7627730811f224f3363ee6fda51ed8fccfd840010f0c591e9553bfab940b2cb8dd7935cbacbed43a732b0b5924d34eee6750866aceaec0b7aa296c79171

data/lib/binance-ruby.rb

@@ -6,12 +6,12 @@ require "faye/websocket"
 require "binance/api"
 require "binance/api/account"
 require "binance/api/configuration"
-require "binance/api/data_stream"
 require "binance/api/error"
 require "binance/api/margin"
 require "binance/api/margin/account"
 require "binance/api/margin/order"
 require "binance/api/order"
 require "binance/api/request"
+require "binance/api/user_data_stream"
 require "binance/api/version"
 require "binance/websocket"

data/lib/binance/api/request.rb

@@ -10,8 +10,10 @@ module Binance
           raise Error.new(message: "invalid security type #{security_type}") unless security_types.include?(security_type)
           all_headers = default_headers(api_key_type: api_key_type, security_type: security_type, api_key: api_key)
           params.delete_if { |k, v| v.nil? }
-          signature = signed_request_signature(params: params, api_secret_key: api_secret_key)
-          params.merge!(signature: signature) if [:trade, :user_data].include?(security_type)
+          if %w(trade user_data).include?(security_type&.to_s)
+            signature = signed_request_signature(params: params, api_secret_key: api_secret_key)
+            params.merge!(signature: signature)
+          end
           # send() is insecure so don't use it.
           case method
           when :get

data/lib/binance/api/{data_stream.rb → user_data_stream.rb}

@@ -1,17 +1,18 @@
 module Binance
   module Api
-    class DataStream
+    class UserDataStream
       class << self
         # It's recommended to send a ping about every 30 minutes.
         def keepalive!(listen_key: nil, api_key: nil, api_secret_key: nil)
           raise Error.new(message: "listen_key is required") if listen_key.nil?
           Request.send!(api_key_type: :none, method: :put, path: "/api/v1/userDataStream",
-                        params: { listenKey: listen_key }, security_type: :user_stream)
+                        params: { listenKey: listen_key }, security_type: :user_stream,
+                        api_key: api_key, api_secret_key: api_secret_key)
         end
 
         def start!(api_key: nil, api_secret_key: nil)
           Request.send!(api_key_type: :none, method: :post, path: "/api/v1/userDataStream",
-                        security_type: :user_stream, api_key: api_key, api_secret_key: api_secret_key)
+                        security_type: :user_stream, api_key: api_key, api_secret_key: api_secret_key)[:listenKey]
         end
 
         def stop!(listen_key: nil, api_key: nil, api_secret_key: nil)

data/lib/binance/api/version.rb

@@ -1,5 +1,5 @@
 module Binance
   module Api
-    VERSION = "1.2.1"
+    VERSION = "1.2.2"
   end
 end

data/lib/binance/websocket.rb

@@ -1,9 +1,12 @@
 module Binance
   class WebSocket < Faye::WebSocket::Client
+    class Error < StandardError; end
+
     def initialize(on_open: nil, on_close: nil)
       super "wss://stream.binance.com:9443/stream", nil, ping: 180
 
       @request_id_inc = 0
+      @user_stream_handlers = {}
 
       on :open do |event|
         on_open&.call(event)
@@ -50,6 +53,11 @@ module Binance
       subscribe(symbols_fmt.map { |s| "#{s.downcase}@kline_#{interval}" })
     end
 
+    def user_data_stream!(listen_key, &on_receive)
+      @user_stream_handlers[listen_key] = on_receive
+      subscribe([listen_key])
+    end
+
     private
 
     def process_data(data)
@@ -62,6 +70,11 @@ module Binance
         case json[:data][:e]&.to_sym
         when :kline
           @candlesticks_handler&.call(json[:stream], json[:data])
+        when :outboundAccountPosition
+        when :balanceUpdate
+        when :executionReport # order update
+          listen_key = json[:stream]
+          @user_stream_handlers[listen_key]&.call(listen_key, json[:data])
         end
       end
     end
@@ -78,12 +91,15 @@ module Binance
       }.to_json)
     end
 
-    def unsubscribe(streams)
-      send({
-        method: "UNSUBSCRIBE",
-        params: streams,
-        id: request_id,
-      }.to_json)
-    end
+    # Terminating socket connection achieves the same result.
+    # If you have a use-case for this, please create a GitHub issue.
+    #
+    # def unsubscribe(streams)
+    #   send({
+    #     method: "UNSUBSCRIBE",
+    #     params: streams,
+    #     id: request_id,
+    #   }.to_json)
+    # end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: binance-ruby
 version: !ruby/object:Gem::Version
-  version: 1.2.1
+  version: 1.2.2
 platform: ruby
 authors:
 - Jake Peterson
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2021-05-04 00:00:00.000000000 Z
+date: 2021-05-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: codecov
@@ -95,19 +95,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '12.0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: byebug
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.3
+        version: 11.1.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.11.3
+        version: 11.1.3
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -122,20 +122,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.20.0
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 5.1.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 5.1.0
 - !ruby/object:Gem::Dependency
   name: awrence
   requirement: !ruby/object:Gem::Requirement
@@ -192,6 +178,26 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 5.1.0
 description: Ruby wrapper for the Binance API.
 email:
 - hello@jakenberg.io
@@ -203,7 +209,6 @@ files:
 - lib/binance/api.rb
 - lib/binance/api/account.rb
 - lib/binance/api/configuration.rb
-- lib/binance/api/data_stream.rb
 - lib/binance/api/error.rb
 - lib/binance/api/margin.rb
 - lib/binance/api/margin/account.rb
@@ -211,6 +216,7 @@ files:
 - lib/binance/api/market_stream.rb
 - lib/binance/api/order.rb
 - lib/binance/api/request.rb
+- lib/binance/api/user_data_stream.rb
 - lib/binance/api/version.rb
 - lib/binance/websocket.rb
 homepage: https://github.com/jakenberg/binance-ruby
@@ -236,5 +242,5 @@ requirements: []
 rubygems_version: 3.1.6
 signing_key:
 specification_version: 4
-summary: binance-ruby-1.2.1
+summary: binance-ruby-1.2.2
 test_files: []