bima-shark-sdk 2.4.4 → 3.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e003bacef5ad3777bebedc0d3cc6998774649c19f9d01feceaf3353491368c5e
-  data.tar.gz: 744acc3e2be82f620f064a8d01b9f858939ff0fc28ec35f2b5fd9ea6b86f8d06
+  metadata.gz: 5c3d5438f91e3e0715d520cae493446b62571f4f63baa1dcf4b4ff1ce9a97380
+  data.tar.gz: 7d321474ad227eabb72a5c9f64806e2219a606ce9b804b1c36bf78b8e6176b48
 SHA512:
-  metadata.gz: 7bd2cbb0c39408763febc462074a670cf29a5afdcdaa9e8cf6c7407e7a6d3343829ce291a13361434764b29e9a7b30d7f94f9c09bd2101f73e38b802d77490b8
-  data.tar.gz: bce739bb923bc2aba6dba2095ba000781fe3e2fcc4b44324e328aba34662dbd147373d369cb29bf8929b5babdd1dc2f987a14029318726bde30e602a6ad68f9d
+  metadata.gz: '078265caf5dd06022b0ae91356fd4bd9f8093a879c1191a55297280786be708950652563cf1d5ccb9df8a51c5b9bec7a66f7f8b534eb865ad6142b757310a216'
+  data.tar.gz: ae7031d4aee957a60d2791122b650a713c77b75fa0c661b84444830cc463c5f40ac69dda0f19ed296cf22d7acee21f76346973e523ccb8316bf16ce4ed178ab6

data/CHANGELOG.md

@@ -1,8 +1,12 @@
 ## Changelog
 
+#### 3.0.0
+- new minimum requirements are `Ruby 3.0` and `faraday 2.0`
+- remove `Shark::Subscription`
+
 #### 2.4.4
-* lowest supported Ruby version is 2.7
-* add `recipient` to `Shark::DoubleOptIn::Execution`
+- lowest supported Ruby version is 2.7
+- add `recipient` to `Shark::DoubleOptIn::Execution`
 
 #### 2.4.3
 - allow `Shark::MailingService::Mailer#mail` to use separate layouts

data/bima-shark-sdk.gemspec

@@ -21,10 +21,9 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'activesupport', '>= 4.1.0'
-  spec.add_dependency 'faraday'
-  spec.add_dependency 'json_api_client', '>= 1.10.0'
-  spec.add_dependency 'net-http-persistent'
+  spec.add_dependency 'activesupport'
+  spec.add_dependency 'faraday', '~> 2.0'
+  spec.add_dependency 'json_api_client', '>= 1.23.0'
   spec.add_dependency 'rack'
 
   spec.add_development_dependency 'bundler'

data/lib/shark/client/connection.rb

@@ -12,11 +12,11 @@ module Shark
           params: options[:params] || {}
         }
 
-        @connection = Faraday.new do |faraday|
-          faraday.use Shark::Middleware::ComposeRequest
-          faraday.use Shark::Middleware::Status
-          faraday.use JsonApiClient::Middleware::ParseJson
-          faraday.adapter :net_http_persistent
+        @connection = Faraday.new do |conn|
+          conn.use Shark::Middleware::ComposeRequest
+          conn.use Shark::Middleware::Status
+          conn.response :json, content_type: /\bjson$/
+          conn.adapter Faraday.default_adapter
         end
       end
 

data/lib/shark/configuration.rb

@@ -29,12 +29,6 @@ module Shark
     end
   end
 
-  module SubscriptionService
-    module Resource
-      mattr_accessor :site
-    end
-  end
-
   module SurveyService
     module Resource
       mattr_accessor :site
@@ -65,7 +59,6 @@ module Shark
     attr_reader :form_service
     attr_reader :survey_service
     attr_reader :notification_service
-    attr_reader :subscription_service
     attr_reader :asset_service
     attr_reader :mailing_service
 
@@ -76,7 +69,6 @@ module Shark
       @form_service = Service.new
       @mailing_service = Service.new
       @notification_service = NotificationService::Resource
-      @subscription_service = SubscriptionService::Resource
       @survey_service = SurveyService::Resource
     end
   end

data/lib/shark/rspec/helpers.rb

@@ -5,7 +5,6 @@ require_relative 'helpers/cache_helper'
 require_relative 'fake_asset_service'
 require_relative 'fake_contact_service'
 require_relative 'fake_notification_service'
-require_relative 'fake_subscription_service'
 require_relative 'fake_double_opt_in'
 require_relative 'fake_mailing_service'
 require_relative 'fake_survey_service'

data/lib/shark/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Shark
-  VERSION = '2.4.4'
+  VERSION = '3.0.0'
 end

data/lib/shark.rb

@@ -82,7 +82,6 @@ require 'shark/membership'
 require 'shark/notification'
 require 'shark/package'
 require 'shark/permission'
-require 'shark/subscription'
 require 'shark/survey'
 require 'shark/survey_participant'
 require 'shark/contact_log'

metadata

@@ -1,31 +1,17 @@
 --- !ruby/object:Gem::Specification
 name: bima-shark-sdk
 version: !ruby/object:Gem::Version
-  version: 2.4.4
+  version: 3.0.0
 platform: ruby
 authors:
 - bima-team@justrelate.com
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2024-04-10 00:00:00.000000000 Z
+date: 2024-09-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.1.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 4.1.0
-- !ruby/object:Gem::Dependency
-  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -39,33 +25,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: json_api_client
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.0
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.10.0
+        version: '2.0'
 - !ruby/object:Gem::Dependency
-  name: net-http-persistent
+  name: json_api_client
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.23.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.23.0
 - !ruby/object:Gem::Dependency
   name: rack
   requirement: !ruby/object:Gem::Requirement
@@ -244,9 +230,6 @@ files:
 - lib/shark/rspec/fake_mailing_service/request.rb
 - lib/shark/rspec/fake_notification_service.rb
 - lib/shark/rspec/fake_notification_service/request.rb
-- lib/shark/rspec/fake_subscription_service.rb
-- lib/shark/rspec/fake_subscription_service/object_cache.rb
-- lib/shark/rspec/fake_subscription_service/request.rb
 - lib/shark/rspec/fake_survey_service.rb
 - lib/shark/rspec/fake_survey_service/object_cache.rb
 - lib/shark/rspec/fake_survey_service/request.rb
@@ -257,7 +240,6 @@ files:
 - lib/shark/rspec/helpers/fixtures.rb
 - lib/shark/rspec/helpers/form_service_helper.rb
 - lib/shark/rspec/helpers/response.rb
-- lib/shark/subscription.rb
 - lib/shark/survey.rb
 - lib/shark/survey_participant.rb
 - lib/shark/version.rb
@@ -279,7 +261,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.4.19
 signing_key:
 specification_version: 4
 summary: ''

data/lib/shark/rspec/fake_subscription_service/object_cache.rb

@@ -1,54 +0,0 @@
-# frozen_string_literal: true
-
-module Shark
-  module RSpec
-    module FakeSubscriptionService
-      class ObjectCache
-        include Singleton
-        attr_accessor :objects
-
-        def initialize
-          @objects = []
-        end
-
-        def self.clear
-          instance.objects = []
-        end
-
-        def add(payload_data)
-          id = payload_data.delete('id')
-
-          if id && !objects.find { |subscription| subscription['id'] == id }
-            object = {
-              id: id,
-              attributes: payload_data
-            }
-
-            objects << object
-          else
-            objects << {
-              id: SecureRandom.uuid,
-              attributes: payload_data
-            }
-          end
-          objects.last
-        end
-
-        def add_multiple(payload_data)
-          added = []
-          payload_data.each { |subscription| added << add(subscription) }
-          added.compact
-        end
-
-        def remove(id)
-          objects.delete_if { |subscription| subscription[:id] == id }
-        end
-
-        def remove_multiple(payload_data)
-          payload_data.each { |subscription| remove(subscription['id']) }
-          objects
-        end
-      end
-    end
-  end
-end

data/lib/shark/rspec/fake_subscription_service/request.rb

@@ -1,100 +0,0 @@
-# frozen_string_literal: true
-
-require 'webmock/rspec'
-
-module Shark
-  module RSpec
-    module FakeSubscriptionService
-      class Request
-        include Singleton
-
-        ALLOWED_FILTERS = %w[name subscriberId].freeze
-
-        def self.setup
-          instance = self.instance
-          instance.stub_requests
-        end
-
-        def stub_requests
-          WebMock.stub_request(:post, %r{^#{host}/subscriptions}).to_return do |request|
-            log_info "Faking POST request with body: #{request.body}"
-
-            payload_data = JSON.parse(request.body)['data']['attributes']
-
-            object_data = ObjectCache.instance.add(payload_data)
-
-            SharkSpec.fake_response(201, data: object_data)
-          end
-
-          WebMock.stub_request(
-            :post,
-            %r{^#{host}/subscriptions/bulk_creation}
-          ).to_return do |request|
-            log_info "Faking POST request with body: #{request.body}"
-
-            payload_data = JSON.parse(request.body)['data']['attributes']['subscriptions']
-
-            objects_data = ObjectCache.instance.add_multiple(payload_data)
-
-            SharkSpec.fake_response(201, data: objects_data)
-          end
-
-          WebMock.stub_request(
-            :post,
-            %r{^#{host}/subscriptions/bulk_deletion}
-          ).to_return do |request|
-            log_info "Faking POST request with body: #{request.body}"
-
-            payload_data = JSON.parse(request.body)['data']['attributes']['subscriptions']
-            ObjectCache.instance.remove_multiple(payload_data)
-
-            SharkSpec.fake_response(204, nil)
-          end
-
-          WebMock.stub_request(:delete, %r{^#{host}/subscriptions/.+}).to_return do |request|
-            log_info "Faking DELETE request with body: #{request.body}"
-
-            id = request.uri.path.split('/')[2]
-
-            ObjectCache.instance.remove(id)
-
-            SharkSpec.fake_response(204, nil)
-          end
-
-          WebMock.stub_request(:get, %r{^#{host}/subscriptions}).to_return do |request|
-            log_info 'Faking GET request'
-
-            query_parameters = request.uri.query_values
-
-            objects_data = if query_parameters
-                             params = {}
-                             query_parameters.each do |key, value|
-                               parsed_key = key.match(/filter\[(.*)\]/)[1].camelize(:lower)
-                               params[parsed_key] = value if ALLOWED_FILTERS.include?(parsed_key)
-                             end
-
-                             ObjectCache.instance.objects.select do |subscription|
-                               conditions = params.map do |param, value|
-                                 subscription[:attributes][param] == value
-                               end
-                               conditions.all?
-                             end
-                           else
-                             ObjectCache.instance.objects
-                           end
-
-            SharkSpec.fake_response(200, data: objects_data)
-          end
-        end
-
-        def host
-          Shark.configuration.subscription_service.site
-        end
-
-        def log_info(message)
-          Shark.logger.info "[Shark::SubscriptionService] #{message}"
-        end
-      end
-    end
-  end
-end

data/lib/shark/rspec/fake_subscription_service.rb

@@ -1,19 +0,0 @@
-# frozen_string_literal: true
-
-require_relative 'fake_subscription_service/object_cache'
-require_relative 'fake_subscription_service/request'
-
-module Shark
-  module RSpec
-    module FakeSubscriptionService
-      def self.setup
-        ObjectCache.clear
-        Request.setup
-      end
-
-      def self.reset
-        ObjectCache.clear
-      end
-    end
-  end
-end

data/lib/shark/subscription.rb

@@ -1,43 +0,0 @@
-# frozen_string_literal: true
-
-module Shark
-  class Subscription < Base
-    extend SubscriptionService::Resource
-
-    custom_endpoint :bulk_creation, on: :collection, request_method: :post
-    custom_endpoint :bulk_deletion, on: :collection, request_method: :post
-
-    def self.create_multiple(attributes)
-      bulk_creation(subscriptions_attributes(attributes))
-    end
-
-    def self.destroy_multiple(attributes)
-      bulk_deletion(subscriptions_attributes(attributes))
-    end
-
-    def save
-      if self['id'].present?
-        raise Shark::ActionNotSupportedError,
-              'Shark::Subscription#save is not supported for persisted subscriptions'
-      else
-        super
-      end
-    end
-
-    def update_attributes(_attributes = {})
-      raise Shark::ActionNotSupportedError,
-            'Shark::Subscription#update_attributes is not supported'
-    end
-
-    def self.subscriptions_attributes(attributes)
-      {
-        data: {
-          type: 'bulk-subscriptions',
-          attributes: {
-            subscriptions: attributes
-          }
-        }
-      }
-    end
-  end
-end