bill_forward 1.2016.117 → 2.2016.209

checksums.yaml

@@ -1,7 +1,7 @@
---- 
-SHA1: 
-  data.tar.gz: cb407f764927f632efa78d3b0943c73d49d8eb6b
-  metadata.gz: 863538088b15757ab8a32ad52c5fce80e0b0aab9
-SHA512: 
-  data.tar.gz: 212d2ba8ce914c60e7a3b881731ebef4dc93947e3c7ce71634ebba6aab9c68320440908f50ebf1f3c885e758931bc688276638417c85402f76eadec3990fa02b
-  metadata.gz: 4d5a1a8b0d4782837a6e6aaa96e3eddfe87baf3f2f63d4a8d6742b331b3dbcc5fc40540fd7359feda371fe4f8e61acbf3753352b56ba53397ee7826d434905f2
+---
+SHA1:
+  metadata.gz: 6bac0a04b2fe610fe54fba1c0775c9616b414c6c
+  data.tar.gz: a9e266b50f608de09cfa3920a51c9c5d4c5e10a7
+SHA512:
+  metadata.gz: 489036e8af35a96690eeb0482743d171c0efff0d135bdd29c21470f57b74e55aa60f3141a0828200e0daee3c5217a08d3fe40d31a25963e55f52f770ac169f0e
+  data.tar.gz: 230fde068d38e85c86239501eae443d7262132d436487e877b25d9b46e9d1f729833530441480ed916a6391396511cd674d9994ec004b7ffea2f4d3bac0fca63

data/Gemfile

@@ -4,10 +4,4 @@ source 'https://rubygems.org'
 gemspec
 
 gem 'json', '~> 1.8.1'
-gem 'require_all'
-
-if Gem::Version.new(RUBY_VERSION.dup) < Gem::Version.new('1.9.3')
-	gem 'i18n', '< 0.7'
-	gem 'rest-client', '~> 1.6.8'
-	gem 'activesupport', '~> 3.2'
-end
+gem 'require_all'

data/README.md

@@ -2,6 +2,10 @@
 
 This client library provides (via Ruby) easy access to the BillForward API.
 
+## Support
+
+Until [commit 1ca55](https://github.com/billforward/bf-ruby/tree/1ca55ca8d361130c935df68e3b6496611221938a), [version 1.2016.117](https://rubygems.org/gems/bill_forward/versions/1.2016.117), the SDK targeted Ruby 1.8.7.
+
 ## Installation
 ### From Git
 

data/bill_forward.gemspec

@@ -21,6 +21,7 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rest-client', '~> 1.4'
   spec.add_dependency 'json', '~> 1.8.1'
   spec.add_dependency 'require_all'
+  spec.add_dependency 'activesupport'
 
   spec.add_development_dependency "bundler", "~> 1.6"
   spec.add_development_dependency "rspec"

data/lib/bill_forward/billing_entity.rb

@@ -6,7 +6,7 @@ module BillForward
 
 		def initialize(state_params = nil, client = nil)
 			raise AbstractInstantiateError.new('This abstract class cannot be instantiated!') if self.class == MutableEntity
-			
+
 			client = self.class.singleton_client if client.nil?
 			state_params = {} if state_params.nil?
 
@@ -20,7 +20,7 @@ module BillForward
 			# initiate with empty state params
 			# use indifferent hash so 'id' and :id are the same
 			@_state_params = HashWithIndifferentAccess.new
-			# legacy Ruby gives us this 'id' chuff. we kinda need it back.	
+			# legacy Ruby gives us this 'id' chuff. we kinda need it back.
 			@_state_params.instance_eval { undef id if defined? id }
 			# populate state params now
 			unserialize_all state_params
@@ -143,14 +143,16 @@ module BillForward
 
 		def method_missing(method_id, *arguments, &block)
 			def camel_case_lower(operand)
-				operand.split('_').reduce('') do |accumulator, iterand|
-					accumulator.empty? \
-						? iterand \
-						: accumulator + iterand.capitalize
-				end
+				elements = operand.split('_')
+				camel_cased = elements.join('_').camelize(:lower)
+
+				camel_cased.gsub!(/Id/, 'ID') if elements.size > 1 && elements.last =~ /id=?\Z/
+
+				camel_cased
 			end
 
 			qualified = camel_case_lower method_id.to_s
+
 			if qualified != method_id.to_s
 				return self.send(qualified.intern, *arguments)
 			end
@@ -196,7 +198,7 @@ module BillForward
 				field
 			end
 		end
-		
+
 		def to_ordered_hash
 			serialize_field self
 		end
@@ -329,4 +331,4 @@ module BillForward
 			end
 		end
 	end
-end
+end

data/lib/bill_forward/version.rb

@@ -1,4 +1,4 @@
 module BillForward
   # in an rspec run, the gemspec and bill_forward.rb loader will both visit this
-  VERSION = "1.2016.117" unless const_defined?(:VERSION)
+  VERSION = "2.2016.209" unless const_defined?(:VERSION)
 end

data/spec/component/subscription_spec.rb

@@ -9,27 +9,28 @@ describe BillForward::Subscription do
       # skip OAuth request
       allow_any_instance_of(BillForward::Client).to receive(:get_token).and_return('fake token')
    end
+
 	describe '::get_by_id' do
 		context 'where subscription exists' do
 			describe 'the unserialized subscription' do
+				let(:response) { double :response }
+				let(:subscription_id) { 'ACD66517-6F32-44CB-AF8C-3097F97E1E67' }
+				let(:subscription) { BillForward::Subscription.get_by_id(subscription_id) }
+
+				before do
+					allow(response).to receive(:to_str).and_return(canned_subscription_get)
+					allow(RestClient::Request).to receive(:execute).and_return(response)
+					# mainly just confirm that unserialization is reasonably healthy.
+					expect(subscription.id).to eq(subscription_id)
+				end
+
 				describe '.to_ordered_hash' do
 					context 'using array access' do
 						it "has @type at top" do
-				            subscription_id = 'ACD66517-6F32-44CB-AF8C-3097F97E1E67'
-
-				            response = double
-				            allow(response).to receive(:to_str).and_return(canned_subscription_get)
-				            allow(RestClient::Request).to receive(:execute).and_return(response)
-
-				            subscription = BillForward::Subscription.get_by_id subscription_id
-
-				            # mainly just confirm that unserialization is reasonably healthy.
-				            expect(subscription.id).to eq(subscription_id)
-
-				            # check that @type is the first key on subscription (we use ordered hashes)
-				            payload = subscription.to_ordered_hash
-				            payload_first_kvp = payload.first
-				            kvp_key  = payload_first_kvp.first
+							# check that @type is the first key on subscription (we use ordered hashes)
+							payload = subscription.to_ordered_hash
+							payload_first_kvp = payload.first
+							kvp_key  = payload_first_kvp.first
 							expect(kvp_key).to eq('@type')
 
 							# check that @type is the first key on nested entities (we use ordered hashes)
@@ -41,17 +42,6 @@ describe BillForward::Subscription do
 					end
 					context 'using dot access' do
 						it "has @type at top" do
-				            subscription_id = 'ACD66517-6F32-44CB-AF8C-3097F97E1E67'
-
-				            response = double
-				            allow(response).to receive(:to_str).and_return(canned_subscription_get)
-				            allow(RestClient::Request).to receive(:execute).and_return(response)
-
-				            subscription = BillForward::Subscription.get_by_id subscription_id
-
-				            # mainly just confirm that unserialization is reasonably healthy.
-				            expect(subscription.id).to eq(subscription_id)
-
 				            # check that @type is the first key on subscription (we use ordered hashes)
 				            payload = subscription.to_ordered_hash
 				            payload_first_kvp = payload.first
@@ -64,6 +54,17 @@ describe BillForward::Subscription do
 							kvp_key  = pricing_component_first_kvp.first
 							expect(kvp_key).to eq('@type')
 						end
+
+						it 'has product_id at the top' do
+							expect(subscription.product_id).to eq("0CE0A471-A8B1-4E33-B5F4-115947DE8C55")
+						end
+
+                                                it 'can set the product_id to something else' do
+                                                  subscription.product_id = 100
+                                                  expect(subscription.product_id).to eq(100)
+                                                  expect(subscription.productID).to eq(100)
+                                                  expect(subscription['productID']).to eq(100)
+                                                end
 					end
 				end
 				# NOTE: ideally no anonymous entity would exist, because we would register all known nested entities.
@@ -74,26 +75,10 @@ describe BillForward::Subscription do
 				describe 'nested anonymous entity' do
 					context 'using dot access' do
 						it "can be read" do
-				            subscription_id = 'ACD66517-6F32-44CB-AF8C-3097F97E1E67'
-
-				            response = double
-				            allow(response).to receive(:to_str).and_return(canned_subscription_get)
-				            allow(RestClient::Request).to receive(:execute).and_return(response)
-
-				            subscription = BillForward::Subscription.get_by_id subscription_id
-
 							a_pricing_component = subscription.productRatePlan.pricingComponents.first
 							expect(a_pricing_component.name).to eq('Devices used, fixed')
 						end
 						it "can be changed" do
-				            subscription_id = 'ACD66517-6F32-44CB-AF8C-3097F97E1E67'
-
-				            response = double
-				            allow(response).to receive(:to_str).and_return(canned_subscription_get)
-				            allow(RestClient::Request).to receive(:execute).and_return(response)
-
-				            subscription = BillForward::Subscription.get_by_id subscription_id
-
 							a_pricing_component = subscription.productRatePlan.pricingComponents.first
 							expect(a_pricing_component.name).to eq('Devices used, fixed')
 
@@ -105,26 +90,10 @@ describe BillForward::Subscription do
 					end
 					context 'using array access' do
 						it "can be read" do
-				            subscription_id = 'ACD66517-6F32-44CB-AF8C-3097F97E1E67'
-
-				            response = double
-				            allow(response).to receive(:to_str).and_return(canned_subscription_get)
-				            allow(RestClient::Request).to receive(:execute).and_return(response)
-
-				            subscription = BillForward::Subscription.get_by_id subscription_id
-
 							a_pricing_component = subscription['productRatePlan']['pricingComponents'].first
 							expect(a_pricing_component['name']).to eq('Devices used, fixed')
 						end
 						it "can be changed" do
-				            subscription_id = 'ACD66517-6F32-44CB-AF8C-3097F97E1E67'
-
-				            response = double
-				            allow(response).to receive(:to_str).and_return(canned_subscription_get)
-				            allow(RestClient::Request).to receive(:execute).and_return(response)
-
-				            subscription = BillForward::Subscription.get_by_id subscription_id
-
 							a_pricing_component = subscription['productRatePlan']['pricingComponents'].first
 							expect(a_pricing_component['name']).to eq('Devices used, fixed')
 
@@ -354,4 +323,4 @@ def canned_subscription_get
       "fixedTerms" : [ ]
    } ]
 }'
-end
+end

data/spec/functional/bad_citizen/situational/subscription_chargeable_spec.rb

@@ -21,21 +21,21 @@ describe BillForward::Subscription do
 			first_org = organisations.first
 
 
-			# remove from our organisation all existing AuthorizeNetConfigurations (if any)
-			filtered = first_org.apiConfigurations.reject do |config|
-				config['@type'] == 'AuthorizeNetConfiguration'
-			end
-			first_org.apiConfigurations = filtered
+			# # remove from our organisation all existing AuthorizeNetConfigurations (if any)
+			# filtered = first_org.apiConfigurations.reject do |config|
+			# 	config['@type'] == 'AuthorizeNetConfiguration'
+			# end
+			# first_org.apiConfigurations = filtered
 
 
-			# add to our organisation: a new AuthorizeNetConfiguration
-			first_org.apiConfigurations.push BillForward::APIConfiguration.new({
-				 "@type" =>          "AuthorizeNetConfiguration",
-			     "APILoginID" =>     @authorize_net_login_id,
-			     "transactionKey" => @authorize_net_transaction_key,
-			     "environment" =>    "Sandbox"
-				})
-			updated_org = first_org.save
+			# # add to our organisation: a new AuthorizeNetConfiguration
+			# first_org.apiConfigurations.push BillForward::APIConfiguration.new({
+			# 	 "@type" =>          "AuthorizeNetConfiguration",
+			#      "APILoginID" =>     @authorize_net_login_id,
+			#      "transactionKey" => @authorize_net_transaction_key,
+			#      "environment" =>    "Sandbox"
+			# 	})
+			# updated_org = first_org.save
 
 
 			# create an account
@@ -236,7 +236,7 @@ describe BillForward::Subscription do
 			@created_account = created_account
 			@created_prp = created_prp
 			@created_payment_method = created_payment_method
-			@updated_org = updated_org
+			@updated_org = first_org
 		end
 		subject(:account) { @created_account }
 		subject(:prp) { @created_prp }

metadata

@@ -1,85 +1,122 @@
---- !ruby/object:Gem::Specification 
+--- !ruby/object:Gem::Specification
 name: bill_forward
-version: !ruby/object:Gem::Version 
-  version: 1.2016.117
+version: !ruby/object:Gem::Version
+  version: 2.2016.209
 platform: ruby
-authors: 
+authors:
 - BillForward
 autorequire: 
 bindir: bin
 cert_chain: []
-
-date: 2016-04-27 00:00:00 Z
-dependencies: 
-- !ruby/object:Gem::Dependency 
+date: 2016-07-28 00:00:00.000000000 Z
+dependencies:
+- !ruby/object:Gem::Dependency
   name: rest-client
-  prerelease: false
-  requirement: &id001 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        version: "1.4"
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.4'
   type: :runtime
-  version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: json
   prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.4'
+- !ruby/object:Gem::Dependency
+  name: json
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
         version: 1.8.1
   type: :runtime
-  version_requirements: *id002
-- !ruby/object:Gem::Dependency 
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.8.1
+- !ruby/object:Gem::Dependency
   name: require_all
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :runtime
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
-    requirements: 
-    - &id005 
-      - ">="
-      - !ruby/object:Gem::Version 
-        version: "0"
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: activesupport
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :runtime
-  version_requirements: *id003
-- !ruby/object:Gem::Dependency 
-  name: bundler
   prerelease: false
-  requirement: &id004 !ruby/object:Gem::Requirement 
-    requirements: 
-    - - ~>
-      - !ruby/object:Gem::Version 
-        version: "1.6"
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: bundler
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.6'
   type: :development
-  version_requirements: *id004
-- !ruby/object:Gem::Dependency 
-  name: rspec
   prerelease: false
-  requirement: &id006 !ruby/object:Gem::Requirement 
-    requirements: 
-    - *id005
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.6'
+- !ruby/object:Gem::Dependency
+  name: rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id006
-- !ruby/object:Gem::Dependency 
-  name: rake
   prerelease: false
-  requirement: &id007 !ruby/object:Gem::Requirement 
-    requirements: 
-    - *id005
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
   type: :development
-  version_requirements: *id007
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Enables you to call the BillForward API easily using Ruby
-email: 
+email:
 - support@billforward.net
 executables: []
-
 extensions: []
-
 extra_rdoc_files: []
-
-files: 
-- .gitignore
-- .rspec
+files:
+- ".gitignore"
+- ".rspec"
 - Gemfile
 - LICENSE.md
 - README.md
@@ -167,29 +204,30 @@ files:
 - tools/local_bundle_build.sh
 - tools/local_bundle_install.sh
 homepage: http://www.billforward.net
-licenses: 
+licenses:
 - MIT
 metadata: {}
-
 post_install_message: 
 rdoc_options: []
-
-require_paths: 
+require_paths:
 - lib
-required_ruby_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - *id005
-required_rubygems_version: !ruby/object:Gem::Requirement 
-  requirements: 
-  - *id005
+required_ruby_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
+required_rubygems_version: !ruby/object:Gem::Requirement
+  requirements:
+  - - ">="
+    - !ruby/object:Gem::Version
+      version: '0'
 requirements: []
-
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: BillForward Ruby Client Library
-test_files: 
+test_files:
 - spec/component/account_spec.rb
 - spec/component/billing_entity_spec.rb
 - spec/component/invoice_spec.rb