bigcartel-theme-fonts 1.8.1 → 1.8.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c24d66f05033aa4200161c1f0c2e1f76b2e2d7ffc05ebf2c7362d0402c83d731
-  data.tar.gz: c2c5567bbd85fa600d66c62d561984d9bd16cd7c60132f6684620d63112c99b3
+  metadata.gz: d58b062226017f9cf542de6c90d1cdb4a2f6ffc780948745c497d7b0384ef4a1
+  data.tar.gz: a1f4600d2e543286f9a4312216387b183b0534734cc66bef62155a3a0f0ab2fc
 SHA512:
-  metadata.gz: 4a321d1697c53a3dba38e686faa7dff2f7425ca78f604153e209dcfccaf2cfabd551dd7866bf99ed5b7f8f02e5dfb1260afd9fca1b3ca379ebe719a62b978792
-  data.tar.gz: 8ecd906210fdae6fd8ea4d7a239cc520d27630a9785b7631a2a124b2110bd9d41915a3a3e94f45c9b9c4aa539427e70cebb7b00ec7d70453c42fae96d03a2118
+  metadata.gz: 1cc9c664c5678b0005512f22cfcf23f142bf158838adf52042535da9468a7a6a1d7c98d8841a034e5ed5b48b9acf9d132df2beb69aa38dfb10a03a10fbdcd3cf
+  data.tar.gz: 15cccfc9483a7391b06cc7fee064fdbc9f0e452ef02b933f71562c7f31ce560eadca6f1c38a9b9b58047a87c51f3cfe0b4e8388f260372e18eb747bef5564b8b

data/bigcartel-theme-fonts.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
   spec.name          = 'bigcartel-theme-fonts'
-  spec.version       = '1.8.1'
+  spec.version       = '1.8.2'
   spec.authors       = ['Big Cartel']
   spec.email         = ['dev@bigcartel.com']
   spec.description   = %q{A simple class for working with Big Cartel's supported theme fonts.}

data/lib/bigcartel/theme/fonts/theme_font.rb

@@ -69,12 +69,12 @@ class ThemeFont < Struct.new(:name, :family, :weights, :collection)
     def google_font_url_for_theme_json(account_theme)
       # Cosmos and Lunch Break use the secondary font for the primary text font
       font_setting = if ["cosmos", "lunch break"].include?(account_theme.theme.name.downcase)
-        account_theme.settings["secondary_font"]
+        account_theme.settings[:secondary_font]
       else
-        account_theme.settings["primary_font"] ||
-        account_theme.settings["text_font"] ||
-        account_theme.settings["font"] ||
-        account_theme.settings["serif_font"]
+        account_theme.settings[:primary_font] ||
+        account_theme.settings[:text_font] ||
+        account_theme.settings[:font] ||
+        account_theme.settings[:serif_font]
       end
 
       font = find_by_name(font_setting)

data/spec/theme_font_spec.rb

@@ -158,7 +158,7 @@ describe ThemeFont do
 
     context "with default theme" do
       it "uses primary_font when present" do
-        stub(account_theme).settings { { "primary_font" => "One Font" } }
+        stub(account_theme).settings { { primary_font: "One Font" } }
         result = ThemeFont.google_font_url_for_theme_json(account_theme)
         result.should == {
           "primary_text_font" => "https://fonts.googleapis.com/css?family=One+Font"
@@ -167,7 +167,7 @@ describe ThemeFont do
 
       context "font setting fallback stack" do
         it "falls back to text_font when primary_font is absent" do
-          stub(account_theme).settings { { "text_font" => "Three" } }
+          stub(account_theme).settings { { text_font: "Three" } }
           result = ThemeFont.google_font_url_for_theme_json(account_theme)
           result.should == {
             "primary_text_font" => "https://fonts.googleapis.com/css?family=Three"
@@ -175,7 +175,7 @@ describe ThemeFont do
         end
 
         it "falls back to font when primary_font and text_font are absent" do
-          stub(account_theme).settings { { "font" => "One Font" } }
+          stub(account_theme).settings { { font: "One Font" } }
           result = ThemeFont.google_font_url_for_theme_json(account_theme)
           result.should == {
             "primary_text_font" => "https://fonts.googleapis.com/css?family=One+Font"
@@ -183,7 +183,7 @@ describe ThemeFont do
         end
 
         it "falls back to serif_font when all others are absent" do
-          stub(account_theme).settings { { "serif_font" => "Three" } }
+          stub(account_theme).settings { { serif_font:"Three" } }
           result = ThemeFont.google_font_url_for_theme_json(account_theme)
           result.should == {
             "primary_text_font" => "https://fonts.googleapis.com/css?family=Three"
@@ -192,10 +192,10 @@ describe ThemeFont do
 
         it "prefers primary_font over other settings" do
           stub(account_theme).settings { {
-            "primary_font" => "One Font",
-            "text_font" => "Three",
-            "font" => "Three",
-            "serif_font" => "Three"
+            primary_font: "One Font",
+            text_font: "Three",
+            font: "Three",
+            serif_font: "Three"
           } }
           result = ThemeFont.google_font_url_for_theme_json(account_theme)
           result.should == {
@@ -205,13 +205,13 @@ describe ThemeFont do
       end
 
       it "returns empty hash for non-Google font" do
-        stub(account_theme).settings { { "primary_font" => "Two" } }
+        stub(account_theme).settings { { primary_font: "Two" } }
         result = ThemeFont.google_font_url_for_theme_json(account_theme)
         result.should == {}
       end
 
       it "returns empty hash for unknown font" do
-        stub(account_theme).settings { { "primary_font" => "Unknown" } }
+        stub(account_theme).settings { { primary_font: "Unknown" } }
         result = ThemeFont.google_font_url_for_theme_json(account_theme)
         result.should == {}
       end
@@ -221,7 +221,7 @@ describe ThemeFont do
       let(:theme) { double("Theme", name: "cosmos") }
 
       it "uses secondary_font setting" do
-        stub(account_theme).settings { { "secondary_font" => "Three" } }
+        stub(account_theme).settings { { secondary_font: "Three" } }
         result = ThemeFont.google_font_url_for_theme_json(account_theme)
         result.should == {
           "primary_text_font" => "https://fonts.googleapis.com/css?family=Three"
@@ -230,8 +230,8 @@ describe ThemeFont do
 
       it "ignores primary_font when secondary_font is present" do
         stub(account_theme).settings { {
-          "secondary_font" => "Three",
-          "primary_font" => "One Font"
+          secondary_font: "Three",
+          primary_font: "One Font"
         } }
         result = ThemeFont.google_font_url_for_theme_json(account_theme)
         result.should == {
@@ -244,7 +244,7 @@ describe ThemeFont do
       let(:theme) { double("Theme", name: "lunch break") }
 
       it "uses secondary_font setting" do
-        stub(account_theme).settings { { "secondary_font" => "One Font" } }
+        stub(account_theme).settings { { secondary_font: "One Font" } }
         result = ThemeFont.google_font_url_for_theme_json(account_theme)
         result.should == {
           "primary_text_font" => "https://fonts.googleapis.com/css?family=One+Font"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bigcartel-theme-fonts
 version: !ruby/object:Gem::Version
-  version: 1.8.1
+  version: 1.8.2
 platform: ruby
 authors:
 - Big Cartel