bidu-house 0.2.1 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a983db5f6db921362ce62f4d7f0a0cbe09272968
-  data.tar.gz: bfc7a4ace34f0eb1ba940ad1e562e2ed0351d98c
+  metadata.gz: e81c76e00406e53d4990c5cc225f38e81fa4de1c
+  data.tar.gz: cf6bd8a5b1f369c44cf2b3e4c67464a13c4e4700
 SHA512:
-  metadata.gz: b4c2f0f4e0c0c5151a98171e5ae307cf332c965b00e3dacc44dfa05ea369f9aa2fedd5b984c5231ebe3d96c5514b3abc7746471e02d5aaf5cf267c825179e943
-  data.tar.gz: 535155a3de8ecb7e6a101e80a1d3bd287c75d3be780a9d53df3221deb1cb38d1be5286b988e56cf2b9f1b4bc1b98f460c9fe69ca1b1f79366a11351d3a816273
+  metadata.gz: 6dc1bf73244b34f0a5c84c8ca65238f4f43bcf94b7278d6d028f41e3e9d0351a4711cd08ab95a93499ff7033c7ff9e52e3c0cdb84cc3bba7ac5b67ead002be67
+  data.tar.gz: a6d7313fa19994b600c4a87bb83191d1ca8e289563756e8b23a52a122712d104daed6e6561a4975a4ebb2d1a029a8b44e57c9ac0550f3947de666e0a6f3852af

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bidu-house (0.2.1)
+    bidu-house (1.0.0)
       activesupport
       bidu-active_ext
       concern_builder
@@ -27,7 +27,7 @@ GEM
     bidu-active_ext (1.0.0)
       activesupport
       bidu-core_ext
-    bidu-core_ext (1.2.1)
+    bidu-core_ext (1.2.2)
       activesupport
     builder (3.2.2)
     coderay (1.1.0)
@@ -82,4 +82,4 @@ DEPENDENCIES
   sqlite3
 
 BUNDLED WITH
-   1.10.6
+   1.12.5

data/README.md

@@ -50,6 +50,9 @@ with error and render the report
  - threshold: default report threshold (default: 0.02)
  - period: default search period (default: 1 day)
  - on: report bucket (default: :default)
+ - base_scope: scope to be universal sample
+ - uniq: when the output ids should not be repeated
+ - limit: limit of ids to be outputed
 
 4. Run the server and hit the health-check routes
 

data/lib/bidu/house/report/error.rb

@@ -1,29 +1,22 @@
 module Bidu
   module House
-    module Report
-      class Error
-        include JsonParser
-
+    class Report
+      class Error < Report
         ALLOWED_PARAMETERS=[:period, :threshold]
-
-        attr_reader :json
+        DEFAULT_OPTION = {
+          external_key: :id,
+          threshold: 0.02,
+          period: 1.day,
+          scope: :with_error,
+          base_scope: :all,
+          uniq: false
+        }
 
         json_parse :threshold, type: :float
-        json_parse :period, type: :period
-        json_parse :scope, :id, :clazz, :base_scope, :external_key, case: :snake
+        json_parse :scope, :id, :external_key, :uniq, :limit, case: :snake
 
         def initialize(options)
-          @json = {
-            external_key: :id,
-            threshold: 0.02,
-            period: 1.day,
-            scope: :with_error,
-            base_scope: :all
-          }.merge(options)
-        end
-
-        def status
-          @status ||= error? ? :error : :ok
+          super(DEFAULT_OPTION.merge(options))
         end
 
         def percentage
@@ -38,13 +31,9 @@ module Bidu
           @error ||= percentage > threshold
         end
 
-        def status
-          error? ? :error : :ok
-        end
-
         def as_json
           {
-            ids: scoped.pluck(external_key),
+            ids: ids,
             percentage: percentage,
             status: status
           }
@@ -52,6 +41,14 @@ module Bidu
 
         private
 
+        def ids
+          relation = scoped
+          relation = relation.uniq if uniq
+          relation = relation.limit(limit) if limit
+
+          relation.pluck(external_key)
+        end
+
         def fetch_percentage
           if (scope.is_a?(Symbol))
             last_entries.percentage(*(scope.to_s.split('.').map(&:to_sym)))
@@ -59,24 +56,6 @@ module Bidu
             last_entries.percentage(scope)
           end
         end
-
-        def fetch_scoped(base, scope)
-          if (scope.is_a?(Symbol))
-            scope.to_s.split('.').inject(base) do |entries, method|
-              entries.public_send(method)
-            end
-          else
-            base.where(scope)
-          end
-        end
-
-        def last_entries
-          @last_entries ||= base.where('updated_at >= ?', period.seconds.ago)
-        end
-
-        def base
-          fetch_scoped(clazz, base_scope)
-        end
       end
     end
   end

data/lib/bidu/house/report.rb

@@ -1,7 +1,51 @@
 module Bidu
   module House
-    module Report
+    class Report
+      include JsonParser
       require 'bidu/house/report/error'
+      ALLOWED_PARAMETERS = []
+      DEFAULT_OPTION = {}
+
+      attr_reader :json
+
+      json_parse :period, type: :period
+      json_parse :clazz, :base_scope, case: :snake
+
+      def initialize(options)
+        @json = DEFAULT_OPTION.merge(options)
+      end
+
+      def status
+        @status ||= error? ? :error : :ok
+      end
+
+      def error?
+        raise 'Not implemented yet'
+      end
+
+      def as_json
+        { status: status }
+      end
+
+      private
+
+      def fetch_scoped(base, scope)
+        if (scope.is_a?(Symbol))
+          scope.to_s.split('.').inject(base) do |entries, method|
+            entries.public_send(method)
+          end
+        else
+          base.where(scope)
+        end
+      end
+
+      def last_entries
+        @last_entries ||= base.where('updated_at >= ?', period.seconds.ago)
+      end
+
+      def base
+        fetch_scoped(clazz, base_scope)
+      end
     end
   end
 end

data/lib/bidu/house/version.rb

@@ -1,5 +1,5 @@
 module Bidu
   module House
-    VERSION = '0.2.1'
+    VERSION = '1.0.0'
   end
 end

data/spec/lib/bidu/house/report/error_spec.rb

@@ -341,6 +341,35 @@ describe Bidu::House::Report::Error do
         it 'returns the correct external keys' do
           expect(subject.as_json).to eq(expected)
         end
+
+        context 'when some external ids are the same' do
+          let(:ids_expected) { [10, 10, 10] }
+          before do
+            Document.update_all(outter_external_id: 10)
+          end
+
+          it 'returns the correct external keys' do
+            expect(subject.as_json).to eq(expected)
+          end
+
+          context 'and passing uniq option' do
+            before { options[:uniq] = true }
+            let(:ids_expected) { [10] }
+
+            it 'returns the correct external keys only once' do
+              expect(subject.as_json).to eq(expected)
+            end
+          end
+        end
+
+        context 'with a limit' do
+          before { options[:limit] = 2 }
+          let(:ids_expected) { [0, 1] }
+
+          it 'returns only the limited ids' do
+            expect(subject.as_json).to eq(expected)
+          end
+        end
       end
 
       context 'when configurated without external key' do

data/spec/support/report/dummy.rb

@@ -1,7 +1,7 @@
 module Bidu
   module House
-    module Report
-      class Dummy
+    class Report
+      class Dummy < Report
         ALLOWED_PARAMETERS=[:period, :threshold]
         def initialize(options)
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bidu-house
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 1.0.0
 platform: ruby
 authors:
 - Bidu Dev's Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-01 00:00:00.000000000 Z
+date: 2016-08-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -222,7 +222,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.8
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: Gem for easy health check