bidi2pdf 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dbc473cb8b54517914bfa958b1925d97db54ab3e6ee640a28101b48346077192
-  data.tar.gz: 76c2d11f399a33a932f66348cfc3aad9d0c80f1e15407566b10d16a646b17d1c
+  metadata.gz: 715f3587349e1680386f0c485f45b91a6096143c07cc8b531ca7e284a9516615
+  data.tar.gz: 8914fd60cdb04510070dee6b6d7134a94666584583681e26e830824bbf457059
 SHA512:
-  metadata.gz: eb72b6bc4eeb2a65172c37138be3f2af5129a046a217acaf90236532c323547e0f1456f7743c509015808389da586b145cd069a26a85bbc35278c44cfea32249
-  data.tar.gz: e3b6d68003a6419e86fa33a68b51c065d7d60f95cc7bf657b12cb13ed5bef085938599b5387aca641b1a699ec47fab6804e300892b962a842d06748b061a1e5d
+  metadata.gz: a8e17273531b0131ef9e8b5454154996dbd340d18cbf16a151478b91234e1e53005e0ffb057e16d540f6870b8915bafbdf03831afc2d9b4e9d861494ca13c38f
+  data.tar.gz: d0a4d3b193fc51b681a2e3b54da5cc7cccf05cf578b908144eb7ca5988327f0ee938b07dce88ca826d37889a469e3f32a7da61c68bbb05b5913731aeb0cc9e38

data/.rubocop.yml

@@ -48,6 +48,16 @@ RSpec/InstanceVariable:
 RSpec/BeforeAfterAll:
   Enabled: false
 
+RSpec/SpecFilePathFormat:
+  Enabled: true
+  Exclude:
+    - 'spec/acceptance/**/*_spec.rb'
+
+RSpec/DescribeClass:
+  Enabled: true
+  Exclude:
+    - 'spec/acceptance/**/*_spec.rb'
+
 plugins:
   - rubocop-rake
   - rubocop-rspec

data/CHANGELOG.md

@@ -6,8 +6,20 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [Unreleased]
+
+[unreleased]: https://github.com/dieter-medium/bidi2pdf/compare/v0.1.2..HEAD
+
 <!-- generated by git-cliff end -->
 
+## [0.1.3] - 2025-04-06
+
+### 🐛 Fixed
+
+- Improve zombie process detection and termination logic in Chromedriver manager by @dieter-medium
+- Add close method for WebSocket connection and update session close logic. Don't leak threads. by @dieter-medium
+
 ## [0.1.2] - 2025-04-05
 
 ### 🔄 Changed

data/cliff.toml

@@ -79,33 +79,57 @@ commit_preprocessors = [
 ]
 # regex for parsing and grouping commits
 commit_parsers = [
-    # ✅ Additions
-      { message = "^[a|A]dd", group = "🚀 Added" },
-      { message = "^[s|S]upport", group = "🚀 Added" },
-      { message = "^.*: add", group = "🚀 Added" },
-      { message = "^.*: support", group = "🚀 Added" },
-
-      # ❌ Removals
-      { message = "^[r|R]emove", group = "🗑️ Removed" },
-      { message = "^.*: remove", group = "🗑️ Removed" },
-      { message = "^.*: delete", group = "🗑️ Removed" },
-
-      # 🐛 Fixes
-      { message = "^test", group = "🐛 Fixed" },
-      { message = "^fix", group = "🐛 Fixed" },
-      { message = "^.*: fix", group = "🐛 Fixed" },
-
-      # ⛔️ Chore & CI commits to skip
-      { message = "^chore\\(release\\): prepare for", skip = true },
-      { message = "^chore\\(deps.*\\)", skip = true },
-      { message = "^chore\\(pr\\)", skip = true },
-      { message = "^chore\\(pull\\)", skip = true },
-      { message = "^chore", skip = true },
-      { message = "^ci", skip = true },
-
-      # 🌀 Catch-All
-      { message = "^.*", group = "🔄 Changed" }
+    # ✅ Features (additions)
+    { message = "^feat(?:\\([^)]+\\))?!?:", group = "🚀 Added" },
+    { message = "^[aA]dd", group = "🚀 Added" },
+    { message = "^[sS]upport", group = "🚀 Added" },
+
+    # ❌ Removals
+    { message = "^[rR]emove", group = "🗑️ Removed" },
+    { message = "^[dD]elete", group = "🗑️ Removed" },
+
+    # 🐛 Fixes
+    { message = "^fix(?:\\([^)]+\\))?!?:", group = "🐛 Fixed" },
+    { message = "^[tT]est", group = "🐛 Fixed" },
+    { message = "^[fF]ix", group = "🐛 Fixed" },
+
+    # 🎨 Refactors
+    { message = "^refactor(?:\\([^)]+\\))?!?:", group = "🎨 Refactored" },
+
+    # ⚡️ Performance
+    { message = "^perf(?:\\([^)]+\\))?!?:", group = "⚡️ Performance" },
+
+    # 📝 Docs
+    { message = "^docs(?:\\([^)]+\\))?!?:", group = "📝 Docs" },
+
+    # 💄 Style (formatting, whitespace, etc.)
+    { message = "^style(?:\\([^)]+\\))?!?:", group = "💄 Style" },
+
+    # 🧪 Tests
+    { message = "^test(?:\\([^)]+\\))?!?:", group = "🧪 Tests" },
+
+    # 🔧 Build
+    { message = "^build(?:\\([^)]+\\))?!?:", group = "🔧 Build" },
+
+    # 🛠️ CI
+    { message = "^ci(?:\\([^)]+\\))?!?:", skip = true },
+
+    # 🧹 Chores (skip)
+    { message = "^chore\\(release\\): prepare for", skip = true },
+    { message = "^chore\\(deps.*\\)", skip = true },
+    { message = "^chore\\(pr\\)", skip = true },
+    { message = "^chore\\(pull\\)", skip = true },
+    { message = "^chore(?:\\([^)]+\\))?!?:", skip = true },
+    { message = "^\\s*chore", skip = true },
+
+    # ⏪ Reverts
+    { message = "^revert(?:\\([^)]+\\))?!?:", group = "⏪ Reverted" },
+
+    # 🌀 Catch-all (only if nothing else matched)
+    { message = "^.*", group = "🔄 Changed" }
 ]
+
+
 # filter out the commits that are not matched by commit parsers
 filter_commits = false
 # sort the tags topologically

data/docker/nginx/default.conf

@@ -39,4 +39,10 @@ server {
              return 403;
          }
     }
+
+    location /nginx_status {
+        stub_status on;
+
+        access_log off;
+    }
 }

data/lib/bidi2pdf/bidi/client.rb

@@ -18,14 +18,6 @@ module Bidi2pdf
 
       def initialize(ws_url)
         @ws_url = ws_url
-        @id = 0
-        @pending_responses = {}
-
-        @connected = false
-        @connection_mutex = Mutex.new
-        @next_id_mutex = Mutex.new
-        @connection_cv = ConditionVariable.new
-
         @started = false
       end
 
@@ -103,6 +95,15 @@ module Bidi2pdf
         )
       end
 
+      def close
+        return unless @socket
+
+        Bidi2pdf.logger.debug "Closing WebSocket connection"
+        @socket&.close
+        @socket = nil
+        @started = false
+      end
+
       private
 
       def dispatcher

data/lib/bidi2pdf/bidi/session.rb

@@ -10,19 +10,9 @@ require_relative "user_context"
 module Bidi2pdf
   module Bidi
     class Session
-      SUBSCRIBE_EVENTS = [
-        "browsingContext",
-        "network",
-        "log",
-        "script",
-        "goog:cdp.Debugger.scriptParsed",
-        "goog:cdp.CSS.styleSheetAdded",
-        "goog:cdp.Runtime.executionContextsCleared",
-        # Tracing
-        "goog:cdp.Tracing.tracingComplete",
-        "goog:cdp.Network.requestWillBeSent",
-        "goog:cdp.Debugger.scriptParsed",
-        "goog:cdp.Page.screencastFrame"
+      SUBSCRIBE_EVENTS = %w[
+        log
+        script
       ].freeze
 
       attr_reader :session_uri, :started
@@ -48,6 +38,7 @@ module Bidi2pdf
       def close
         client&.send_cmd_and_wait("session.end", {}) do |response|
           Bidi2pdf.logger.debug "Session ended: #{response}"
+          @client&.close
           @client = nil
           @websocket_url = nil
           @browser = nil

data/lib/bidi2pdf/chromedriver_manager.rb

@@ -55,9 +55,11 @@ module Bidi2pdf
 
       close_session
 
-      term_chromedriver
+      debug_show_all_children
+
+      old_childprocesses = term_chromedriver
 
-      detect_zombie_processes
+      detect_zombie_processes old_childprocesses
 
       return unless process_alive?
 
@@ -68,14 +70,10 @@ module Bidi2pdf
 
     private
 
-    # rubocop:disable Metrics/AbcSize
-    def detect_zombie_processes
-      debug_show_all_children
+    def detect_zombie_processes(old_childprocesses)
+      Bidi2pdf.logger.debug "Old child processes for #{@pid}: #{old_childprocesses.map(&:pid).join(", ")}"
 
-      child_processes = Bidi2pdf::ProcessTree.new(@pid).children(@pid)
-      Bidi2pdf.logger.debug "Found child processes: #{child_processes.map(&:pid).join(", ")}"
-
-      zombie_processes = child_processes.select { |child| process_alive? child.pid }
+      zombie_processes = old_childprocesses.select { |child| process_alive? child.pid }
 
       return if zombie_processes.empty?
 
@@ -83,9 +81,18 @@ module Bidi2pdf
       printable_zombie_processes_str = printable_zombie_processes.join(", ")
 
       Bidi2pdf.logger.error "Zombie Processes detected #{printable_zombie_processes_str}"
+
+      term_zombie_processes zombie_processes
     end
 
-    # rubocop:enable Metrics/AbcSize
+    def term_zombie_processes(zombie_processes)
+      Bidi2pdf.logger.info "Terminating zombie processes: #{zombie_processes.map(&:pid).join(", ")}"
+
+      zombie_processes.each do |child|
+        Bidi2pdf.logger.debug "Terminating PID #{child.pid} (#{child.name})"
+        Process.kill("TERM", child.pid)
+      end
+    end
 
     def debug_show_all_children
       Bidi2pdf::ProcessTree.new(@pid).traverse do |process, level|
@@ -103,9 +110,11 @@ module Bidi2pdf
     end
 
     def term_chromedriver
-      Bidi2pdf.logger.info "Stopping Chromedriver (PID #{@pid})"
+      Bidi2pdf::ProcessTree.new(@pid).children(@pid).tap do |_child_processes|
+        Bidi2pdf.logger.info "Stopping Chromedriver (PID #{@pid})"
 
-      Process.kill("TERM", @pid)
+        Process.kill("TERM", @pid)
+      end
     rescue Errno::ESRCH
       Bidi2pdf.logger.debug "Process already gone"
       @pid = nil

data/lib/bidi2pdf/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Bidi2pdf
-  VERSION = "0.1.2"
+  VERSION = "0.1.3"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bidi2pdf
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Dieter S.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-04-05 00:00:00.000000000 Z
+date: 2025-04-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: base64