bic_validation 0.3.0 → 0.3.1

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 41030cdd80127e17ea3b852f00e3868d1961c123
+  data.tar.gz: ae8ad538cf76e0c2787efd30387d2c8109b57c13
+SHA512:
+  metadata.gz: 9f61dd3004c2b425736ad8070073a7667dca8c43992b9ec86dc915e1c53721bcce9e516ea4ab47f1e75276440224ea2e9d5dc2efae27fe5ea76934fb5010c91a
+  data.tar.gz: 17263e94ef4c3ed3c04487aadda8606838f0ef3dbebdfa722a8c7ad7be3c2ebf929aa5186a80b4974b6f1e69277f6ab07d76491199cd5ec8bb9907c536e5a17a

data/.travis.yml

@@ -1,9 +1,8 @@
 language: ruby
 rvm:
-  - 1.9.3
   - 2.0.0
+  - 2.1.0
   - ruby-head
-  - jruby-19mode
   - jruby-head
-  - rbx-2.1.1
+  - rbx-2.6
 script: rspec

data/CHANGELOG.md

@@ -0,0 +1,8 @@
+# Changelog
+
+## 0.3.1 (2015-12-21)
+
+Bugfixes:
+
+  - fix wrong validation rule, concerning Romanian users in particular
+    (#6, @svoop)

data/bic_validation.gemspec

@@ -24,6 +24,7 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'activesupport'
   gem.add_dependency 'banking_data'
   gem.add_development_dependency 'rspec'
+  gem.add_development_dependency 'rspec-its'
   gem.add_development_dependency 'coveralls'
   gem.add_development_dependency 'pry'
   gem.add_development_dependency 'rubocop'

data/lib/bic_validation/bic.rb

@@ -20,9 +20,9 @@ module BicValidation
       country_codes.include? country
     end
 
-    def has_valid_branch_code?
+    def has_valid_location_code?
       # WTF? http://de.wikipedia.org/wiki/ISO_9362
-      country[0] =~ /[^01]/ && country[1] =~ /[^O]/
+      location[0] =~ /[^01]/ && location[1] =~ /[^O]/
     end
 
     def known?
@@ -34,7 +34,7 @@ module BicValidation
       of_valid_length? &&
         of_valid_format? &&
         has_valid_country_code? &&
-        has_valid_branch_code?
+        has_valid_location_code?
     end
 
     def invalid?

data/lib/bic_validation/version.rb

@@ -1,3 +1,3 @@
 module BicValidation
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

data/spec/bic_validation/bic_spec.rb

@@ -80,7 +80,7 @@ module BicValidation
     end
 
     ['DEUTDEBB', 'CRESCHZZ10S', 'UBSWCHZH86N', 'OEKOATWWXXX',
-     'OEKOATWW'].each do |swift|
+     'OEKOATWW', 'BTRLRO22'].each do |swift|
       describe 'validity checks' do
         it "validates #{swift}" do
           bic = Bic.new(swift)

data/spec/spec_helper.rb

@@ -1,6 +1,7 @@
 require 'simplecov'
 require 'coveralls'
 require 'pry'
+require 'rspec/its'
 
 SimpleCov.formatter = SimpleCov::Formatter::MultiFormatter[
   SimpleCov::Formatter::HTMLFormatter,

metadata

@@ -1,140 +1,141 @@
 --- !ruby/object:Gem::Specification
 name: bic_validation
 version: !ruby/object:Gem::Version
-  version: 0.3.0
-  prerelease: 
+  version: 0.3.1
 platform: ruby
 authors:
 - Frank C. Eckert
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-11-01 00:00:00.000000000 Z
+date: 2015-12-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: banking_data
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rspec-its
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: ! "    BicValidation provides a simple ActiveModel::EachValidator for\n
-  \   formally validating Business Identifier Codes (BIC) aka SWIFT-codes.\n"
+description: |2
+      BicValidation provides a simple ActiveModel::EachValidator for
+      formally validating Business Identifier Codes (BIC) aka SWIFT-codes.
 email:
 - frank.eckert@boost-project.com
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .rubocop.yml
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".rubocop.yml"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.txt
 - README.md
@@ -152,30 +153,28 @@ files:
 - spec/spec_helper.rb
 homepage: https://github.com/opahk/bic_validation
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.2.2
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: ActiveModel BIC validator
 test_files:
 - spec/bic_validation/bic_spec.rb
 - spec/bic_validation/bic_validator_spec.rb
 - spec/spec_helper.rb
-has_rdoc: