bfs-s3 0.6.2 → 0.6.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37e10fdc93aa067bed7a72b5bcbccbc8b05bebad755e1bdd5091f6ed03b78206
-  data.tar.gz: 6db5a4abb0b6b6825785eff4a18ca74e5bf6083c2a6ce3f0344e3ea28b7e0446
+  metadata.gz: cbc8a8c0a41de684e3d77bc2593f75aff0f438154779dfce05199ab5898bdd60
+  data.tar.gz: 25369f70e61e235bc3dc18a4e5d1a7d6d1f05fc3897cc6070dd56794300b2f9a
 SHA512:
-  metadata.gz: 37ddc5cd5672316032a45fe30e99ee1a29b8e17b83c770542fd7998c2bf4c3f6046acb374e3440ae4ea646c88437dc7cf065b8d6f40b6456d81d56fa2d8786f4
-  data.tar.gz: c3744960bc91b119af9fe51c52429662b6d7e13aee85c4d373efc579e11492df599ddd0fbd35e1a5dd107cd870c2937add208db43ce9d6a96a8068b82e27f1f8
+  metadata.gz: 2f9f61852c8eeb4437aa15c17a27f9b367c60076a68f520ee54f607acd1f6f006281912470bfb7807df9d226db8272fbe9b70fa02080b185eb85030f215a0685
+  data.tar.gz: 7ca097e4764bda327018ddb7ce01f87ec9df8aa47f24dfe0ffb62138557151d4ed17b498961e62c5f8a5842d99363a5efbdebdb4f8dcd3aedee635b9779cbbff

data/lib/bfs/bucket/s3.rb

@@ -1,6 +1,5 @@
 require 'bfs'
 require 'aws-sdk-s3'
-require 'cgi'
 
 module BFS
   module Bucket
@@ -21,7 +20,6 @@ module BFS
       # @option opts [Symbol] :acl canned ACL
       # @option opts [String] :storage_class storage class
       # @option opts [Aws::S3::Client] :client custom client, uses default_client by default
-      # @option opts [String] :encoding Custom encoding.
       def initialize(name, **opts)
         super(**opts)
 
@@ -74,9 +72,8 @@ module BFS
       # @option opts [String] :acl custom ACL override
       # @option opts [String] :server_side_encryption SSE override
       # @option opts [String] :storage_class storage class override
-      def create(path, encoding: nil, perm: nil, **opts, &block)
+      def create(path, encoding: self.encoding, perm: self.perm, **opts, &block)
         path = full_path(path)
-        enc  = encoding || @encoding
         opts = opts.merge(
           bucket: name,
           key: path,
@@ -85,8 +82,8 @@ module BFS
         opts[:server_side_encryption] ||= @sse if @sse
         opts[:storage_class] ||= @storage_class if @storage_class
 
-        temp = BFS::TempWriter.new(path, encoding: enc, perm: perm) do |t|
-          File.open(t, encoding: enc) do |file|
+        temp = BFS::TempWriter.new(path, encoding: encoding, perm: perm) do |t|
+          File.open(t, encoding: encoding) do |file|
             @client.put_object(opts.merge(body: file))
           end
         end
@@ -104,10 +101,9 @@ module BFS
       # @param [Hash] opts options
       # @option opts [String] :encoding Custom encoding.
       # @option opts [String] :tempdir Custom temp dir.
-      def open(path, encoding: nil, tempdir: nil, **opts, &block)
+      def open(path, encoding: self.encoding, tempdir: nil, **opts, &block)
         path = full_path(path)
-        enc  = encoding || @encoding
-        temp = Tempfile.new(File.basename(path), tempdir, encoding: enc)
+        temp = Tempfile.new(File.basename(path), tempdir, encoding: encoding)
         temp.close
 
         opts = opts.merge(
@@ -117,7 +113,7 @@ module BFS
         )
         @client.get_object(**opts)
 
-        File.open(temp.path, encoding: enc, &block)
+        File.open(temp.path, encoding: encoding, &block)
       rescue Aws::S3::Errors::NoSuchKey, Aws::S3::Errors::NoSuchBucket, Aws::S3::Errors::NotFound
         raise BFS::FileNotFound, trim_prefix(path)
       end
@@ -162,17 +158,9 @@ module BFS
   end
 end
 
-BFS.register('s3') do |url|
-  params = CGI.parse(url.query.to_s)
-  prefix = BFS.norm_path(params.key?('prefix') ? params['prefix'].first : url.path)
-  prefix = nil if prefix.empty?
-
-  BFS::Bucket::S3.new url.host,
-                      prefix: prefix,
-                      region: params.key?('region') ? params['region'].first : nil,
-                      sse: params.key?('sse') ? params['sse'].first : nil,
-                      access_key_id: params.key?('access_key_id') ? params['access_key_id'].first : nil,
-                      secret_access_key: params.key?('secret_access_key') ? params['secret_access_key'].first : nil,
-                      acl: params.key?('acl') ? params['acl'].first : nil,
-                      storage_class: params.key?('storage_class') ? params['storage_class'].first : nil
+BFS.register('s3') do |url, opts|
+  prefix = BFS.norm_path(opts[:prefix] || url.path)
+  opts[:prefix] = prefix.empty? ? nil : prefix
+
+  BFS::Bucket::S3.new url.host, **opts.slice(:prefix, :region, :sse, :access_key_id, :secret_access_key, :acl, :storage_class, :encoding)
 end

data/spec/bfs/bucket/s3_spec.rb

@@ -25,10 +25,11 @@ RSpec.describe BFS::Bucket::S3, if: run_spec do
   it_behaves_like 'a bucket'
 
   it 'should resolve from URL' do
-    bucket = BFS.resolve("s3://#{sandbox[:bucket]}/?acl=private")
+    bucket = BFS.resolve("s3://#{sandbox[:bucket]}/?acl=private&encoding=binary")
     expect(bucket).to be_instance_of(described_class)
     expect(bucket.name).to eq(sandbox[:bucket])
     expect(bucket.acl).to eq(:private)
+    expect(bucket.encoding).to eq('binary')
     expect(bucket.instance_variable_get(:@prefix)).to be_nil
 
     bucket = BFS.resolve("s3://#{sandbox[:bucket]}/a/b/")

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bfs-s3
 version: !ruby/object:Gem::Version
-  version: 0.6.2
+  version: 0.6.3
 platform: ruby
 authors:
 - Dimitrij Denissenko
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-02-12 00:00:00.000000000 Z
+date: 2020-02-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: aws-sdk-s3
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: 0.6.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.6.2
+        version: 0.6.3
 description: https://github.com/bsm/bfs.rb
 email: dimitrij@blacksquaremedia.com
 executables: []
@@ -67,7 +67,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: S3 bucket adapter for bfs