bettertabs 1.4.1 → 1.4.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: d5e79ce335fbcdf9f066d26895489c7ba7a9a618
+  data.tar.gz: 66ffe69bc3cce378572156a6387f36bdc4c0bd45
+SHA512:
+  metadata.gz: 0df7a14d5b0ab4499619abca8ebb0e104ab229947caf5c6dfadc3769f83fc39366b04ef78c64a4f04d0ba1548fd9b6279f95118234f40ce2f6916ff01ff07041
+  data.tar.gz: 42f2ed91ee5c4b6ecc215c9f54edb1c7c3aed6e1655d6f5078b1fb71f84ecc3df646147ca73e418f69731c60c45e44f0d5fce81c272efa5217950310a17b7878

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 Bettertabs Changelog
 ====================
 
+### v1.4.2 (2014-11-10)
+
+  * Add option :list_item_html_options to specify the attributes on the rendered li elements for tabs. Thanks (@jskinner-arpc).
+
 ### v1.4.1 (2013-02-27)
 
   * Ensure BettertabsHelper is included even if config.action_controller.include_all_helpers is false, https://github.com/agoragames/bettertabs/pull/13

data/MIT-LICENSE

@@ -1,4 +1,4 @@
-Copyright 2013 Mario Izquierdo
+Copyright 2013-2014 Mario Izquierdo
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -1,24 +1,30 @@
 Bettertabs for Rails
 ====================
 
-We know that splitting content into several tabs is easy, but doing well, clean, DRY, accessible, usable, fast and testable is not so simple after all.
+We know that splitting content into several tabs is easy, but doing it well, clean, DRY, accessible, usable, testable and fast is not so simple after all.
 
-Bettertabs is a simple `Rails 3.1+ Engine` that includes a **helper** and a **jquery plugin** to render the needed markup and javascript for a section with tabs in a easy and declarative way, forcing you to keep things simple and ensuring accessibility and usability, no matter if the content is loaded statically or via ajax.
+Bettertabs is a `Rails 3.1+ Engine` that includes a **helper** and a **jquery plugin** to render the needed markup and javascript for a section with tabs in a declarative way, forcing you to [KISS](http://en.wikipedia.org/wiki/KISS_principle), ensuring accessibility and usability, whether the content is loaded statically or via ajax.
 
+[Try demo app online](http://bettertabs-demo.herokuapp.com)
 
 ## Features ##
 
-Having to worry only on a few aspects like putting the content in the right site, you will have a site with tabs that:
+Bettertabs allows for a site with tabs that:
 
   * Works with tabs for static, links or ajax loaded content
-  * Works without javascript, so you can click on a tab before the whole page was loaded and it will work. Also it's usually much more easy to test.
-  * It changes the URL (in HTML5 browsers, using [history.replaceState()](https://developer.mozilla.org/en/DOM/Manipulating_the_browser_history)), so when you use the browser's back button, you'll land in the last selected tab. Also selected tabs can be permalinked.
+  * Works without javascript
+    * SEO-friendly, specially good for ajax loaded tabs, because search engines can access and index the content anyway
+    * Progressive enhancement, obviously it works in devices without JavaScript
+    * Click on a tab before the whole page was loaded and it still works
+    * Allows to open the content in a new window if neccessary
+    * Easy to test
+  * It changes the URL (in HTML5 browsers, using [history.replaceState()](https://developer.mozilla.org/en/DOM/Manipulating_the_browser_history)), so when you use the browser's back button, you'll land in the last selected tab, and selected tabs can be permalinked.
   * Declarative code, that helps you to have your view code more readable and DRY
   * It has some basic error handling (like for example if the ajax loaded content returns an error, it redirects to the error page)
   * If you need more control in the javascript behavior, you can use some predefined jQuery events (for example: `$('#tabs').bind('bettertabs-before-ajax-loading', show_loading_clock);`)
   * The gem does not include any stylesheet, because each project has a different way of showing the tabs styles. Anyway the generated HTML is easy to style (see the [CSS Reference Guide](https://github.com/agoragames/bettertabs/blob/master/doc/STYLESHEETS-GUIDE.md))
 
-## Try it out ##
+## Demo Test app ##
 
 The bettertabs gem includes a dummy test app, that is used for development (to execute rspec tests) and that can be easily launched to play with.
 
@@ -32,7 +38,7 @@ The bettertabs gem includes a dummy test app, that is used for development (to e
 
 
 ## Requirements: ##
-  * Ruby 1.9
+  * Ruby 1.9 or higher
   * Rails 3.1 or higher
   * jQuery 1.3 or higher (but bettertabs also works without javascript)
 

data/app/assets/javascripts/jquery.bettertabs.js

@@ -1,12 +1,12 @@
 (function() {
   /*!
    jQuery Bettertabs Plugin
-   version: 1.4.1 (Mar-12-2012)
+   version: 1.4.2 (Nov-10-2014)
    @requires jQuery v1.3 or later
 
    Examples and documentation at: https://github.com/agoragames/bettertabs
 
-   Copyright (c) 2011 Mario Izquierdo (tothemario@gmail.com)
+   Copyright (c) 2011-2014 Mario Izquierdo (tothemario@gmail.com)
    Dual licensed under the MIT and GPL licenses:
      http://www.opensource.org/licenses/mit-license.php
      http://www.gnu.org/licenses/gpl.html

data/app/assets/javascripts/jquery.bettertabs.js.coffee

@@ -1,11 +1,11 @@
 ###!
  jQuery Bettertabs Plugin
- version: 1.4.1 (Mar-12-2012)
+ version: 1.4.2 (Nov-10-2014)
  @requires jQuery v1.3 or later
 
  Examples and documentation at: https://github.com/agoragames/bettertabs
 
- Copyright (c) 2011 Mario Izquierdo (tothemario@gmail.com)
+ Copyright (c) 2011-2014 Mario Izquierdo (tothemario@gmail.com)
  Dual licensed under the MIT and GPL licenses:
    http://www.opensource.org/licenses/mit-license.php
    http://www.gnu.org/licenses/gpl.html

data/app/assets/javascripts/jquery.bettertabs.min.js

@@ -1,12 +1,12 @@
 (function(){
 /*!
    jQuery Bettertabs Plugin
-   version: 1.4.1 (Mar-12-2012)
+   version: 1.4.2 (Nov-10-2014)
    @requires jQuery v1.3 or later
 
    Examples and documentation at: https://github.com/agoragames/bettertabs
 
-   Copyright (c) 2011 Mario Izquierdo (tothemario@gmail.com)
+   Copyright (c) 2011-2014 Mario Izquierdo (tothemario@gmail.com)
    Dual licensed under the MIT and GPL licenses:
      http://www.opensource.org/licenses/mit-license.php
      http://www.gnu.org/licenses/gpl.html

data/app/helpers/bettertabs_helper.rb

@@ -20,8 +20,10 @@ module BettertabsHelper
   #       * :render_only_active_content => if true, this helper renders only the selected tab contents (no wrapper, no tabs, only content).
   #                       Default to true only if controller.request.xhr? or params[:ajax].present? (true when its an ajax request).
   #       * :attach_jquery_bettertabs_inline => this helper includes a little inline script to apply the Bettertabs jQuery plugin to this widget. If false, do not render that inline script.
+  #       * :list_html_options => html attributes on the <ul> element (list) for the tabs (added to 'tabs' that is automatically assigned)
+  #       * :list_item_html_options => html attributes on the <li> elements (list items) for the tabs (added to 'tab' or 'tab active' class that is automatically assigned)
   #       * :class => html class attribute of the wrapper element. By default is 'bettertabs'
-  #       * :id => html id attribute of the wrapper element. By default is the bettertabs_id
+  #       * :id => html id attribute of the wrapper element. By default is the same value as `bettertabs_id` option.
   #       * Any other option will be used as wrapper elmenet html attribute.
   #
   # ==== tab builder arguments

data/bettertabs.gemspec

@@ -13,12 +13,13 @@ Gem::Specification.new do |s|
   s.homepage    = "https://github.com/agoragames/bettertabs"
   s.summary     = %q{Just a simple, accessible, usable, flexible and fast way to split view content in tabs in a rails application.}
   s.description = %q{Bettertabs is a Rails 3.1+ engine that adds a helper and jQuery plugin to define the markup and behavior for a tabbed area in a easy and declarative way, using the appropiate JavaScript but ensuring accessibility and usability, no matter if the content is loaded statically, via ajax or just with links. }
+  s.license     = 'MIT'
 
   s.files = `git ls-files`.split("\n")
-  
+
   s.add_dependency "rails", ">= 3.1.0"
   s.add_dependency "jquery-rails"
-  
+
   s.add_development_dependency 'rspec-rails'
   s.add_development_dependency 'haml-rails'
 end

data/lib/bettertabs/bettertabs_builder.rb

@@ -8,6 +8,7 @@ class BettertabsBuilder
     @template = template
     @selected_tab_id = selected_tab_id
     @list_html_options = options.delete(:list_html_options) # sets html_options on the :ul element
+    @list_item_html_options = options.delete(:list_item_html_options) # sets html_options on the :li elements
     @render_only_active_content = options.delete(:render_only_active_content) # used in ajax calls
     @wrapper_html_options = options
 
@@ -110,21 +111,26 @@ class BettertabsBuilder
       content_tag(:div, @wrapper_html_options) do
 
         # Tabs list
-         @list_html_options ||= {}
-         @list_html_options[:class] ||= ''
-         @list_html_options[:class] += @list_html_options[:class].empty? ? 'tabs' : ' tabs'
-         content_tag(:ul, @list_html_options) do
-           @tabs.map do |tab|
-             content_tag(:li, class: ('active' if tab[:active]), id: tab_html_id_for(tab[:tab_id])) do
-               tab[:html_options][:"data-tab-type"] ||= tab[:tab_type] # for javascript: change click behavior depending on type :static, :link or :ajax
-               tab[:html_options][:"data-show-content-id"] ||= content_html_id_for(tab[:tab_id]) # for javascript: element id to show when select this tab
-               tab[:html_options][:"data-ajax-url"] ||= tab[:ajax_url] if tab[:tab_type] == :ajax # for javascript: url to make ajax call
-               tab[:html_options][:class] ||= ''
-               tab[:html_options][:class] += 'active' if tab[:active]
-               @template.link_to(tab[:text], tab[:url], tab[:html_options])
-             end
-           end.join.html_safe
-         end +
+        @list_html_options ||= {}
+        @list_html_options[:class] ||= ''
+        @list_html_options[:class] += @list_html_options[:class].empty? ? 'tabs' : ' tabs'
+
+        @list_item_html_options ||= {}
+        @list_item_html_options[:class] ||= ''
+        @list_item_html_options[:class] += @list_item_html_options[:class].empty? ? 'tab' : ' tab'
+
+        content_tag(:ul, @list_html_options) do
+          @tabs.map do |tab|
+            content_tag(:li, tab_li_options(tab)) do
+              tab[:html_options][:"data-tab-type"] ||= tab[:tab_type] # for javascript: change click behavior depending on type :static, :link or :ajax
+              tab[:html_options][:"data-show-content-id"] ||= content_html_id_for(tab[:tab_id]) # for javascript: element id to show when select this tab
+              tab[:html_options][:"data-ajax-url"] ||= tab[:ajax_url] if tab[:tab_type] == :ajax # for javascript: url to make ajax call
+              tab[:html_options][:class] ||= ''
+              tab[:html_options][:class] += 'active' if tab[:active]
+              @template.link_to(tab[:text], tab[:url], tab[:html_options])
+            end
+          end.join.html_safe
+        end +
 
          # Content sections
          @contents.map do |content|
@@ -188,4 +194,12 @@ class BettertabsBuilder
     end
   end
 
+  # Gets the the html_options for the tab list_item element
+  def tab_li_options(tab)
+    options = @list_item_html_options.clone
+    options[:class] += ' active' if tab[:active]
+    options[:id] = tab_html_id_for(tab[:tab_id])
+    options
+  end
+
 end

data/lib/bettertabs/version.rb

@@ -1,3 +1,3 @@
 module Bettertabs
-  VERSION = "1.4.1"
+  VERSION = "1.4.2"
 end

data/spec/requests/bettertabs_spec.rb

@@ -4,9 +4,10 @@
 #  * The bettertabs hepler should accept:
 #    * args: (bettertabs_id, options)
 #    * options can be:
-#       * :selected_tab => tab_id to select by default
-#         * :selected_tab should be overridden with params[:"#{bettertabs_id}_selected_tab"] if present
+#       * :selected_tab => tab_id to select by default.
+#                          It is be overridden with request params[:"#{bettertabs_id}_selected_tab"] if present.
 #       * :list_html_options => html_options for the :ul element
+#       * :list_item_html_options => html_options for the :li elements (each tab )
 #       * any other option is used as wrapper html_options (wrapper is the top-level widget dom element).
 #  * The bettertabs helper should render clear markup:
 #     * A wrapper with class 'bettertabs'
@@ -79,6 +80,10 @@ describe "Bettertabs requests" do
     it "has a 200 status code" do
       response.status.should be(200)
     end
+
+    it 'should contain active on a list-item element' do
+      response.body.should have_selector("#tab2_link_tab[class*='active']")
+    end
   end
 
   describe "GET /bettertabs/ajax" do
@@ -91,6 +96,10 @@ describe "Bettertabs requests" do
       response.body.should include("data-ajax-url")
     end
 
+    it 'should include the default class=tab for the list_item' do
+      response.body.should have_selector("li.tab")
+    end
+
     it "should include the default ajax=true extra param in the data-ajax-url" do
       response.body.should include("data-ajax-url=\"/bettertabs/ajax/ajax_tab_2?ajax=true\"")
     end

metadata

@@ -1,81 +1,72 @@
 --- !ruby/object:Gem::Specification
 name: bettertabs
 version: !ruby/object:Gem::Version
-  version: 1.4.1
-  prerelease: 
+  version: 1.4.2
 platform: ruby
 authors:
 - Mario Izquierdo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-02-27 00:00:00.000000000 Z
+date: 2014-11-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: 3.1.0
 - !ruby/object:Gem::Dependency
   name: jquery-rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: haml-rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
-description: ! 'Bettertabs is a Rails 3.1+ engine that adds a helper and jQuery plugin
+description: 'Bettertabs is a Rails 3.1+ engine that adds a helper and jQuery plugin
   to define the markup and behavior for a tabbed area in a easy and declarative way,
   using the appropiate JavaScript but ensuring accessibility and usability, no matter
   if the content is loaded statically, via ajax or just with links. '
@@ -152,34 +143,28 @@ files:
 - spec/requests/bettertabs_spec.rb
 - spec/spec_helper.rb
 homepage: https://github.com/agoragames/bettertabs
-licenses: []
+licenses:
+- MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 3598349345553857565
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 3598349345553857565
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.23
+rubygems_version: 2.0.14
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Just a simple, accessible, usable, flexible and fast way to split view content
   in tabs in a rails application.
 test_files: []