bettertabs 1.3.1 → 1.3.2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    bettertabs (1.3.1)
+    bettertabs (1.3.2)
       jquery-rails
       rails (~> 3.1.0)
 

data/app/assets/javascripts/jquery.bettertabs.js

@@ -3,14 +3,15 @@
    jQuery Bettertabs Plugin
    version: 1.3.1 (Sep-13-2011)
    @requires jQuery v1.3 or later
-
+   
    Examples and documentation at: https://github.com/agoragames/bettertabs
-
+   
    Copyright (c) 2011 Mario Izquierdo (tothemario@gmail.com)
    Dual licensed under the MIT and GPL licenses:
      http://www.opensource.org/licenses/mit-license.php
      http://www.gnu.org/licenses/gpl.html
-  */  var $, ajax_url_attr, content_id_from, show_content_id_attr, tab_type_attr, tab_type_of;
+  */
+  var $, ajax_url_attr, content_id_from, show_content_id_attr, tab_type_attr, tab_type_of;
   $ = jQuery;
   tab_type_attr = 'data-tab-type';
   show_content_id_attr = 'data-show-content-id';
@@ -23,7 +24,7 @@
   };
   $.Bettertabs = {
     change_browser_url: function(url) {
-      if ((typeof history != "undefined" && history !== null) && (history.replaceState != null)) {
+      if ((typeof history !== "undefined" && history !== null) && (history.replaceState != null)) {
         return history.replaceState(null, document.title, url);
       }
     },
@@ -45,14 +46,16 @@
         if (tab_type_of(this_link) !== 'link') {
           event.preventDefault();
           this_tab = this_link.parent();
-          if (!this_tab.is('.active') && !this_link.is('.ajax-loading')) {
+          if (!this_tab.hasClass('active') && !this_link.hasClass('ajax-loading')) {
             this_tab_content = tabs_contents.filter("#" + (content_id_from(this_link)));
             previous_active_tab = tabs.filter('.active');
             previous_active_tab_content = tabs_contents.filter('.active');
             activate_tab_and_content = function() {
               tabs.removeClass('active');
+              tabs_links.removeClass('active');
               tabs_contents.removeClass('active').addClass('hidden');
               this_tab.addClass('active');
+              this_link.addClass('active');
               this_tab_content.removeClass('hidden').addClass('active');
               previous_active_tab_content.trigger('bettertabs-after-deactivate');
               this_tab_content.trigger('bettertabs-after-activate');

data/app/assets/javascripts/jquery.bettertabs.js.coffee

@@ -43,17 +43,19 @@ $.fn.bettertabs = ->
     
     tabs_links.click (event) ->
       this_link = $(this)
-      if tab_type_of(this_link) isnt 'link'
+      unless tab_type_of(this_link) is 'link'
         event.preventDefault()
         this_tab = this_link.parent()
-        if not this_tab.is('.active') and not this_link.is('.ajax-loading')
+        if not this_tab.hasClass('active') and not this_link.hasClass('ajax-loading')
           this_tab_content = tabs_contents.filter "##{content_id_from this_link}"
           previous_active_tab = tabs.filter '.active'
           previous_active_tab_content = tabs_contents.filter '.active'
           activate_tab_and_content = ->
             tabs.removeClass('active')
+            tabs_links.removeClass('active')
             tabs_contents.removeClass('active').addClass('hidden')
             this_tab.addClass('active')
+            this_link.addClass('active')
             this_tab_content.removeClass('hidden').addClass('active')
             previous_active_tab_content.trigger 'bettertabs-after-deactivate'
             this_tab_content.trigger 'bettertabs-after-activate'

data/doc/CHANGELOG.md

@@ -1,6 +1,11 @@
 Bettertabs Changelog
 ====================
 
+2011-09-13  Mario Izquierdo Martinez <mizquierdo@majorleaguegaming.com>
+
+  * Tag v1.3.2
+  * Update the jquery.bettertabs plugin to update the link .active class a well as li element
+
 2011-09-13  Mario Izquierdo Martinez <mizquierdo@majorleaguegaming.com>
 
   * Tag v1.3.1

data/doc/JAVASCRIPTS-DEV-GUIDE.md

@@ -15,11 +15,10 @@ You can then install CoffeeScript with npm:
     npm install coffee-script
     
 
-Then you will be able to compile `jquery.bettertabs.coffee` into `jquery.bettertabs.js` using the coffee command:
+Then you will be able to compile `jquery.bettertabs.js.coffee` into `jquery.bettertabs.js` using the coffee command:
 
-    coffee --watch --compile jquery.bettertabs.coffee
-    
-With this, each time you save the `jquery.bettertabs.coffee` file, `jquery.bettertabs.js` will be automatically updated.
+    cd app/assets/javascripts
+    coffee --print jquery.bettertabs.js.coffee > jquery.bettertabs.js
 
 
 ## JavaScript Compressor ##

data/lib/bettertabs/version.rb

@@ -1,3 +1,3 @@
 module Bettertabs
-  VERSION = "1.3.1"
+  VERSION = "1.3.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bettertabs
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
   prerelease: 
 platform: ruby
 authors:
@@ -14,7 +14,7 @@ default_executable:
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
-  requirement: &2156493880 !ruby/object:Gem::Requirement
+  requirement: &2152611360 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -22,10 +22,10 @@ dependencies:
         version: 3.1.0
   type: :runtime
   prerelease: false
-  version_requirements: *2156493880
+  version_requirements: *2152611360
 - !ruby/object:Gem::Dependency
   name: jquery-rails
-  requirement: &2156493160 !ruby/object:Gem::Requirement
+  requirement: &2152610340 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -33,10 +33,10 @@ dependencies:
         version: '0'
   type: :runtime
   prerelease: false
-  version_requirements: *2156493160
+  version_requirements: *2152610340
 - !ruby/object:Gem::Dependency
   name: rspec-rails
-  requirement: &2156492340 !ruby/object:Gem::Requirement
+  requirement: &2152609660 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -44,10 +44,10 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156492340
+  version_requirements: *2152609660
 - !ruby/object:Gem::Dependency
   name: haml-rails
-  requirement: &2156491380 !ruby/object:Gem::Requirement
+  requirement: &2152608920 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -55,7 +55,7 @@ dependencies:
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2156491380
+  version_requirements: *2152608920
 description: ! 'Bettertabs is a Rails 3.1 engine that adds a helper and jQuery plugin
   to define the markup and behavior for a tabbed area in a easy and declarative way,
   using the appropiate JavaScript but ensuring accessibility and usability, no matter
@@ -145,7 +145,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3213150091351247240
+      hash: 4239099548208733678
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -154,7 +154,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: -3213150091351247240
+      hash: 4239099548208733678
 requirements: []
 rubyforge_project: 
 rubygems_version: 1.6.2