betterlint 1.10.0 → 1.10.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8ae56cca2ec6c902c0eb366462cdc80fafb3895c3ea56454bdc247f528694cfa
-  data.tar.gz: d70a646105175ee4c68a1098c7bc31dc8d06249484245f180ad2e2164aa720c3
+  metadata.gz: ebad0e83ab9fb4d6fd1beb0c28ea03bbf593cd7d9831c5b2546f646b8622a449
+  data.tar.gz: c8c3b31f1b37f54fdd8ae8857ceb9f39f372e130b888541afab8beae78d60ccb
 SHA512:
-  metadata.gz: cbde32295337b547e4b8a9fe128ebd0406573745a8e8a8acafb8c3bd8f10f6e052442c6ff36e1c915d559fc3a924f8ed7aa40914d78b3560e00c373f1019deaa
-  data.tar.gz: 709a0ea18f486e1489da86947951cf73d9d22341178a46c242d282d686eeafbce4986fbef7143305e20698e047478532dc0ce2556d781ad4b6b6fd093721ee05
+  metadata.gz: 743afd50991fd213f1ca6a4f311cc96c506c0f2dc76de117887756ec634b0ad1704e953a871c0f0280a25c7dba60194076fe262257b80364903ca56b6541f33d
+  data.tar.gz: c7ba0f48ee2e69d0590de7973922aeef331c48a6a79417bae84b05ff45c33217ffb8bd01f0814123ff22201c8e73a40c9a307879a377826951589beed966523f

data/lib/rubocop/cop/betterment/redirect_status.rb

@@ -17,11 +17,7 @@ module RuboCop
         MSG
 
         def on_def(node)
-          each_offense(node, :redirect_to) do |responder|
-            add_offense(responder) do |corrector|
-              corrector.insert_after(responder, ", status: :see_other")
-            end
-          end
+          each_offense(node, :redirect_to) { :see_other }
         end
       end
     end

data/lib/rubocop/cop/betterment/render_status.rb

@@ -18,9 +18,7 @@ module RuboCop
 
         def on_def(node)
           each_offense(node, :render) do |responder|
-            add_offense(responder) do |corrector|
-              corrector.insert_after(responder, ", status: #{infer_status(responder).inspect}")
-            end
+            infer_status(responder)
           end
         end
 

data/lib/rubocop/cop/betterment/utils/response_status.rb

@@ -11,15 +11,28 @@ module RuboCop
 
           private
 
-          def each_offense(node, responder_name, &block)
-            if UNSAFE_ACTIONS.include?(node.method_name)
-              on_missing_status(node, responder_name, &block)
+          def each_offense(node, responder_name)
+            return unless UNSAFE_ACTIONS.include?(node.method_name)
+
+            on_missing_status(node, responder_name) do |responder|
+              add_offense(responder) do |corrector|
+                status = yield(responder)
+
+                if responder.arguments?
+                  corrector.insert_after(responder.last_argument, ", status: #{status.inspect}")
+                else
+                  corrector.replace(responder, "#{responder_name} status: #{status.inspect}")
+                end
+              end
             end
           end
 
           # @!method on_missing_status(node)
           def_node_search :on_missing_status, <<~PATTERN
-            (send nil? %1 ... !(hash <(pair (sym :status) _) ...>))
+            {
+              (send nil? %1)
+              (send nil? %1 ... !(hash <(pair (sym :status) _) ...>))
+            }
           PATTERN
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: betterlint
 version: !ruby/object:Gem::Version
-  version: 1.10.0
+  version: 1.10.1
 platform: ruby
 authors:
 - Development
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-04-09 00:00:00.000000000 Z
+date: 2024-04-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop