bettercap 1.1.3 → 1.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3ec474a048798ccf1e1cdffd8e9cd89451664e34
-  data.tar.gz: b7a71427a38b282296afe4ea29e4ff17544a2ae8
+  metadata.gz: 0302105b4b7c6f181542e22fff7662fa6b4b922b
+  data.tar.gz: b46e666f283922dbe0bdb09fd6f2883dee7d89b2
 SHA512:
-  metadata.gz: 1181286df3a437f4687ad6472dec73979358f517946775f7b5b058831bdd8209505ae8efe77e2034698d7cc0952daeb4b80e072f28698e6fee2b3e46304c6105
-  data.tar.gz: b180321825414edddc52aa36d3eee9a3c67c320aa55ed1911a1fe5c0a9758c241adc914bfab558dc1fe15c32d65574ec1b62e3dd2e993661a20b1744c11708f1
+  metadata.gz: ef42d62d1d051931e7b2ea84d56e09498e630628a1293bd3be5fc7a23d5457b57a2470896431171638bd59981ec0736a85847b359f592ca991ba378301831a34
+  data.tar.gz: ca6291a117033ab2139a616a7e8734fbf0bc5b05b57e25299b222bfceed8bcbc9785b148a988c4c059cfd4079d79b7f24d1cdfd76a439ce3c3b35f42d0c4a6d8

data/CONTRIBUTING.md

@@ -0,0 +1,42 @@
+# How To Contribute
+
+As any other open source projects, there're many ways you can contribute to bettercap depending on your skills as a developer or will to help as a user, but first 
+of all let me thank you for your help! <3
+
+### Submitting Issues
+
+If you find bugs or inconsistencies while using bettercap, you can create an **Issue** using the [GitHub Issue tracker](https://github.com/evilsocket/bettercap/issues), but before doing that please make sure that:
+
+* You are using a relatively new Ruby version ( >= 1.9 ) : `ruby -v`.
+* Your GEM environment is configured properly and updated : `sudo gem update`.    
+* You are using the latest version of bettercap : `bettercap --check-updates`.
+* The bug you're reporting is actually related to bettercap and not to one of the other GEMs.
+
+Once you've gone through this list, open an issue and please give us as much as informations as possible in order for us to fix the bug as soon as possible:
+
+* Your OS version.
+* Ruby version you're using.
+* Full output of the error ( exception backtrace, error message, etc ).
+* Your network configuration: `ifconfig -a`
+
+Also, you should attach to the issue a debug log that you can generate with:
+
+    sudo bettercap [arguments you are using for testing] --debug --log=debug.log
+
+Wait for the error to happen then close bettercap and paste the **debug.log** file inside the issue.
+
+### Pull Requests
+
+If you know how to code in Ruby and have ideas to improve bettercap, you're very welcome to send us pull requests, we'll be happy to merge them whenever they comply to the following rules:
+
+* You have at least manually tested your code, ideally you've created actual tests for it.
+* Respect our coding standard, 2 spaces indentation and modular code.
+* There're no conflicts with the current dev branch.
+* Your commit messages are enough explanatory to us.
+
+There're plenty of things you can to do improve the software:
+
+* Implement a new proxy module and push it to the [dedicated repository](https://github.com/evilsocket/bettercap-proxy-modules).
+* Implement a new [Spoofer module](https://github.com/evilsocket/bettercap/blob/master/lib/bettercap/spoofers/arp.rb).
+* Implement a new [Sniffer credentials parser](https://github.com/evilsocket/bettercap/blob/master/lib/bettercap/sniffer/parsers/post.rb).
+* Fix, extend or improve the core.

data/Gemfile

@@ -0,0 +1,2 @@
+source "https://rubygems.org"
+gemspec

data/Gemfile.lock

@@ -0,0 +1,25 @@
+PATH
+  remote: .
+  specs:
+    bettercap (1.1.3)
+      colorize (~> 0.7.5)
+      packetfu (~> 1.1.10)
+      pcaprub (~> 0.12.0)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    colorize (0.7.7)
+    minitest (5.7.0)
+    packetfu (1.1.10)
+    pcaprub (0.12.0)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  bettercap!
+  minitest
+
+BUNDLED WITH
+   1.10.3

data/README.md

@@ -1,4 +1,4 @@
-![logo](http://www.bettercap.org/images/logo_dark.png)
+![logo](http://www.bettercap.org/assets/img/navbar-logo.png)
 
 Copyleft of Simone '[evilsocket](https://twitter.com/evilsocket)' Margaritelli*.  
 

data/Rakefile

@@ -0,0 +1,7 @@
+require 'rake/testtask'
+
+Rake::TestTask.new do |t|
+  t.libs << 'test'
+  t.libs << 'lib/bettercap'
+  t.pattern = "test/**/*_test.rb"
+end

data/TODO.md

@@ -7,9 +7,8 @@ This is a list of TODOs I use to keep track of tasks and upcoming features.
 - [x] BPF filters.
 - [x] BeEF proxy module ( [BeefBOX](https://github.com/evilsocket/bettercap-proxy-modules/blob/master/beefbox.rb) ).
 - [x] Use raw file arp parsing instead of "arp -a" to improve speed. ( Solved with arp -a -n )
+- [x] sslmitm
 - [ ] *BSD Support.
-- [ ] sslstrip
-- [ ] sslmitm
 - [ ] HTTP/2 Support.
 - [ ] Active packet filtering/injection/etc.
 
@@ -21,3 +20,4 @@ This is a list of TODOs I use to keep track of tasks and upcoming features.
 - [ ] Windows Support? ( OMG PLZ NO! )
 - [ ] Output/actions as json for UI integration?
 - [ ] BeefBox / BeefDRONE with Raspberry PI?
+- [ ] sslstrip ( not really sure, currently is quite useless )

data/bettercap.gemspec

@@ -15,6 +15,8 @@ Gem::Specification.new do |gem|
   gem.add_dependency( 'packetfu', '~> 1.1.10' )
   gem.add_dependency( 'pcaprub', '~> 0.12.0' )
 
+  gem.add_development_dependency( 'minitest' )
+
   gem.files = `git ls-files`.split("\n")
   gem.require_paths = ["lib"]
 

data/bin/bettercap

@@ -32,7 +32,7 @@ begin
       ctx.options[:spoofer] = v
     end
 
-    opts.on( '-T', '--target ADDRESS', 'Target IP address, if not specified the whole subnet will be targeted.' ) do |v|
+    opts.on( '-T', '--target ADDRESS1,ADDRESS2', 'Target IP addresses, if not specified the whole subnet will be targeted.' ) do |v|
       ctx.options[:target] = v
     end
 
@@ -72,19 +72,40 @@ begin
       ctx.options[:arpcache] = true
     end
 
-    opts.on( '--no-spoofing', 'Disable spoofing, alias for --spoofer NONE.' ) do |v|
+    opts.on( '--no-spoofing', 'Disable spoofing, alias for --spoofer NONE.' ) do
       ctx.options[:spoofer] = 'NONE'
     end
 
+    opts.on( '--half-duplex', 'Enable half-duplex MITM, this will make bettercap work in those cases when the router is not vulnerable.' ) do
+      ctx.options[:half_duplex] = true
+    end
+
     opts.on( '--proxy', 'Enable HTTP proxy and redirects all HTTP requests to it, default to false.' ) do
       ctx.options[:proxy] = true
     end
 
+    opts.on( '--proxy-https', 'Enable HTTPS proxy and redirects all HTTPS requests to it, default to false.' ) do
+      ctx.options[:proxy] = true
+      ctx.options[:proxy_https] = true
+    end
+
     opts.on( '--proxy-port PORT', 'Set HTTP proxy port, default to ' + ctx.options[:proxy_port].to_s + ' .' ) do |v|
       ctx.options[:proxy] = true
       ctx.options[:proxy_port] = v.to_i
     end
 
+    opts.on( '--proxy-https-port PORT', 'Set HTTPS proxy port, default to ' + ctx.options[:proxy_https_port].to_s + ' .' ) do |v|
+      ctx.options[:proxy] = true
+      ctx.options[:proxy_https] = true
+      ctx.options[:proxy_https_port] = v.to_i
+    end
+
+    opts.on( '--proxy-pem FILE', 'Use a custom PEM certificate file for the HTTPS proxy.' ) do |v|
+      ctx.options[:proxy] = true
+      ctx.options[:proxy_https] = true
+      ctx.options[:proxy_pem_file] = File.expand_path v
+    end
+
     opts.on( '--proxy-module MODULE', 'Ruby proxy module to load.' ) do |v|
       ctx.options[:proxy] = true
       ctx.options[:proxy_module] = File.expand_path v
@@ -132,17 +153,11 @@ begin
   end.parse!
 
   if ctx.options[:check_updates]
-    begin
-    ver = ctx.check_updates
-    if !ver.nil?
-      Logger.warn "New version #{ver} available!"
-    else
-      Logger.info 'You are running the latest version.'
-    end
-    rescue Exception => e
-      Logger.error "Could not check for updates: #{e.message}"
-    end
+    error_policy = lambda { |e|
+      Logger.error("Could not check for udpates: #{e.message}")
+    }
 
+    ctx.check_updates(error_policy)
     exit
   end
 
@@ -160,48 +175,36 @@ begin
 
     ctx.start_discovery_thread
   else
-    raise BetterCap::Error, "Invalid target '#{ctx.options[:target]}'" unless Network.is_ip? ctx.options[:target]
+    targets = ctx.options[:target].split(",")
+    valid_targets = targets.select { |target| Network.is_ip?(target) }
 
-    ctx.targets = [ Target.new( ctx.options[:target], nil ) ]
-  end
+    raise BetterCap::Error, "Invalid target" if valid_targets.empty?
 
-  ctx.spoofer = SpooferFactory.get_by_name( ctx.options[:spoofer] )
+    invalid_targets = targets - valid_targets
+    invalid_targets.each do |target|
+      Logger.warn "Invalid target #{target}"
+    end
 
-  Logger.info "  Local : #{ctx.ifconfig[:ip_saddr]} ( #{ctx.ifconfig[:eth_saddr]} )"
+    ctx.targets = valid_targets.map { |target| Target.new(target) }
+  end
 
-  Logger.debug "Module: #{ctx.options[:spoofer]}"
 
-  ctx.spoofer.start
+  ctx.spoofer=Array.new
+  spoofer_modules_names=ctx.options[:spoofer].split(",")
+  spoofer_modules_names.each do |module_name|
+    Logger.info "Loading module : #{module_name}"
+    ctx.spoofer << SpooferFactory.get_by_name( module_name )
+    ctx.spoofer.last.start
+  end
 
   if ctx.options[:proxy]
     if ctx.options[:sniffer] and ( ctx.options[:parsers].include?'*' or ctx.options[:parsers].include?'URL' )
       Logger.warn "WARNING: Both HTTP transparent proxy and URL parser are enabled, you're gonna see duplicated logs."
     end
 
-    ctx.firewall.add_port_redirection( ctx.options[:iface], 'TCP', 80, ctx.ifconfig[:ip_saddr], ctx.options[:proxy_port] )
-
-    if not ctx.options[:proxy_module].nil?
-      require ctx.options[:proxy_module]
-
-      Proxy::Module.register_modules
-
-      raise BetterCap::Error, "#{ctx.options[:proxy_module]} is not a valid bettercap proxy module." unless !Proxy::Module.modules.empty?
-    end
-
-    ctx.proxy = Proxy::Proxy.new( ctx.ifconfig[:ip_saddr], ctx.options[:proxy_port] ) do |request,response|
-      if Proxy::Module.modules.empty?
-        Logger.warn 'WARNING: No proxy module loaded, skipping request.'
-      else
-        # loop each loaded module and execute if enabled
-        Proxy::Module.modules.each do |mod|
-          if mod.enabled?
-            mod.on_request request, response
-          end
-        end
-      end
-    end
+    ctx.enable_port_redirection
 
-    ctx.proxy.start
+    ctx.create_proxies
   end
 
   if ctx.options[:httpd]
@@ -212,7 +215,9 @@ begin
   if ctx.options[:sniffer]
     Sniffer.start ctx
   else
-    Logger.warn 'WARNING: Sniffer module was NOT enabled ( -X argument ), this will cause the MITM to run but no data to be collected.'
+    if ctx.options[:spoofer] != 'NONE' and ctx.options[:spoofer] != 'none'
+      Logger.warn 'WARNING: Sniffer module was NOT enabled ( -X argument ), this will cause the MITM to run but no data to be collected.'
+    end
 
     loop do
       sleep 1

data/lib/bettercap/context.rb

@@ -18,7 +18,8 @@ require 'json'
 
 class Context
   attr_accessor :options, :ifconfig, :network, :firewall, :gateway,
-                :targets, :spoofer, :proxy, :httpd
+                :targets, :spoofer, :proxy, :https_proxy, :httpd,
+                :certificate
 
   @@instance = nil
 
@@ -37,6 +38,7 @@ class Context
     @options = {
       iface: iface,
       spoofer: 'ARP',
+      half_duplex: false,
       target: nil,
       logfile: nil,
       debug: false,
@@ -49,7 +51,10 @@ class Context
       local: false,
 
       proxy: false,
+      proxy_https: false,
       proxy_port: 8080,
+      proxy_https_port: 8083,
+      proxy_pem_file: nil,
       proxy_module: nil,
 
       httpd: false,
@@ -59,30 +64,49 @@ class Context
       check_updates: false
     }
 
-    @ifconfig  = nil
-    @network   = nil
-    @firewall  = nil
-    @gateway   = nil
-    @targets   = []
-    @proxy     = nil
-    @spoofer   = nil
-    @httpd     = nil
+    @ifconfig    = nil
+    @network     = nil
+    @firewall    = nil
+    @gateway     = nil
+    @targets     = []
+    @proxy_processor = nil
+    @proxy       = nil
+    @https_proxy = nil
+    @spoofer     = nil
+    @httpd       = nil
+    @certificate = nil
 
     @discovery_running = false
     @discovery_thread  = nil
   end
 
-  def check_updates
+  def check_updates(error_policy = ->{ raise })
+    ver = get_latest_version
+
+    case ver
+    when BetterCap::VERSION
+      Logger.info 'You are running the latest version.'
+    else
+      Logger.warn "New version '#{ver}' available!"
+    end
+  rescue Exception => e
+    error_policy.call(e)
+  end
+
+  def get_latest_version
     Logger.info 'Checking for updates ...'
 
-    api  = URI('https://api.github.com/repos/evilsocket/bettercap/releases/latest')
-    body = Net::HTTP.get(api)
-    json = JSON.parse(body)
+    api = URI('https://rubygems.org/api/v1/versions/bettercap/latest.json')
+    response = Net::HTTP.get_response(api)
 
-    if json['tag_name'] != BetterCap::VERSION and json['tag_name'] != "v#{BetterCap::VERSION}"
-      return json['tag_name']
+    case response
+    when Net::HTTPSuccess
+      json = JSON.parse(response.body)
+    else
+      raise response.message
     end
-    nil
+
+    return json['version']
   end
 
   def update_network
@@ -110,7 +134,12 @@ class Context
           Logger.info 'Searching for alive targets ...'
         else
           # make sure we don't stress the logging system
-          sleep 10
+          10.times do
+            sleep 1
+            if !@discovery_running
+              break
+            end
+          end
         end
 
         @targets = Network.get_alive_targets self
@@ -139,17 +168,93 @@ class Context
     end
   end
 
+  def enable_port_redirection
+    Logger.info "Redirecting traffic from port 80 to #{@ifconfig[:ip_saddr]}:#{@options[:proxy_port]}"
+
+    @firewall.add_port_redirection( @options[:iface], 'TCP', 80, @ifconfig[:ip_saddr], @options[:proxy_port] )
+    if @options[:proxy_https]
+      Logger.info "Redirecting traffic from port 443 to #{@ifconfig[:ip_saddr]}:#{@options[:proxy_https_port]}"
+
+      @firewall.add_port_redirection( @options[:iface], 'TCP', 443, @ifconfig[:ip_saddr], @options[:proxy_https_port] )
+    end
+  end
+
+  def disable_port_redirection
+    @firewall.del_port_redirection( @options[:iface], 'TCP', 80, @ifconfig[:ip_saddr], @options[:proxy_port] )
+    if @options[:proxy_https]
+      @firewall.del_port_redirection( @options[:iface], 'TCP', 443, @ifconfig[:ip_saddr], @options[:proxy_https_port] )
+    end
+  end
+
+  def create_proxies
+    if not @options[:proxy_module].nil?
+      require @options[:proxy_module]
+
+      Proxy::Module.register_modules
+
+      raise BetterCap::Error, "#{@options[:proxy_module]} is not a valid bettercap proxy module." unless !Proxy::Module.modules.empty?
+    end
+
+    @proxy_processor = Proc.new do |request,response|
+      if Proxy::Module.modules.empty?
+        Logger.warn 'WARNING: No proxy module loaded, skipping request.'
+      else
+        # loop each loaded module and execute if enabled
+        Proxy::Module.modules.each do |mod|
+          if mod.enabled?
+            # we need to save the original response in case something
+            # in the module will go wrong
+            original = response
+
+            begin
+              mod.on_request request, response
+            rescue Exception => e
+              Logger.warn "Error with proxy module: #{e.message}"
+              response = original
+            end
+          end
+        end
+      end
+    end
+
+    # create HTTP proxy
+    @proxy = Proxy::Proxy.new( @ifconfig[:ip_saddr], @options[:proxy_port], false, @proxy_processor )
+    @proxy.start
+
+    # create HTTPS proxy
+    if @options[:proxy_https]
+      # We're not acting as a normal HTTPS proxy, thus we're not
+      # able to handle CONNECT requests, thus we don't know the
+      # hostname the client is going to connect to.
+      # We can only use a self signed certificate.
+      if @options[:proxy_pem_file].nil?
+        @certificate = Proxy::CertStore.get_selfsigned
+      else
+        @certificate = Proxy::CertStore.from_file @options[:proxy_pem_file]
+      end
+
+      @https_proxy = Proxy::Proxy.new( @ifconfig[:ip_saddr], @options[:proxy_https_port], true, @proxy_processor )
+      @https_proxy.start
+    end
+  end
+
   def finalize
     stop_discovery_thread
 
     # Consider !!@spoofer
-    if !@spoofer.nil?
-      @spoofer.stop
+
+    if !@spoofer.nil? and @spoofer.length != 0 
+      @spoofer.each do |itr|
+        itr.stop
+      end
     end
 
     if !@proxy.nil?
       @proxy.stop
-      @firewall.del_port_redirection( @options[:iface], 'TCP', 80, @ifconfig[:ip_saddr], @options[:proxy_port] )
+      if !@https_proxy.nil?
+        @https_proxy.stop
+      end
+      disable_port_redirection
     end
 
     if !@firewall.nil?

data/lib/bettercap/factories/firewall_factory.rb

@@ -29,4 +29,8 @@ class FirewallFactory
 
     @@instance
   end
+
+  def FirewallFactory.clear_firewall
+    @@instance = nil
+  end
 end

data/lib/bettercap/factories/parser_factory.rb

@@ -28,6 +28,8 @@ class ParserFactory
     end
 
     def from_cmdline(v)
+      raise BetterCap::Error, "No parser names provided" if v.nil?
+
       avail = available
       list = v.split(',').collect(&:strip).collect(&:upcase).reject{ |c| c.empty? }
       list.each do |parser|

data/lib/bettercap/firewalls/linux.rb

@@ -14,34 +14,40 @@ require 'bettercap/shell'
 
 class LinuxFirewall < IFirewall
   def enable_forwarding(enabled)
-    Shell.execute("echo #{enabled ? 1 : 0} > /proc/sys/net/ipv4/ip_forward")
+    shell.execute("echo #{enabled ? 1 : 0} > /proc/sys/net/ipv4/ip_forward")
   end
 
   def forwarding_enabled?
-    Shell.execute('cat /proc/sys/net/ipv4/ip_forward').strip == '1'
+    shell.execute('cat /proc/sys/net/ipv4/ip_forward').strip == '1'
   end
 
   def enable_icmp_bcast(enabled)
-    Shell.execute("echo #{enabled ? 0 : 1} > /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts")
+    shell.execute("echo #{enabled ? 0 : 1} > /proc/sys/net/ipv4/icmp_echo_ignore_broadcasts")
   end
 
   def add_port_redirection( iface, proto, from, addr, to )
     # clear nat
-    Shell.execute('iptables -t nat -F')
+    shell.execute('iptables -t nat -F')
     # clear
-    Shell.execute('iptables -F')
+    shell.execute('iptables -F')
     # post route
-    Shell.execute('iptables -t nat -I POSTROUTING -s 0/0 -j MASQUERADE')
+    shell.execute('iptables -t nat -I POSTROUTING -s 0/0 -j MASQUERADE')
     # accept all
-    Shell.execute('iptables -P FORWARD ACCEPT')
+    shell.execute('iptables -P FORWARD ACCEPT')
     # add redirection
-    Shell.execute("iptables -t nat -A PREROUTING -i #{iface} -p #{proto} --dport #{from} -j REDIRECT --to #{to}")
+    shell.execute("iptables -t nat -A PREROUTING -i #{iface} -p #{proto} --dport #{from} -j REDIRECT --to #{to}")
   end
 
   def del_port_redirection( iface, proto, from, addr, to )
     # remove post route
-    Shell.execute('iptables -t nat -D POSTROUTING -s 0/0 -j MASQUERADE')
+    shell.execute('iptables -t nat -D POSTROUTING -s 0/0 -j MASQUERADE')
     # remove redirection
-    Shell.execute("iptables -t nat -D PREROUTING -i #{iface} -p #{proto} --dport #{from} -j REDIRECT --to #{to}")
+    shell.execute("iptables -t nat -D PREROUTING -i #{iface} -p #{proto} --dport #{from} -j REDIRECT --to #{to}")
+  end
+
+  private
+
+  def shell
+    Shell
   end
 end

data/lib/bettercap/firewalls/osx.rb

@@ -14,20 +14,20 @@ require 'bettercap/shell'
 
 class OSXFirewall < IFirewall
   def enable_forwarding(enabled)
-    Shell.execute("sysctl -w net.inet.ip.forwarding=#{enabled ? 1 : 0}")
+    shell.execute("sysctl -w net.inet.ip.forwarding=#{enabled ? 1 : 0}")
   end
 
   def enable_icmp_bcast(enabled)
-    Shell.execute("sysctl -w net.inet.icmp.bmcastecho=#{enabled ? 1 : 0}")
+    shell.execute("sysctl -w net.inet.icmp.bmcastecho=#{enabled ? 1 : 0}")
   end
 
   def forwarding_enabled?
-    Shell.execute('sysctl net.inet.ip.forwarding').strip.split(' ')[1] == '1'
+    shell.execute('sysctl net.inet.ip.forwarding').strip.split(' ')[1] == '1'
   end
 
   def enable(enabled)
     begin
-      Shell.execute("pfctl -#{enabled ? ?e : ?d} >/dev/null 2>&1")
+      shell.execute("pfctl -#{enabled ? 'e' : 'd'} >/dev/null 2>&1")
     rescue; end
   end
 
@@ -36,11 +36,11 @@ class OSXFirewall < IFirewall
     config_file = "/tmp/bettercap_pf_#{Process.pid}.conf"
 
     File.open( config_file, 'a+t' ) do |f|
-      f.write "rdr on #{iface} inet proto #{proto} to any port #{from} -> #{addr} port #{to}\n"
+      f.write "rdr pass on #{iface} proto #{proto} from any to any port #{from} -> #{addr} port #{to}\n"
     end
 
     # load the rule
-    Shell.execute("pfctl -f #{config_file} >/dev/null 2>&1")
+    shell.execute("pfctl -f #{config_file} >/dev/null 2>&1")
     # enable pf
     enable true
   end
@@ -51,7 +51,18 @@ class OSXFirewall < IFirewall
 
     # disable pf
     enable false
-    # remove the pf config file
-    File.delete( "/tmp/bettercap_pf_#{Process.pid}.conf" )
+
+    begin
+      # remove the pf config file
+      File.delete( "/tmp/bettercap_pf_#{Process.pid}.conf" )
+    rescue
+    end
+
+  end
+
+  private
+
+  def shell
+    Shell
   end
 end

data/lib/bettercap/logger.rb

@@ -37,6 +37,7 @@ module Logger
       # make sure that logging is thread safe
       @@semaphore.synchronize {
         puts message
+
         if !@logfile.nil?
           f = File.open( @logfile, 'a+t' )
           f.puts( message.gsub( /\e\[(\d+)(;\d+)*m/, '') + "\n")
@@ -46,6 +47,7 @@ module Logger
     end
 
     private
+
     def formatted_message(message, message_type)
       "[#{message_type}] #{message}"
     end

data/lib/bettercap/network.rb

@@ -24,7 +24,7 @@ require 'bettercap/discovery/arp'
 class Network
     class << self
     def is_ip?(ip)
-      if /\A(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})\Z/ =~ ip
+      if /\A(\d{1,3})\.(\d{1,3})\.(\d{1,3})\.(\d{1,3})\Z/ =~ ip.to_s
         return $~.captures.all? {|i| i.to_i < 256}
       end
       false
@@ -39,12 +39,18 @@ class Network
       gw  = nil
       out.each do |line|
         if line.include?( Context.get.options[:iface] )
-          gw = line.split[1]
-          break if is_ip?(gw)
+          tmp = line.split[1]
+          if is_ip?(tmp)
+            gw = tmp
+            break
+          end
         end
       end
 
-      raise BetterCap::Error, 'Could not detect gateway address' unless gw.nil? or is_ip?(gw)
+      raise BetterCap::Error, "Could not detect the gateway address for interface #{Context.get.options[:iface]}, "\
+                              'make sure you\'ve specified the correct network interface to use and to have the '\
+                              'correct network configuration, this could also happen if bettercap '\
+                              'is launched from a virtual environment.' unless !gw.nil? and is_ip?(gw)
       gw
     end