better_frame 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: efce9ae5a3ae64f1e9b2d780d4bd22dc23f88e7f
-  data.tar.gz: b34de21b687948a9f412f1902ce5783dfb947979
+  metadata.gz: 13d2177a2085fbc59122813f41ce7eea8d248e94
+  data.tar.gz: ac8ea62d957ecb4f3e42029d2e2942192b9ade9c
 SHA512:
-  metadata.gz: fd06295a1252fa78dafee10440aded01067ecf9d63f616051501c55fd3c1e0d9bebbc027e0ac8a1d7d97164ff9bafc9f6f37e4b1345a5c35846c2ab65571c1f2
-  data.tar.gz: 3934267675fd7b82c4e0ee57cf9e3b5ec877be8da9e3b5ea6be36639f005401c15cb3cf8f114154d92412740899c0338ab2ddf9142017da32c87929a81ae73f2
+  metadata.gz: aec1bf79d43e0bdcde5f87d79aa3f0bec953da5aef2ec4b9d7f4100d8a1de37fdcf644ee9d85960355d20eae5ed64ba5af6add43e22933511020ab452811c31d
+  data.tar.gz: 1254e457555eff500ce75aeb4fc177d28a7d2a2cb098729906a186313402198ac8aaafc5c88fdbb09e8d9f32ae8774b9bcb66f0d902328de8bfed488f1ae6ee0

data/app/assets/javascripts/better_frame/better_frame.js

@@ -35,7 +35,7 @@
     fill(url).then(storeURLInHistory);
   }
 
-  $(document).on("click", "#app-content a:not([target=\"_blank\"]):not([data-ignore-better-frame])", handleLinks);
+  $(document).on("click", "#app-content a:not([target=\"_blank\"]):not([data-ignore-better-frame]):not([data-method])", handleLinks);
 
   $(document).on("ajax:success", "#app-content form", function(e, data, status, xhr) {
     fillContent(data);

data/app/assets/javascripts/better_frame/jquery-ujs.js

@@ -99,7 +99,7 @@
 
     // Default way to get an element's href. May be overridden at $.rails.href.
     href: function(element) {
-      return element[0].href;
+      return element[0].getAttribute("href");
     },
 
     // Checks "data-remote" if true to handle the request through a XHR request.
@@ -117,14 +117,7 @@
 
         if (element.is('form')) {
           method = element.data('ujs:submit-button-formmethod') || element.attr('method');
-          var url_or_path = element.data('ujs:submit-button-formaction') || element.attr('action');
-          var railsURL = $("#app-content").data("railsurl");
-          // if url_or_path starts with a slash assume it's a path
-          if (url_or_path.match(/^\//) && railsURL !== undefined) {
-            url = railsURL + url_or_path;
-          } else {
-            url = url_or_path;
-          }
+          url = element.data('ujs:submit-button-formaction') || element.attr('action');
           data = $(element[0]).serializeArray();
           // memoized value from clicked submit button
           var button = element.data('ujs:submit-button');
@@ -149,6 +142,13 @@
           url = rails.href(element);
           data = element.data('params') || null;
         }
+        var railsURL = $("#app-content").data("railsurl");
+        // if url starts with a slash assume it's a path
+        if (url.match(/^\//) && railsURL !== undefined) {
+          url = railsURL + url;
+        } else {
+          url = url;
+        }
 
         options = {
           type: method || 'GET', data: data, dataType: dataType,
@@ -229,12 +229,13 @@
     // <a href="/users/5" data-method="delete" rel="nofollow" data-confirm="Are you sure?">Delete</a>
     handleMethod: function(link) {
       var href = rails.href(link),
-        method = link.data('method'),
-        target = link.attr('target'),
-        csrfToken = rails.csrfToken(),
-        csrfParam = rails.csrfParam(),
-        form = $('<form method="post" action="' + href + '"></form>'),
-        metadataInput = '<input name="_method" value="' + method + '" type="hidden" />';
+          method = link.data('method'),
+          target = link.attr('target'),
+          csrfToken = rails.csrfToken(),
+          csrfParam = rails.csrfParam(),
+          remote = rails.isRemote(link),
+          form = $('<form method="post" action="' + href + '" data-with-credentials="true" data-remote="true"></form>'),
+          metadataInput = '<input name="_method" value="' + method + '" type="hidden" />';
 
       if (csrfParam !== undefined && csrfToken !== undefined && !rails.isCrossDomain(href)) {
         metadataInput += '<input name="' + csrfParam + '" value="' + csrfToken + '" type="hidden" />';
@@ -242,7 +243,7 @@
 
       if (target) { form.attr('target', target); }
 
-      form.hide().append(metadataInput).appendTo('body');
+      form.hide().append(metadataInput).appendTo('#app-content');
       form.submit();
     },
 

data/lib/better_frame/version.rb

@@ -1,3 +1,3 @@
 module BetterFrame
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: better_frame
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Yves Siegrist
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-07-22 00:00:00.000000000 Z
+date: 2016-07-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler