better_errors 2.0.0 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: bc36d3113c7041816a7697fbd1e50333f5976003
-  data.tar.gz: 834f3f4a4903a45f150d83adde3f25452d2fd86b
+  metadata.gz: 2f7d7bc114aeb551e440f8da17f54695d2e577c0
+  data.tar.gz: 98a63563c768d1dc39cfde6b480f08ef57a4d8ba
 SHA512:
-  metadata.gz: 130d61a4ce2e5509eb1585dfa0e3c620bf54387ac6a0931d1a534296460a0e06601a6d71ce41b3d3ffbd15951626ddfd7e753bb1bc911c35cf76cfa52cfcd771
-  data.tar.gz: 5906697a352187036b92cdefe124fea459405d7e3cc80f3bcc6f07c7a2952f328367f452e88272947edef464a4cc75fbe3d276c24580b9b633b6f9e60c99a60d
+  metadata.gz: 39f582d75f4f5036509eba3c3c97b99f6ee7f695ff3c6913a860ad3d20fb6e22be3d79cc27daa9cb1328b597c83e40c08ffc608497f3213ac738fc56b11670f2
+  data.tar.gz: ba38267fddb50b97ff7fb9ddb27489d03526521d0a479859fe90c6095cc03f37d9f103110879650c76efe9ea1de1f9a1726aadf1ce4ed6e567b9b9317ecf963b

data/README.md

@@ -1,8 +1,8 @@
-# Better Errors [![Gem Version](http://img.shields.io/gem/v/better_errors.svg)](https://rubygems.org/gems/better_errors) [![Build Status](https://travis-ci.org/charliesome/better_errors.svg)](https://travis-ci.org/charliesome/better_errors) [![Code Climate](http://img.shields.io/codeclimate/github/charliesome/better_errors.svg)](https://codeclimate.com/github/charliesome/better_errors)
+# Better Errors [![Gem Version](https://img.shields.io/gem/v/better_errors.svg)](https://rubygems.org/gems/better_errors) [![Build Status](https://travis-ci.org/charliesome/better_errors.svg)](https://travis-ci.org/charliesome/better_errors) [![Code Climate](https://img.shields.io/codeclimate/github/charliesome/better_errors.svg)](https://codeclimate.com/github/charliesome/better_errors)
 
 Better Errors replaces the standard Rails error page with a much better and more useful error page. It is also usable outside of Rails in any Rack app as Rack middleware.
 
-![image](http://i.imgur.com/6zBGAAb.png)
+![image](https://i.imgur.com/6zBGAAb.png)
 
 ## Features
 
@@ -21,7 +21,7 @@ group :development do
 end
 ```
 
-If you would like to use Better Errors' **advanced features** (REPL, local/instance variable inspection, pretty stack frame names), you need to add the [`binding_of_caller`](https://github.com/banister/binding_of_caller) gem by [@banisterfiend](http://twitter.com/banisterfiend) to your Gemfile:
+If you would like to use Better Errors' **advanced features** (REPL, local/instance variable inspection, pretty stack frame names), you need to add the [`binding_of_caller`](https://github.com/banister/binding_of_caller) gem by [@banisterfiend](https://twitter.com/banisterfiend) to your Gemfile:
 
 ```ruby
 gem "binding_of_caller"
@@ -77,6 +77,11 @@ get "/" do
 end
 ```
 
+### Plain text
+
+Better Errors will render a plain text error page  when the request is an
+`XMLHttpRequest` or when the `Accept` header does *not* include 'html'.
+
 ### Unicorn, Puma, and other multi-worker servers
 
 Better Errors works by leaving a lot of context in server process memory. If

data/lib/better_errors.rb

@@ -139,7 +139,7 @@ begin
   require "binding_of_caller"
   require "better_errors/exception_extension"
   BetterErrors.binding_of_caller_available = true
-rescue LoadError => e
+rescue LoadError
   BetterErrors.binding_of_caller_available = false
 end
 

data/lib/better_errors/code_formatter.rb

@@ -11,9 +11,9 @@ module BetterErrors
       ".erb"  => :erb,
       ".haml" => :haml
     }
-    
+
     attr_reader :filename, :line, :context
-    
+
     def initialize(filename, line, context = 5)
       @filename = filename
       @line     = line
@@ -29,7 +29,7 @@ module BetterErrors
     def formatted_code
       formatted_lines.join
     end
-    
+
     def coderay_scanner
       ext = File.extname(filename)
       FILE_TYPES[ext] || :text
@@ -40,20 +40,20 @@ module BetterErrors
         yield (current_line == line), current_line, str
       }
     end
-    
+
     def highlighted_lines
       CodeRay.scan(context_lines.join, coderay_scanner).div(wrap: nil).lines
     end
-    
+
     def context_lines
       range = line_range
       source_lines[(range.begin - 1)..(range.end - 1)] or raise Errno::EINVAL
     end
-    
+
     def source_lines
       @source_lines ||= File.readlines(filename)
     end
-    
+
     def line_range
       min = [line - context, 1].max
       max = [line + context, source_lines.count].min

data/lib/better_errors/code_formatter/html.rb

@@ -11,7 +11,7 @@ module BetterErrors
         sprintf '<pre class="%s">%s</pre>', class_name, str
       }
     end
-    
+
     def formatted_nums
       each_line_of(highlighted_lines) { |highlight, current_line, str|
         class_name = highlight ? "highlight" : ""

data/lib/better_errors/error_page.rb

@@ -103,7 +103,7 @@ module BetterErrors
       CGI.escapeHTML(obj.inspect)
     rescue NoMethodError
       "<span class='unsupported'>(object doesn't support inspect)</span>"
-    rescue Exception => e
+    rescue Exception
       "<span class='unsupported'>(exception was raised in inspect)</span>"
     end
   end

data/lib/better_errors/repl.rb

@@ -9,17 +9,17 @@ module BetterErrors
     def self.provider
       @provider ||= const_get detect[:const]
     end
-    
+
     def self.provider=(prov)
       @provider = prov
     end
-    
+
     def self.detect
       PROVIDERS.find { |prov|
         test_provider prov
       }
     end
-    
+
     def self.test_provider(provider)
       require provider[:impl]
       true

data/lib/better_errors/repl/basic.rb

@@ -4,11 +4,11 @@ module BetterErrors
       def initialize(binding)
         @binding = binding
       end
-    
+
       def send_input(str)
         [execute(str), ">>", ""]
       end
-    
+
     private
       def execute(str)
         "=> #{@binding.eval(str).inspect}\n"

data/lib/better_errors/repl/pry.rb

@@ -9,29 +9,29 @@ module BetterErrors
           Fiber.yield
         end
       end
-      
+
       class Output
         def initialize
           @buffer = ""
         end
-        
+
         def puts(*args)
           args.each do |arg|
             @buffer << "#{arg.chomp}\n"
           end
         end
-        
+
         def tty?
           false
         end
-        
+
         def read_buffer
           @buffer
         ensure
           @buffer = ""
         end
       end
-      
+
       def initialize(binding)
         @fiber = Fiber.new do
           @pry.repl binding
@@ -42,7 +42,7 @@ module BetterErrors
         @pry.hooks.clear_all if defined?(@pry.hooks.clear_all)
         @fiber.resume
       end
-    
+
       def send_input(str)
         local ::Pry.config, color: false, pager: false do
           @fiber.resume "#{str}\n"
@@ -59,7 +59,7 @@ module BetterErrors
       rescue
         [">>", ""]
       end
-      
+
     private
       def local(obj, attrs)
         old_attrs = {}

data/lib/better_errors/stack_frame.rb

@@ -33,7 +33,7 @@ module BetterErrors
     end
 
     def gem_path
-      if path = Gem.path.detect { |path| filename.index(path) == 0 }
+      if path = Gem.path.detect { |p| filename.index(p) == 0 }
         gem_name_and_version, path = filename.sub("#{path}/gems/", "").split("/", 2)
         /(?<gem_name>.+)-(?<gem_version>[\w.]+)/ =~ gem_name_and_version
         "#{gem_name} (#{gem_version}) #{path}"

data/lib/better_errors/templates/main.erb

@@ -182,7 +182,7 @@
         word-wrap: break-word;
         white-space: pre-wrap;
         height: auto;
-        max-height: 7em;
+        max-height: 7.5em;
     }
 
     @media screen and (max-width: 1100px) {
@@ -875,6 +875,7 @@
             this.previousCommandOffset = previousCommands.push(text);
             if(previousCommands.length > 100) {
               previousCommands.splice(0, 1);
+              this.previousCommandOffset -= 1;
             }
             localStorage.setItem("better_errors_previous_commands", JSON.stringify(previousCommands));
         }

data/lib/better_errors/version.rb

@@ -1,3 +1,3 @@
 module BetterErrors
-  VERSION = "2.0.0"
+  VERSION = "2.1.0"
 end

data/spec/better_errors/code_formatter_spec.rb

@@ -3,16 +3,16 @@ require "spec_helper"
 module BetterErrors
   describe CodeFormatter do
     let(:filename) { File.expand_path("../support/my_source.rb", __FILE__) }
-    
+
     let(:formatter) { CodeFormatter.new(filename, 8) }
-    
+
     it "picks an appropriate scanner" do
       formatter.coderay_scanner.should == :ruby
     end
-    
+
     it "shows 5 lines of context" do
       formatter.line_range.should == (3..13)
-      
+
       formatter.context_lines.should == [
           "three\n",
           "four\n",
@@ -43,12 +43,12 @@ module BetterErrors
         formatter = CodeFormatter::HTML.new(filename, 20)
         formatter.output.should_not == formatter.source_unavailable
       end
-      
+
       it "doesn't barf when the lines don't make any sense" do
         formatter = CodeFormatter::HTML.new(filename, 999)
         formatter.output.should == formatter.source_unavailable
       end
-      
+
       it "doesn't barf when the file doesn't exist" do
         formatter = CodeFormatter::HTML.new("fkdguhskd7e l", 1)
         formatter.output.should == formatter.source_unavailable
@@ -82,7 +82,7 @@ module BetterErrors
         formatter = CodeFormatter::Text.new(filename, 999)
         formatter.output.should == formatter.source_unavailable
       end
-      
+
       it "doesn't barf when the file doesn't exist" do
         formatter = CodeFormatter::Text.new("fkdguhskd7e l", 1)
         formatter.output.should == formatter.source_unavailable

data/spec/better_errors/error_page_spec.rb

@@ -3,36 +3,36 @@ require "spec_helper"
 module BetterErrors
   describe ErrorPage do
     let!(:exception) { raise ZeroDivisionError, "you divided by zero you silly goose!" rescue $! }
-  
+
     let(:error_page) { ErrorPage.new exception, { "PATH_INFO" => "/some/path" } }
-    
+
     let(:response) { error_page.render }
-    
+
     let(:empty_binding) {
       local_a = :value_for_local_a
       local_b = :value_for_local_b
-      
+
       @inst_c = :value_for_inst_c
       @inst_d = :value_for_inst_d
-      
+
       binding
     }
-  
+
     it "includes the error message" do
       response.should include("you divided by zero you silly goose!")
     end
-  
+
     it "includes the request path" do
       response.should include("/some/path")
     end
-  
+
     it "includes the exception class" do
       response.should include("ZeroDivisionError")
     end
-    
+
     context "variable inspection" do
       let(:exception) { empty_binding.eval("raise") rescue $! }
-      
+
       if BetterErrors.binding_of_caller_available?
         it "shows local variables" do
           html = error_page.do_variables("index" => 0)[:html]
@@ -47,7 +47,7 @@ module BetterErrors
           html.should include(%{gem "binding_of_caller"})
         end
       end
-      
+
       it "shows instance variables" do
         html = error_page.do_variables("index" => 0)[:html]
         html.should include("inst_c")
@@ -65,7 +65,7 @@ module BetterErrors
         html.should_not include("<pre>:value_for_inst_d</pre>")
       end
     end
-    
+
     it "doesn't die if the source file is not a real filename" do
       exception.stub(:backtrace).and_return([
         "<internal:prelude>:10:in `spawn_rack_application'"

data/spec/better_errors/repl/basic_spec.rb

@@ -9,7 +9,7 @@ module BetterErrors
         local_a = 123
         binding
       }
-      
+
       let(:repl) { Basic.new fresh_binding }
 
       it_behaves_like "a REPL provider"

data/spec/better_errors/repl/shared_examples.rb

@@ -3,13 +3,13 @@ shared_examples_for "a REPL provider" do
     repl.send_input("local_a = 456")
     fresh_binding.eval("local_a").should == 456
   end
-  
+
   it "returns a tuple of output and the new prompt" do
     output, prompt = repl.send_input("1 + 2")
     output.should == "=> 3\n"
     prompt.should == ">>"
   end
-  
+
   it "doesn't barf if the code throws an exception" do
     output, prompt = repl.send_input("raise Exception")
     output.should include "Exception: Exception"

data/spec/better_errors/stack_frame_spec.rb

@@ -7,20 +7,20 @@ module BetterErrors
         BetterErrors.stub(:application_root).and_return("/abc/xyz")
         frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index")
 
-        frame.application?.should be_true
+        frame.should be_application
       end
 
       it "is false for everything else" do
         BetterErrors.stub(:application_root).and_return("/abc/xyz")
         frame = StackFrame.new("/abc/nope", 123, "foo")
 
-        frame.application?.should be_false
+        frame.should_not be_application
       end
 
       it "doesn't care if no application_root is set" do
         frame = StackFrame.new("/abc/xyz/app/controllers/crap_controller.rb", 123, "index")
 
-        frame.application?.should be_false
+        frame.should_not be_application
       end
     end
 
@@ -29,14 +29,14 @@ module BetterErrors
         Gem.stub(:path).and_return(["/abc/xyz"])
         frame = StackFrame.new("/abc/xyz/gems/whatever-1.2.3/lib/whatever.rb", 123, "foo")
 
-        frame.gem?.should be_true
+        frame.should be_gem
       end
 
       it "is false for everything else" do
         Gem.stub(:path).and_return(["/abc/xyz"])
         frame = StackFrame.new("/abc/nope", 123, "foo")
 
-        frame.gem?.should be_false
+        frame.should_not be_gem
       end
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: better_errors
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.1.0
 platform: ruby
 authors:
 - Charlie Somerville
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-20 00:00:00.000000000 Z
+date: 2014-12-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: erubis