better_errors 0.8.0 → 0.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 092b8845c91cd3c3ea3134d950e5c25075f19c96
-  data.tar.gz: 989272a11a82a89c5fa51715d97ab6b27586760e
+  metadata.gz: 785a0ad660868a52fd48ab6d3b7c2f0271a9c32d
+  data.tar.gz: 40d2e1dab31d7aeca46c9d6761ab907e5c944b87
 SHA512:
-  metadata.gz: 4a4f8df6ad24fe881afd99292f39826035cdbe77f3ccd7e751d1f0b123c6c8d805aebdd708d857e0f5de046a58f1f1ac6139cc9b90cc8247bf35644674474fbe
-  data.tar.gz: 674c43d266041da8918725037d2227dddb6ac38d19e4122a581f719b90d4943d8c962fa31722be2d26d581ef01f134401bf3e7792cbfd2266410dc60068a4ccd
+  metadata.gz: 715085c73baaa36af3b73294f1de9d61b8dd44011e310f1d2145fe9156d624c8fe1f089c1558ad5156c37b7f9386c43eb4573e5e8e485a7e0cda6ef1c70fc82e
+  data.tar.gz: 56cf655e78b89ecdbd960008e7f77973ed91c2d2583ad6c3d6c0fa9cf1b88aa098c37525b7072f801b4e2ae62fdf371d2a8cbd2e947397063104900c6594c5d2

data/README.md

@@ -51,6 +51,8 @@ Note that the `allow_ip!` is actually backed by a `Set`, so you can add more tha
 
 **Tip:** You can find your apparent IP by hitting the old error page's "Show env dump" and looking at "REMOTE_ADDR".
 
+**VirtualBox:** If you are using VirtualBox and are accessing the guest from your host's browser, you will need to use `allow_ip!` to see the error page.
+
 ## Usage
 
 If you're using Rails, there's nothing else you need to do.
@@ -82,6 +84,19 @@ end
 
 [![Build Status](https://travis-ci.org/charliesome/better_errors.png)](https://travis-ci.org/charliesome/better_errors)
 
+### Unicorn, Puma, and other multi-worker servers
+
+Better Errors works by leaving a lot of context in server process memory. If
+you're using a web server that runs muliple "workers" it's likely that a second
+request (as happens when you click on a stack frame) will hit a different
+worker. That worker won't have the necessary context in memory, and you'll see
+a `Session Expired` message.
+
+If this is the case for you, consider turing the number of workers to one (1)
+in `development`. Another option would be to use `rails server`, or another
+single-process web server, when you are trying to troubleshoot an issue in
+development.
+
 ## Get in touch!
 
 If you're using better_errors, I'd love to hear from you. Drop me a line and tell me what you think!

data/lib/better_errors/core_ext/exception.rb

@@ -1,8 +1,8 @@
 class Exception
-  original_initialize = instance_method(:initialize)
+  original_set_backtrace = instance_method(:set_backtrace)
   
   if BetterErrors.binding_of_caller_available?
-    define_method :initialize do |*args|
+    define_method :set_backtrace do |*args|
       unless Thread.current[:__better_errors_exception_lock]
         Thread.current[:__better_errors_exception_lock] = true
         begin
@@ -11,7 +11,7 @@ class Exception
           Thread.current[:__better_errors_exception_lock] = false
         end
       end
-      original_initialize.bind(self).call(*args)
+      original_set_backtrace.bind(self).call(*args)
     end
   end
   

data/lib/better_errors/stack_frame.rb

@@ -48,10 +48,10 @@ module BetterErrors
     end
     
     def gem_path
-      Gem.path.each do |path|
-        if filename.index(path) == 0
-          return filename.gsub("#{path}/gems/", "(gem) ")
-        end
+      if path = Gem.path.detect { |path| filename.index(path) == 0 }
+        gem_name_and_version, path = filename.sub("#{path}/gems/", "").split("/", 2)
+        /(?<gem_name>.+)-(?<gem_version>[\w.]+)/ =~ gem_name_and_version
+        "#{gem_name} (#{gem_version}) #{path}"
       end
     end
 

data/lib/better_errors/templates/main.erb

@@ -680,7 +680,18 @@
       host app.
     %>
     <script>
-      if (window.Turbolinks) document.head.innerHTML = "";
+      if (window.Turbolinks) {
+          for(var i=0; i < document.styleSheets.length; i++) {
+              if(document.styleSheets[i].href)
+                  document.styleSheets[i].disabled = true;
+          }
+          document.addEventListener("page:restore", function restoreCSS(e) {
+              for(var i=0; i < document.styleSheets.length; i++) {
+                  document.styleSheets[i].disabled = false;
+              }
+              document.removeEventListener("page:restore", restoreCSS, false);
+          });
+      }
     </script>
 
     <div class='top'>

data/lib/better_errors/version.rb

@@ -1,3 +1,3 @@
 module BetterErrors
-  VERSION = "0.8.0"
+  VERSION = "0.9.0"
 end

data/spec/better_errors/stack_frame_spec.rb

@@ -54,7 +54,7 @@ module BetterErrors
         Gem.stub!(:path).and_return(["/abc/xyz"])
         frame = StackFrame.new("/abc/xyz/gems/whatever-1.2.3/lib/whatever.rb", 123, "foo")
         
-        frame.gem_path.should == "(gem) whatever-1.2.3/lib/whatever.rb"
+        frame.gem_path.should == "whatever (1.2.3) lib/whatever.rb"
       end
       
       it "should prioritize gem path over application path" do
@@ -62,7 +62,7 @@ module BetterErrors
         Gem.stub!(:path).and_return(["/abc/xyz/vendor"])
         frame = StackFrame.new("/abc/xyz/vendor/gems/whatever-1.2.3/lib/whatever.rb", 123, "foo")
         
-        frame.gem_path.should == "(gem) whatever-1.2.3/lib/whatever.rb"
+        frame.gem_path.should == "whatever (1.2.3) lib/whatever.rb"
       end
     end
     

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: better_errors
 version: !ruby/object:Gem::Version
-  version: 0.8.0
+  version: 0.9.0
 platform: ruby
 authors:
 - Charlie Somerville
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-04-04 00:00:00.000000000 Z
+date: 2013-05-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -201,7 +201,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.0
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Better error page for Rails and other Rack apps